From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2881CC48BF8 for ; Mon, 19 Feb 2024 22:17:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E69A6B0074; Mon, 19 Feb 2024 17:17:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9967B6B0078; Mon, 19 Feb 2024 17:17:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 885BA6B007B; Mon, 19 Feb 2024 17:17:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 796486B0074 for ; Mon, 19 Feb 2024 17:17:15 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 39ADA80435 for ; Mon, 19 Feb 2024 22:17:15 +0000 (UTC) X-FDA: 81809965230.19.4484E95 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 8424610000A for ; Mon, 19 Feb 2024 22:17:13 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GfYGMr7Z; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708381033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CxtMk3yq2Qz4CG4FzUmJSlKegITC+zYFcxo/o9Az1yM=; b=1gs1C3Qpl4d6/jm0lP6VLrXGVgMG5Z6Wl5D5xC33GzUp1Ipiy8QyfjqlNcmI2nse3lYF+I LW55zUjAvbPu6ViJ6kgTuSMbLGjckbpf6EVqRwDOO2h9U2qmzA4LkjlXMzLnH/a6npC1vV bjZCgIP8eGvFNYKpPTXycNN7QcokQU4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GfYGMr7Z; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708381033; a=rsa-sha256; cv=none; b=IlFzY2EaLeHf7XJPiGgzTZtCL3EKsbSHAbfJPK5nrdYrECXb5GLBQ6fhTDo63T2OtsDASh byuA+XCtIYRnlzBm7heJNqVmbaxV+CKtLdnu/isO5WzWszfJUITPOWpq6cUoDX64oFJV1k h8dOI1b4wVcUJlvQ5Pq26Kl/tbEcUjc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7A0CF60EA5; Mon, 19 Feb 2024 22:17:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD8ADC433F1; Mon, 19 Feb 2024 22:17:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1708381032; bh=QqEECE7J9KzN04/aZSUGpwjB+2RUj7Mu2p+vi43L4Xo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GfYGMr7ZEJQfihP6Kke0iD18IunQdnASEZ7PBQ/W19M7ffbOlwzSXRyW5GVKIJq6t +54VAIQ0s01xAJFyb0BhhFqE0hc7ynq2BqiLxpdd6zT3VZeImWHHt4foZEe9PBoKav MVjo++pixnGQqJ+EwcR4IoDq0YW4W1TvhYdu1wLw= Date: Mon, 19 Feb 2024 14:17:11 -0800 From: Andrew Morton To: Christoph Hellwig Cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Hui Su , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: put the xfs xfile abstraction on a diet v4 Message-Id: <20240219141711.2c6d171069166f0923f49b14@linux-foundation.org> In-Reply-To: <20240219062730.3031391-1-hch@lst.de> References: <20240219062730.3031391-1-hch@lst.de> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8424610000A X-Rspam-User: X-Stat-Signature: tzdqqpg7i7dc9fxexw4zorqieg99dokp X-Rspamd-Server: rspam01 X-HE-Tag: 1708381033-545499 X-HE-Meta: U2FsdGVkX19vM77r4xgYKRqxE0dEgto4nfPUeh4/bnZDEW96s0eoVkxY2hlRsQs+y7gzVfISGEvZL2clnDEDQ7Hcu9J6+AhDN0PdOECdJmVnz5wDVpvHHLk8Q90Lb7iNVE75OzvpwOHwNwfBNxfQjnUxKJSQEtufQYDXzHe0ouLJI9pwXKe6Ji/rbObE1GDqtoN9CpRy9VoD2bn1JQdok+ilvfW+6yhTsQGYsKbjZLwxxKyeVm2pHUhZpUV5XugAMGSMxJBdbel0wnbHrUZfcvapUKuE8lYcf1h9A12/8wO73ZFa7aNUS99D53OzdAYbyz0CESRNtrSTbTv0mhOv93/o35Qk8+Za9kXHh4d+bXLuL5RPG2ze5swaOe/I5hoJrjbxKPxv87sKkG4zwVmjOX9RN7pQm25oQJs/MkZp9RDcasNI1PxzkgR/QFYrgEi0//GqlCOMROONKnp6AAoiHlkF/h60zWF1d2KIMYu//nfuF28n8uFsTkyMU9oPZAA2hMy5XF6+j0gGHI8bAvbTCR4x+lFgMDsjTS11IOZOBaKHp4314eqHVCMmxme9X04MSQtzRFxF70A1oCriEdFWJV9tWXpB3TBGnCy4mTmZbIyBm98UMweLkyqeIAYHbf3BBAFWKbAqmmKczt3M20nyPZYzB9GHFKWBb9f+ZuIvHU9kASvkHE7CNaz4B2dHlijULtn1SJHh8dSrNzgcqpnOo3c+Lrsje9O/YFC1lTa+ewjajuBmldmREIncyO0Q+VBCLWu/SfvOeQQWuH23/ZIyGsLTfKrYS5CNlyj/PA9pKdnOGjO4vR4BZAI8OSdfOlT3Y7iBdqRo3K2oo8UQOhnPhK2b/paoxhHQLmsCwt8tEyzEs3fF5NoG+z+ntJ75veJDHo25oU2WeYkyEdDGxaOCOLX0ZL2QfgnMOe/QSAoaESJKwiMQqf0B2cw7zN/YZWDlcRan+H5irDIrbA+T0zJ qFWlhgTZ u/OAIkStvdVOOrqPCMPgbS4XZ9GCfin/9EYKOwJwfu5UAJIQ4ILk/GUxFLltdPhR3+KTIyfh7BpAv7fZENk5gaQwd5FeMHBJg+5z/eD9wgyj1u4QR9pauozVR3PsUGn2U1P4e8UT3MUP8QcPYfH9Ty7TsM7Aw0HXjCkMsacGk8BFt+4WjUQEfmAIKtIrG5fPUnAwgbbdfSoOY88xwpSN5wF8PAHToUmh3BITv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 19 Feb 2024 07:27:08 +0100 Christoph Hellwig wrote: > this series refactors and simplifies the code in the xfs xfile > abstraction, which is a thing layer on a kernel-use shmem file. > > To do this is needs a slighly lower level exports from shmem.c, > which I combined with improving an assert and documentation there. > > As per the previous discussion this should probably be merged through > the xfs tree. The mm/ changes look OK to me. Some are quite welcome! Please proceed with the above merge plan.