From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45650C48260 for ; Mon, 19 Feb 2024 06:31:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB0D06B007D; Mon, 19 Feb 2024 01:31:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C608B6B0088; Mon, 19 Feb 2024 01:31:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B28206B0093; Mon, 19 Feb 2024 01:31:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A22F16B007D for ; Mon, 19 Feb 2024 01:31:52 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5FEA9C022C for ; Mon, 19 Feb 2024 06:31:52 +0000 (UTC) X-FDA: 81807582864.17.1E094B1 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf20.hostedemail.com (Postfix) with ESMTP id 458C41C000C for ; Mon, 19 Feb 2024 06:31:45 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708324309; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HEvscUIGswPayhJvEl0TD6OKF4eQQafeT5zbk5nQDd0=; b=ebDpCSv9SKGQReHWKxA7B7+ATDDS76481+1d3m0QraXge0eiAnLt9QcoyFsQ+lalcpYZYa XiH9GyqJDdKcX9A4yh1qwBFovL5OuSdEx9TzXOxPL+VgHdOcrcqjxz9BN3ItcXRCGMzM75 /oP+LZxRjOcIk2PZnCaKeHhcXYqMkII= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708324309; a=rsa-sha256; cv=none; b=2EXTmDEinVCQ6toVF5gqyQIhyzw6/aDEhXcdwwX0VuY/5eeFRDvTvYoezTzcHLFit1Yua9 JIfMR9i8uxSA/Cb2IzU95x9Mt2AoV2k3OxjBS4uohka4TxnsbY1aeeMVBqGcFxFn9HSQNX 2L1kFI54jQfywWShLsnLtsiBoOQng/w= X-AuditID: a67dfc5b-d85ff70000001748-01-65d2f5d0f14a Date: Mon, 19 Feb 2024 15:31:39 +0900 From: Byungchul Park To: Baolin Wang Cc: akpm@linux-foundation.org, ying.huang@intel.com, osalvador@suse.de, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, stable@vger.kernel.org Subject: Re: [PATCH] mm/vmscan: Fix a bug calling wakeup_kswapd() with a wrong zone index Message-ID: <20240219063139.GC65758@system.software.com> References: <20240216111502.79759-1-byungchul@sk.com> <517e58d4-7537-4d9f-8893-0130c65c3fdb@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <517e58d4-7537-4d9f-8893-0130c65c3fdb@linux.alibaba.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGLMWRmVeSWpSXmKPExsXC9ZZnoe6Fr5dSDd6vNLSYs34Nm8X/vccY LVZv8rW4vGsOm8W9Nf9ZLc5MK7JYsPERo8XJWZNZHDg8Dr95z+yxeM9LJo9Nnyaxe5yY8ZvF Y+dDS4/Np6s9Pm+SC2CP4rJJSc3JLEst0rdL4Mp40nyJteC5ckXnvXVsDYybZLoYOTkkBEwk 9hz6x9jFyAFm33mmDGKyCKhKXNzmC1LBJqAucePGT2aQsIiAvkTvXLAws8BBRolDL2xAbGGB aInH7+ayg9i8AhYST3Y+ZAaxhQQKJI5OvgEVF5Q4OfMJC0SvusSfeZfARjILSEss/8cBEZaX aN46G6yVU8BV4tjqp0wgtqiAssSBbceBbC6gG4+wSUz8cJkJ4nhJiYMrbrBMYBSchWTFLCQr ZiGsmIVkxQJGllWMQpl5ZbmJmTkmehmVeZkVesn5uZsYgbGxrPZP9A7GTxeCDzEKcDAq8fBm iFxKFWJNLCuuzD3EKMHBrCTC6950IVWINyWxsiq1KD++qDQntfgQozQHi5I4r9G38hQhgfTE ktTs1NSC1CKYLBMHp1QDo0nLiwqb983M88o1+Rdu/pKtqzmVf96Uq19unbRZEvJVx2W7rom/ u0PrA5M9i4Vd4wq7TobOm7OCa+3GOsX+YyaFi85ur7nq8SKwZ8Hn2t1fzCM6y3SE+2tbrqfn 1KXky1ncrYmsjJP/nqPsmKP/82762uWJ8tn8L6wzD579zb3n5rXjpjZhSizFGYmGWsxFxYkA mpFoV4kCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsXC5WfdrHvh66VUg96XKhZz1q9hs/i/9xij xepNvhaH555ktbi8aw6bxb01/1ktzkwrsliw8RGjxclZk1kcOD0Ov3nP7LF4z0smj02fJrF7 nJjxm8Vj50NLj8UvPjB5bD5d7fF5k1wARxSXTUpqTmZZapG+XQJXxpPmS6wFz5UrOu+tY2tg 3CTTxcjBISFgInHnmTKIySKgKnFxm28XIycHm4C6xI0bP5lBwiIC+hK9c8HCzAIHGSUOvbAB sYUFoiUev5vLDmLzClhIPNn5kBnEFhIokDg6+QZUXFDi5MwnLBC96hJ/5l0CG8ksIC2x/B8H RFheonnrbLBWTgFXiWOrnzKB2KICyhIHth1nmsDINwvJpFlIJs1CmDQLyaQFjCyrGEUy88py EzNzTPWKszMq8zIr9JLzczcxAgN9We2fiTsYv1x2P8QowMGoxMObIXIpVYg1say4MvcQowQH s5IIr3vThVQh3pTEyqrUovz4otKc1OJDjNIcLErivF7hqQlCAumJJanZqakFqUUwWSYOTqkG xkTt/r2ffZq/fAgscyqd4eIywZjz2ed8VTGLu1e9d58XvR14Od9SayvnMt0JwUcyrwbocUld vHSy49Pp2pLVs9lFPn7NTvz+K6jz/SrRZCvD9oPt81feXu9nOG2RZMgPu9rkbRc28D23CtaM 2mG1plyRc9qU8rfb++QluOvCzsk5Fi/LUrt9VomlOCPRUIu5qDgRACBOvv5wAgAA X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 458C41C000C X-Rspam-User: X-Stat-Signature: 1qep86m61ad8wj4m3ntymudggmtc9eh9 X-Rspamd-Server: rspam01 X-HE-Tag: 1708324305-379133 X-HE-Meta: U2FsdGVkX1+YlYw5a2raVcmQXrafxXf2e5jZob3TBE6xuUBcGUw0JQtxkPS6YqWlDj094gTTTj62y0cNK/BWjbC6g2GgRehVl1xZ9+4iipHLPdhFjtG+Lc66grjU9S3IPgyvt5pBZq/xZvqwRX+qmJ+YW4/ruonjQ/YabnZvK8k5xSYZrxeoLG4EaL6IiuPjMo4oNXuqumuxixS2b51ZjkKohRqFt71+IR7RVSUrcTFCWpG6YKK6iz6pO/soXeMZ2oG/jZBfcF0P1rOotEBMYaj7MWnUCKrLaDi/zfef5brSHpPEte4KnlhsiR3q+nxVsv6sGwCQvGhz3jal9HUQPmtrETTXfFE0OvFSvwYNv50jbqt6XL1UzDdhi6ycjr+WF2jfwo4Kk8JaaPE4e0D1uVnoqB3+ix+aGKgQTToaDD0qf7OAHKhBUry28YDmSZRVE7oqYN/gX8eWHnk8Th6iGHtuR3/Mk7zqe3ThSxSndn7z4u9ynACLxfVddYv0GLqLLZZWIatnvCl7TtM6EvyJD4KK6+fZXIScJ/duU04/bU/tkHgRsSo3NURo/7WWYiMowMpsJDUBtX/bx2VEAd+5gTdBW018G1wKVt6xXMj1s2klQnOV7fn0Oq1fe4Jura3Vy70G/BKw9tpC2sIaMKd5pc/j0QrOZuGGPJQIVmk0mFJ6RXl8kvk5jgOSqG6/x5OJDb21dhWSzGMvhe7fb4HELw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 19, 2024 at 02:25:11PM +0800, Baolin Wang wrote: > > > On 2024/2/16 19:15, Byungchul Park wrote: > > With numa balancing on, when a numa system is running where a numa node > > doesn't have its local memory so it has no managed zones, the following > > oops has been observed. It's because wakeup_kswapd() is called with a > > wrong zone index, -1. Fixed it by checking the index before calling > > wakeup_kswapd(). > > > > > BUG: unable to handle page fault for address: 00000000000033f3 > > > #PF: supervisor read access in kernel mode > > > #PF: error_code(0x0000) - not-present page > > > PGD 0 P4D 0 > > > Oops: 0000 [#1] PREEMPT SMP NOPTI > > > CPU: 2 PID: 895 Comm: masim Not tainted 6.6.0-dirty #255 > > > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS > > > rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014 > > > RIP: 0010:wakeup_kswapd (./linux/mm/vmscan.c:7812) > > > Code: (omitted) > > > RSP: 0000:ffffc90004257d58 EFLAGS: 00010286 > > > RAX: ffffffffffffffff RBX: ffff88883fff0480 RCX: 0000000000000003 > > > RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff88883fff0480 > > > RBP: ffffffffffffffff R08: ff0003ffffffffff R09: ffffffffffffffff > > > R10: ffff888106c95540 R11: 0000000055555554 R12: 0000000000000003 > > > R13: 0000000000000000 R14: 0000000000000000 R15: ffff88883fff0940 > > > FS: 00007fc4b8124740(0000) GS:ffff888827c00000(0000) knlGS:0000000000000000 > > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > CR2: 00000000000033f3 CR3: 000000026cc08004 CR4: 0000000000770ee0 > > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > PKRU: 55555554 > > > Call Trace: > > > > > > ? __die > > > ? page_fault_oops > > > ? __pte_offset_map_lock > > > ? exc_page_fault > > > ? asm_exc_page_fault > > > ? wakeup_kswapd > > > migrate_misplaced_page > > > __handle_mm_fault > > > handle_mm_fault > > > do_user_addr_fault > > > exc_page_fault > > > asm_exc_page_fault > > > RIP: 0033:0x55b897ba0808 > > > Code: (omitted) > > > RSP: 002b:00007ffeefa821a0 EFLAGS: 00010287 > > > RAX: 000055b89983acd0 RBX: 00007ffeefa823f8 RCX: 000055b89983acd0 > > > RDX: 00007fc2f8122010 RSI: 0000000000020000 RDI: 000055b89983acd0 > > > RBP: 00007ffeefa821a0 R08: 0000000000000037 R09: 0000000000000075 > > > R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000000 > > > R13: 00007ffeefa82410 R14: 000055b897ba5dd8 R15: 00007fc4b8340000 > > > > > > > Signed-off-by: Byungchul Park > > Reported-by: Hyeongtak Ji > > Cc: stable@vger.kernel.org > > Fixes: c574bbe917036 ("NUMA balancing: optimize page placement for memory tiering system") > > This means that there is no memory on the target node？ if so, we can add a > check at the beginning to avoid calling unnecessary > migrate_misplaced_folio(). Right. However, the check is necessary no matter where it comes from. FYI, the fix is going on in another thread: https://lore.kernel.org/lkml/20240216114045.24828-1-byungchul@sk.com/ https://lore.kernel.org/lkml/20240219041920.1183-1-byungchul@sk.com/ Byungchul > diff --git a/mm/memory.c b/mm/memory.c > index e95503d7544e..a64a1aac463f 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -5182,7 +5182,7 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf) > else > last_cpupid = folio_last_cpupid(folio); > target_nid = numa_migrate_prep(folio, vma, vmf->address, nid, > &flags); > - if (target_nid == NUMA_NO_NODE) { > + if (target_nid == NUMA_NO_NODE || !node_state(target_nid, N_MEMORY)) > { > folio_put(folio); > goto out_map; > } > > (similar changes for do_huge_pmd_numa_page()) > > > --- > > mm/migrate.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/mm/migrate.c b/mm/migrate.c > > index fbc8586ed735..51ee6865b0f6 100644 > > --- a/mm/migrate.c > > +++ b/mm/migrate.c > > @@ -2825,6 +2825,14 @@ static int numamigrate_isolate_folio(pg_data_t *pgdat, struct folio *folio) > > if (managed_zone(pgdat->node_zones + z)) > > break; > > } > > + > > + /* > > + * If there are no managed zones, it should not proceed > > + * further. > > + */ > > + if (z < 0) > > + return 0; > > + > > wakeup_kswapd(pgdat->node_zones + z, 0, > > folio_order(folio), ZONE_MOVABLE); > > return 0;