From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 033F6C48BC4 for ; Mon, 19 Feb 2024 02:09:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5576D6B0085; Sun, 18 Feb 2024 21:09:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 507AF6B0088; Sun, 18 Feb 2024 21:09:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CEF06B0089; Sun, 18 Feb 2024 21:09:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2C4636B0085 for ; Sun, 18 Feb 2024 21:09:09 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9D2BAA0221 for ; Mon, 19 Feb 2024 02:09:08 +0000 (UTC) X-FDA: 81806920776.27.5E765F4 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf15.hostedemail.com (Postfix) with ESMTP id A2BABA000F for ; Mon, 19 Feb 2024 02:09:04 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708308547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bakTu0Wgr+lpD3iZQrWCbmV1QY8l1NopcS9Pm1xX/7c=; b=zAKySG1FO/drRzcIfRQboNYXiP2UiLl83Tdn2WSU/zoRiVq8J8ph+bcDDx6ZLT+YMfQuiU 3amY5kfzdub4kxoDgb8WuvTLgcPoLH51hu3+ue/bwmFyCkNM75WGelmpSm6UpLrgu0gGDm SGqgxSfo71JU6Zkjg9tpg8gXrz6MOxc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708308547; a=rsa-sha256; cv=none; b=XURQaLX74v4h8U2a1JPzVkPpjn7YIiRhJTT8ICa8WHPWiBWFZkEkJh/1Pcwn+i38Dm94Pw P3ByGZIgeC77TaZss4Mr4xyDbLg0UgK6gYS4bApZ1bkQA1imbD9ii/SkeureUH/89eTNZB QIuYu19e5pQ77iTQIqWavBIXj0xlqLI= X-AuditID: a67dfc5b-d6dff70000001748-7b-65d2b83c33aa Date: Mon, 19 Feb 2024 11:08:54 +0900 From: Byungchul Park To: Oscar Salvador Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org Subject: Re: [PATCH v3] sched/numa, mm: do not promote folios to nodes not set N_MEMORY Message-ID: <20240219020854.GA65758@system.software.com> References: <20240216114045.24828-1-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplkeLIzCtJLcpLzFFi42LhesuzUNdmx6VUg+s/JCzmrF/DZnHp8VU2 i+kvG1ksnk7Yymxxt38qi8XlXXPYLO6t+c9qMfndM0aLSwcWMFmcmVZkcbz3AJPFvo4HTBYd R74xW2w9+p3dgc9jzbw1jB4t+26xeyzYVOqxeYWWx6ZPk9g97lzbw+ZxYsZvFo/3+66yeWw+ Xe3xeZNcAFcUl01Kak5mWWqRvl0CV8b67l+sBQsEKnp+T2BsYLzH08XIySEhYCLR27ubCcZe v3AyI4jNIqAqsffGFzCbTUBd4saNn8wgtoiAmsS0V43sXYxcHMwCp5gkJny+AORwcAgLREoc eisIUsMrYCEx7+xHVpCwkECCxJ/L7hBhQYmTM5+wgNjMAloSN/69ZAIpYRaQllj+jwMkzClg KrHoynp2EFtUQFniwLbjTCCbJASa2SXazq9jhThTUuLgihssExgFZiEZOwvJ2FkIYxcwMq9i FMrMK8tNzMwx0cuozMus0EvOz93ECIykZbV/oncwfroQfIhRgINRiYc3Q+RSqhBrYllxZe4h RgkOZiURXvemC6lCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeY2+lacICaQnlqRmp6YWpBbBZJk4 OKUaGAXlZpiKJsrd31C0T8PnABNj9dXmrzxy2ZJFWkySBt0JbO0u2lr1e5ctkVZZ8mTR7ba+ mBt/Nv30e18X/+KE5doHugt19tWyxBpbGvAJL1+y/DN3VIrV1A/s86+u3qX04aqxY/7jkjyB E2WWe6ar7rh/8n2F0KopS3hma7PmxWg8OF7W/syVS4mlOCPRUIu5qDgRADv7PY6gAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsXC5WfdrGuz41KqwY33XBZz1q9hs7j0+Cqb xfSXjSwWTydsZba42z+VxeLw3JOsFpd3zWGzuLfmP6vF5HfPGC0uHVjAZHFmWpHF8d4DTBb7 Oh4wWXQc+cZssfXod3YHfo8189YwerTsu8XusWBTqcfmFVoemz5NYve4c20Pm8eJGb9ZPN7v u8rmsfjFByaPzaerPT5vkgvgjuKySUnNySxLLdK3S+DKWN/9i7VggUBFz+8JjA2M93i6GDk5 JARMJNYvnMwIYrMIqErsvfEFzGYTUJe4ceMnM4gtIqAmMe1VI3sXIxcHs8ApJokJny8AORwc wgKREofeCoLU8ApYSMw7+5EVJCwkkCDx57I7RFhQ4uTMJywgNrOAlsSNfy+ZQEqYBaQllv/j AAlzCphKLLqynh3EFhVQljiw7TjTBEbeWUi6ZyHpnoXQvYCReRWjSGZeWW5iZo6pXnF2RmVe ZoVecn7uJkZgXCyr/TNxB+OXy+6HGAU4GJV4eDNELqUKsSaWFVfmHmKU4GBWEuF1b7qQKsSb klhZlVqUH19UmpNafIhRmoNFSZzXKzw1QUggPbEkNTs1tSC1CCbLxMEp1cB42j9ia21Gqnjs 0aYOM88AtWLeRd5Ff7V+Xr37K0SHc6nj3WMzLtou43MseXr1rebecP4/7S2STukGO3c41+5k b7qxYdv2rEP8p28YTsnJ1DBevERrx9WtlcnFT5X6K4VtqjM1+hT+TjMs/qGj+eOms27OfJXJ F3/bntZW2d/jrxNz4f7BTH0lluKMREMt5qLiRACSVU0DhwIAAA== X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A2BABA000F X-Stat-Signature: y1pheh1gjo1zena44ucgfzngifkjq78e X-Rspam-User: X-HE-Tag: 1708308544-211657 X-HE-Meta: U2FsdGVkX19q4ARYXb5OOtfIHa0nL5l1UlIDzKmoLfMj/FZ+JdTXd+pMhxksPUZWysSgL5cpvseZoYW8ZDg/bdoLMTdzqb7JFZibY/fcEz+GlO22Jjb5klqQsxikGH30LSx6vvzejVBh1fq3WnlcbscmKO/+iN/CrKXfTYP62CfH1sgkPeBBsGqc2pV04vAMAp/Qt904eSh4Kic5ecerG/K5NH7QcpZlb2DACB7whgXnavglGycpqMnasKuZOUZ157C4Oqf3hKSHA+Zg4d6t5Y1gSuOz1l0E0O3kPsDE0cXe1r6uwOnwD1o5HlWZIygdZNhYblerMb1pHnc01S3uhhLkpprkMxyILtDB0E00JAN9t2R89OTlFc9gY+sNky0+BaygKmlJ8cZm8l1klkUPuLVtMXww2TdFvmHERQy6S/eK3HdZeumZxzKWwsYJ7DfhTHOi83ninpgjBotpNavb3WkgZFF12LAAVE3SbG0unYFG0apOja9VVA8CbeXUlmod7FUd5QK0BflVyN5WOp/Xsc9vQ/OnBU8D4onjakseMvRsm3bL/xQ0Lh11JA9AyLQBO12X9Jlb/3wzfrdpMRU53KBGK8dGRjuTrVH0JN75ksyJERkon01QREiIZf5WMrZICBkGSxzPkbVsUpLNya+PtAVaHaoxU+5+O0vyCAAPQEISeLsFxyc5MKXD2J10lItK2gw8ZTYcMPe8YSfImvoPAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 02:51:24PM +0100, Oscar Salvador wrote: > On Fri, Feb 16, 2024 at 08:40:45PM +0900, Byungchul Park wrote: > > From 150af2f78e19217a1d03e47e3ee5279684590fb4 Mon Sep 17 00:00:00 2001 > > From: Byungchul Park > > Date: Fri, 16 Feb 2024 20:18:10 +0900 > > Subject: [PATCH v3] sched/numa, mm: do not promote folios to nodes not set N_MEMORY > > "do not try to promote folios to memoryless nodes" Thank you. I will. > because AFAICS we are just trying. > Even if should_numa_migrate_memory() returns true, I assume that we will > fail somewhere down the chain e.g: migrate_pages() when we see that this > node does not any memory, right? Yes. > > A numa node might not have its local memory but CPUs. Promoting a folio > > to the node's local memory is nonsense. So avoid nodes not set N_MEMORY > > from getting promoted. > > If you talk about memoryless nodes everybody gets it better IMHO. > "Memoryless nodes do not have any memory to migrate to, so stop trying it." Much better. > > Signed-off-by: Byungchul Park > > --- > > kernel/sched/fair.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index d7a3c63a2171..7ed9ef3c0134 100644 > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c > > @@ -1828,6 +1828,13 @@ bool should_numa_migrate_memory(struct task_struct *p, struct folio *folio, > > int dst_nid = cpu_to_node(dst_cpu); > > int last_cpupid, this_cpupid; > > > > + /* > > + * A node of dst_nid might not have its local memory. Promoting > > + * a folio to the node is meaningless. > > + */ > > + if (!node_state(dst_nid, N_MEMORY)) > > + return false; > > "Cannot migrate to memoryless nodes" > > seems shorter and more clear. Agree. Byungchul > So, what happens when we return true here? will we fail at > migrate_pages() I guess? That is quite down the road so I guess > this check can save us some time. > > > -- > Oscar Salvador > SUSE Labs