From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A480DC48BF6 for ; Sun, 18 Feb 2024 13:02:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAD208D0003; Sun, 18 Feb 2024 08:02:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B5D948D0001; Sun, 18 Feb 2024 08:02:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A25108D0003; Sun, 18 Feb 2024 08:02:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8EAB18D0001 for ; Sun, 18 Feb 2024 08:02:27 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2EC4C1A018B for ; Sun, 18 Feb 2024 13:02:27 +0000 (UTC) X-FDA: 81804938334.18.7F33049 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by imf03.hostedemail.com (Postfix) with ESMTP id 8DCB920020 for ; Sun, 18 Feb 2024 13:02:24 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jgk5wIy6; spf=pass (imf03.hostedemail.com: domain of lkp@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708261345; a=rsa-sha256; cv=none; b=cbZ/aHnJpKR4yWwUyp+nL2Z2JvK5xER/xiCsRWoSIY7lu4HdBQXSjvd6YjkEcX4Q2lWjxH l4SvraeTazweZba0Io9FWmDbOt/Q60CwohMtKNeU5ZH3HyO+Cpe5dd1xVGziEaOPiN695K dLwCqFjFTxgB9URRqYuvdFBKk05OKb0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jgk5wIy6; spf=pass (imf03.hostedemail.com: domain of lkp@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708261345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CSokenJwckkf5CmIxRDAyvN7teENNYUKqgV+UX9qhRs=; b=Om2GZktTvvw+m18tRQ9vSZmRVUir1fM7+/6vm8o8pIwAvWYP69SBI5dybBkBQRe6cecIHE JMbanNHQ0u29u8y4TOY1piM5/IRlet9cOVFfIU136RqcuyDUkwczsP+j3JtdkTgjWzB6ZR 8y2NqAeglyyQxJgebymG7mPWgCBUePY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708261344; x=1739797344; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=dVY8BMPtchDOweysfrajkGdjXqnmHGF53GbnihHyl/8=; b=jgk5wIy6ymWcAWjmwDBnWClaKHcyWI5posqHnPdnyZRGvhr9kfwMEovB 2dQ6NeRUZcqWYXM0s0Q1l4HSlmRybhIfxMkTYc51lWqml6OO7XSFRetvT 1drBv7dmnv115x9QZb95Bbs50PdrNfwLqueczcbmscvYXc2LtbhmMSX+8 1nsIPnaYQD6Qd9krXEz/49SLzuBee7gHB4Y4DF9ZN5VCLSd9l5dOGffBc mamn7f+UUk0xiatXNtWWFd7lXeFB6tzMFgNr8ThR8Q0yrr6FzNgBuBqaa iZKZ7waO10NzqdX6vYCN51n+PJgH81J9rQMwYAoA5+1+En2uoyiBxoKwR w==; X-IronPort-AV: E=McAfee;i="6600,9927,10987"; a="2207209" X-IronPort-AV: E=Sophos;i="6.06,168,1705392000"; d="scan'208";a="2207209" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2024 05:02:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,168,1705392000"; d="scan'208";a="8850629" Received: from lkp-server02.sh.intel.com (HELO 3c78fa4d504c) ([10.239.97.151]) by fmviesa003.fm.intel.com with ESMTP; 18 Feb 2024 05:02:18 -0800 Received: from kbuild by 3c78fa4d504c with local (Exim 4.96) (envelope-from ) id 1rbgnS-00031w-2W; Sun, 18 Feb 2024 13:01:49 +0000 Date: Sun, 18 Feb 2024 20:58:37 +0800 From: kernel test robot To: Robert Richter , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Jonathan Cameron , Dave Jiang , Davidlohr Bueso , "Rafael J. Wysocki" , Andrew Morton Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, Len Brown , Robert Richter , linux-acpi@vger.kernel.org Subject: Re: [PATCH v4 3/3] lib/firmware_table: Provide buffer length argument to cdat_table_parse() Message-ID: <202402182055.zfTIyfls-lkp@intel.com> References: <20240216155844.406996-4-rrichter@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240216155844.406996-4-rrichter@amd.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8DCB920020 X-Stat-Signature: exsqmo7wai999gk779663r89cy4suass X-Rspam-User: X-HE-Tag: 1708261344-209584 X-HE-Meta: U2FsdGVkX18ZfIrEGYJLV6E9sZtjn2pgwizTxSBMX1Ew3JGPHbCxcSf2K1aVy5gNcbPl/dLndUB8qeSaz4M/uuJD9CUP0/EsN1zAawHQPqqEHlBCi4LN6KimN+3zbG+IQsG9mmM7Wm1Au+/M/zgXShA23FSc0doWn0Nzzg5x5fR6DXNFMIZazwQmmxa958ctJa7he4BtR+uyEBg3fk2ilUmyqeN2w9+s5Pdn84gLyeqoPRORjmRaVM2qrUqrUq3MSP7RmbOLftNo+sde6NPWFDBUJqDCEgWhrWNAkfWOONA42iaom9CxtP4stE97AtecfF6yKva22tPLarUhV2NldK4MbfbFYbM97lYnXejmlwcHWj257hJr8xauFTfMP3E5864ZCnNJckrSvwmHy1OC60MA3gnSvTdYUo5xiccaM0PGmf6OP2cj6a5sx50E13nQcizpv+3Hki8yuwVZ1+69AcBeOB82TJtpW+xQ0P+WjH5NsAYGTGqQMQb6qLImbZ2IxkOk/2evRbLG6lMMdwOOpdoktHdeDQQI5aPmpMMFSZtms4qWmbxHZJHHvX1KF7h0FiCwLyjsj17y7BaOBAM9R/dQzjAz2KKc4mWvHPZCZdIGgr2U9WL3ZVczJlGrr9KKArCNcElQrrbZruVd+IRy35MCpiLK29p9H07uh/5qroVRD4TB1IxH3Mqe52ZPMaG0AQVWB2++Np6Mcocp5lErrhQt+isg7gY+RyucN8IgX72JV5tmTWMfPrrp0MCwtOldn8j4W9Bx3ZIA3vuQDSnQmiTFz3WTxCtU15+VI/qapo4Ys9lwFoFmFWpnL6Zta/+NGhrpaikqmvl4np5XF0zeMf14OKGIWXs7Ezo/8Tfgj2xZBxHImzxC0bbmnTs+5A9QVSPAOR0xW3M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Robert, kernel test robot noticed the following build warnings: [auto build test WARNING on 6be99530c92c6b8ff7a01903edc42393575ad63b] url: https://github.com/intel-lab-lkp/linux/commits/Robert-Richter/cxl-pci-Rename-DOE-mailbox-handle-to-doe_mb/20240217-000206 base: 6be99530c92c6b8ff7a01903edc42393575ad63b patch link: https://lore.kernel.org/r/20240216155844.406996-4-rrichter%40amd.com patch subject: [PATCH v4 3/3] lib/firmware_table: Provide buffer length argument to cdat_table_parse() config: i386-randconfig-006-20240217 (https://download.01.org/0day-ci/archive/20240218/202402182055.zfTIyfls-lkp@intel.com/config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240218/202402182055.zfTIyfls-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202402182055.zfTIyfls-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/cxl/core/pci.c:673:4: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat] 672 | dev_warn(dev, "Malformed CDAT table length (%lu:%lu), discarding trailing data\n", | ~~~ | %zu 673 | table_length, length); | ^~~~~~~~~~~~ include/linux/dev_printk.h:146:70: note: expanded from macro 'dev_warn' 146 | dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__) | ~~~ ^~~~~~~~~~~ include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ~~~ ^~~~~~~~~~~ drivers/cxl/core/pci.c:673:18: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat] 672 | dev_warn(dev, "Malformed CDAT table length (%lu:%lu), discarding trailing data\n", | ~~~ | %zu 673 | table_length, length); | ^~~~~~ include/linux/dev_printk.h:146:70: note: expanded from macro 'dev_warn' 146 | dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__) | ~~~ ^~~~~~~~~~~ include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ~~~ ^~~~~~~~~~~ 2 warnings generated. vim +673 drivers/cxl/core/pci.c 611 612 /** 613 * read_cdat_data - Read the CDAT data on this port 614 * @port: Port to read data from 615 * 616 * This call will sleep waiting for responses from the DOE mailbox. 617 */ 618 void read_cdat_data(struct cxl_port *port) 619 { 620 struct device *uport = port->uport_dev; 621 struct device *dev = &port->dev; 622 struct pci_doe_mb *doe_mb; 623 struct pci_dev *pdev = NULL; 624 struct cxl_memdev *cxlmd; 625 struct cdat_doe_rsp *buf; 626 size_t table_length, length; 627 int rc; 628 629 if (is_cxl_memdev(uport)) { 630 struct device *host; 631 632 cxlmd = to_cxl_memdev(uport); 633 host = cxlmd->dev.parent; 634 if (dev_is_pci(host)) 635 pdev = to_pci_dev(host); 636 } else if (dev_is_pci(uport)) { 637 pdev = to_pci_dev(uport); 638 } 639 640 if (!pdev) 641 return; 642 643 doe_mb = pci_find_doe_mailbox(pdev, PCI_DVSEC_VENDOR_ID_CXL, 644 CXL_DOE_PROTOCOL_TABLE_ACCESS); 645 if (!doe_mb) { 646 dev_dbg(dev, "No CDAT mailbox\n"); 647 return; 648 } 649 650 port->cdat_available = true; 651 652 if (cxl_cdat_get_length(dev, doe_mb, &length)) { 653 dev_dbg(dev, "No CDAT length\n"); 654 return; 655 } 656 657 /* 658 * The begin of the CDAT buffer needs space for additional 4 659 * bytes for the DOE header. Table data starts afterwards. 660 */ 661 buf = devm_kzalloc(dev, sizeof(*buf) + length, GFP_KERNEL); 662 if (!buf) 663 goto err; 664 665 table_length = length; 666 667 rc = cxl_cdat_read_table(dev, doe_mb, buf, &length); 668 if (rc) 669 goto err; 670 671 if (table_length != length) 672 dev_warn(dev, "Malformed CDAT table length (%lu:%lu), discarding trailing data\n", > 673 table_length, length); 674 675 if (cdat_checksum(buf->data, length)) 676 goto err; 677 678 port->cdat.table = buf->data; 679 port->cdat.length = length; 680 681 return; 682 err: 683 /* Don't leave table data allocated on error */ 684 devm_kfree(dev, buf); 685 dev_err(dev, "Failed to read/validate CDAT.\n"); 686 } 687 EXPORT_SYMBOL_NS_GPL(read_cdat_data, CXL); 688 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki