From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3549CC48BC4 for ; Sun, 18 Feb 2024 21:45:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 557826B0085; Sun, 18 Feb 2024 16:45:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 508736B0088; Sun, 18 Feb 2024 16:45:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41D3B6B0089; Sun, 18 Feb 2024 16:45:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2EB076B0085 for ; Sun, 18 Feb 2024 16:45:38 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BAA521C00FC for ; Sun, 18 Feb 2024 21:45:37 +0000 (UTC) X-FDA: 81806256714.24.7F214FD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 24BE640009 for ; Sun, 18 Feb 2024 21:45:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zKNM5G5Y; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708292736; a=rsa-sha256; cv=none; b=70fPRWXAetExsZIXfwW99VcN6gMseOHnu9FVrk7KyBN8wTK/TUS999R/R/BZeA5NfPsrg7 EWP3ExFi8v4EWGA82XnOblOUr6HgAGaRO79bGS2y1yP7C1OY76auslafs9qBHx2ve6ohnU usxUEVaelZ3679NF6EI9RTyJ9ne7SkM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zKNM5G5Y; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708292736; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ES7XbA6v978Hj7tQoFXsIHoL1ljvqFgWyMbxulyyaog=; b=nvgA4vueZj/0SCVmSlS6pdC8glgwMkxtri9wKg5A1pD2OKdntV8VO0KKhuSs3Gewp55hFV ZD7UPOxPeVBsoUjQZywvt2tJlSUVSuPJWcfSkRgdKIurrRE+G4tvYbZJXQTguQKvkULbrn yq+Lecqmn3k1FOkwqfVo9M4PJXO1bq0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4E1FB60AE2; Sun, 18 Feb 2024 21:45:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8B4CC433F1; Sun, 18 Feb 2024 21:45:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1708292735; bh=l95OYFV0oWrXm6XhHujtK/Iz/W76B054ieH/C9GE0GU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zKNM5G5YwF1ogU++a7VUsSysSaZVgQbYutxxrkHXOIncI5iCLrgZvzFj7qMRvcKJp 9m/Qe0vD+3vYOX6eh4GDtMnhrhtWO8UX1pkyLeQp/AC88cwZvB5ekS86ad/hNqMXk0 wXUwIWkCK6tACHeD0rtEsnsfTgRdRZsVepri6kUg= Date: Sun, 18 Feb 2024 13:45:34 -0800 From: Andrew Morton To: Yosry Ahmed Cc: Barry Song <21cnbao@gmail.com>, hannes@cmpxchg.org, linux-mm@kvack.org, nphamcs@gmail.com, zhouchengming@bytedance.com, senozhatsky@chromium.org, linux-kernel@vger.kernel.org, Barry Song Subject: Re: [PATCH v2] mm: zswap: increase reject_compress_poor but not reject_compress_fail if compression returns ENOSPC Message-Id: <20240218134534.15a7b1cc7f297a2ecf4b8bc9@linux-foundation.org> In-Reply-To: References: <20240217053642.79558-1-21cnbao@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 24BE640009 X-Stat-Signature: 7jasb58au8wh68t9axgh7dsnaihf8dxd X-Rspam-User: X-HE-Tag: 1708292735-318785 X-HE-Meta: U2FsdGVkX19z+3PJ7CE9NI7fvATCsrkTv/X03BfLiNupptHqXlDjx04dvuxxm4gEGugDOj333W8DAchs2hh3bljzZOnasBmWUK2nC8yRPSm36t3aTGYqGsTDZ6lYY1ehezSdrTbe0vPqivTeBEIfavRzyu8+QJNp3tiM/yoVUO2/3hAF2VHRMA4SxCKg/Nu18pWBW5v41zigjia+aVeMKKLo61wXryuHaXyNPTIkBVCVtck/GsQ5jPrPlBl21vKY+JNgs/LA8WkQccv3s9uq+EXlMwfh9AW3NgHZwdcezXHpO0L9OUpqFspPJwuDJAVj4KMxeyUtnImkDxhet1IvIAtosCMGNz9Sb6qF0acRJbdPmwrXcqpWZt71Mu04ZLWO4qJPOnxmgt+1Dde2nOkniDP5XAInak96/SOPSVkxILsyQa4JzBBZ7EpvVVEehU9Gep0YSLJVNsL8I07dahY1jdjNxPEqcgazB91ONnChCyBbVr+Nlvbw830WTFj9CmViRsaN++QCEFf0bh3JZwXOLTlJvEeY1K/7semjw9mBGrT41b9b3ihO8DFfYXugpAF8MZdXefZlosvvY4M/q6eYHzbV2aclWdQ4A8Ng0Fj6FglHwH3jd+9HiEKK5YM/E4mw5ZOsuZvSXc4a0iwOUjg1eVwBAGpIrZ6tg247r8iK89JkQrvfAsQ5hgprnnjilzXKfvvyd7D1XVDJsaxd1mBcNHct7+4T4MA9gY9ms58BMd8v5XZD6ANLTj/hEZdOfHMXeqJij3CnoWGELxRLNxkN0hlfjpO2CM5Z1dXTJ6J9uWvCH+mEiBoafgu/ae3h6VZ6CehKCP8aJEE7xEu30l7RX51JVJg8TKb22/AUU4slbZltYbyLdFuop/9YqTaHeRZa6ESX8ABETKVlZpswWBGMsN4UZzm3XQre33IFss2h5eFQCy9PgCZFz6Sqh3cAshEN+uyQaFS5TWoi5LYs0pL UjxUGQTA 6WlIM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 17 Feb 2024 15:14:34 -0800 Yosry Ahmed wrote: > > > > > > > > The patch LGTM, but it won't apply on top of mm-unstable given the > > > amount of zswap refactoring there. I would rebase on top of mm-unstable > > > if I were you (and if you did, add mm-unstable in the subject prefix). > > > > This patch has a "fixes" tag, so I assume it should be also in 6.8? > > Hmm that's up to Andrew. This fixes debug counters so it's not > critical. On the other hand, it will conflict with the cleanup series > in his tree and he'll have to rebase and fix the conflicts (which > aren't a lot, but could still be annoying). Personally I think this > can wait till v6.9, but if Andrew doesn't have a problem taking it for > v6.8 that's fine too. Yes, there are some pretty extensive repairs needed after this change. I'd prefer not to because lazy, and there are risks involved. So against mm-unstable would be preferred please.