From: Andrew Morton <akpm@linux-foundation.org>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Barry Song <21cnbao@gmail.com>,
hannes@cmpxchg.org, linux-mm@kvack.org, nphamcs@gmail.com,
zhouchengming@bytedance.com, senozhatsky@chromium.org,
linux-kernel@vger.kernel.org, Barry Song <v-songbaohua@oppo.com>
Subject: Re: [PATCH v2] mm: zswap: increase reject_compress_poor but not reject_compress_fail if compression returns ENOSPC
Date: Sun, 18 Feb 2024 13:45:34 -0800 [thread overview]
Message-ID: <20240218134534.15a7b1cc7f297a2ecf4b8bc9@linux-foundation.org> (raw)
In-Reply-To: <CAJD7tkbHrMzi0z0SzQJj32cDrx4tyH5=_o41GM6JGf9DjahkYg@mail.gmail.com>
On Sat, 17 Feb 2024 15:14:34 -0800 Yosry Ahmed <yosryahmed@google.com> wrote:
> >
> > >
> > > The patch LGTM, but it won't apply on top of mm-unstable given the
> > > amount of zswap refactoring there. I would rebase on top of mm-unstable
> > > if I were you (and if you did, add mm-unstable in the subject prefix).
> >
> > This patch has a "fixes" tag, so I assume it should be also in 6.8?
>
> Hmm that's up to Andrew. This fixes debug counters so it's not
> critical. On the other hand, it will conflict with the cleanup series
> in his tree and he'll have to rebase and fix the conflicts (which
> aren't a lot, but could still be annoying). Personally I think this
> can wait till v6.9, but if Andrew doesn't have a problem taking it for
> v6.8 that's fine too.
Yes, there are some pretty extensive repairs needed after this change.
I'd prefer not to because lazy, and there are risks involved.
So against mm-unstable would be preferred please.
next prev parent reply other threads:[~2024-02-18 21:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 5:36 Barry Song
2024-02-17 8:52 ` Nhat Pham
2024-02-17 8:57 ` Yosry Ahmed
2024-02-17 10:19 ` Barry Song
2024-02-17 23:14 ` Yosry Ahmed
2024-02-18 21:45 ` Andrew Morton [this message]
2024-02-17 13:27 ` Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240218134534.15a7b1cc7f297a2ecf4b8bc9@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=21cnbao@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=v-songbaohua@oppo.com \
--cc=yosryahmed@google.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox