From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFD6EC48BF6 for ; Sun, 18 Feb 2024 21:39:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D40166B0082; Sun, 18 Feb 2024 16:39:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CC9366B0083; Sun, 18 Feb 2024 16:39:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB72F6B0085; Sun, 18 Feb 2024 16:39:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ABB896B0082 for ; Sun, 18 Feb 2024 16:39:00 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2AE82120177 for ; Sun, 18 Feb 2024 21:39:00 +0000 (UTC) X-FDA: 81806240040.04.20EAEA8 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf15.hostedemail.com (Postfix) with ESMTP id 2F30AA0012 for ; Sun, 18 Feb 2024 21:38:57 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="Nbp/Ink4"; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708292338; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xiVXO4rHRWfGZ5oxQolWqb94buuIBeR5xbwyH8qjg5Q=; b=d/wXyjtnql90FL9wlgXONvJ9XObR9vChNi5Eq+6F6UjSAjfzSkOivme/Y3AJ7skc9oFMof 3zuJEbTTyIRIuw0PgzEcflA3cqoB8WUOhu8Ut+Dr5w1c+oIAB642EOodZOQFuyemR74sHn 3dpiK4+Rty0rMeUINuTA7oR6XSvyaEU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="Nbp/Ink4"; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708292338; a=rsa-sha256; cv=none; b=zEG9kFvZJHrBaZZRQ9zRKSgju94QNdBwUp1M8zdFa5gACTe4iyt1vCYXnrO78aw0QrCRtZ gStjo49RVYWosNjBSYxTQqCX9z1mjGvQOilNYX/IIB0gwqVhmUR6Wtc8b1imq46y7N9sy3 FiQ/+3Ii1GCOf6AnHpXT21cHdhLjYKE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D312FCE0B50; Sun, 18 Feb 2024 21:38:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 695DAC433C7; Sun, 18 Feb 2024 21:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1708292333; bh=KKc8FE2bdtNuk4G8An0mXCAzt6JMeCEm+SY5mrD71fU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Nbp/Ink4ziA5vhwf0sUWh7CGnF72TQNaoyWHagIaLFeTUecm9hccCnqqciGQhjWKO di5+uSUjSAvJEgiscCFr9wkhUdICeUCPnH0cecv0Xc1vrompSDxzq+IV/O95Vb0SGi F3AkUjQkxE8izaOhvNFZiBan40lDCpm4Nnog/IGI= Date: Sun, 18 Feb 2024 13:38:51 -0800 From: Andrew Morton To: Donet Tom Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Aneesh Kumar , Huang Ying , Dave Hansen , Mel Gorman , Ben Widawsky , Feng Tang , Michal Hocko , Andrea Arcangeli , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , Matthew Wilcox , Mike Kravetz , Vlastimil Babka , Dan Williams , Hugh Dickins , Kefeng Wang , Suren Baghdasaryan Subject: Re: [PATCH 1/3] mm/mempolicy: Use the already fetched local variable Message-Id: <20240218133851.22c22b55460e866a099be5ce@linux-foundation.org> In-Reply-To: <9c3f7b743477560d1c5b12b8c111a584a2cc92ee.1708097962.git.donettom@linux.ibm.com> References: <9c3f7b743477560d1c5b12b8c111a584a2cc92ee.1708097962.git.donettom@linux.ibm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: h4zg1gmpzff9guyn8s4jhjzkb9xz7pxo X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2F30AA0012 X-HE-Tag: 1708292337-974225 X-HE-Meta: U2FsdGVkX1+Z3NyRhuJiJS3Omt5pYGZO7R+6RJBfo03E7SBr/cb+FirHOOYmgf/MRQcL6zj3au2mQhj5q1MOg8LPA86z+4KBJvCRZSse792HXUEy7h00Tb7csTVG+1oEb7YVbP/bHFm4zHjKMmI3baiuM1r4ilZVHWgX2e5Tu1CiRc1RpjxkKX7itDSgEcLsTPaVDBH+oQN4zZMSbDit2zay3MJ/RmwYCNmdlNijTeiWLby96zFEuYN6vcgZ88XKFovPIVz2YDlB1ivCuFVf7DmhMf1zmWEue5yHMkUHQlqchtkBWIY7QNNDjiPTeweiu4RMz7vqX4yTvrufWuY+S21ST+RAyxcAqO3lL0ku3z+PL2iZdnGSrYdPbw8P9sAB4vhxUxXBKJ5BKJmOaO9UC3HfnNCq/m4LixnnrDNuxxHHT3mVTtTBa2aP74g0+ameHHNDvb5ag7DJxvCJsU+CsRe+yUvlNb0DN60//n7kTbXZZvVADuBJNYk/whJzWEExwJOSGwUHZb0CV6bAdPb24sDMZvn5A8TuvgNVrnzF+eCKp1kUBjTfyEWnFLofCKBnFdvVNctFl54R4mWbM619TLHjoWwjgpudgEusGIrEg/SermAZZ6PevGFgwNxzrFiq341vulDnhEFjipe3CkcLfT11AdyIHnMAfUl0hdOI3zZkIimJoi6ikMCHeZfOPBOHijrDC4XUmqX2cjyD/eeWXnkRg2BNECcfs5fhvFMZZAVu4QK/94E/dmOEOsY8zEXESZVwvrQf4l/pTy1mR6FwqDWFeuzna/fZxTbuMhlz7E1Oh+6AaPwKxyUSeLCgi19HpbhmEBJdSHtdwdrqA42h1jEeur8D+xx+YAt9s/fk6H8Hd5vHmrKPwJgmE+8R8Rn6GhUZdtPX3JVZiAtc9AoEKhFzOnspMtpxqOgzH9G+Lng= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 17 Feb 2024 01:31:33 -0600 Donet Tom wrote: > Avoid doing a per cpu read and use the local variable thisnid. IMHO > this also makes the code more readable. > > ... > > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -2526,7 +2526,7 @@ int mpol_misplaced(struct folio *folio, struct vm_area_struct *vma, > if (node_isset(curnid, pol->nodes)) > goto out; > z = first_zones_zonelist( > - node_zonelist(numa_node_id(), GFP_HIGHUSER), > + node_zonelist(thisnid, GFP_HIGHUSER), > gfp_zone(GFP_HIGHUSER), > &pol->nodes); > polnid = zone_to_nid(z->zone); int thisnid = cpu_to_node(thiscpu); Is there any dofference between numa_node_id() and cpu_to_node(raw_smp_processor_id())? And it it explicable that we're using one here and not the other?