From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E9FFC48260 for ; Sat, 17 Feb 2024 00:08:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D21E6B00A2; Fri, 16 Feb 2024 19:08:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 981006B00A5; Fri, 16 Feb 2024 19:08:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 821D86B00A6; Fri, 16 Feb 2024 19:08:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 72C516B00A2 for ; Fri, 16 Feb 2024 19:08:51 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1C0DC1A0002 for ; Sat, 17 Feb 2024 00:08:51 +0000 (UTC) X-FDA: 81799360062.11.4DA3FC2 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf08.hostedemail.com (Postfix) with ESMTP id 33D28160002 for ; Sat, 17 Feb 2024 00:08:49 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Vai1dJT5; spf=pass (imf08.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.45 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708128529; a=rsa-sha256; cv=none; b=1/OQbwM7uKuYr98CDIvft1slGKpr2v+OPTE/69e6Q5Ide+dKcDtOVy2Za3iF1BKqGJ8BMg tU/gFXP2/Jb/7BPXyetnwESjDlui7gDHp1A3gYleM5hr36fM2gSDKyT2thHypbR/j3Onhq zgWHDI9Ly0ooTYJtqEbVyIYX3curA0A= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Vai1dJT5; spf=pass (imf08.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.45 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708128529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S1txfacIBFBZ/O4tjcxs+bfhiTiZyaDvYXwzko6DwYw=; b=gZ29FMxSN8voeWoAjzaxjkB2/H5bt/ohpQWuMTy1fX8oJ5NIeLsdjFy9AxNJqzsxjys2NV G0DjOk4mWYvPj3hgoXk/4QcemFudHzvDItoscVOuTZlXQoNblCPD9bpW1ELYvQQDdFZKGo j1laO20zx+DeUZvWUXiE4JyWe/2KhRM= Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2995185dbbbso270358a91.3 for ; Fri, 16 Feb 2024 16:08:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708128528; x=1708733328; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=S1txfacIBFBZ/O4tjcxs+bfhiTiZyaDvYXwzko6DwYw=; b=Vai1dJT5QvF2EZU9Pb8yAEkavP8N2qiutfq1iZ/a6V8UJ7baqWPvWdD1u7Qzq4KtM9 0Wt+dXJaAKXIQJbTt6atdSuM+NWR7KD7vYoVwbBd1mJJFNzaaPndvEhqrdKnJ7BDJOGj N+vrtj3JVMcsAt380B3KW0DvHd6klFeroGJcs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708128528; x=1708733328; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S1txfacIBFBZ/O4tjcxs+bfhiTiZyaDvYXwzko6DwYw=; b=clITkeXNALZGSG6LV9jt3CK5GP5p4fZqcinZAYBSsa+Qg1TYLwssxqbxZdwFiCK6zV Jh5jSa35TrY+i+O0nbq/5J17CJ28l4MeRqGDmn5t64HTNo8pMnGeMsr2IhD0GPSh7Zm3 iB2mlH/FxFLcDODu7zbxNt1AaXSWdSq23rPLP/g6jltymPxDb5IhV5nvIPOyxOdRRMXv NiQmuOFaSS7KsW5QXQwvpTqPVk/t3g8RjWusCXfSugaZr0owDJA1AyNpLgm9v1azAzhL xcvHort7ydi3+0RQq6CsZMkJsMOIX5Sg1U0jAZ5eGT7h8p5Te2At8c1WQ7E2N0zV0QRo +ITg== X-Forwarded-Encrypted: i=1; AJvYcCXp62cG8IMIQ82eFw6JMFIL1vfGHZXvJoCeqEh//tOIu07DRqSBwsQx1x0XSmD0Jqe0FIsq8f4NNta8iBWHW8Xjqc0= X-Gm-Message-State: AOJu0YwdBjcboulh5vl3n5owQxa4yLocthy5HEG0D/uUSwpu/RMyl9xo pZPmGIAQrUT5e78vz6sLjO1sczuEzzwQyUfwC4rqEaSotnps4HsW9eHbH8RxDw== X-Google-Smtp-Source: AGHT+IH/+9L6OGC47okEyWyHRr0TBS/QRSzKnhlJpg9ASbA9E31sS8Nyhe3YVufQSOLml7og6eiQSA== X-Received: by 2002:a17:90a:e602:b0:299:29bd:ee1f with SMTP id j2-20020a17090ae60200b0029929bdee1fmr4886121pjy.0.1708128528040; Fri, 16 Feb 2024 16:08:48 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id ds5-20020a17090b08c500b00298ff26e4c8sm572039pjb.26.2024.02.16.16.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 16:08:47 -0800 (PST) Date: Fri, 16 Feb 2024 16:08:46 -0800 From: Kees Cook To: Kent Overstreet Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 13/35] lib: add allocation tagging support for memory allocation profiling Message-ID: <202402161607.0208EB45C@keescook> References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-14-surenb@google.com> <202402121433.5CC66F34B@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 33D28160002 X-Stat-Signature: fffwhsa4eby1u4j61muzkwt98tpbkunt X-Rspam-User: X-HE-Tag: 1708128528-90304 X-HE-Meta: U2FsdGVkX19pdwWbt4agQROKvnz+8gcpgpvdAdgG9Y/dXsSUYSLRlTRsfAY0b7zx2jqDgK8fw23MYhqK/FwzOHyPGRacI9Au8iqT+KNLXRfMRwbOEAp3wGDr3yIcTBVpRNqZDUc35BywrK7SlckitoZls9nK4Ac2BX9197qAhIzqAkVMibNuhiR7UjKhS99/XooIxB9aivalDihJ/ZMTfkfRFWsEfRrg2RPa0E7thgxxYlRMfXGR1Kdgw4PQythZDbdiUF3glbbLzLb8ltDLt5L7WiuoS4d5EOG7ovJI7RFhq5f3JJWXZ1Fi+Jn3Qi9oJPxqJSBRz8pPRMibT8K7UgIavykhIn7XPKmEaj9iyxSnzU/1Bs2puGX69cYjdtac8zoffeSGra76w5ZC419lowoZC9zQf+3MDPQxtkrFJ6TgN74p9YQqZjz1qgPLY945sZdVQnEZYcuxxfuacUCjDSx48Tq2Fi4BF534V4qbBl35DY4VpQ0NJPP3DGYyWq+ZEOPKfzLYW8nIl0BMZ3sXiLP1xezFHsybtt+sk4xkyFfym9JwGkX7sVBDBOXAWVIZmzpDHOlBzH5oWfraMjvala9c4tTzXrPVSNSw6Rz6+LXcw8c/9h5l+uILjJyK3ALDLys5wad2AoHZ+xi9t8i9Ax7DQkpOyMYF4xTUP/a0cwF+/Z4MqpHTQDl56GAsIRZs3BbZ3ODRFR5NQRPtmaDWGQyAUBWtDSkyob8iSN6Ne23Py45aUFX8CksMolNyWzmxtLjCS5SO5Glg123GWNau5xNSwdxLHCFdfefY8fLRB5Ctc0pbssJ6f2ICk42FHH/JajG8pr7fDreGT9RiBtp6h8yYlBVmQBrKuWGBTFJAWK7ZLG7V7O4tFlCqkF7WVlucF+/iDfJc7Q0k1Jh1rl+gF8jvb4pn+k5a0mm/aQebH6gIIxZCdvap349I8zFtQy7kkPMXaiFmTtJ6y5WGloQ fhTbsSqk mxK7M4lJqerSYlkEcpe+HwAk4qToe5l/r8orLZyqYBRekBIrc7nuvQKdDoXbxEei22p5JR61KfeS+c75tota9lhW+Mf2Gue8JPmwJYWMS+FzxN4tETL18pyag1aqd/qWxX2Mx6EMzASngE6oSRCvLG5wQTd1s3dKoE1Tq7o7baMfi208hw2WN8ew3P8kNZo9KAvGTaCYlU3qY/l7PXRk11x8leCOemasazT/YwNy55LZkwhWO7ZDANc9LCAFgaOfVRxT7gX90YsfqXoVP6oKf20ylLLm+CJIclotS9pWe7kff7XeZFyAI+qont++/fANAGTgSfF3kfvf4ZWupYFjHJyYMeTsnJYpSYLE8vdEIX/yc8Wmls2LCi795HiEg4e2wwzkUQnzwZXU/XQMqRmhsNiWX2hBhh9zSEs4aFvvFqXSCANk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 06:26:06PM -0500, Kent Overstreet wrote: > On Mon, Feb 12, 2024 at 02:40:12PM -0800, Kees Cook wrote: > > On Mon, Feb 12, 2024 at 01:38:59PM -0800, Suren Baghdasaryan wrote: > > > diff --git a/include/linux/sched.h b/include/linux/sched.h > > > index ffe8f618ab86..da68a10517c8 100644 > > > --- a/include/linux/sched.h > > > +++ b/include/linux/sched.h > > > @@ -770,6 +770,10 @@ struct task_struct { > > > unsigned int flags; > > > unsigned int ptrace; > > > > > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > > + struct alloc_tag *alloc_tag; > > > +#endif > > > > Normally scheduling is very sensitive to having anything early in > > task_struct. I would suggest moving this the CONFIG_SCHED_CORE ifdef > > area. > > This is even hotter than the scheduler members; we actually do want it > up front. It is? I would imagine the scheduler would touch stuff more than the allocator, but whatever works. :) -- Kees Cook