From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E61C48260 for ; Fri, 16 Feb 2024 09:23:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BAF98D0006; Fri, 16 Feb 2024 04:23:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 168DE8D0001; Fri, 16 Feb 2024 04:23:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02FF08D0006; Fri, 16 Feb 2024 04:23:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E49458D0001 for ; Fri, 16 Feb 2024 04:23:20 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B275CA04C7 for ; Fri, 16 Feb 2024 09:23:20 +0000 (UTC) X-FDA: 81797128560.12.D04FEB2 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf04.hostedemail.com (Postfix) with ESMTP id B43D74000A for ; Fri, 16 Feb 2024 09:23:15 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708075399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g4ohZB27ELYs2yMYoRfmYNVAla0kVPLN9dOQzIAaWuM=; b=I0+Dd3esMzwe4T+7rlYnfallCrCz9Pa5BaiAnUhD1kYrJSMReRAbJVOl1dWOm93XpfN/pG +2p3b9Byqk2KkvsRnVqn/AkHeLqa/qxMPbeKYYHcw/hZTpUJxAqWkdhyju4hIl/Wyvs+lb PnWJjVMgdKO/I6SsWziQVxdYgFlhjGQ= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708075399; a=rsa-sha256; cv=none; b=es7ASY7a6sGIoA20RhFV8gzYQbhTL672ipJk8pdpQNVVlsAbANt3RtBTbVFIof98UGg/0V TbuBdORdZQ+tp+eDmd5D6L5wDnG0cBoWXaKhlSM+VUoswZ6lM+aYp50fxYMOo7w/UT2DPi /InQVff2A0hLbmLTPIbS5abw5/81VfM= X-AuditID: a67dfc5b-d6dff70000001748-d5-65cf297e427b Date: Fri, 16 Feb 2024 18:23:05 +0900 From: Byungchul Park To: Oscar Salvador Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org Subject: Re: [PATCH] sched/numa, mm: do not promote folios to nodes not set N_MEMORY Message-ID: <20240216092305.GC75176@system.software.com> References: <20240214035355.18335-1-byungchul@sk.com> <20240216070754.GB32626@system.software.com> <20240216091139.GA75176@system.software.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240216091139.GA75176@system.software.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeLIzCtJLcpLzFFi42LhesuzSLdO83yqwYEjhhZz1q9hs7j0+Cqb xfSXjSwWTydsZba42z+VxeLyrjlsFvfW/Ge1mPzuGaPFpQMLmCzOTCuyON57gMliX8cDJouO I9+YLbYe/c7uwOexZt4aRo+WfbfYPRZsKvXYvELLY9OnSewed67tYfM4MeM3i8f7fVfZPDaf rvb4vEkugCuKyyYlNSezLLVI3y6BK2PL+odMBY95K2aunsLWwHifq4uRk0NCwERi6+8rjDD2 2xUrWLoYOThYBFQl5k6rBwmzCahL3LjxkxnEFhFQk5j2qpG9i5GLg1ngFJPEhM8X2EHqhQXC JP6+UQCp4RWwkNjzuZ0JpEZI4CWjxLopK1ghEoISJ2c+YQGxmQW0JG78e8kE0sssIC2x/B8H SJhTwFLi5o7N7CC2qICyxIFtx8HmSAi0s0tMeXOXCeJOSYmDK26wTGAUmIVk7CwkY2chjF3A yLyKUSgzryw3MTPHRC+jMi+zQi85P3cTIzCWltX+id7B+OlC8CFGAQ5GJR7eA3/OpgqxJpYV V+YeYpTgYFYS4Z3UeyZViDclsbIqtSg/vqg0J7X4EKM0B4uSOK/Rt/IUIYH0xJLU7NTUgtQi mCwTB6dUA+OMh6uU5eXnng/boH1DMvp+qWbHsYacLjbX4sSfL+Zu/77ruERyeYNti2uZr9N6 qUzVSTfmFqRNec59M6Jy7febRhMeTXhkFsMbf1jisIzqvJyiS/PfuvexHvxvVbP+/s8DlUIl Ubt3lE1ay/bijeXF/8dOMT8rUko6Mm1xtetMq+03DATWze5RYinOSDTUYi4qTgQAnxLzKKEC AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKLMWRmVeSWpSXmKPExsXC5WfdrFuneT7VYFq3osWc9WvYLC49vspm Mf1lI4vF0wlbmS3u9k9lsTg89ySrxeVdc9gs7q35z2ox+d0zRotLBxYwWZyZVmRxvPcAk8W+ jgdMFh1HvjFbbD36nd2B32PNvDWMHi37brF7LNhU6rF5hZbHpk+T2D3uXNvD5nFixm8Wj/f7 rrJ5LH7xgclj8+lqj8+b5AK4o7hsUlJzMstSi/TtErgytqx/yFTwmLdi5uopbA2M97m6GDk5 JARMJN6uWMHSxcjBwSKgKjF3Wj1ImE1AXeLGjZ/MILaIgJrEtFeN7F2MXBzMAqeYJCZ8vsAO Ui8sECbx940CSA2vgIXEns/tTCA1QgIvGSXWTVnBCpEQlDg58wkLiM0soCVx499LJpBeZgFp ieX/OEDCnAKWEjd3bGYHsUUFlCUObDvONIGRdxaS7llIumchdC9gZF7FKJKZV5abmJljqlec nVGZl1mhl5yfu4kRGBnLav9M3MH45bL7IUYBDkYlHt4Df86mCrEmlhVX5h5ilOBgVhLhndR7 JlWINyWxsiq1KD++qDQntfgQozQHi5I4r1d4aoKQQHpiSWp2ampBahFMlomDU6qBMfJTy5oV G8tlvre7zLDsi/FrEe54dJfb0Jp7zTbVKNa1QaYOq37WA2NJ5knj860ly1X0E3fOPtltGFDO zejhO3/+9DdW2pUXW15EHffVdlr26oOrb+ymj/du+igrrHtXVpNyQUq6mmllNmvVXiejiOIa l491R3dkBj3iXSDeukxXap/wxAwlluKMREMt5qLiRADnLik4iAIAAA== X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: B43D74000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 8syzqambnh5wi569qt7rw44dd4su86r1 X-HE-Tag: 1708075395-387663 X-HE-Meta: U2FsdGVkX1+EjrfphBKtuOAKKmiIzIkXI1vZ4Mo7N5ey7oXVUDaPnhlVD0Ztm97BMGYURvbloVcH1Ikd9y9ONjGeDgwhYpmrpYmHCCUH98GztqQ/6h1Ob1ApPEF9XJ211O6LsXXpc8vb5lEqU4y3AwT8J9uTeGby092WKIGpnFKeJhmvda77biQJ5mWmHFcd5Up9maYj/+micUoNMKYSZrXMCcf8h8KKwAwf/l3VdPJ8yvPOhw/kb3/XbNyYHWEbY5e7k+y6HvsU6tWfiD2YPvQkFlJ7BJD/DzKw/d6Od5ITZju8ER6M2aa6FOcn6BOSgirDKcgGFYV8O3op4fyF7WeYGaGYEI0e0DoGl+FAEIB9diGZAgY8dynStYSn07JvqJsn2vIGRPDr84oURO3RTFb9f6yeRdT55j4U1GU90bHTNb97qzR5Le0KVke6WE/c17aXQncewgU4a3GqDZWRB0PWmyaFiJzJDPkO9Rdid3nWLwtkV/+ap0pqUR84aHW1ESMiaBUlXK/qpQlDLiX1XzzKTkut0dJiXnowX8vMFS+iIEo+6/IAPVH2uiATrDrrAbKJsPpmPSuizoLVrgTo3kN0jvuu0rTsPSPp/dKWMUplh9rn8pkn9l8uNk2s+r8zZygiFdUyQYeIoQj2Ga/1w0aUitcwd9bw4/5YYpxYO3s+ploXzP5siFZWQJZzZSn0UaOfeMzJJUethMv1xJQ1GQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 06:11:40PM +0900, Byungchul Park wrote: > On Fri, Feb 16, 2024 at 08:52:30AM +0100, Oscar Salvador wrote: > > On Fri, Feb 16, 2024 at 04:07:54PM +0900, Byungchul Park wrote: > > > For normal numa nodes, node_data[] is initialized at alloc_node_data(), > > > but it's not for memoryless node. However, the node *gets onlined* at > > > init_cpu_to_node(). > > > > > > Let's look at back free_area_init(). free_area_init_node() will be called > > > with node_data[] not set yet, because it's already *onlined*. So > > > ->zone_pgdat cannot be initialized properly in the path you mentioned. > > > > I am might be missing something., so bear with me. > > > > free_area_init() gets called before init_cpu_to_node() does. > > free_area_init_node() gets called on every possible node. > > > > free_area_init_node then() does > > > > pg_data_t *pgdat = NODE_DATA(nid);, > > > > and then we call free_area_init_core(). > > > > free_area_init_core() does > > > > free_area_init_core() does > > zone_init_internals() > > > > which ends up doing zone->zone_pgdat = NODE_DATA(nid); > > > > If node_data[] was not set at all, we would already blow up when doing > > the first > > > > for_each_node() > > pgdat = NODE_DATA(nid); > > free_area_init_node(nid); > > > > back in free_area_init(). > > It seems that I got it wrong about the reason. Let me check it again and > share the reason. > > Just in case, this patch is still definitely necessary tho. Sorry for the confusing expression. Please don't misunderstand it. The oops has been always observed in the configuration that I descriped. I meant: Just in case, I need to say the fix is still necessary. Byungchul