From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C97FDC48260 for ; Fri, 16 Feb 2024 09:14:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61D4C6B0089; Fri, 16 Feb 2024 04:14:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CB638D0006; Fri, 16 Feb 2024 04:14:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 494BF6B008C; Fri, 16 Feb 2024 04:14:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3A9096B0089 for ; Fri, 16 Feb 2024 04:14:05 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BF7FBA044A for ; Fri, 16 Feb 2024 09:14:03 +0000 (UTC) X-FDA: 81797105166.05.65CFC29 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf04.hostedemail.com (Postfix) with ESMTP id 90EC44000B for ; Fri, 16 Feb 2024 09:14:01 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708074841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mfo+oHNvqkOf5Mp/Sv+TmyI3EgULl3MJq1hNpKdInFI=; b=NXP2WaNB69losUl4GJt4Xa3c6u3mvTyT9G5sK0GbPC/YuDRbErhH9akM9B6CXrCxbDqlNI HgK1CJjtiQUGhpC4euPXckGTbsf0OdZYXrz7XTN/CcH6ajA7XdP6sLFfEZe5U0fDzzKUlb qZCs68lLasC8f+hD5rLSLVQQnVCQGjM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708074841; a=rsa-sha256; cv=none; b=YncVbn8SP3WYHNqGj9EN0dL3ZwKIgkXhOjlK3A4KiEpAIPLrDbwQsZ/KlfrraM728mYPcq 8r8WFLkoRx2WrGrjUKOV5sGqpn+jXzMUWGLNivKVcv3NAsGPPZfogC00dB8eGT749uORTY wez2CmQPoUorA1Xwfwf9M189gYMwBuQ= X-AuditID: a67dfc5b-d85ff70000001748-a1-65cf275412ba Date: Fri, 16 Feb 2024 18:13:51 +0900 From: Byungchul Park To: David Hildenbrand Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org Subject: Re: [PATCH v2] sched/numa, mm: do not promote folios to nodes not set N_MEMORY Message-ID: <20240216091351.GB75176@system.software.com> References: <20240216073340.55404-1-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeLIzCtJLcpLzFFi42LhesuzSDdE/Xyqwf17ahZz1q9hs7j0+Cqb xfSXjSwWX9f/YrZ4OmErs8Xd/qksFpd3zWGzuLfmP6vF5HfPGC0uHVjAZHG89wCTxb6OB0wW HUe+MVtsPfqd3YHPY828NYweLftusXss2FTqsXmFlsemT5PYPe5c28PmcWLGbxaP9/uusnls Pl3t8XmTXABXFJdNSmpOZllqkb5dAlfG9HkHmQrOSFbsOPCKsYHxkkgXIweHhICJxLFFXl2M nGBm98qdLCA2i4CqxJK/N8BsNgF1iRs3fjKD2CICGhKb2jYA2VwczAKnmCQmfL7ADpIQFoiU eDa/mRHE5hWwkFhz4yBYs5BApkTr5AZWiLigxMmZT8DizAJaEjf+vWQCuYFZQFpi+T8OkDCn gJ3EgxsrwcpFBZQlDmw7zgSyS0KgmV1i1qzF7BCHSkocXHGDZQKjwCwkY2chGTsLYewCRuZV jEKZeWW5iZk5JnoZlXmZFXrJ+bmbGIHRtKz2T/QOxk8Xgg8xCnAwKvHwHvhzNlWINbGsuDL3 EKMEB7OSCO+k3jOpQrwpiZVVqUX58UWlOanFhxilOViUxHmNvpWnCAmkJ5akZqemFqQWwWSZ ODilGhjZ5O7uyf9/8Pz2tXN/vbiedeta52/++9IXp0xcJ3r6Qd2MDyvvST5ld/6j+uaL8j++ rTnShy3dZCx2d/Puv9qSq6dz+oP6/GCzp7xe237sL3x5Zemm26ynV7u4fCi5ybjur66l3PFf zYcsehcxChqqR8ZnhdUutK1yLeGZOF3Q6wLzh22pIoFTlFiKMxINtZiLihMBeDkdbaICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsXC5WfdrBuifj7VYPkuYYs569ewWVx6fJXN YvrLRhaLr+t/MVs8nbCV2eJu/1QWi8NzT7JaXN41h83i3pr/rBaT3z1jtLh0YAGTxfHeA0wW +zoeMFl0HPnGbLH16Hd2B36PNfPWMHq07LvF7rFgU6nH5hVaHps+TWL3uHNtD5vHiRm/WTze 77vK5rH4xQcmj82nqz0+b5IL4I7isklJzcksSy3St0vgypg+7yBTwRnJih0HXjE2MF4S6WLk 5JAQMJHoXrmTBcRmEVCVWPL3BpjNJqAucePGT2YQW0RAQ2JT2wYgm4uDWeAUk8SEzxfYQRLC ApESz+Y3M4LYvAIWEmtuHARrFhLIlGid3MAKEReUODnzCVicWUBL4sa/l0xdjBxAtrTE8n8c IGFOATuJBzdWgpWLCihLHNh2nGkCI+8sJN2zkHTPQuhewMi8ilEkM68sNzEzx1SvODujMi+z Qi85P3cTIzA6ltX+mbiD8ctl90OMAhyMSjy8B/6cTRViTSwrrsw9xCjBwawkwjup90yqEG9K YmVValF+fFFpTmrxIUZpDhYlcV6v8NQEIYH0xJLU7NTUgtQimCwTB6dUA+PT+iVai1dqn5+/ rMr50OfXf5ZWfxL5uD2+Rt9d0aJcxUJunpPp2VseO0TPu559za4Vfb3VoHXqlltLzsxzaqt1 6fjsKXDq2Osjwl9SnKTV3C6s5k2P0m6asNLig2RH3alTURazPB/vVpZ1eDGjvXfHz7kinP8f 5hZdXTvzm30sP/MOs5Ws6W5KLMUZiYZazEXFiQDQaJh4igIAAA== X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 90EC44000B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: zwnkrxrg5xsgrw1heh3h7rtqmbtonmkf X-HE-Tag: 1708074841-48433 X-HE-Meta: U2FsdGVkX1/22fr6h3/f+GQOSye9MkOG/FXriNFxRAbrIsEKz1nvXs3dq58htfXPMEb550WwV4GabE8o1Z7PmEeUxXTQQXSBusk+aoqDqDTT07SDB6avvfqGFWpUmATIZE+cTb64epa87NGQv4+ZMZbsfizvQtyQYIFJAUfo0L7LS6LV0V/UZkt6hSaUlljuTRnQ6hMsb40jnEBuTAPNvpMeLWd7w2cyV/TpooUinLHNGlmZffesWjACXnnGqB5ZJfWhF9wBtuXq3JzzsxFpak/18DW3G8XPNdrTyyQcr0Jm8BhNwgoJiK2bvu8f+r4vVRPNzrdF65MYLBN9tiybblzpTduiEQhnHjNRZ7TirBiYco8InKZDF/DBQFW2thVyrgDpjFNIv4pfbbAe63wMxzL5ji37dMxAoZWo0DmbOFkhf4hW59tGWMdfJWKPQjYHpevs+V1usjR8A3fCM5ng4s7e4/AdohLMhaFzQNumkjkJjUbXQ41gxd2UbYT//Op6DRiN0TBPsTDBlz5fOhjjWVluZhiVuST03PU+TgGhKBbVD57buPjtSL2RGpiX5r/qJIvMlcAMJhrjdBRLN8li5QZdJGY6SX/JPrtl51UAjSMf1U4/L6wpf6FJrVlEFNrT2ZKXZSn4zLgAaGJHaG80n+fxPVOp7ayi3fgVRlhxwkDfRKYhnby9L8En8f2CrjF5fyNtH/JJHjtSW5kfq4HXP0k2nPCQm1FmHSfcVvjNV2yOYs8JALBbi3f/fxUEj3QtYtZfJBHwJucwSFz1IksIWSjiXR2tCOLheWMVi43IVmftHr272ziFX6Wy3U/nv1P4VZOZY8IoFa6K4fPWaJkZ/zfip/af0ryP2hm2Er+iXgkz6S7+G8N9ACoti6QxT0VVSPO/bjwEX2WXIqrHmXfcH9L9TO2//nkVDLq/+yfuor3a40hnDTSfMILyOu0Vg25n8FuJoPwCa4uNgR0UM+A iTeCqOL3 /fYvvz8QKqNTW0UWHdDQn6rS2YixfOzWpkl2wyibZuHn0cZi3X9QlCv2MKV+siQqu6FbGC6AP621J1W/sB0XxHVNf2qSkGrJFpPHKX4U4ZHFmLdw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 10:07:53AM +0100, David Hildenbrand wrote: > On 16.02.24 08:33, Byungchul Park wrote: > > Changes from v1: > > 1. Trim the verbose oops in the commit message. (feedbacked by > > Phil Auld) > > 2. Rewrite a comment in code. (feedbacked by Phil Auld) > > > > --->8--- > > From 6830b59db267a31b78f6f09af12ae0e3132b4bca Mon Sep 17 00:00:00 2001 > > From: Byungchul Park > > Date: Fri, 16 Feb 2024 16:26:23 +0900 > > Subject: [PATCH v2] sched/numa, mm: do not promote folios to nodes not set N_MEMORY > > > > While running qemu with a configuration where some CPUs don't have their > > local memory and with a kernel numa balancing on, the following oops has > > been observed. It's because of null pointers of ->zone_pgdat of zones of > > those nodes that are not initialized properly at booting time. So should > > avoid nodes not set N_MEMORY from getting promoted. > > > > > BUG: unable to handle page fault for address: 00000000000033f3 > > > #PF: supervisor read access in kernel mode > > > #PF: error_code(0x0000) - not-present page > > > PGD 0 P4D 0 > > > Oops: 0000 [#1] PREEMPT SMP NOPTI > > > CPU: 2 PID: 895 Comm: masim Not tainted 6.6.0-dirty #255 > > > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS > > > rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014 > > > RIP: 0010:wakeup_kswapd (./linux/mm/vmscan.c:7812) > > > Code: (omitted) > > > RSP: 0000:ffffc90004257d58 EFLAGS: 00010286 > > > RAX: ffffffffffffffff RBX: ffff88883fff0480 RCX: 0000000000000003 > > > RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff88883fff0480 > > > RBP: ffffffffffffffff R08: ff0003ffffffffff R09: ffffffffffffffff > > > R10: ffff888106c95540 R11: 0000000055555554 R12: 0000000000000003 > > > R13: 0000000000000000 R14: 0000000000000000 R15: ffff88883fff0940 > > > FS: 00007fc4b8124740(0000) GS:ffff888827c00000(0000) knlGS:0000000000000000 > > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > CR2: 00000000000033f3 CR3: 000000026cc08004 CR4: 0000000000770ee0 > > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > PKRU: 55555554 > > > Call Trace: > > > > > > ? __die > > > ? page_fault_oops > > > ? __pte_offset_map_lock > > > ? exc_page_fault > > > ? asm_exc_page_fault > > > ? wakeup_kswapd > > > migrate_misplaced_page > > > __handle_mm_fault > > > handle_mm_fault > > > do_user_addr_fault > > > exc_page_fault > > > asm_exc_page_fault > > > RIP: 0033:0x55b897ba0808 > > > Code: (omitted) > > > RSP: 002b:00007ffeefa821a0 EFLAGS: 00010287 > > > RAX: 000055b89983acd0 RBX: 00007ffeefa823f8 RCX: 000055b89983acd0 > > > RDX: 00007fc2f8122010 RSI: 0000000000020000 RDI: 000055b89983acd0 > > > RBP: 00007ffeefa821a0 R08: 0000000000000037 R09: 0000000000000075 > > > R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000000 > > > R13: 00007ffeefa82410 R14: 000055b897ba5dd8 R15: 00007fc4b8340000 > > > > > > > This sounds like we need a Fixes: and want to CC stable? Sure. I will CC stable at the next spin - might need to rewrite the reason. Byungchul > -- > Cheers, > > David / dhildenb