From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4723C48260 for ; Fri, 16 Feb 2024 09:11:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4941E8D001B; Fri, 16 Feb 2024 04:11:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 444048D0013; Fri, 16 Feb 2024 04:11:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 332E18D001B; Fri, 16 Feb 2024 04:11:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 246238D0013 for ; Fri, 16 Feb 2024 04:11:52 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EF3901A03C4 for ; Fri, 16 Feb 2024 09:11:51 +0000 (UTC) X-FDA: 81797099622.25.FB9E097 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf10.hostedemail.com (Postfix) with ESMTP id C1E98C0013 for ; Fri, 16 Feb 2024 09:11:47 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708074710; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tcgj4V9LKgIykr3hRYm2x/tFcmwC/6gKOyKa8hpSeBA=; b=vjA7uKMzpaAFOhniBbB/20zoI4y0i7L0fFBbOlgdVZolwNXmtT0fVXetac4X/v+xAdymxe FdxfUtx7l1fvytOIWhL9Q+lwtg9sK9r8kM1t5AKl5tO2MZF8QfqrlCKsz5OCH7jEUmpoZi wYCUhjJT969dzk4Vnz7pSit5VNVD55I= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708074710; a=rsa-sha256; cv=none; b=2tZIcidmRoBwrANh3zVus03OW4rQrjRZif1p0VJchdVZvbfWHPuBx8fOx2sjPAeZfJi5OE oMQhmAon5gXGZVebxmnUpwBICxhlGJ/V16WOa3te5yb2anVtwtU5MJWPX3OUv9ITho0eny Z6z9tz8k9S+9dq/mVLB0n0+00CpvwxM= X-AuditID: a67dfc5b-d6dff70000001748-b0-65cf26d1d245 Date: Fri, 16 Feb 2024 18:11:40 +0900 From: Byungchul Park To: Oscar Salvador Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org Subject: Re: [PATCH] sched/numa, mm: do not promote folios to nodes not set N_MEMORY Message-ID: <20240216091139.GA75176@system.software.com> References: <20240214035355.18335-1-byungchul@sk.com> <20240216070754.GB32626@system.software.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeLIzCtJLcpLzFFi42LhesuzSPei2vlUg2nHxS3mrF/DZnHp8VU2 i+kvG1ksnk7Yymxxt38qi8XlXXPYLO6t+c9qMfndM0aLSwcWMFmcmVZkcbz3AJPFvo4HTBYd R74xW2w9+p3dgc9jzbw1jB4t+26xeyzYVOqxeYWWx6ZPk9g97lzbw+ZxYsZvFo/3+66yeWw+ Xe3xeZNcAFcUl01Kak5mWWqRvl0CV0bD+4nMBT+4Kn43PGZuYLzO0cXIySEhYCKx9NJndhj7 SGcjM4jNIqAqMf9YP1icTUBd4saNn2BxEQE1iWmvGoHiXBzMAqeYJCZ8vgDkcHAIC4RJ/H2j AFLDK2AhceT/KlaQGiGBXYwS19YsYINICEqcnPmEBcRmFtCSuPHvJRNIL7OAtMTyfxwgJqeA qcTfNTUgFaICyhIHth1nAhkjIdDMLrFi3yOoOyUlDq64wTKBUWAWkqmzkEydhTB1ASPzKkah zLyy3MTMHBO9jMq8zAq95PzcTYzAWFpW+yd6B+OnC8GHGAU4GJV4eA/8OZsqxJpYVlyZe4hR goNZSYR3Uu+ZVCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8Rt/KU4QE0hNLUrNTUwtSi2CyTByc Ug2MXfLJpscN8pi3X5Hv/LVDbdfpyc+9lgZtnnz8crIlS/gz3t15ka+90tdlsCS0NFzLPTCt r1Wis7Ly9tsgxnMLpBu1Vf8f97vp2fL+j4GOvueSbL+nXx93lEws8f24ofrKt/CNtxd/t5mc tbK8U3X356l6eyV2n5NLaZqf0Cy+4ODtTuVjerdmKLEUZyQaajEXFScCAKiRbaKhAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKLMWRmVeSWpSXmKPExsXC5WfdrHtR7XyqwaxmXos569ewWVx6fJXN YvrLRhaLpxO2Mlvc7Z/KYnF47klWi8u75rBZ3Fvzn9Vi8rtnjBaXDixgsjgzrcjieO8BJot9 HQ+YLDqOfGO22Hr0O7sDv8eaeWsYPVr23WL3WLCp1GPzCi2PTZ8msXvcubaHzePEjN8sHu/3 XWXzWPziA5PH5tPVHp83yQVwR3HZpKTmZJalFunbJXBlNLyfyFzwg6vid8Nj5gbG6xxdjJwc EgImEkc6G5lBbBYBVYn5x/rZQWw2AXWJGzd+gsVFBNQkpr1qBIpzcTALnGKSmPD5ApDDwSEs ECbx940CSA2vgIXEkf+rWEFqhAR2MUpcW7OADSIhKHFy5hMWEJtZQEvixr+XTCC9zALSEsv/ cYCYnAKmEn/X1IBUiAooSxzYdpxpAiPvLCTNs5A0z0JoXsDIvIpRJDOvLDcxM8dUrzg7ozIv s0IvOT93EyMwMpbV/pm4g/HLZfdDjAIcjEo8vAf+nE0VYk0sK67MPcQowcGsJMI7qfdMqhBv SmJlVWpRfnxRaU5q8SFGaQ4WJXFer/DUBCGB9MSS1OzU1ILUIpgsEwenVANj1u0VNy7b+G5f z8ZiJDNR6WTjjUPOByr+/nk1L2NXeWzGdceUG+ZN8luc/+64LBV3Wf6R2EWrv4WJ9Y+mJJWv Off/ztQGw/qrhcc4birmZj7wj05JnmE7bdUl51MvZrNLiPfuq31Qwt+Rqbzxl+e9mX9uXY/7 8fOSRty05VOtUuK4Nz3bncz/S4mlOCPRUIu5qDgRAArQxHCIAgAA X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: C1E98C0013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: wqwn8hn36gfso3ik4cce6un4p6gq1iax X-HE-Tag: 1708074707-305369 X-HE-Meta: U2FsdGVkX19jeG22l8FRVVZnaJYTI9j7vLUkX8fvdrM9qQZLhLdhR+J51aiIEv2Bxb/wVdhdzQi2sv8RACn49BrKI9vvPj7xfgr+vPpXrckBQPH/X+tfcTyDCxUgfUBg9sz55DCp2ry3phBborDGXQC3R3mg2sCgtDs6abODD6VfJaX2RcZDdp9KoDjXaBanfCrK7lxxoyr4AIaaTPF4OiIMBlj+1SPDEWEqXES+KimzMwws0bEHD5v37kKn9T7kzKCcsbznjia+7jy+kiTl8qt6/TdyzbFcojgcWE8b1uvM/h2HdKq1grT8lARSCUyO1K8pvQ/6cyAZtOUBBKwjs0CyUwNauizw1bxEmGrxX+fUwg4+NGAgawgBsAghmJICrAOLwOgkv96SFQ6LY8aHYJCwLhsN83bjeZZafjeq2mSY9NTMngu3kZA11mVX6mzHb2kY28HtL8G1/FK5qjn3eF9NwAKQrfV1Ov6Qc5BpFdAHgmJtxQgViguRZiwPJSRs/Cw9mW2VcbuNP6qUSg+bPCTYiEdrDm6KNXGLDO0xwlhP90HLk/3iRgAq3j+ShKU33uhh1QCBN4XUpCFu+k2Y0DuyPtLZ+krvHjYRIJli1Apoi6veR0UyhvTBKicFhEW2Fi9se9Me5EhdEE9SDlPS5ICn6lNq6K1OjP+gr/RPcYFFykwV/Slac3Y1+e8gRnNRHO07vXe4d3pdcC9gdpSFiIFCwK6pdg+x+JvqrI71mZ9p86RVkg5TNjf2q6uUT0S7NlRfy/jacs8GqA4YAnwf5gSr90W1ppTFYHcSYdaT8fgQRNQ8ozMUVL5f57hl+67jZb8FPDsIFMkRUFpjb6Jspwkj+ZJG3d+kjeiiOGc1ifbKZ9Z41gE3FJSEtV0gMTI7sCpQcTLBeI3wWwy1zKwDis5EiWRJquSkKUdj3z+vmmTzspz4bOFR6cllztl8yKinnOQzE0d/7vkv135R3HY dnw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 08:52:30AM +0100, Oscar Salvador wrote: > On Fri, Feb 16, 2024 at 04:07:54PM +0900, Byungchul Park wrote: > > For normal numa nodes, node_data[] is initialized at alloc_node_data(), > > but it's not for memoryless node. However, the node *gets onlined* at > > init_cpu_to_node(). > > > > Let's look at back free_area_init(). free_area_init_node() will be called > > with node_data[] not set yet, because it's already *onlined*. So > > ->zone_pgdat cannot be initialized properly in the path you mentioned. > > I am might be missing something., so bear with me. > > free_area_init() gets called before init_cpu_to_node() does. > free_area_init_node() gets called on every possible node. > > free_area_init_node then() does > > pg_data_t *pgdat = NODE_DATA(nid);, > > and then we call free_area_init_core(). > > free_area_init_core() does > > free_area_init_core() does > zone_init_internals() > > which ends up doing zone->zone_pgdat = NODE_DATA(nid); > > If node_data[] was not set at all, we would already blow up when doing > the first > > for_each_node() > pgdat = NODE_DATA(nid); > free_area_init_node(nid); > > back in free_area_init(). It seems that I got it wrong about the reason. Let me check it again and share the reason. Just in case, this patch is still definitely necessary tho. Byungchul