From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F511C4829E for ; Thu, 15 Feb 2024 21:58:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F8998D001A; Thu, 15 Feb 2024 16:58:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 381468D0017; Thu, 15 Feb 2024 16:58:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 185418D001A; Thu, 15 Feb 2024 16:58:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EBDE58D0017 for ; Thu, 15 Feb 2024 16:58:08 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C798A140244 for ; Thu, 15 Feb 2024 21:58:08 +0000 (UTC) X-FDA: 81795401856.09.00AF53C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf06.hostedemail.com (Postfix) with ESMTP id C646C180012 for ; Thu, 15 Feb 2024 21:58:06 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EZ3PpDLz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pQlxj99O; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EZ3PpDLz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pQlxj99O; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf06.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708034287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UU5PIcSFlnhz6cXk2ilb785BgTp12PKW8ZT88F+31qU=; b=5Rl77FAl5V24ui2xJFrO+Vt7+c0J/d+KZj/7MNzPd7GX6BbJ6A2PMZu0nEEj5vShS3NF1p wtGP0Srjh66TIRmoCbjGiO3KZhKkURoVbUAYq33vQZpBbl1HwuXG7nIzqRnjed3ZwEYr6h BRlkxarLHH6K2HHus02ma04LquLsjOM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EZ3PpDLz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pQlxj99O; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EZ3PpDLz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pQlxj99O; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf06.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708034287; a=rsa-sha256; cv=none; b=nj0x5PxOntlu3U9ndyzOAPicAKQAcEpAWDG5DTAMOwtaqTQH/4QrWzmw4lYk5niPZls2SP NViqrYLIH6I+iQciMkl19o0JNSmfMXWVNvgWrngHqzcgM+UYZBJPzd6WlFyIwxMgFWX0kc UWinBwyYhGWSIwdo6m67IdnllHTCd9I= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 517541FB3E; Thu, 15 Feb 2024 21:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UU5PIcSFlnhz6cXk2ilb785BgTp12PKW8ZT88F+31qU=; b=EZ3PpDLzHqfRdouWrKvhiFgV/d57rIlBfkzEFeyn9bI4p0XEkUp6LGfHGT0d8U+HH0O+I+ UUFbv1XVGoHYvll7SY9AhBI1H4NXVxXclUOqSsAtlbJAkajRrm1qu4OsNEfCR2nf/YAUzo Uc+WfSXpdLQYwD19g60MvSZv9tGnQS8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UU5PIcSFlnhz6cXk2ilb785BgTp12PKW8ZT88F+31qU=; b=pQlxj99OEdxWMiTXrTx3SJlkXKfOYL+DB+G6s8TOPjqB+C6eeoZrfgF0Ow6P6DmFq934iG IYkyn+3KmGWoCnBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UU5PIcSFlnhz6cXk2ilb785BgTp12PKW8ZT88F+31qU=; b=EZ3PpDLzHqfRdouWrKvhiFgV/d57rIlBfkzEFeyn9bI4p0XEkUp6LGfHGT0d8U+HH0O+I+ UUFbv1XVGoHYvll7SY9AhBI1H4NXVxXclUOqSsAtlbJAkajRrm1qu4OsNEfCR2nf/YAUzo Uc+WfSXpdLQYwD19g60MvSZv9tGnQS8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UU5PIcSFlnhz6cXk2ilb785BgTp12PKW8ZT88F+31qU=; b=pQlxj99OEdxWMiTXrTx3SJlkXKfOYL+DB+G6s8TOPjqB+C6eeoZrfgF0Ow6P6DmFq934iG IYkyn+3KmGWoCnBg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id C264B1346A; Thu, 15 Feb 2024 21:58:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id SN7FLOyIzmXPAQAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 21:58:04 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v10 4/7] mm,page_owner: Implement the tracking of the stacks count Date: Thu, 15 Feb 2024 22:59:04 +0100 Message-ID: <20240215215907.20121-5-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215215907.20121-1-osalvador@suse.de> References: <20240215215907.20121-1-osalvador@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: + X-Rspamd-Queue-Id: C646C180012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: bgzbwhdo7byhsd7rcxw7ez7z1e14393d X-HE-Tag: 1708034286-987764 X-HE-Meta: U2FsdGVkX19tRK4RJIG3hv9bEqMkHsq8V8vLtFvLWdLeR2OxEGfZXDbp04ORd4kB1rfpXz8la2bts1g7bV7xSGakTU0nUPCku3sWsdXAVx0EkrBorLf9NfocIVcin6kxdanzmtrT2wtRJbTZU5HPVH3032QG84AaxjUPU3uty5T6wxD+mlthh7+oMs67G9VFp1uru87YTOuFJAcOsZpfBgyCHVEtVjLZLy06Mv7X0VUEmCNt8yKukaI/LOB6R95S8MAedJQloXzFlaYl7oTNCQvmRd185zbYPGvCgdb47ZoWLHFMuU+oDDvk0emNdLALg0QhUjpJ9gNfm9EFCGBE/fRfqkoNPuINIKCnBDnf1BuL92QUMxrX2p5C6uyxFyKgCuc4vegOFEQEbrFm8YeQCiE3XtK+2ioroKOOmZSKmNYr8tMgpV5Bn4XrItZXZdarAZrfvktW+KauTNp9AcppsbuwD8K+HnIpsx0HPgIo1rni432SsE/6j5Qvbldo+zIprhsMlzVpv5e6c4Lm5OXzl0u3SahbreC94xGNxZSG+KzWcXCyhkYmvaov+8Dd+ky0EgzUk4/2T5YrRNyPkAnFceAD6Eu8Ir3eEQdtgTW34g9gSJ53iQRGHZwjGh1q6WauqmIxP7hu2FJUSWvcLLsUK5DXuMDLozTZfPTRSK/WrQE5esjXBcyOgrtiSB0og4kcoiU/JACH7ACAVH2o5yrDebeYooX3cu9iFxJ4iH42tBTXLflvfKQ2DN+H48aI/CTdayZVf7XMiRqy5DXWJHkeiLBLWSbbYKh9027AjK/AxoqZ9Dqsqe27EcF61B79DwGxk/aziUNP+78j4kuxyAk4P1BZ2XPFh/+Yn6M/HF0gTXWv+PxUTq9COeSRfCYtBd0PKeFSwcjwVR6R7/6XKLyiAMNFlhsaEsQu5q+QVyjLbhpVuC2KnSdSGdQd9dpWw7x0L73AhUNFj8FW09R0Hp8 mPBsW6+w CFOkaHv138oRuNyqH9o+BQIpx7RUJPhBQlymr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Implement {inc,dec}_stack_record_count() which increments or decrements on respective allocation and free operations, via __reset_page_owner() (free operation) and __set_page_owner() (alloc operation). Newly allocated stack_record structs will be added to the list stack_list via add_stack_record_to_list(). Modifications on the list are protected via a spinlock with irqs disabled, since this code can also be reached from IRQ context. Signed-off-by: Oscar Salvador Reviewed-by: Marco Elver Reviewed-by: Vlastimil Babka --- mm/page_owner.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index 33e342b15d9b..df6a923af5de 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -43,6 +43,7 @@ struct stack { static struct stack dummy_stack; static struct stack failure_stack; static struct stack *stack_list; +static DEFINE_SPINLOCK(stack_list_lock); static bool page_owner_enabled __initdata; DEFINE_STATIC_KEY_FALSE(page_owner_inited); @@ -150,11 +151,68 @@ static noinline depot_stack_handle_t save_stack(gfp_t flags) return handle; } +static void add_stack_record_to_list(struct stack_record *stack_record, + gfp_t gfp_mask) +{ + unsigned long flags; + struct stack *stack; + + /* Filter gfp_mask the same way stackdepot does, for consistency */ + gfp_mask &= ~GFP_ZONEMASK; + gfp_mask &= (GFP_ATOMIC | GFP_KERNEL); + gfp_mask |= __GFP_NOWARN; + + stack = kmalloc(sizeof(*stack), gfp_mask); + if (!stack) + return; + + stack->stack_record = stack_record; + stack->next = NULL; + + spin_lock_irqsave(&stack_list_lock, flags); + stack->next = stack_list; + stack_list = stack; + spin_unlock_irqrestore(&stack_list_lock, flags); +} + +static void inc_stack_record_count(depot_stack_handle_t handle, gfp_t gfp_mask) +{ + struct stack_record *stack_record = __stack_depot_get_stack_record(handle); + + if (!stack_record) + return; + + /* + * New stack_record's that do not use STACK_DEPOT_FLAG_GET start + * with REFCOUNT_SATURATED to catch spurious increments of their + * refcount. + * Since we do not use STACK_DEPOT_FLAG_GET API, let us + * set a refcount of 1 ourselves. + */ + if (refcount_read(&stack_record->count) == REFCOUNT_SATURATED) { + int old = REFCOUNT_SATURATED; + + if (atomic_try_cmpxchg_relaxed(&stack_record->count.refs, &old, 1)) + /* Add the new stack_record to our list */ + add_stack_record_to_list(stack_record, gfp_mask); + } + refcount_inc(&stack_record->count); +} + +static void dec_stack_record_count(depot_stack_handle_t handle) +{ + struct stack_record *stack_record = __stack_depot_get_stack_record(handle); + + if (stack_record) + refcount_dec(&stack_record->count); +} + void __reset_page_owner(struct page *page, unsigned short order) { int i; struct page_ext *page_ext; depot_stack_handle_t handle; + depot_stack_handle_t alloc_handle; struct page_owner *page_owner; u64 free_ts_nsec = local_clock(); @@ -162,17 +220,29 @@ void __reset_page_owner(struct page *page, unsigned short order) if (unlikely(!page_ext)) return; + page_owner = get_page_owner(page_ext); + alloc_handle = page_owner->handle; + handle = save_stack(GFP_NOWAIT | __GFP_NOWARN); for (i = 0; i < (1 << order); i++) { __clear_bit(PAGE_EXT_OWNER_ALLOCATED, &page_ext->flags); - page_owner = get_page_owner(page_ext); page_owner->free_handle = handle; page_owner->free_ts_nsec = free_ts_nsec; page_owner->free_pid = current->pid; page_owner->free_tgid = current->tgid; page_ext = page_ext_next(page_ext); + page_owner = get_page_owner(page_ext); } page_ext_put(page_ext); + if (alloc_handle != early_handle) + /* + * early_handle is being set as a handle for all those + * early allocated pages. See init_pages_in_zone(). + * Since their refcount is not being incremented because + * the machinery is not ready yet, we cannot decrement + * their refcount either. + */ + dec_stack_record_count(alloc_handle); } static inline void __set_page_owner_handle(struct page_ext *page_ext, @@ -214,6 +284,7 @@ noinline void __set_page_owner(struct page *page, unsigned short order, return; __set_page_owner_handle(page_ext, handle, order, gfp_mask); page_ext_put(page_ext); + inc_stack_record_count(handle, gfp_mask); } void __set_page_owner_migrate_reason(struct page *page, int reason) -- 2.43.0