From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E6D1C48BEC for ; Thu, 15 Feb 2024 21:58:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A468A8D0019; Thu, 15 Feb 2024 16:58:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C6D78D0017; Thu, 15 Feb 2024 16:58:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77CB48D0019; Thu, 15 Feb 2024 16:58:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 617958D0017 for ; Thu, 15 Feb 2024 16:58:08 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 327E6120141 for ; Thu, 15 Feb 2024 21:58:08 +0000 (UTC) X-FDA: 81795401856.13.5943FF8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 039C840002 for ; Thu, 15 Feb 2024 21:58:05 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OdZe2HVT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Nmku8TLu; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OdZe2HVT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Nmku8TLu; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708034286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pcxp99FnLp1RnVVp7F0RPZtIZa/+vMDeTxogq7yX6CE=; b=Hu5gi0nb0RR2/uj3QP37lJVvxdfmICEIiLB9J3q6r56axnPwFUR7N/t85K2vWK1rbwD5IA IriWam6+aQqesSRXeIg60orLF6m3ZCOMGuLoTEarVKBvEIQ6g2KsIrIqQayIhRz6BodGl3 RAvASE9eyPj9aIsswQePiCtFgZHxiw4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OdZe2HVT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Nmku8TLu; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OdZe2HVT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Nmku8TLu; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708034286; a=rsa-sha256; cv=none; b=QbU+oqLzSE/vLtsihG05tTke7ucEMt3eNpy0ltdKHfLFCiiSs9O0u+Ow40/MvIXSFSWtFy WCm4V8MtlHtkZC34LnPimv58lmrATq57VaNumI4ZnZFO8jS11/5rKXwQZSXtJvTyk/yDob p2rVthT8CxJVuNtS13R6wcceaNUfzgc= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 09430220A6; Thu, 15 Feb 2024 21:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pcxp99FnLp1RnVVp7F0RPZtIZa/+vMDeTxogq7yX6CE=; b=OdZe2HVToKR+dXod4mHXxxhQTyYmVE8e7iPBXbqfOUzVljTJpGs5Ga/r/LStLFWk2J7mPa 1sTa/uWN++cLaozklVYWtu1zJCOX+GVAlFVB3XEFsWLBKiEAptEJzMae/h5Ln+0lxFSISK BA4DYYqmjAPMrkAX4JTW2lh3xKsVfE8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pcxp99FnLp1RnVVp7F0RPZtIZa/+vMDeTxogq7yX6CE=; b=Nmku8TLuOVciMQqnVySHUqlbN4Yj+dlteZY+KFFJIRTwfSVWGNKbHU89jXYC10ZWs3n3Vi x2zhcwY5hjJikZBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pcxp99FnLp1RnVVp7F0RPZtIZa/+vMDeTxogq7yX6CE=; b=OdZe2HVToKR+dXod4mHXxxhQTyYmVE8e7iPBXbqfOUzVljTJpGs5Ga/r/LStLFWk2J7mPa 1sTa/uWN++cLaozklVYWtu1zJCOX+GVAlFVB3XEFsWLBKiEAptEJzMae/h5Ln+0lxFSISK BA4DYYqmjAPMrkAX4JTW2lh3xKsVfE8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pcxp99FnLp1RnVVp7F0RPZtIZa/+vMDeTxogq7yX6CE=; b=Nmku8TLuOVciMQqnVySHUqlbN4Yj+dlteZY+KFFJIRTwfSVWGNKbHU89jXYC10ZWs3n3Vi x2zhcwY5hjJikZBQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 7AAD51346A; Thu, 15 Feb 2024 21:58:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id GIBCG+uIzmXPAQAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 21:58:03 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v10 3/7] mm,page_owner: Maintain own list of stack_records structs Date: Thu, 15 Feb 2024 22:59:03 +0100 Message-ID: <20240215215907.20121-4-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215215907.20121-1-osalvador@suse.de> References: <20240215215907.20121-1-osalvador@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 039C840002 X-Rspam-User: X-Stat-Signature: w6xhjqfdjdsjbbzf141m81cw6nmrgffn X-Rspamd-Server: rspam01 X-HE-Tag: 1708034285-842497 X-HE-Meta: U2FsdGVkX1++iuVN0TyGQ1deyyKFzY4uU8DaL9g7FITGUQwEBz3IRvn2oi5pE/npQ5gQZsG5Qoqd8nbOdrcPNo+5Nbl6vIyaW7+HyKWpsY2sXdhH2hLYtzeeCvXVOHQbdcsyh1l3+FDwpxWKp1aFCHAH+CjaPy6xipU6yh5slFUxpover/cY8ZGQXhCQpvueFcllrseH6p9tJl3sxubn5rt+3delZrr1brw5rnY8hbhjP40pwocvnF3TZp+UmQp19dyCFz4rafPJsbACAyLbe5Rw44Af2EHuQDnPWU0IF8NLtwHOAAP+P//GznyU3aSL+VptVj1zxMeevmoq46BljIkP7JCR9GEDB5xGuHi8o0OaGTUXW2barQ2Nd65kVB4Mjln/uhjGwHYv8TSZ6SCmW3sNGWWZ0dz7DgwH/kgz6+lXCRhX/Nuallj12GzXqN08proUJUlbjfhqG5Zx9aBHk3WdsY9Jeci/n3+gb4YStXyhnRmOh5yxITkoofRlTne2aSRX+cpGY+eAtekLOvXZPJKAthw9oETnZsdyJ0yNpKaqwgndRV/lkA0k5E2aoddb3xFvzswEkTe3A78ZO0bngH2TWyGyhFgSOFSWpwGDW+dLCQ13Jzk8O4v/TL87aQ4fdKpNcW0DwxU6/2/eMwrUNT0alhhZybNEhWem4O5k3FVASmhHWX4E1HKxmuqDSyCMLXQWB7oVIiWYDL7ZJECDYVgYz0ZXHWItKuacL+TBANplfAPpJBHLT6wYMHiWi1FjuAeSrOOx3uoF2XoDr1hZSy8yegyH5iTE+LjZwUOWExdE4UdIViUuh+1Ax8syRhwmpY9l5gSJGiqGEF6tBGe6eY8rXZPgBEfW/PKhLd8/Jeg1c86iv1mXUQQH4mKxKzOx4kvhOMlcyfMUdPywgscfJfEWoqpj0EzmqdVjapZ3ktvXnANpTwts72HYPQqvhlYMEriDcg5BKNA/hvmKmo8 +jsY1SNq aU3gBZPsEktzwFUcMJSH0O7zdyQPNzRNAMjCXwtCQjqQbaj9bamdrlwrt4gUlfLeHnjQ0yyr20MNdfTiHnuMoOSwvFIjyUSw3BLd+wPssDbGIH2K/s7QNzgEAe0Rga4WJQhhlbOlgykW2mLDzHEHKmiLRfXin9MPBNK44i6IJdrBvH5KCoXen+dF6Sj1ZxwnTm/f9JB72EFutjtPPmjILUvTcmPsvSlCUUq/zN8t/rE57tArffCOXqBbEWTfDBlAHz8wqISlizmwPVvB2OsgSQPaTaw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: page_owner needs to increment a stack_record refcount when a new allocation occurs, and decrement it on a free operation. In order to do that, we need to have a way to get a stack_record from a handle. Implement __stack_depot_get_stack_record() which just does that, and make it public so page_owner can use it. Also, traversing all stackdepot buckets comes with its own complexity, plus we would have to implement a way to mark only those stack_records that were originated from page_owner, as those are the ones we are interested in. For that reason, page_owner maintains its own list of stack_records, because traversing that list is faster than traversing all buckets while keeping at the same time a low complexity. For now, add to stack_list only the stack_records of dummy_handle and failure_handle, and set their refcount of 1. Further patches will add code to increment or decrement stack_records count on allocation and free operation. Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka Reviewed-by: Marco Elver --- include/linux/stackdepot.h | 11 +++++++++++ lib/stackdepot.c | 8 ++++++++ mm/page_owner.c | 15 +++++++++++++++ 3 files changed, 34 insertions(+) diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h index c4b5ad57c066..3c6caa5abc7c 100644 --- a/include/linux/stackdepot.h +++ b/include/linux/stackdepot.h @@ -178,6 +178,17 @@ depot_stack_handle_t stack_depot_save_flags(unsigned long *entries, depot_stack_handle_t stack_depot_save(unsigned long *entries, unsigned int nr_entries, gfp_t gfp_flags); +/** + * __stack_depot_get_stack_record - Get a pointer to a stack_record struct + * + * @handle: Stack depot handle + * + * This function is only for internal purposes. + * + * Return: Returns a pointer to a stack_record struct + */ +struct stack_record *__stack_depot_get_stack_record(depot_stack_handle_t handle); + /** * stack_depot_fetch - Fetch a stack trace from stack depot * diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 514b8d40ff57..8c795bb20afb 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -687,6 +687,14 @@ depot_stack_handle_t stack_depot_save(unsigned long *entries, } EXPORT_SYMBOL_GPL(stack_depot_save); +struct stack_record *__stack_depot_get_stack_record(depot_stack_handle_t handle) +{ + if (!handle) + return NULL; + + return depot_fetch_stack(handle); +} + unsigned int stack_depot_fetch(depot_stack_handle_t handle, unsigned long **entries) { diff --git a/mm/page_owner.c b/mm/page_owner.c index 5634e5d890f8..33e342b15d9b 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -36,6 +36,14 @@ struct page_owner { pid_t free_tgid; }; +struct stack { + struct stack_record *stack_record; + struct stack *next; +}; +static struct stack dummy_stack; +static struct stack failure_stack; +static struct stack *stack_list; + static bool page_owner_enabled __initdata; DEFINE_STATIC_KEY_FALSE(page_owner_inited); @@ -95,6 +103,13 @@ static __init void init_page_owner(void) register_early_stack(); static_branch_enable(&page_owner_inited); init_early_allocated_pages(); + /* Initialize dummy and failure stacks and link them to stack_list */ + dummy_stack.stack_record = __stack_depot_get_stack_record(dummy_handle); + failure_stack.stack_record = __stack_depot_get_stack_record(failure_handle); + refcount_set(&dummy_stack.stack_record->count, 1); + refcount_set(&failure_stack.stack_record->count, 1); + dummy_stack.next = &failure_stack; + stack_list = &dummy_stack; } struct page_ext_operations page_owner_ops = { -- 2.43.0