From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09775C4829E for ; Fri, 16 Feb 2024 01:16:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88FE58D000E; Thu, 15 Feb 2024 20:16:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 817198D0001; Thu, 15 Feb 2024 20:16:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B74C8D000E; Thu, 15 Feb 2024 20:16:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 564FE8D0001 for ; Thu, 15 Feb 2024 20:16:30 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 941C3AB66D for ; Fri, 16 Feb 2024 00:54:44 +0000 (UTC) X-FDA: 81795846930.04.BF0402C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id B55DD40012 for ; Fri, 16 Feb 2024 00:54:42 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KYXR1+er; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708044882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bNHj95k9HjXwquwXTV4JxeGBU5zX1SyQoOc+W+JEAgY=; b=hktwHPx8+a7GQX5BDqA/WI/QJQLSAOhU0A2veVmxyKAop1QhSwsn88x2q1Y7j2nm6x9i8f aSfuxIassh6DqzAe2wWeB7/1pXcNC584dE09qmCqgU8Co/WXSPC89yiYnIw6XXcO5Wxl1N DabOSVVrhT5hrqrURepLrKUBVFOQrfk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KYXR1+er; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708044882; a=rsa-sha256; cv=none; b=uZGhJQV7UQ+fibCnNwIzs7ML3psr7jXCupzhR46fZUY1e+l3K+OnBu2kX48bXjDGSvYeEb gqkhZjCQEydokeFMhQXSA8+J/t41vVTBKjxmo5puuwA2CDFeW7ngudM01LQx6/4Cv/BPc0 sD8q3HuB5LxZDtxcXZ+mtVQCti59dKY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7B59460FC9; Fri, 16 Feb 2024 00:54:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAA5BC433F1; Fri, 16 Feb 2024 00:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1708044881; bh=ZIEOMXwsk6UMZSFSW/RNZRCFWY8oX4WOTkp26Ser0Og=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KYXR1+er6CkT6dVj5BHoTm5sdpzXInSUFDjwd/A/Yjb7LGJBkBRSRWj5hWf4h9LKS C+G7d4aLzLoAak5aMT/1pDhdwp5e2TSMBrg/VJtTWmvU2Yy7hQLmAYDDo5TkqKMuWM 2DEbMt/kOf0QnfRdomb4IRyy3uv3wiqCnc9MsNuo= Date: Thu, 15 Feb 2024 16:54:38 -0800 From: Andrew Morton To: Suren Baghdasaryan Cc: kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 13/35] lib: add allocation tagging support for memory allocation profiling Message-Id: <20240215165438.cd4f849b291c9689a19ba505@linux-foundation.org> In-Reply-To: <20240212213922.783301-14-surenb@google.com> References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-14-surenb@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B55DD40012 X-Rspam-User: X-Stat-Signature: t8t7d9z47e3zfz4snju6yz46no4wrto6 X-Rspamd-Server: rspam01 X-HE-Tag: 1708044882-521461 X-HE-Meta: U2FsdGVkX19ZfIGhvdT2hzK0eqRhv97FdGSAx6aR9HfJyiIbbM+8Bl6wie97cCZ01CVc8trwSlSV5mYDWb/zQeRAZFai9avNKeb4sUcmG2y31WEJ6mpD4AeogMYrt+wikQlDdNYxjEKxDUmL78ysfnYdJdatyoQBk4ttvVgKyinBfM7pmFLiMut4VonsxRlAbgKwm3Ds8tOl0ibStaDq9xr2W6cWla1oFrejPgEDQgrCdLBIi3u8GNkJmvOD9VOoOyzC/NTWKk5Gdksa6yKa/3rFD24IXAts3eYqDtpWP1pJNdfrI94PjmKSlIdkXXFgvddU2InsS6FpI4OqLtfrIiCSTc2kBdTZsH+jcWmoyOBhjv3zLA5r+2Pp2f8V7c67FFN0JET8+QVBnLQMKgGTcdBGVWBpY+/iCYlNd0uy4Ev4GvN9JPzQuqJ4Ipnup4y3YnUOkIsW+OnpGwbTVB4A8xsJJw85iIWCVVDZCoOvAojoe7xDyfRKxwAa7dEb6dg7JRl1KjjFOVVv/GyAbHBcISb3B9OXw/31FI+XCxYaTeIGUc6TSrMr5orTXB1ASup/GUKCN4gQGk8FdZID5gqzFU3kkEDXJO7Ia2IsJR/NT2xRrgE98lNIACYka5bGxbO5EkQyl9QNmMS5+o1yfTiuzVIgZ2J/6PACqMqWMJbQhnHu/8oXqHY/4NM1EqJHtl4nwij5Zpm6akzYYB4L4yjT8GuNU6vaowuSce1t5rXeM74+HYuarogN9HxJxwqW1F9yjIm6mKU8/splrpg/kOWeQUEFk+TmgdJsl9nGMJW6yoRTjSkjrVBJUKTfYrF8SeB5O8WT3lAg0yBwr4cV6EpW1YJpcOfaZX8GF1FVzyVhwG7bGuwfMKmSuOwMbKSMZL7jp4hJacuQFZeTT8hwEc+a9UYydkNnY+Dlwwve2v+0RFlTxyi4j0QhGodQ/uWYRnNckyaF6bviPsgKJ6M7Mox enbbDap1 UPm3sCS5isUp7nQiGhEiLWwTtpZiPTCzRM8JZFBBR2SGdAIYjDl0YB9ZDCg+Zvz1TpW87G9MwzYCem7H9mC7x70WmXnq7P6S3nPYm9bEn2Kawg+piHsfYjhChCLXPE0CmDKtvc/kY0TsFLUh9txeEM+KZpY7osuNQ1lhRTciYFJqQ2uqHGsvQAfeCIqSiCtv3LFt/JgRIvzyyQ4GtE+p2JB8IvtEi7RiG/l8afOQboo35+ED4XRfR7jRt6LGYsxVVqPnakCUkxK6WxEre9tuUhFO4ZQ7QvG1EQgH8Kpz4XCsicI4as6AS9T0NmzpjJBBKRhIU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 12 Feb 2024 13:38:59 -0800 Suren Baghdasaryan wrote: > +Example output. > + > +:: > + > + > cat /proc/allocinfo > + > + 153MiB mm/slub.c:1826 module:slub func:alloc_slab_page > + 6.08MiB mm/slab_common.c:950 module:slab_common func:_kmalloc_order > + 5.09MiB mm/memcontrol.c:2814 module:memcontrol func:alloc_slab_obj_exts > + 4.54MiB mm/page_alloc.c:5777 module:page_alloc func:alloc_pages_exact > + 1.32MiB include/asm-generic/pgalloc.h:63 module:pgtable func:__pte_alloc_one I don't really like the fancy MiB stuff. Wouldn't it be better to just present the amount of memory in plain old bytes, so people can use sort -n on it? And it's easier to tell big-from-small at a glance because big has more digits. Also, the first thing any sort of downstream processing of this data is going to have to do is to convert the fancified output back into plain-old-bytes. So why not just emit plain-old-bytes? If someone wants the fancy output (and nobody does) then that can be done in userspace.