From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38F7FC48BC4 for ; Thu, 15 Feb 2024 23:56:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC49B8D0017; Thu, 15 Feb 2024 18:56:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A749B8D0007; Thu, 15 Feb 2024 18:56:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93C128D0017; Thu, 15 Feb 2024 18:56:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 77D4A8D0007 for ; Thu, 15 Feb 2024 18:56:01 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5256EA28A6 for ; Thu, 15 Feb 2024 23:56:01 +0000 (UTC) X-FDA: 81795698922.08.48A4C63 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id B0E194001C for ; Thu, 15 Feb 2024 23:55:59 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ARjB6lGo; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708041359; a=rsa-sha256; cv=none; b=z2TojepAz/vNBJbqJryFyI2DMEUESNU68vD6x9JBzmIJoMKJikB5S00UYjQxdki+RMh9p5 zzWo1Q7KzQQyl6Ge74v2ZOtBDRYLcO3SMAdFZcMVz9v5UgTvrC/4sA7Ry2VdpcPDLY48lP QKrYQXaxybNkNsg9krWlITb9cfZODDs= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ARjB6lGo; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708041359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xkLARS43hvjAHVhcFLH6Ls32cEsh4jHwC8XtRpeLQ+g=; b=RZKpwasY+sbZ4dsyY6RsysdBs7TyuXRzxoQQdukqmOdfVX996oZaqIaRm5bN8yLkqcuqbP HFeINyBaGv3wniZLHa8nZ6dcknXkt1Lbv75rNXB94T4WbRjR6bu0FOL/hw5CoNJZRHNUjZ CgNDnwwB3dd9auMyrVreFl7duf65Zdk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 93E5660F21; Thu, 15 Feb 2024 23:55:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE900C433F1; Thu, 15 Feb 2024 23:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1708041358; bh=+32/LIgsTmazR7DFb8Tgomviel8c8z5g+ukyJtBOrV0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ARjB6lGonfAu0Rk38IH8t89nBWYjI3WfC2X2+Rs0xh8Fpv8dbOtxJ/5PENGx2mnli cURmyUmJxM+hu+VGcsNL06CkPuSJy8k4COIslVXGus96sRDZOPfL1VE4s7mOvcbh1d cEhW8YpDtWTr9ItDBH2/G9BQh5D4jCfTmagWo0h4= Date: Thu, 15 Feb 2024 15:55:57 -0800 From: Andrew Morton To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Mel Gorman , Matthew Wilcox , Mike Rapoport , Pasha Tatashin , Kent Overstreet , Michal Hocko Subject: Re: [PATCH v2] mm: document memalloc_noreclaim_save() and memalloc_pin_save() Message-Id: <20240215155557.93b23f4a69c6062e7878ed14@linux-foundation.org> In-Reply-To: <20240215095827.13756-2-vbabka@suse.cz> References: <20240215095827.13756-2-vbabka@suse.cz> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B0E194001C X-Stat-Signature: ioiftapsp13mtnz5dkq67mrddcz6rx97 X-Rspam-User: X-HE-Tag: 1708041359-913754 X-HE-Meta: U2FsdGVkX1+fyMW+Xg/A2CrOypkHNKDjIUUtpXAgrrpE85CSSa6t43cRtqhbe+JZTVltFxJkDzLoUzsuYt/y26iCPnH1jYZyiABfdr9Kava8LH6ShRi7Eq/Tq0fAboXCSkM0DBOV2Ca92q5Tpax1nx0MMn9jePeuo9zbivOU+wACP83cgD0QTBc6ddNOKgxCQV0RjeUThTPrlO73JiyodxGMYEbeOs9lhJO/KJXXhA78rMUJ5Wx2J/kNeEG1B9VK7Q9VgN66tb2zy9+DsSWLwAGKpJCiS25CsStDq/PFutC3rBy/JmJAtb2gv5JlNkHY3VVjE7HJgEWh3c+1lKlbES8GdX6A2iOTC/CbL315DAFuguNvIwwEtApx93RpAkIn9ujT06LJXobQgMIGAhhNqBTbbDr3JHgt3r177e+1OlRPucydJGeGspT5GcbqvO93F6WpynXDn67ulqd1U/adOaJ3gNwgYTEaD8YSs2ZSVjLSoNo+cupqflHyLZ5phq7/rxOv7pIODRWvea7xNpHQQaKn0WaL1bVfxZZ0cqOAdbHG8Z5cBIMW8hJa0pxmtMiWHq6/w69lv5HoBR5HjKV2icY12d5AgNd116ZFiez1i75wRW7tjInqxaSeIMq4Z8Cfb+K4zVtwqCU78oArIKmanPbLB2vNFkMx3y3BEG1J59aSwObdQ5nEJjOBeD6AwrqI0c4eyfimpPVy6Df9U5pMPlv2guFawVK96QIKPB8P/2E/M4QbVvS13N1ILgY8osKMp4RyPmPqMSbzmCadeGQlaaegCd9eq5/JgYRYzu/wB331WMrTJ55lWUHuqzLjtxIZX7qcq+y8HM1uEE8xOtaN8S9a5AqXSI40WxzwZFEVYjpPNuV1BN6A8VIMOiaY7XeeBg78aKfdr+9owgkze4jSfr2LRnCY3VpAEcXRoJOpNXNGM1z9oSEI7/DexCiXpnmhuLK4cWcYyycJELjHFQw usS5r2a0 r+uTY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 15 Feb 2024 10:58:28 +0100 Vlastimil Babka wrote: > > ... > > v2: fix issues that Mike pointed out Cool. > sending as replacement instead of fixup because I've used the wrong > address for Kent and it became part of Cc: tag in the mm tree. akpm has editor ;) > + * This function marks the beginning of the __GFP_MEMALLOC allocation scope. > ... > > + * This function marks the beginning of the ~__GFP_MOVABLE allocation scope. pet peeves. We can assume that the reader knows that this is a function! Perhaps we should teach checkpatch to whine. Like "the function foo" and "the function foo()" in changelogs. "foo()" is enough!