From: Andrew Morton <akpm@linux-foundation.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@kernel.org>,
Mel Gorman <mgorman@techsingularity.net>,
Matthew Wilcox <willy@infradead.org>,
Mike Rapoport <rppt@kernel.org>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Kent Overstreet <kent.overstreet@linux.dev>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v2] mm: document memalloc_noreclaim_save() and memalloc_pin_save()
Date: Thu, 15 Feb 2024 15:55:57 -0800 [thread overview]
Message-ID: <20240215155557.93b23f4a69c6062e7878ed14@linux-foundation.org> (raw)
In-Reply-To: <20240215095827.13756-2-vbabka@suse.cz>
On Thu, 15 Feb 2024 10:58:28 +0100 Vlastimil Babka <vbabka@suse.cz> wrote:
>
> ...
>
> v2: fix issues that Mike pointed out
Cool.
> sending as replacement instead of fixup because I've used the wrong
> address for Kent and it became part of Cc: tag in the mm tree.
akpm has editor ;)
> + * This function marks the beginning of the __GFP_MEMALLOC allocation scope.
> ...
>
> + * This function marks the beginning of the ~__GFP_MOVABLE allocation scope.
pet peeves. We can assume that the reader knows that this is a
function! Perhaps we should teach checkpatch to whine.
Like "the function foo" and "the function foo()" in changelogs.
"foo()" is enough!
next prev parent reply other threads:[~2024-02-15 23:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 9:58 Vlastimil Babka
2024-02-15 23:55 ` Andrew Morton [this message]
2024-02-16 18:04 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215155557.93b23f4a69c6062e7878ed14@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox