From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82731C4829E for ; Thu, 15 Feb 2024 12:47:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDA628D000E; Thu, 15 Feb 2024 07:47:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C899B8D0001; Thu, 15 Feb 2024 07:47:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B29F58D000E; Thu, 15 Feb 2024 07:47:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A0D308D0001 for ; Thu, 15 Feb 2024 07:47:20 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 67132A0FF0 for ; Thu, 15 Feb 2024 12:47:20 +0000 (UTC) X-FDA: 81794013840.22.3184C94 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf05.hostedemail.com (Postfix) with ESMTP id 4266610000C for ; Thu, 15 Feb 2024 12:47:17 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GfTUL9tm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hCJjNIfk; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GfTUL9tm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hCJjNIfk; dmarc=none; spf=pass (imf05.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708001238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+cWO/tWfyRm+uLRU3AlRpL172DdnCULMSesTiEnWQ9I=; b=o6pVsgIjHJ16H2H1OKYukqeLs0iC58YKlYLYTiIMBwjLj9yufrJhz1WIc/rKa07PjxA2dW utKfG27eUj1wWaaHsJMkfx0sYSAmjJGS4LkrnHKCqZk9u0jOWL3/IruOTR+4UkTOQPg80Z 5fkX9Far2eeGJ08WGT02vcnUMKtaWTo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GfTUL9tm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hCJjNIfk; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GfTUL9tm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hCJjNIfk; dmarc=none; spf=pass (imf05.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708001238; a=rsa-sha256; cv=none; b=QJUfT5Pu1+fy89T/KDvIENQJQzV1OisNjk82lGTEgNaR2NcZOA4kUHDc+dmFUAwqhTazdH hY9sECWAoJ7SeloZb+1mxPdRC2DB3ERGR27np+miYnPBfLs6QAIeC28JfGoolOHPZyOrcL 0f6Pq3TDD7meJIPWiNFPgJr/ldG5wuo= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 756F61F893; Thu, 15 Feb 2024 12:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708001236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+cWO/tWfyRm+uLRU3AlRpL172DdnCULMSesTiEnWQ9I=; b=GfTUL9tmlOv92k8l4zlSF9Tu1SL55JdV/3vw8wfaPFcfFFzIUjo8DN+7u3fqye4wK2Q+xi nJGOgp8o2COBQ+fLPc3APPa9r95FdBOzfIZhPbcDUyKhhE8USCHOqeGolNz1ZMA5RJ0/OP 8PWzR6Ir7EnrR60yea1+EG1eWV5w5Ac= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708001236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+cWO/tWfyRm+uLRU3AlRpL172DdnCULMSesTiEnWQ9I=; b=hCJjNIfkKuflINvJYN1DacPorlSqfOeOGWa0eC9yp1gT1Pja0hilfS06+/LF4FsxdGisoJ OIuDqSU1Q9fplKDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708001236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+cWO/tWfyRm+uLRU3AlRpL172DdnCULMSesTiEnWQ9I=; b=GfTUL9tmlOv92k8l4zlSF9Tu1SL55JdV/3vw8wfaPFcfFFzIUjo8DN+7u3fqye4wK2Q+xi nJGOgp8o2COBQ+fLPc3APPa9r95FdBOzfIZhPbcDUyKhhE8USCHOqeGolNz1ZMA5RJ0/OP 8PWzR6Ir7EnrR60yea1+EG1eWV5w5Ac= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708001236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+cWO/tWfyRm+uLRU3AlRpL172DdnCULMSesTiEnWQ9I=; b=hCJjNIfkKuflINvJYN1DacPorlSqfOeOGWa0eC9yp1gT1Pja0hilfS06+/LF4FsxdGisoJ OIuDqSU1Q9fplKDg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 5AC43139D0; Thu, 15 Feb 2024 12:47:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id 26QeFtQHzmWVEQAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 12:47:16 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 149AFA0809; Thu, 15 Feb 2024 13:47:16 +0100 (CET) Date: Thu, 15 Feb 2024 13:47:16 +0100 From: Jan Kara To: Chuck Lever Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, hughd@google.com, akpm@linux-foundation.org, Liam.Howlett@oracle.com, oliver.sang@intel.com, feng.tang@intel.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, lkp@intel.com Subject: Re: [PATCH RFC 2/7] libfs: Define a minimum directory offset Message-ID: <20240215124716.a7vdfjcnntyc6qj6@quack3> References: <170785993027.11135.8830043889278631735.stgit@91.116.238.104.host.secureserver.net> <170786025248.11135.14453586596030949713.stgit@91.116.238.104.host.secureserver.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <170786025248.11135.14453586596030949713.stgit@91.116.238.104.host.secureserver.net> X-Rspamd-Queue-Id: 4266610000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 14zzpozrrsosc8kz5ukfzjt6zjt6gneq X-HE-Tag: 1708001237-53055 X-HE-Meta: U2FsdGVkX191xsu2voFXrDEZ5izsLC7UD9HLkiZAwXvCZ2DlJl3N2QL5uT5pmS0RmkNF0Z/+C85jMQftx+cFYSbYqAJ54Cx0LDdrbbXAtOmfrg+TUgIIOo4cqNBu/f1y9ZnK9Korg5ZvCFNawTuKxsNKx16mrXioMVNPbx/JnwB7ugFZB+PaQm8lw/4rnon20rcNru9QJwGNBMJg4Qu3YKZnCsMGkGcG4i7hScv+2euXWVh3/jDod2FzdgRLN/XkQfDOUFMdfQ46rH6hMhsjg6gqzp3AB+iOoj04oIzYk87KMmqEG82q10P8wuKUpnYrSqwRQhrBdHhVyUMOvlCnVviQubOQHaxU4oT8OQQ2Glo6Lx1ecztG2fXUMzB4/vxheI4VG9pOzHyjIU4fwx3nhN6W865lU3SPGUddiz7r0uU2TOL5Ctb+cisA2bVYTeSDCEu7igUVpLShd6GWNRXtTA1q2kisAm6ojSslOEe8uWo72EaXYkXD9iFe6q0etW+jhLEAtdO4QJ7QC+yzMM/gYnidiDQ+By5yWE3WoSEtouNah81oRMvkKorEH9cUpuShOg+WLIZAdESvfJXk8izT8gug8dgaUUauzP2hdCMqzdV5d+CnbxX4OKZAzbqn4QBaxcIz4lMP1kOdd3/QNJAf1A4hHsPGwuQUIwqCom9yKL6NeN5hKdSFucwrsAmdODwX1fW1JtnCByS74amN+V6g3R9+DkO7NeW/NE5DfzwqV4nQExPSa9/ssFQR4+MSXlnnpjQQ8SJodxPQZJPzC9D3WHRgQakWInmfGa6JRpTkDJ9iWv4exT5Qtm9jJfwQ4Xrqto3OMwcEIV89F6ZfXOpyaBZBYHna9TSmPK6qUt/5rmey5/NlsSMIHPOfR5sFKu6HJgpAf2/wV91DpMMAV0xj5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 13-02-24 16:37:32, Chuck Lever wrote: > From: Chuck Lever > > This value is used in several places, so make it a symbolic > constant. > > Signed-off-by: Chuck Lever Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/libfs.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/fs/libfs.c b/fs/libfs.c > index bfbe1a8c5d2d..a38af72f4719 100644 > --- a/fs/libfs.c > +++ b/fs/libfs.c > @@ -240,6 +240,11 @@ const struct inode_operations simple_dir_inode_operations = { > }; > EXPORT_SYMBOL(simple_dir_inode_operations); > > +/* 0 is '.', 1 is '..', so always start with offset 2 or more */ > +enum { > + DIR_OFFSET_MIN = 2, > +}; > + > static void offset_set(struct dentry *dentry, u32 offset) > { > dentry->d_fsdata = (void *)((uintptr_t)(offset)); > @@ -261,9 +266,7 @@ void simple_offset_init(struct offset_ctx *octx) > { > xa_init_flags(&octx->xa, XA_FLAGS_ALLOC1); > lockdep_set_class(&octx->xa.xa_lock, &simple_offset_xa_lock); > - > - /* 0 is '.', 1 is '..', so always start with offset 2 */ > - octx->next_offset = 2; > + octx->next_offset = DIR_OFFSET_MIN; > } > > /** > @@ -276,7 +279,7 @@ void simple_offset_init(struct offset_ctx *octx) > */ > int simple_offset_add(struct offset_ctx *octx, struct dentry *dentry) > { > - static const struct xa_limit limit = XA_LIMIT(2, U32_MAX); > + static const struct xa_limit limit = XA_LIMIT(DIR_OFFSET_MIN, U32_MAX); > u32 offset; > int ret; > > @@ -481,7 +484,7 @@ static int offset_readdir(struct file *file, struct dir_context *ctx) > return 0; > > /* In this case, ->private_data is protected by f_pos_lock */ > - if (ctx->pos == 2) > + if (ctx->pos == DIR_OFFSET_MIN) > file->private_data = NULL; > else if (file->private_data == ERR_PTR(-ENOENT)) > return 0; > > -- Jan Kara SUSE Labs, CR