From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F82EC4829E for ; Thu, 15 Feb 2024 12:42:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B77EF8D0006; Thu, 15 Feb 2024 07:42:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B26C98D0001; Thu, 15 Feb 2024 07:42:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C6C88D0006; Thu, 15 Feb 2024 07:42:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8CC248D0001 for ; Thu, 15 Feb 2024 07:42:57 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5A9CD121018 for ; Thu, 15 Feb 2024 12:42:57 +0000 (UTC) X-FDA: 81794002794.13.63F3D66 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf16.hostedemail.com (Postfix) with ESMTP id DB9C418000E for ; Thu, 15 Feb 2024 12:42:53 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SFCehM1i; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZD2C3IWP; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SFCehM1i; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZD2C3IWP; dmarc=none; spf=pass (imf16.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708000974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xllyM6ganl1nkUdTCw7dKs4zu1EaUQeku+Rjbl7poO4=; b=NiBcc77cbkWX0z5LYXK1tnOjS9HDLSH/eJRGZ5Y3zmeORWFwBYsn02mPLtLr9MTzEXvUdY C3+SNpmq/4q6uHAS/lgjDIguGXtw/WQysbsYofYKOVFdivbmv0UZzRkD/Sa2FAdgsnRJkf gcT1XEiTn81Po1ucHktspCEeK9DKfLg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SFCehM1i; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZD2C3IWP; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SFCehM1i; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZD2C3IWP; dmarc=none; spf=pass (imf16.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708000974; a=rsa-sha256; cv=none; b=je2E3khgGX4hQ/ZuMco3tSSoTGfAh/ETWDjiKnZjvBkBPlVp2zhD5BlojNf+fWZSdnuK6+ KPtMGZJf2ZqL3eDcTws229HHI6nSa58lFQNYZK6hOTnFROUEK+kD1qJzWaW6Q+llqV4TkI /foEaOQH4HEE4DGYi//2J2Aq+2GlxDU= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 010891F88F; Thu, 15 Feb 2024 12:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708000972; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xllyM6ganl1nkUdTCw7dKs4zu1EaUQeku+Rjbl7poO4=; b=SFCehM1i0eL+sOnqh6j56G4C/q2zS+cbmhg5mLeK71FLcnOiHc6cxMoD4IhU08kh3glFXP q+8Hy/BxIOVsPqoWXSih1xbyTGeHW6/8Za/nx5MhvCEEVyiALHMmeHpIaqdUCrZjoRUSqP ThPhgtf506qzJBb1S3ZDaBWvberFkG4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708000972; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xllyM6ganl1nkUdTCw7dKs4zu1EaUQeku+Rjbl7poO4=; b=ZD2C3IWPN70iRjUwEZcMgKUegCNZK9lM6VlWwkd3uS6MQL4FW4DrdYcnIbFvTxVtd1pd7m IsVBucz/sNZkaxCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708000972; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xllyM6ganl1nkUdTCw7dKs4zu1EaUQeku+Rjbl7poO4=; b=SFCehM1i0eL+sOnqh6j56G4C/q2zS+cbmhg5mLeK71FLcnOiHc6cxMoD4IhU08kh3glFXP q+8Hy/BxIOVsPqoWXSih1xbyTGeHW6/8Za/nx5MhvCEEVyiALHMmeHpIaqdUCrZjoRUSqP ThPhgtf506qzJBb1S3ZDaBWvberFkG4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708000972; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xllyM6ganl1nkUdTCw7dKs4zu1EaUQeku+Rjbl7poO4=; b=ZD2C3IWPN70iRjUwEZcMgKUegCNZK9lM6VlWwkd3uS6MQL4FW4DrdYcnIbFvTxVtd1pd7m IsVBucz/sNZkaxCA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id E22AD139D0; Thu, 15 Feb 2024 12:42:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id tzgtN8sGzmWsEAAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 12:42:51 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 8E7C5A0809; Thu, 15 Feb 2024 13:42:47 +0100 (CET) Date: Thu, 15 Feb 2024 13:42:47 +0100 From: Jan Kara To: Chuck Lever Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, hughd@google.com, akpm@linux-foundation.org, Liam.Howlett@oracle.com, oliver.sang@intel.com, feng.tang@intel.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, lkp@intel.com Subject: Re: [PATCH RFC 1/7] libfs: Rename "so_ctx" Message-ID: <20240215124247.yfzxqbp6dirnvgrf@quack3> References: <170785993027.11135.8830043889278631735.stgit@91.116.238.104.host.secureserver.net> <170786024524.11135.12492553100384328157.stgit@91.116.238.104.host.secureserver.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <170786024524.11135.12492553100384328157.stgit@91.116.238.104.host.secureserver.net> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: DB9C418000E X-Stat-Signature: zswuwh79mxru89bpr55fekmrkjz39nrd X-Rspam-User: X-HE-Tag: 1708000973-824270 X-HE-Meta: U2FsdGVkX1+eEmnYB66FY4nzCWzEfxPpUedf0j/1dqpAWrVtBBvQGvuvWLbpZXUyhHzCdvXeQMk9DeB1uw/e3Hq9IrkTHGgPGPyL4qm2BbMbdafLyDqZTZdrN9bba1dhkBulgwae/X9f1h6iBGSyWKvDg9E4L5e97bM10D8Cl5YEXkp0sdR+3njyxqCqHvXdew49MNKkuHfUYwCtJ+91N9iBYoz2o00RZMqrATGNbBxUBDiG0+mVSGdlin8yjjjHwRr/of1zugbNr8P2YkpzHQgKE+R3lGncXblUYaiyRozupXjqXveYHMfKK4bKbHHeFf7HonHK05iJ+XX/PwZLS4fP9lDuuI66ocyt9/lr3jVTL1kE0Vtbhjfmd0kAbomuwOIWHqRvX3yq+pcYvCtX9J/QUsaJphTghEVB2+ef3IqIfbN9wY914kGrBCxym/EHqXzG14klOOOpY3qNKOfCAc/Qw70nqHc9FMrVm19nQ9cNon2QyTnZzQyzPUXQmSyP+wkUcDcrXhfzrvYBvY/BEPjvgnNE67hUIRs1t9yRfacrzaGdoRbgGPaiATIv9qx/hdEfXpEevQ+oyEhikgFCQqB1iaRg6+u5itLvaHD/RLXg2nyK5krg68Tbejn55cQtL13/x4nJgO2HuO7ihd6Th0+nt5Y1u4FKt3KFmv5dy50f709DlkRpo7yTdFuz1Qc5kD1DFUSAtfs1gekFuC1uI72arZT4zSe/NHTEM6XDgb7RryH1ZaEQqCFfU158P4rj/XjrwVB2LHfDOXMrYsCyBNcsjcX+owZDjQKzrEH/x+BAqaX82D3xxQQv2hl8iH9WbW8ZBJb7NCMVZPeHl7uwBWO+JlobQe6T6SWgzHre67lR9vnQEVdNX/yh+yVlaR86q16n+o7FoU86/N8SvJpRtj9Q+U2I8WlyRpdttB0fZlzpOrZPdANugRMBAoeNMm6nzfwqvBLCuKB4uGWa1f0 Ilr8j7Pj UEMCaz/IxOKS01GNmdohn6J14c552JKt1XKie+Ekm5bltgFXGnH3zqteUNcihUHf4fWKHkPzpd2sWogyPDlFlTD1LTUrS8zRyNtR66ekW5si+grnIc318pEcW7ATuGnkSipaZUeykhIHJ1Bs3iw5SS/iJ1cmr/QYh5m+E6PJK/BDmsAy1ef0XH5beOTB4K03shCd52mbtfNktNwfaPGeb8IBgstZF93zqCrUC8Lxc0MzZsnToVzlJxwAxvFHQr9ARem4r6bffiC1ALkfJnnL2Wb4+kFPIzTjB3DH/7WAvKzNZCBHyxjADaavI+u0FyXg7Qza4NnTfZ5abfs8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 13-02-24 16:37:25, Chuck Lever wrote: > From: Chuck Lever > > Most of instances of "so_ctx" were renamed before the simple offset > work was merged, but there were a few that were missed. > > Signed-off-by: Chuck Lever Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/libfs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/libfs.c b/fs/libfs.c > index eec6031b0155..bfbe1a8c5d2d 100644 > --- a/fs/libfs.c > +++ b/fs/libfs.c > @@ -271,7 +271,7 @@ void simple_offset_init(struct offset_ctx *octx) > * @octx: directory offset ctx to be updated > * @dentry: new dentry being added > * > - * Returns zero on success. @so_ctx and the dentry offset are updated. > + * Returns zero on success. @octx and the dentry's offset are updated. > * Otherwise, a negative errno value is returned. > */ > int simple_offset_add(struct offset_ctx *octx, struct dentry *dentry) > @@ -430,8 +430,8 @@ static bool offset_dir_emit(struct dir_context *ctx, struct dentry *dentry) > > static void *offset_iterate_dir(struct inode *inode, struct dir_context *ctx) > { > - struct offset_ctx *so_ctx = inode->i_op->get_offset_ctx(inode); > - XA_STATE(xas, &so_ctx->xa, ctx->pos); > + struct offset_ctx *octx = inode->i_op->get_offset_ctx(inode); > + XA_STATE(xas, &octx->xa, ctx->pos); > struct dentry *dentry; > > while (true) { > > -- Jan Kara SUSE Labs, CR