From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65F20C4829E for ; Thu, 15 Feb 2024 09:31:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E22AC6B008C; Thu, 15 Feb 2024 04:31:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD3BE6B0093; Thu, 15 Feb 2024 04:31:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C24FF6B0096; Thu, 15 Feb 2024 04:31:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AD1626B008C for ; Thu, 15 Feb 2024 04:31:23 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 601A4160E7F for ; Thu, 15 Feb 2024 09:31:23 +0000 (UTC) X-FDA: 81793520046.06.0716444 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf09.hostedemail.com (Postfix) with ESMTP id 12EB7140010 for ; Thu, 15 Feb 2024 09:31:20 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DeW4mmZx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1wnlXCsM; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DeW4mmZx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1wnlXCsM; dmarc=none; spf=pass (imf09.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707989481; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IJ2RIRbHuDlNpht/wlEMXLnwxWumvhJ/wdRsLs0UrL8=; b=YejolSMZOqzc5+MkGYYkjDF5DRklzwyu5yozfog2yHOrCxcLhDrvlqxfTpoe7AZbA3o+ry 02gulZHVF55g9P4EtzTecmvke0ZP5n4bRrkWiuCv3Fkp2zcsmIFsfY9flYmdWGl+ZPQ+70 i9/2jx1HZen2CtRk7aXmd+5fZEx3Cw4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DeW4mmZx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1wnlXCsM; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DeW4mmZx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1wnlXCsM; dmarc=none; spf=pass (imf09.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707989481; a=rsa-sha256; cv=none; b=7OOhmna6p8nszv/2cPNPK3tYRf0+u2F7VsPfj6/3kqWfLnqR154BSLMbdZU37FO5fQkJhs gUCgDu+HlGZ5ynvvXlpCfGP8u72cicZ1nbAOS3oQmQrDm0jddE4bLhydVCq6clqkA2IwmO Qosw90PFQWo66GgVRhFUNYHuvkg1III= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6351421F86; Thu, 15 Feb 2024 09:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707989479; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IJ2RIRbHuDlNpht/wlEMXLnwxWumvhJ/wdRsLs0UrL8=; b=DeW4mmZx4HnTja/ymavqoKDrOaQqrC4tu/qZ97aClfsrUSIcBS3S1AxiG75s5jgYJkHRNp jCpUKpnV9eWDEwlE0Yoorp0aWlApy7Z5UXTBgGTxJje9G1USQJxPCVnXOzuglNNRmVxQ6E ETCRPcWDXVpuVyx58jkF49DgiXgFmY8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707989479; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IJ2RIRbHuDlNpht/wlEMXLnwxWumvhJ/wdRsLs0UrL8=; b=1wnlXCsMiq2FXMU0Evi59wWmLyM8qsADTkLmSCUGY3jFMOHzJXN659NqKocPediwGzriBz tPEKXvatjxDp9RBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707989479; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IJ2RIRbHuDlNpht/wlEMXLnwxWumvhJ/wdRsLs0UrL8=; b=DeW4mmZx4HnTja/ymavqoKDrOaQqrC4tu/qZ97aClfsrUSIcBS3S1AxiG75s5jgYJkHRNp jCpUKpnV9eWDEwlE0Yoorp0aWlApy7Z5UXTBgGTxJje9G1USQJxPCVnXOzuglNNRmVxQ6E ETCRPcWDXVpuVyx58jkF49DgiXgFmY8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707989479; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IJ2RIRbHuDlNpht/wlEMXLnwxWumvhJ/wdRsLs0UrL8=; b=1wnlXCsMiq2FXMU0Evi59wWmLyM8qsADTkLmSCUGY3jFMOHzJXN659NqKocPediwGzriBz tPEKXvatjxDp9RBA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 5916A139EF; Thu, 15 Feb 2024 09:31:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id dM24FefZzWXtZwAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 09:31:19 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 0D39DA0809; Thu, 15 Feb 2024 10:31:15 +0100 (CET) Date: Thu, 15 Feb 2024 10:31:15 +0100 From: Jan Kara To: Christoph Hellwig Cc: linux-mm@kvack.org, Matthew Wilcox , Jan Kara , David Howells , Brian Foster , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/14] writeback: don't call mapping_set_error on AOP_WRITEPAGE_ACTIVATE Message-ID: <20240215093115.ad6ouwphhbbcwq73@quack3> References: <20240215063649.2164017-1-hch@lst.de> <20240215063649.2164017-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215063649.2164017-2-hch@lst.de> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 12EB7140010 X-Stat-Signature: j5ftm67ahhzk6ba6rxqzk565u3xf3p6g X-Rspam-User: X-HE-Tag: 1707989480-300026 X-HE-Meta: U2FsdGVkX1/lud9cMf8AtiG9hrqBYEBzIaOLQrcYFlYDj/cgj3yH0nI836F2Kt/EIeqJmFWHgcFy0IRWyWVJZiQmtFVAewMF87gZextallgnO556irfHPdNALMs2EmpoIBl3iWNkJAKjxtvg3vCzudGBF3BjdJq6H1F+/Xh1qf6aeDaJgAYTL/KMw1Ml+XwqCxhM+Y1MLq/sx85TJeZwESlZEd3fvjdT3s1eOY78I6oUkF0tnppHtgEHe4Z/LmBlHJBJ7wn2UTiNIbPnb1MJdO32kz3wLT1dEwKyQlk5EGm00b4GPXx1vUjQL0OtS9N+I5vPCysulOzLAe99RPhCBGW0Z1AVVGHvn7dYjSWVdtmsZXlP9fcI8AO4l8Wr998j/K+uozKGSz4wb/LCe9pyM2bGTO2gx5P5ECk56ienNjjjW7gAevOCZMv0oWQM5HpV7afoKNE9V/bK2fnrchjX+mkZbAcW+Ncbyv0pipnO5ERNQZ8efo3mD8C8fnky81PxpWy7oUZoU8dl77g1VNDtLFTGHPm0XBySOU6NzU2lcdmkTcZhANb7N1pOvlOfD53YZ5Acs7kuuLKVCyGuSdR+fGN9TsnsjKos+Sx1jbHkM/9xpluF0+ln7f28CSC608Z3IaxciErGJ4xhhT7dq3dF4Sl3Mbj/uQ5LzQV3mdSBtgOQWR2Z58osQXuSITLhHB+TYE2s+VmhuQNwEUQqD3/8QkYUpl6Ste6KR03JtIQJQcUZ/m2aARXnkVTsFMUjDx8v0NIl4im8rxLaHjtSFPjAUDBnshhQr9xWx4IiMrX1n5uSgUK5jeGKwA505D5wOvZnTmqyk3pZAeJSf7I2OGNzqg9WmhPHEe93TXnKOLJqHi8JNBOHUfltkXS9YtQkx+2nSQJyK1SXGv8RWbNHzoPmQeJAMbOE4D20O0R41QHsurcv1usxJQY5LnoO69VrVPoMENpUR8svjWVBX4gQ3zg /lXSKt0L 1VOMMM92yD+TyJFLk+YQIfOpiLjKaxgzj4Q+fUxyTS0zuruGYMgmnwBExJMaL0xJKBGqntFIi/UI8l0ue2dQibvQO1nGPshSujiJb6fDx4vTd6RZhb068Xgq88sBc5DDkIthMnW3uD1vflnpyeMjAbHBR64gro5QAAErpc9CaSBwek+3cXq5D+nC9LS0EEI9WDvUhdMJmPRymC7BZP1XSk2llKxNabfOzn+RAOgET8Hh3l1m4aTTgZslnYzQFxqX5hsQXPO9ttfyCaA5U9qomEA5UE+dzXzN1JBFrT/yDqufraGc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 15-02-24 07:36:36, Christoph Hellwig wrote: > mapping_set_error should only be called on 0 returns (which it ignores) > or a negative error code. > > writepage_cb ends up being able to call writepage_cb on the magic > AOP_WRITEPAGE_ACTIVATE return value from ->writepage which means > success but the caller needs to unlock the page. Ignore that and > just call mapping_set_error on negative errors. > > (no fixes tag as this goes back more than 20 years over various renames > and refactors so I've given up chasing down the original introduction) > > Signed-off-by: Christoph Hellwig Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/page-writeback.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 3f255534986a2f..703e83c69ffe08 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -2535,7 +2535,9 @@ static int writepage_cb(struct folio *folio, struct writeback_control *wbc, > { > struct address_space *mapping = data; > int ret = mapping->a_ops->writepage(&folio->page, wbc); > - mapping_set_error(mapping, ret); > + > + if (ret < 0) > + mapping_set_error(mapping, ret); > return ret; > } > > -- > 2.39.2 > -- Jan Kara SUSE Labs, CR