From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4485FC4829A for ; Wed, 14 Feb 2024 06:59:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 938406B009D; Wed, 14 Feb 2024 01:59:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BE6A6B009E; Wed, 14 Feb 2024 01:59:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 737876B009F; Wed, 14 Feb 2024 01:59:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5CCC26B009D for ; Wed, 14 Feb 2024 01:59:50 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2BEF9A229A for ; Wed, 14 Feb 2024 06:59:50 +0000 (UTC) X-FDA: 81789509340.28.0E0AAF3 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf23.hostedemail.com (Postfix) with ESMTP id E7A2D14000A for ; Wed, 14 Feb 2024 06:59:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Qh9Rk2Fv; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf23.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707893988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ril9mg8Dj7XrN9wzpc8gCKAKYMby9fpQxW/AFGXm1Ek=; b=3LXsAen3zwjs76CtV3OX6dAjLv4LeT+FaLpHTXiB5DcP8ZeKdFOXooJTUupZ2NJmGuoT9d DbqQyG3mRY++OMd3w658Uq36LGBZUJysTb4pJo0U9VLsJwSn7pQoBNDOrY2AtD60+AmCh8 n7toQbkbP736c8rcQz1GSpgyZuvY+ho= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Qh9Rk2Fv; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf23.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707893988; a=rsa-sha256; cv=none; b=xIlGhilxGuCUSlwstEX6bYT9uA7CR9iTGskae/zxyPgIapsc19B3q4zbFU8aGx2CRqw5iH gFadvNBxg6zurtVIJUIWrVKSBiXV9Z+4W0b/yuWCpcRgVoxaOPtUYe5TxkW3bQ0LAtBm76 MOPy8doo5IQLgnN/dtqjeQ0M6DefN9U= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4EA6BCE1F63; Wed, 14 Feb 2024 06:59:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0546CC433C7; Wed, 14 Feb 2024 06:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1707893983; bh=CS45QcVTT2orYhyYWwHGZgci25zetj2poa2oQoA+Qkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qh9Rk2FvW4tWlAWdz0iYDcgsCcNhqHDodBRSm2Ahxxogpbd+1FwGwI+oPZPtk2YXt XcXI3kcrT2Gc0TKHUFNK3hQ0VqgTtmfEUjPtLuhjJbnNo+2z2YAQHtrghbVMCMzSeQ XyffkRKeIyHUohBlM/+8e3ex4T2LzDh/eVeZQjc8= Date: Wed, 14 Feb 2024 07:59:40 +0100 From: Greg Kroah-Hartman To: Mathieu Desnoyers Cc: Lukas Wunner , Dan Williams , Arnd Bergmann , Dave Chinner , linux-kernel@vger.kernel.org, Andrew Morton , Linus Torvalds , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Mikulas Patocka Subject: Re: [PATCH v5 5/8] virtio: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal Message-ID: <2024021418-diving-subduing-6e34@gregkh> References: <20240212163101.19614-1-mathieu.desnoyers@efficios.com> <20240212163101.19614-6-mathieu.desnoyers@efficios.com> <20240213062559.GA27364@wunner.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: E7A2D14000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 84s5x7cdkx44zch49zfk9z4ycg81jig7 X-HE-Tag: 1707893987-224258 X-HE-Meta: U2FsdGVkX195gT6SDDkdm2dv9WzyqPW9gsQtiQAzPVnKlA6F665eiARSoWUEkTvuGubEkMvktVjxBdDRZ7x9nlRkRneHQ7QrA6Xgw9kwdosdRg3YdbnURnuSP+V0LGR1bCRsFlhljY/AUu13ZP32TYIADVsluhca0ZnRb52q9csey7xWxgZg4BzuxBLSWm69mP+xzpHsmQlcMqjb1uDANL9TY21pieusX38GL8EiPUOnZDyqtTbpqV1vbiy5jJzqU2A8Z8ajMiaAp0T7psgcMD+nmD1/j6+wy3Xc4Oz+RVrB7x1gDKh5yewp98RHv8YYfnzAsPyIMtoPvihi9yehE6Km+JqlMkFNCFSG9LdogLPv+vuIQaplTbzWB8BHaFFzORMtD7Pn19sIExc3t9EhzvaB8EguQI6LSPEUiZA0WcA7iPG8a/lxi2ysPUgx+pfQ/xENX8dwMtbDyUcIqWWrWfAW4xxiSGXRj/UgpKY+QGXORT0Vw1UYU3dHU15E+7fubS1Jocm3DpFITpLVPBrYgbzRin+hoztLLzWJdhdKrxrvXjXHBEcnmNaDP9M2YaRRqukILumTJ601Pb2xgXMYfUSOlRdJW7WF7AZtp486XSF+vWQDSik8nqNLaHGL4BqvwYZOYpCi1l3FRFcn5UAI933gcRY3BIL+E44QAif0vgaylU2Nfo8AxA9In4znasmlaYn/3vYoBtyYfy3Xn7A7OMCu0DGerW2bWQVofYBnmlbPs/ZSoD6o79po/G8sPQsvsVyUEmpZ1xrHWqq2hiS0oXVbA9im18wnz4oCBSaN4vtSGgVoBb1Kh+jRaztgauWivD8u9a4xmxNGY0bX5pfnJ0huTZp1vsR/arFsUpvWHsn4/5Ivb9/GLhWlJImCl0+AaG2il4vEE+WNJFMXJ9bkjvhc/jMntqRuiEfsqnFJtcag4IMSPdMlhrKIanezzhrnKx7issLCORLGARLK8CV 29NridKR B0QOXb676iJQSfGaIqRb0t+yJxM7LZrnAWZzO7FkjYyjq/4tD3bbMef8VnPejfMo8m+xkiZa3nYxG96UUq8v+kOZkraNxpgKRH2YTNx2OBX4gokJjr0x7P+/BRAbbNHlFzUwWwwcQfQm8b7Wtq22zk9Gai8P727uCyhZs56ZCET352L7ZBq4t+4vbLj4wadutiRLbwz79DDl6JKYYWt6C9VF8icu0vP6j6s5aOsxCpKpbbl3y0+IQmIAxIPGV0ruUSBRKlPzezdKa5+GYUv/nevM8Z2WtUPA3e+vT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 02:46:05PM -0500, Mathieu Desnoyers wrote: > On 2024-02-13 01:25, Lukas Wunner wrote: > > On Mon, Feb 12, 2024 at 11:30:58AM -0500, Mathieu Desnoyers wrote: > > > In preparation for checking whether the architecture has data cache > > > aliasing within alloc_dax(), modify the error handling of virtio > > > virtio_fs_setup_dax() to treat alloc_dax() -EOPNOTSUPP failure as > > > non-fatal. > > > > > > Co-developed-by: Dan Williams > > > Signed-off-by: Dan Williams > > > Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") > > > > That's a v4.0 commit, yet this patch uses DEFINE_FREE() which is > > only available in v6.6 but not any earlier stable kernels. > > I asked this question to Greg KH before creating this patch, and his > answer was to implement my fix for master, and stable kernels would take > care of backporting all the required dependencies. That is correct. > Now if I look at latest 6.1, 5.15, 5.10, 5.4, 4.19 stable kernels, > none seem to have include/linux/cleanup.h today. But I suspect that > sooner or later relevant master branch fixes will require stable > kernels to backport cleanup.h, so why not do it now ? Yes, eventually we will need to backport cleanup.h to the older kernel trees, I know of many patches "in flight" that are using it, so it's not unique to this one at all, so this is fine to have. Remember, make changes for Linus's tree, don't go through any gyrations to make things special for stable releases, that's something to only consider later on, if you want to. stable kernels should have no affect on developers OTHER than a simple cc: stable tag on stuff that they know should be backported, unless they really want to do more than that, that's up to them. thanks, greg k-h