From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B863C48260 for ; Tue, 13 Feb 2024 21:30:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F51B8D0011; Tue, 13 Feb 2024 16:30:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A5528D000E; Tue, 13 Feb 2024 16:30:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAF328D0011; Tue, 13 Feb 2024 16:30:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DCBCB8D000E for ; Tue, 13 Feb 2024 16:30:48 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 894AD160939 for ; Tue, 13 Feb 2024 21:30:48 +0000 (UTC) X-FDA: 81788075376.12.E80E9FA Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf22.hostedemail.com (Postfix) with ESMTP id 0D525C0018 for ; Tue, 13 Feb 2024 21:30:45 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p7eXOBiu; spf=pass (imf22.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707859846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mq2fsD8RZfSz/RgwfKBfIxSIp5WwbkhHWrtrukG5rSw=; b=a3UpCF6uTkGhaAK1JY/BzXYSEVOEDd7JdPL0bHohUnNQV0lPMEzDN2AjTZDvoRDFNiwpKC JeoGcC1gC+nr474Jlb3ppbb3mfl7rQvfaFY2P/MAYo7qmA4T7jwmPCpUmIFOPigGnQYi0S Fn03xY4hElNhEK6h9KDn53cpBIXtBAU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707859846; a=rsa-sha256; cv=none; b=MIFLjeCM+ShANkoBXwUfIQamxaYxdo4cHXxEed9csUsScHm1J9g1c94Ayv0O8q80+VfqDX J+fCSZK6gPqT26za9ghyz3o6sQvxc+txEQCPPK0VLq0iY521QtRy1Vhw7126fSQMZfCuel Gksy5VR96V13uUvFQZLMaWVvD3zUSb8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p7eXOBiu; spf=pass (imf22.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id DED70CE1F26; Tue, 13 Feb 2024 21:30:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21C8BC433C7; Tue, 13 Feb 2024 21:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707859841; bh=9X9GQyhvkWNmvG1Gu8mRVXEfxB+77vFWQKzoIce99lQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p7eXOBiuggM/wGeuiUFMm3PU3dXQ+ZLqQrv6ZQn/m/9yK7QHfgK6lhTagkIPxZBq6 bRlmV8vbS3wCXcSFKQeQO3MoXu0uu9s8uLiC6eEf09qYaFBybPdo9ZbcDvGT1ISe7a Ccn/2uag8Bvt60GxJhqjkPaleE9NshSYrPdF2Qi1dpW8OEgUDl1LrI4iKpm1UcpaYa oH6UglTMhfeRit7IDGYuG3wOUILzp6RrBwrXP5AVKx1N+vSlmpDfJP1pzEYZVrNRxS o0/DeMbvaCpPKCmmsq4sIMfsj0FNOkzy42gmHMJKDaIgCmSkhU7naIYnEQ1IegB34t DdxVA7WqDOJYw== Date: Tue, 13 Feb 2024 13:30:40 -0800 From: "Darrick J. Wong" To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, willy@infradead.org, linux-mm@kvack.org, david@fromorbit.com Subject: Re: [RFC v2 10/14] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: <20240213213040.GX616564@frogsfrogsfrogs> References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-11-kernel@pankajraghav.com> <20240213163037.GR6184@frogsfrogsfrogs> <5kodxnrvjq5dsjgjfeps6wte774c2sl75bn3fg3hh46q3wkwk5@2tru4htvqmrq> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5kodxnrvjq5dsjgjfeps6wte774c2sl75bn3fg3hh46q3wkwk5@2tru4htvqmrq> X-Rspamd-Queue-Id: 0D525C0018 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: i6wxyxagofy883iftpsanb748yde3n3a X-HE-Tag: 1707859845-440651 X-HE-Meta: U2FsdGVkX19Ul9MIk/gLx0V2lu6mH3HJopSNQ/TD+KvaKsAHAnf6Lh3zpzDU2RhYLYdJqo6HWJWmie5UT82i2m7k0LVZ8hWer22/49KIk0jwrhNJMFMRZXJEcib9DSHS9mLBGpkBTxdrvGcZhnb95e+nCHnOsvRX/4tKK+7pfEyEOL0LwcbrLGF8AQJu1upTDEaOzCJgjLVG/+iWLzc6iypIzVtk8pPTmA+Bw2nSs7637YAMiP9uKCBBkeyCw1gCbSNWmXbudwNS7QVugcIMmT11mKr0EEuagPOMO7aisJwhrzRyNsGv3z4mBi87i9JoL573rtcN2ubAb5AQgM5BGALvF1Uitx0Xeut/ktrM9SqHodVAWcYTsoli6Q04LQt/tSABGZhUp/kaEiMKDZwxg4luLXl1MVdhvnn5X+22n2ZHt/jEExnCCLtZzuG35JB78uKVjGwFf8GsAzFhOdu/BpOshVmIM+EMBv8nFu9idMccmJwPFe26hCgB+QBj0EAvk1K0IqjYY1IpPX1fLp35ahIIBvngMXQBseZWRS/ShtOvHpwYoY2HuVqnBCAzEn0lwG+UgY60rmVyy4kYgKq5ZpIhoQ/+/Ea2NJ/Vq6fgHGKTF7iEALm6JpR0ZH0j5DnShzfTKXe05xEuDA35BIvgKjYpRmuret4aloeg2TFeO6Ob6V9kXhjRwR5lv7GusFGpCqT70eMY8QcfGBBayBbTeheLGU1Ehg8Hx10iZU2gWvltNl19Eb8L5RhytTi+Yr9C/pG6ACoYuxR9Tb6ebAYaOiQmABQ5Hy8uAdPkYNRYxDO+MqYw+G9x+cdZRBvLuuKgLGoR48H/i1S17v3MV1IkysX+WgTIgpus8eattsHIODcKcfQ9J5RRHY3AEtSDuGtiHNp/IW4NekKD2VnfSA8FhJziiTkYE3kJMoylM4UKo4Q004kOUdBH2gp81KE30uSGCdmpkqZsNIxmdNsnT+h S/Ve9V4v P12ZWaP0QnPub7Ei+NQxjliTTu3SfpeF9wSxdvBNc3TC9um1m5sAx7mFrZ7cGEHntP6vsCHgYUUr3w6hbW+uSqTJxwv4OibWqsU6/BA3MTCH+cO06Yi3cN4od93ieaErIBIkW33n7N1bnpHeIjt4KpyY35h8ORxagsE98bs7IMWqrG6bTzjq/cZg2rInvCnXKKM886AH6Gel52l56gXlaQ7VvPheXbsVvtwz8l5dSfpC/YJtDAnD0gza/1o/nZTnUBneNzBrLxhb7lFwW24twQvB3U9GnebxNVefBSz+G34klbRucNe28bROSjQkSWQ5Voire X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 10:27:32PM +0100, Pankaj Raghav (Samsung) wrote: > On Tue, Feb 13, 2024 at 08:30:37AM -0800, Darrick J. Wong wrote: > > On Tue, Feb 13, 2024 at 10:37:09AM +0100, Pankaj Raghav (Samsung) wrote: > > > From: Pankaj Raghav > > > > > > iomap_dio_zero() will pad a fs block with zeroes if the direct IO size > > > < fs block size. iomap_dio_zero() has an implicit assumption that fs block > > > size < page_size. This is true for most filesystems at the moment. > > > > > > If the block size > page size, this will send the contents of the page > > > next to zero page(as len > PAGE_SIZE) to the underlying block device, > > > causing FS corruption. > > > > > > iomap is a generic infrastructure and it should not make any assumptions > > > about the fs block size and the page size of the system. > > > > > > Signed-off-by: Pankaj Raghav > > > --- > > > fs/iomap/direct-io.c | 13 +++++++++++-- > > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > > > index bcd3f8cf5ea4..04f6c5548136 100644 > > > --- a/fs/iomap/direct-io.c > > > +++ b/fs/iomap/direct-io.c > > > @@ -239,14 +239,23 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, > > > struct page *page = ZERO_PAGE(0); > > > struct bio *bio; > > > > > > - bio = iomap_dio_alloc_bio(iter, dio, 1, REQ_OP_WRITE | REQ_SYNC | REQ_IDLE); > > > + WARN_ON_ONCE(len > (BIO_MAX_VECS * PAGE_SIZE)); > > > + > > > + bio = iomap_dio_alloc_bio(iter, dio, BIO_MAX_VECS, > > > + REQ_OP_WRITE | REQ_SYNC | REQ_IDLE); > > > fscrypt_set_bio_crypt_ctx(bio, inode, pos >> inode->i_blkbits, > > > GFP_KERNEL); > > > + > > > bio->bi_iter.bi_sector = iomap_sector(&iter->iomap, pos); > > > bio->bi_private = dio; > > > bio->bi_end_io = iomap_dio_bio_end_io; > > > > > > - __bio_add_page(bio, page, len, 0); > > > + while (len) { > > > + unsigned int io_len = min_t(unsigned int, len, PAGE_SIZE); > > > > What was the result of all that discussion about using the PMD-sized > > zero-folio the last time this patch was submitted? Did that prove to be > > unwieldly, or did it require enough extra surgery to become its own > > series? > > > > It proved a bit unwieldly to me at least as I did not know any straight > forward way to do it at the time. So I thought I will keep this approach > as it is, and add support for the PMD-sized zero folio for later > improvement. > > > (The code here looks good to me.) > > Thanks! In that case I'll throw it on the testing pile and let's ask brauner to merge this for 6.9 if nothing blows up. Reviewed-by: Darrick J. Wong --D > > > > --D > > > > > + > > > + __bio_add_page(bio, page, io_len, 0); > > > + len -= io_len; > > > + } > > > iomap_dio_submit_bio(iter, dio, bio, pos); > > > } > > > > > > -- > > > 2.43.0 > > > > > > >