From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B136CC4829A for ; Tue, 13 Feb 2024 19:51:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CD436B0092; Tue, 13 Feb 2024 14:51:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 256DC8D000E; Tue, 13 Feb 2024 14:51:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05B7F6B0095; Tue, 13 Feb 2024 14:51:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E48B26B0092 for ; Tue, 13 Feb 2024 14:51:47 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B2BAD140356 for ; Tue, 13 Feb 2024 19:51:47 +0000 (UTC) X-FDA: 81787825854.16.2373461 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf04.hostedemail.com (Postfix) with ESMTP id 4C6A940010 for ; Tue, 13 Feb 2024 19:51:44 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=WCv21YYi; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=oemmPk8a; spf=pass (imf04.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707853904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ktwy35BjXYTXV8Vk5AV4l5is0qqQjVjVt68lL5V+Noc=; b=pP/IpJVc6ZjkWzhVt9KSnAQd+5sxs0J+LVda0egWtEWOigmEmbuFoRuqf+vONFxpH5590C mVOez0HcdX0IUiS9D9WC0KIQLwQ8RXxBzXTNYUiF9uB8crwD3nHD2i939CtLTjfJkr0BX5 TAqn+/TRy9A35ZX04YmmD5eGnO+1JkY= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1707853904; a=rsa-sha256; cv=pass; b=7a9433kfYo9kFUGv8ESCvj99nhtQEmxCS8u+tu9OEHiOj756jRJ0HjXsF1TeK1B0LWj/jm o91gg41lg15ZcS3OXrsUrZjU7TImN0/nGpEvSw9Z2xU73eAHZIgEj99rZFgUDY7cblmNeq 69ervXGOxJIogH/Fu0QJRl59orzwAhs= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=WCv21YYi; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=oemmPk8a; spf=pass (imf04.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41DIj3IX018242; Tue, 13 Feb 2024 19:51:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2023-11-20; bh=Ktwy35BjXYTXV8Vk5AV4l5is0qqQjVjVt68lL5V+Noc=; b=WCv21YYiPlBqianVw0PBHWBBgNTT7FKC/d1FYmm8pZWxSM6JwJ4yrGB1bLe1VbZa3qm5 zRG+lUXr4LMvcAiLdYAS7FwZzblSjfeaqwgXknLnJoZRywwQITWC5Ep2Ub2zE6J1qGYK nTmUsuzRT7O89gegeiDWnN0VQMSME/Nvcdiutvl7AnvVBc+x/Zyh8oHRQHcVsNkC3fME c+HiOvIALkMRkJOh5h3S/JyjTtcVHzmI63OW/pA1wPLNexzOIOYGd/WN4rw1iITB613N gqyFrpRcgWZ54p0ZmggFGivb+7yIvzDkFk+fqyljfzgiF+kk8CgqCbnI9vHg8Pl6qoXQ Tg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3w8dyjg4nk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Feb 2024 19:51:30 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 41DJMluk015037; Tue, 13 Feb 2024 19:51:30 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3w5yk7v4j0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Feb 2024 19:51:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F4Thb6egZg5jr7sj17ksVoNTIl+j2CBzQI1XNyl+jEc0RiaQ9xLrgXffsIVZXIPRQLYdRiSdtmKzXaA3VVbW4MQxODkAlmEN2h3RF9b5/jbplVWuLUBO3AaMOB1qHU8mlvmLv496iRKiZLOshwp7jFkGf51LYukD3htJw7b9XT/2nURbVCwHe8JJOTd4XfrsuG8NklNRTAZvYCJVsmc08rUU/nlfq6Pi4dTN7bn2EwBnALPE7thSXEeP6ZFz5DUP7eCSRsQDNk+Tze6ndRKAYqPsIJ8/NwCPbxARvsLu59jteCSTk5aaLvH2+TcqJa/V51j3jbpuFS0LbigBNzhPSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ktwy35BjXYTXV8Vk5AV4l5is0qqQjVjVt68lL5V+Noc=; b=YINVfAI89vKASvMsWB36DJAAMG3VujqI6sN63R27evxEYjBovAiBF5uANU39CcejGNvuewB8upWOjH4Yf9d1FOfECuHAkOzSzVtBU5Ed/gzZxxUcr4MrwkDEEINGY06dqUVQQSnpnKEHbGHPBnxHzeW3jyfEZEP7JZv74EnnjYD23fQdWKlno0eC8v3CJwcNQW2coDXtpfjx6LNNFZsxCswqahwGKiLt467PLzdlzxVRI8ZuH1a2mEfe01G+p1Edr1ZQo6Ezix1ryBkZp1lppKN1VuvOnf4uAr/EmJulKSniDYvhTMcBUcKoXQ0piO2rwUTubz0jVl81AWCor2uH5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ktwy35BjXYTXV8Vk5AV4l5is0qqQjVjVt68lL5V+Noc=; b=oemmPk8aKI1ouzk6Y7rGc1SujhND3lRfIdBeFFT4/bGm8EE26gKu2QV71Srs0OI/zj7xp7cJF5eQtP7XmSAy0GWwmF9baXwhTASdjgVuRWZTCOuqCO5xWdJcHOp9SxcpzR9wh6QotErlVE98fjS2H9Sq7fivK/cI3XFF3EUZbP0= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by MN2PR10MB4319.namprd10.prod.outlook.com (2603:10b6:208:1d0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.39; Tue, 13 Feb 2024 19:51:27 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::20c8:7efa:f9a8:7606]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::20c8:7efa:f9a8:7606%4]) with mapi id 15.20.7270.033; Tue, 13 Feb 2024 19:51:27 +0000 Date: Tue, 13 Feb 2024 14:51:25 -0500 From: "Liam R. Howlett" To: Lokesh Gidra Cc: Suren Baghdasaryan , akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, selinux@vger.kernel.org, kernel-team@android.com, aarcange@redhat.com, peterx@redhat.com, david@redhat.com, axelrasmussen@google.com, bgeffon@google.com, willy@infradead.org, jannh@google.com, kaleshsingh@google.com, ngeoffray@google.com, timmurray@google.com, rppt@kernel.org Subject: Re: [PATCH v5 3/3] userfaultfd: use per-vma locks in userfaultfd operations Message-ID: <20240213195125.yhg5ti6qrchpela6@revolver> Mail-Followup-To: "Liam R. Howlett" , Lokesh Gidra , Suren Baghdasaryan , akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, selinux@vger.kernel.org, kernel-team@android.com, aarcange@redhat.com, peterx@redhat.com, david@redhat.com, axelrasmussen@google.com, bgeffon@google.com, willy@infradead.org, jannh@google.com, kaleshsingh@google.com, ngeoffray@google.com, timmurray@google.com, rppt@kernel.org References: <20240213170609.s3queephdyxzrz7j@revolver> <20240213184905.tp4i2ifbglfzlwi6@revolver> <20240213192744.5fqwrlqz5bbvqtf5@revolver> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20220429 X-ClientProxiedBy: YT4PR01CA0149.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:ac::15) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|MN2PR10MB4319:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a533691-06ac-4d26-387f-08dc2ccd2a98 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pAtzD0bVuRic4DRyhDxTZh4+aRTy+K5NLZeA6NvWSvnLreG08yDnzvRERSGQ64X1+WTGI2bfPpsDkouz0RXkCJZO2nERl3J/kDMg/tEVcav8ZpU5CdlPvr1mQJNrs1eTZEzRWP2cLYTMEsTugJDGl6qiJ3LDqGIdRlVH0fs9drUY6RkOHT+SpW1I0UoGaU5vzyQPKzxpD7Q8R72RVG6XbNahBBVKWaPpjKlAlAnQ0tAcANDxMtCROv5gO3ja0Xw86Pu9VXmBre7OeyEYvjFsyR58Obdofe6XZzkGbTo1+CvRY8hQSP/qlU3bb+ESMq0AiytZcYYSevgdFNcbdXi73+5tMovYeSP632T6K+Kf6LG7A85Mg8mOibrk1hLMwLAfMUF6uAOqQzmmoaBBuGUtScrFlQ9qv4fDyqOHd7OojVp8iz2qS6ddj+AvaC4cGJb3vfxGCuK5G+UjnfPiTeUYSoD2HBk9JLLNOa46otwzuoVyA8SDiUu6TBvqG9ku4c/yCe/ev3Gee4Myqg2Gb13+pDWostCC5zPQGWtQK4xQNBS5bi5Ps7zeT0rRVUx1DgMs X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(376002)(346002)(366004)(39860400002)(136003)(396003)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(5660300002)(7416002)(6916009)(66946007)(8676002)(8936002)(4326008)(2906002)(66476007)(66556008)(83380400001)(1076003)(316002)(26005)(86362001)(38100700002)(6512007)(41300700001)(478600001)(6506007)(6486002)(9686003)(33716001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z4Qwb4K+iIL4HobHmLSoonHhOBX0e3xlQbOnU6jikkxxq9PAwKP6HR5BXmBk?= =?us-ascii?Q?ivM8OYOUjP9uTdXG+8sgDvDRlljdvAlX1RLMUbjfFQSao0jPQHYxHwuky447?= =?us-ascii?Q?uqgm8K4alhPL2ayoFtGM9tnf/231hV5ojpbwLiZHgEbwDJA+10bjPfwfELDD?= =?us-ascii?Q?Wb8fJlH1EnggFuiQt4VjIzVozZGEOqaCberu2iq63gSzX6yCCzWbDd9vowjS?= =?us-ascii?Q?VqZ+DZeZvu+3S3armTDhZyJ7DcZqt5ysj0FjnxeB+TYt7rDm0s2SBNUrd8Kj?= =?us-ascii?Q?ohniq9QUl4JeP+wq8QsOTsYRVlPe5Q5/sPJZP/ZIA/Ay9In69y4Vtht2mhMU?= =?us-ascii?Q?KfOHHoC2+UulKs0UOfAf184k3USOtjzERYrMFWxrTh3z+JUN5FZrWIbafNXR?= =?us-ascii?Q?L5ld7PWSIxnGgKO5j2/MMOyy/wk0GzFDok2R9tTnr6KDI6+cDRfDA9muJdr8?= =?us-ascii?Q?XZvpwB13ufrZnFJ2LuVwqECML2SFHInDSN85FcrBor/r5VpGJaSKyB5rO6Ll?= =?us-ascii?Q?NZGC/AF03vzCMaH5Qq/6ZX5hGw39SMo0NSXVuhbShwgDHiXyafvr1eOmmm5V?= =?us-ascii?Q?FAjEF8apoI2s+/3sOx+2+vR5Fp/3yOO8YSR5wVKb2PxoBH3bbY7ZEkqegzV6?= =?us-ascii?Q?x4zO0iNoEIwjVjCYQH8ZM+FsNS3PdZCxZ8zPGOZdk6W3DsFngULyQ0U/MTX0?= =?us-ascii?Q?VMOZnP1vCDumqPV8HSQ7uzltjk9ksVGUVXv0rZPbl5818XewD9pzzgZtUCiz?= =?us-ascii?Q?aUELOrsrlWJKv1BsPIZQej73o2fF1oJ9cX9+OsHuHX08qTM+6tPMYNFLCPbq?= =?us-ascii?Q?PnqjgBim4L4pL2WFvXDX69mEIg2nksWC6oCKRVMrZSjhkmZOWk6mWe1C4TPD?= =?us-ascii?Q?hw1LVtSxHUCptzbvD0aViqqLcPq6dt1OGEFmCXDcyxF75jCd5kPATjTxAGBj?= =?us-ascii?Q?bvYfngN4eDZkvkYrmyAWF9ZeZHePWpUeqzpVEpJRROHedYdO+a3rmCPE6Fmx?= =?us-ascii?Q?CZrueeY/92o0AlGqPAUHWXOk34RPH5MKVwdlDhRoNdv/8x7TwtMzqEmzUoBc?= =?us-ascii?Q?0Vdk+WKC1fAAHxMOFyqAfPSm0cYPdmNKd1AIUON/G1nY4k1zABDHcHI9DdIP?= =?us-ascii?Q?lAS7Doz+8lGnsGuu5xSJTIfxzXW4R+deNgc3xaeU7VPWqQHwR7w8qhHcikmZ?= =?us-ascii?Q?mjAgPbJoxJifKm7HcCqbiMJ/26reynO3uuG+S5M1ObF/E8s4p/BK7ETsdc4o?= =?us-ascii?Q?9bUICQpEsZEPt+9J/r19xQJiDGC7UIxW4EAK9+plwMrmYqDPnQWf6b9ONX3p?= =?us-ascii?Q?x7mgYh0mrszdbjqaxrNaDqEIhJeVwKHymab12zAUjFRemBGppKBHAC9OnaM8?= =?us-ascii?Q?OziZVVUV7mDzrhwo3KB1T7IL+2PPJYlWsHKAOviW2olMgJGuuIevBOXlszCi?= =?us-ascii?Q?McOkx/gE+ZETSJ7EvKYQ6/Z8pBOUlRiQOAj6vwnfsUh2+Px8vqfDvtF8Ujo7?= =?us-ascii?Q?rZfb4GLZ2XWBi5pWxGFe4UbNrpYeShWUOivfA1e13WQdz65izLnhGH0iTe4F?= =?us-ascii?Q?3NwSYgFq+X34Vn1jJ8vo8YxP7PcLLCfRv6JM587wKy55A8M6ijeN9DvfHJPM?= =?us-ascii?Q?sw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 0GLB1mu/Yb3AqxhTp9E2bY17QRY2M+gJf67nUmgrqUOOb/FAetz92ozY6gb/cZJxUT8mVTQVgWBUYoo7UzWbjtZxSzwmxcc1umk/GhGJuAzS7ZcDj8ppaPw2Qz4OjVQiMWsz2F/2tdDq1JcEPEfEbnV1t0l63P/4i6RpW7T0JDYCxME53jQ7XunT/8oghzy4z2/aZd+KuEPdw8HTWy6jWXTUjulJ6InXm/2qzBT8lw7sZ0t5IhUcbtRcdK25VOCoEwProoj1WXKly98y/AZmFlMvVv8U3z5bmIpn4JkmJXIa3zVpV/Fx8idZsbH8SD9M8f3i205wJNLjKZ01H+Tn3v0JkJHX10kYl5mu7VwJWbUFgvgfuQ/5yRMm+F+dAHvkqTfkCzjDxMdGPio9Ivybp9zggHrk8q1lvZpLLE72oTS5Sn0zz2QPzVlS3S87nkYUJW8nyswXSarm+C0jjT1Why7w/yWWw8//C9IhZuiz7m0mDFT7eUOghTfOYC3z68/AnWu1n3s/NaK8W4wwvjbBJ0UlqmFbf0Vppi17NUo5E046YLYrrSWpCGpxuLSx//2NmSyi5cPgt0eqTKW8GolXY/odl0hvTMo1Hnn1pVbk5X4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a533691-06ac-4d26-387f-08dc2ccd2a98 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 19:51:27.5522 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3v+jECGxBOPmz2l5OzqH0y2O+//CxmIvAgNM42gsbhysH3G94BBdava0CRLfqUKCZl8woij2k45iE4kCeWzjkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4319 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-13_12,2024-02-12_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 mlxlogscore=623 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402130157 X-Proofpoint-ORIG-GUID: 0nCoDfDfgcAiikicCJLZ7GJbTc8VPNsk X-Proofpoint-GUID: 0nCoDfDfgcAiikicCJLZ7GJbTc8VPNsk X-Rspamd-Queue-Id: 4C6A940010 X-Rspam-User: X-Stat-Signature: gtcgg4jrrhcfuci1f5zu6357dxa8t3qw X-Rspamd-Server: rspam03 X-HE-Tag: 1707853904-427496 X-HE-Meta: U2FsdGVkX19DxocjcpV58mtKsOnhwbphjkdWembFSHnfQZnVPDA+HkEBs+Cuinm+kTRffX0ETffetJCoAww+4em8FeUyA9d/pRi8sJQy2+D0epel3UzYofuTw3Iado1d3VjK4uGLB4i2nhvcuL3ctDKxBQWHnpwRxBBmfihzy2nH8i77pTolVNzaP3RflTxkndrecIfKktRnv5Ywh6oXHA4+O4OfGbdS5eePIktaEnKHYJTLJO7AWeV10rcNELljxMxsCT76fDkPFrTPoSCFfPrSOoyO4iO8PuI7aCEYqXZT3fiAxROFp9CjMXKrZCsXO4fa0HzmBQyhHBjtWFNeJYvgU27ei118Nja1azs0FS+Vb0aB7PkMbseIGr6Z49/iZKZN8+hnrbj8SETIWP9DgNLmU1NgbQdSo3upml/jwSfLHbx1kQ+qtvAKWj5HDb+U/BD9kbI84HWZuygOYSOLaXLdbYu39d1Rb1akjxq8qB2XKk4UblQI+wcIzKKXBqmo3YOc/LLYVr8gmBbDhQ9jKy1QeQdk436WP17GUH/wz6m7SNxLCCSDhfQaMXawF6VU7hhCugkC4f050CE270VD3EyLz4qLDvmyUsnbImWzLRppuoroeRvTtIE2KfNJJTwfLibjz7p+RUpdPZRhTBHZl4WsyDzXD3CVxMngdhLdYUGkZNqc0o/w3xmOZuFakp9j/QgvRjYbe3jp+RO+MWfKHmjo2S9/ZQgsToiHY0M75OpCnTS0obNqK33JKSdeRD9yW4SUCok7uJu4y4jmJjwCbyW5TKb4tXwScrBI9gfbNI7Mk/FCIeedTSK2hB5wmVe3t7+3vsoZf41GwfdM5syj6Z3/VT416CIRVPHL7YJtwRjeoXOdEy8JV09c/x9vrkoBjijZDbF6ePrFGfyNb5Qe+GhcSUhbM6gETubaxSX4J1ZjfOnau6St4GZEd5WRE/EjHatLZ1cU0+rZwhYwcTi fescu+9p 33v1cLgWED+bpKnyZNtxduNyd1y7gmdsYnHNgzpD2FFNbib6Y9lrlc0ja7wYQSFtsuLdkaw0+gqA5YRrAkYRPg5TefvAHBlUnlG3ZQG8r0lztRRyDvl/XYEpLo8+s+gdk/3F6kGtOR0ImSmK5ZDNw8CWQbh/3AI+L6FWIc/fmq9laF9DhS+H1eQLsclwX+RHCs7wdx9sgWGHHNl1T6v5fbIVebEPHDiK03Yw8NYGrQHijHfIJjibjEmmw5gXHuaoGN1tA2gEvozq2+lFtIcRIC7mpl/HNt6qusAHysio/zkJ09+KtK6qaflRNx5J3ZbLziMp0ZZqGqTXcpljg4dN3MmCu211FJzUkT6N6k+bHfkBkj5eP18ALH5h1gjugaNgpArDLlfH4fmfGWXGMPHMQ6Iiy3j0IlHbA+oy1q8ZtI6m1/NdNiY0abXRPr1EWLcZ5irTPAHoDSSGr+Yg0Qrw2IUrn8IngDx99TfrJuIPm7QhmrBWeAsPRvQz8v8xoOOMASlEwG57JxafmjK0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Lokesh Gidra [240213 14:37]: ... > Asking to avoid any more iterations: these functions should call the > currently defined ones or should replace them. For instance, should I > do the following: > > #ifdef CONFIG_PER_VMA_LOCK > ... uffd_mfill_lock() > { > return find_and_lock_dst_vma(...); > } > #else > ...uffd_mfill_lock() > { > return lock_mm_and_find_dst_vma(...); > } > #endif > > or have the function replace > find_and_lock_dst_vma()/lock_mm_and_find_dst_vma() ? Since the two have the same prototype, then you can replace the function names directly. The other side should take the vma and use vma->vm_mm to get the mm to unlock the mmap_lock in the !CONFIG_PER_VMA_LOCK. That way those prototypes also match and can use the same names directly. move_pages() requires unlocking two VMAs or one, so pass both VMAs through and do the check in there. This, unfortunately means that one of the VMAs will not be used in the !CONFIG_PER_VMA_LOCK case. You could add an assert to ensure src_vma is locked prior to using dst_vma to unlock the mmap_lock(), to avoid potential bot emails. Thanks, Liam