From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7D4BC48260 for ; Tue, 13 Feb 2024 16:47:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 817D98D000F; Tue, 13 Feb 2024 11:47:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 79F558D000E; Tue, 13 Feb 2024 11:47:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6191A8D000F; Tue, 13 Feb 2024 11:47:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4936E8D000E for ; Tue, 13 Feb 2024 11:47:06 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1AC1840CE3 for ; Tue, 13 Feb 2024 16:47:06 +0000 (UTC) X-FDA: 81787360452.18.4E71DF0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 6B5ED20019 for ; Tue, 13 Feb 2024 16:47:04 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YoO0smDc; spf=pass (imf03.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707842824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LivZts/zKuIxUT9ozwhe2M//x0CxjLbMets0sVsLKuA=; b=lOxXHlYlirW9JrhgEyxdMLw9vfooznQL48/6FDocrf984GsO878pbaV2e77WvrhuXUuDil SYwitOXPDIONzQEZWxhheWtFEZTek3msIusYuDrw7KgHEwUBtKWPV/LHHxsFl3SPK5+0Gp xlK273NX45PuFiJP/qbbAxaVWGIVDcU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707842824; a=rsa-sha256; cv=none; b=QctpqxzX/Y296CS3KH+CC9rtP98cJY5mO3r9ZS0r8JcB5Q9TGcdsoHlPr5i3xYM6gcdJGr /MKCKfnNVrerV+ltdZHitu40AtF0TxZ67ONbfClr1f/SBul4j51GRm0txxD+unaZVmw47W QCVIhUAHmh3KXoLEv216JXtUabV8Vbo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YoO0smDc; spf=pass (imf03.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8B19D615AB; Tue, 13 Feb 2024 16:47:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55C6CC433C7; Tue, 13 Feb 2024 16:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707842823; bh=fZLzxiWiWqQTQTGcyFG3odxLRJgONwBOdACD0HVg7b0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YoO0smDcFbjVUaJydJooe2n0xA7HNBbrfT5nr/hwB/CJvoDIvNHE61hXMB+j9pp9C AKFIWh5LT4H+FMMDdkbTgyqfmnmERNCSL+SJ8bJNbbACtV9YZiIKGtBvGnmppMqRl0 0hLJDQkPLYiGU/nGrBADDZk+X0nbto40y8dplPN/7dWAiCNIcCzsTMb8acukJHx9QT IKpg1aBUkYXfOxDY7iH0Izo4xIp5JAL+PVnzRm/6dzBfGhRj86GCgyPabu4qu25ZcJ 1qZjj8wbBv/ZUbcwvd1yFwdkVWkbg0yC14O7+AmmAO4JCVwpZBWPbb6uZ4b+C2hUtA eHRaar1QTSF6g== Date: Tue, 13 Feb 2024 08:47:02 -0800 From: "Darrick J. Wong" To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, willy@infradead.org, linux-mm@kvack.org, david@fromorbit.com Subject: Re: [RFC v2 06/14] readahead: rework loop in page_cache_ra_unbounded() Message-ID: <20240213164702.GX6184@frogsfrogsfrogs> References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-7-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240213093713.1753368-7-kernel@pankajraghav.com> X-Rspamd-Queue-Id: 6B5ED20019 X-Rspam-User: X-Stat-Signature: 9ki5rnzhfquexmq3degixyjonj73z57z X-Rspamd-Server: rspam03 X-HE-Tag: 1707842824-270609 X-HE-Meta: U2FsdGVkX19Izkj/h/QOi542BZhUzOe9kvQGWnAATr6adyqxMo7WEtvrpHlfzeI7vPc0SbE9eJZuw/Czj00u7aAU0cxDKtCtyoCBBt4Tq5OlBVfUn/FnW160ofgc9X9k+b3lFLThhJuxyc/OiGuIxbhgEz7U90rCAW6vEpuB0rhG2tpq3+M54QyB5OnFbIaI0r6BA8FCxntNxAayW40yI9L5+jfWVJJS7KtCYc168dCMhDxLCqbfVueHYXByWMckFYnHbCRqcBOOL/Dit/anWSmejM+nGJrvW6MBWL+p5iAvuKc10UaO+/d2eNcEDm2tf+PKJfkzHnneRYjbj9r/xRaOzAFCQivErOssYJPRKpe59eq/QgNqGGFW1L39NOPTE4eOgmgKz7PDDzptT5e+0j/N05A0fWWly8hK4yeEy5mNlBlZvV9T6J38CpauIhE+wdvRxfQ8cXK9eiTTjlxD0gn6MQwQ/uBlXz1KUslyQtCHskBhWz36gBckeSop4XHyBtX8YAbW5dGwfj1WK0r3tjbou++OpgOTOM43zQXcfAGaiYBG+KYXWHZmzkDVAofoFjtOAVhLsJIJs69pYbhsfpMt2shh7OikKr9+fy7fOJs8O9eVYgKnhgUnZEPILXkvZuX+Vh3FcyGd9qTVx9rcBl08qMVkCXYjlUsuAB6u0ASux2pQvTV0iSvbcoPN6UxtJnnR+T38p7rRccKirRr5a6gQtN7uSesntk7VYXy5vnjBHjyTv7JnPXj30DLwqqVVwT5x1q+X8YygzxFsz3q6N3CdphgfPCmrppRlar4iE1zp2FjaFf07cFWEzZFQ19ETce8WXAIKUKYIcEKfEY6rcFEI3hETfvql53P8Tb8V0jkys6kGe91NPi7jlkoYUFVla7RTOk8zrqrdDyV54O6VuEac9ER2muL3ofN3ptPqlqYfGqtS6xYPmvUcO+3NNNoVelYegbqD1a7345AAgdX f2170+WB Ewbt7WbBe31abViCKbzPA6B/5afdTIU0kKmRiqeXA7KWC7S3b9Y6ILUYLdqT7RaA3ZgSVrK1ycnTVt0mPu7FV69awJO+fV/xEnOl9G+GJX9thoDcUwAKwtUYlktSb9eb13YfO4Bbe1XejAnmh6JOtiAIxwdTrERfzBk6OwlqGoVsAt4I/paU7zHT3GU2iG5sdbac8V3tHm/UjeivXh2/yJtq+4yaDYutDnRmi2GmA66qLxEGchTPruSLJc+fPj1190mCH2lrtkFtL25kIquiuXHyqg0AyOInDSqpc3KfJnoUiJyrxYQjKXxwDdbqe0soV7GL/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 10:37:05AM +0100, Pankaj Raghav (Samsung) wrote: > From: Hannes Reinecke > > Rework the loop in page_cache_ra_unbounded() to advance with > the number of pages in a folio instead of just one page at a time. > > Signed-off-by: Hannes Reinecke > Co-developed-by: Pankaj Raghav > Signed-off-by: Pankaj Raghav Acked-by: Darrick J. Wong --D > --- > mm/readahead.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/mm/readahead.c b/mm/readahead.c > index 5e1ec7705c78..13b62cbd3b79 100644 > --- a/mm/readahead.c > +++ b/mm/readahead.c > @@ -213,7 +213,7 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, > struct address_space *mapping = ractl->mapping; > unsigned long index = readahead_index(ractl); > gfp_t gfp_mask = readahead_gfp_mask(mapping); > - unsigned long i; > + unsigned long i = 0; > > /* > * Partway through the readahead operation, we will have added > @@ -231,7 +231,7 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, > /* > * Preallocate as many pages as we will need. > */ > - for (i = 0; i < nr_to_read; i++) { > + while (i < nr_to_read) { > struct folio *folio = xa_load(&mapping->i_pages, index + i); > > if (folio && !xa_is_value(folio)) { > @@ -244,8 +244,8 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, > * not worth getting one just for that. > */ > read_pages(ractl); > - ractl->_index++; > - i = ractl->_index + ractl->_nr_pages - index - 1; > + ractl->_index += folio_nr_pages(folio); > + i = ractl->_index + ractl->_nr_pages - index; > continue; > } > > @@ -257,13 +257,14 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, > folio_put(folio); > read_pages(ractl); > ractl->_index++; > - i = ractl->_index + ractl->_nr_pages - index - 1; > + i = ractl->_index + ractl->_nr_pages - index; > continue; > } > if (i == nr_to_read - lookahead_size) > folio_set_readahead(folio); > ractl->_workingset |= folio_test_workingset(folio); > - ractl->_nr_pages++; > + ractl->_nr_pages += folio_nr_pages(folio); > + i += folio_nr_pages(folio); > } > > /* > -- > 2.43.0 > >