From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07B90C48260 for ; Tue, 13 Feb 2024 16:46:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5318C6B0087; Tue, 13 Feb 2024 11:46:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B8386B009E; Tue, 13 Feb 2024 11:46:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 332E06B009F; Tue, 13 Feb 2024 11:46:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1AEEB6B0087 for ; Tue, 13 Feb 2024 11:46:41 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E3E8AA084E for ; Tue, 13 Feb 2024 16:46:40 +0000 (UTC) X-FDA: 81787359360.19.A612FD9 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf27.hostedemail.com (Postfix) with ESMTP id B33EE40026 for ; Tue, 13 Feb 2024 16:46:38 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kqdU2nsu; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707842799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3v033BWqEbztl+zzhz2ANi4j7ktPBdMIsuQzCXA6Y+Y=; b=IbzImHRvUZpah4AHvmJbKGRJsob77XqiriOY4UEkmNjBQ914EcaZ94aZCIqZnpmVFmRivY AR33x/W9mbJ0bRtfgyR9K1wy0Vyk3FTzaacqs2BeSpB9OopAig5sKJn2Z8A6NqKs9wuw8l AEfADnOczgyyDTA1yEBYxqRjkINpQnc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kqdU2nsu; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707842799; a=rsa-sha256; cv=none; b=nTJU5rRpkxvWxjS5iIU/poUqIA3yMzz7d673s+Unnqc2J/4PZf6cHfqV5H5WO20LsnUkqI /v6oTQlbJkOVVQDO+qCbq7l3ZnsoBuRLVDWVIiVGHXqdxhMaEcbJK0JQD3bKSv5UhD4MPe bn+xuwck0H1G+ycV8rSQ/4eHQTQmUOc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 545A0CE1D11; Tue, 13 Feb 2024 16:46:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E891AC43399; Tue, 13 Feb 2024 16:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707842795; bh=tbs1Z8Amiwm27iNPaiqfjyYdo8SY3K2w682a+PlnzMg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kqdU2nsuvjv3jLoYMdzGZFfmMFcTuZrLsbrxNizJjJL86utpl1zF/XWGBUEnKN9PS 90ZQlOXSfZC6yMXzKIJ5CEBf8R6SYiBiXWPP9paDfXDJujmy9FnrpTcsmCwCZXCH3/ sT67w/2LuTb5oNxloyW1b+AVBZNganeWlUs4H5NOBWRfhsYUWi4rgCqF8o1Ym3fSZH OLpalrT4dHJl5naSP2I2C6dvz12kH3/BxgBT5r/AjSzX6buLRZx5FFJvgrkmxqucHR Dz5JOkG/vJ0LUJGPHaV3jp3wz7j1xUAEzHsbUtcAAkgp5V2o4aMrMhd+Sp72QrJoXm t7QiR9zj0ZYpQ== Date: Tue, 13 Feb 2024 08:46:34 -0800 From: "Darrick J. Wong" To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, willy@infradead.org, linux-mm@kvack.org, david@fromorbit.com Subject: Re: [RFC v2 04/14] readahead: set file_ra_state->ra_pages to be at least mapping_min_order Message-ID: <20240213164634.GV6184@frogsfrogsfrogs> References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-5-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240213093713.1753368-5-kernel@pankajraghav.com> X-Rspamd-Queue-Id: B33EE40026 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: pr1kgp3p5h9kw4j8tus9et6uooq8px4z X-HE-Tag: 1707842798-847593 X-HE-Meta: U2FsdGVkX1/x2tuF2d2BlDOCPMOQ2Mk4b/MlK8gHeXFL0sb2cZD2Xy3xk/wpnr7fpoiOBhSePysFoaoNZy6J87pJ4xIRNiPBFshtKeBgrj/Tjnl9lItFvupGkYmXK2gpugWxX/gokoYx5tRpxJHal06Sg4de1u6ntSFtqJ/trgNWHKbSJDLl0zMHumDsLxAquD8gYyO6K5R4rLcqV/MgMBhwuYG6gX2ZzDIzcbdlW0TNVyNF2NR6Fl7Wd/PNYg93CUth99GpIR0NCgGN0tui2iQLHeY5KVvHC5hFj3JYtfqJWuMdhE5YaxsWMOiuhFqr/Cbjlb44bA2fBvRHJQF6zj76LlLG2LhGv7PXO1L1JfBPQImNbvs7za0yWJX3Evp3dwQKY1Z4i+Sx69RC+TAsSoFadoRBg8BaCMgS0dldkXDRmFawdv590MX62tMAdi3Fvvsl8uhAVgt7yGQ+G/+DQOlMW66PyA6BpjOUn7inaInSXwNHyEKqLDIKyWahk19nKEA9hPlD21a1oI8A8jebIJHbjHs1cXVdb5kK1boInkvAvsPtsNq98beZSgl6lPhljd4La/ECdBNiU7dAeAjlcyOqYepfVz5sraYdGLJqjqG51jp6M7NuijYDeu45TTky05M5IIl0MYA/Vuo//3ovU08p3L12unTlwLV70z8omMRJHC4UUKQsy9gjV10kq7dfewrOmZtObaz/Jv9ij28XKaVwRqx37KVWTma9/Urkw8Z4xNad15wRBwXtyqrSLUtby0jwa/2E9UXMXEtTGzFW/9HVcLdlAmRjS9tt0hrKJeM5scuMhFKVq9JCS5LWpScyUhYSDRZWLYgj5HiSDenL2+RsMEiArKeoaIRW0zBFkSAHYCBlI0cdLbyHo34VDOqO8Ed7q16FUbVotQxFj9EoVrfCn52wWNSGjRcAmgmHcWXpyTjHlB/fmxcEXK5B6VMPVjxbSZEjVHylT2Z5d6K RdiqdX/W t9I7keS6W77pQsHWEUIKbZHvfZDpdElnd/kKHpsjahzfdRPUqh7RG5J7eq1MqEwDCK+bBtigJxg+HFQ/k3Vq1P3ZfVOJMB+IThg9yp5vaf0cxVIkBHdbyYO+gxS1WDtnw7fjjf/1m+pWmzyEt1mCeU4fhnDorXKQ0qJ8Q2giYzf9nKAD5lLbpsIVaS7AwAGo9ThYE8hAxlq/LNKijcHt+nfiAULRQ6Ooj71JVIwxI1QZaXojkokDzB9UPj5zO5TTSo/DP3vLy4OFaENQzv0i/v0v5kIlveQ9+L+WX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 10:37:03AM +0100, Pankaj Raghav (Samsung) wrote: > From: Luis Chamberlain > > Set the file_ra_state->ra_pages in file_ra_state_init() to be at least > mapping_min_order of pages if the bdi->ra_pages is less than that. > > Signed-off-by: Luis Chamberlain Looks good to me, Acked-by: Darrick J. Wong --D > --- > mm/readahead.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/readahead.c b/mm/readahead.c > index 2648ec4f0494..4fa7d0e65706 100644 > --- a/mm/readahead.c > +++ b/mm/readahead.c > @@ -138,7 +138,12 @@ > void > file_ra_state_init(struct file_ra_state *ra, struct address_space *mapping) > { > + unsigned int min_nrpages = mapping_min_folio_nrpages(mapping); > + unsigned int max_pages = inode_to_bdi(mapping->host)->io_pages; > + > ra->ra_pages = inode_to_bdi(mapping->host)->ra_pages; > + if (ra->ra_pages < min_nrpages && min_nrpages < max_pages) > + ra->ra_pages = min_nrpages; > ra->prev_pos = -1; > } > EXPORT_SYMBOL_GPL(file_ra_state_init); > -- > 2.43.0 > >