From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95B36C48260 for ; Tue, 13 Feb 2024 16:39:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 353506B009B; Tue, 13 Feb 2024 11:39:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 303116B009E; Tue, 13 Feb 2024 11:39:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A39B6B009D; Tue, 13 Feb 2024 11:39:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0AB706B009B for ; Tue, 13 Feb 2024 11:39:35 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C774280CA3 for ; Tue, 13 Feb 2024 16:39:34 +0000 (UTC) X-FDA: 81787341468.30.A1BE36C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 279E712000F for ; Tue, 13 Feb 2024 16:39:32 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=O9m5GsXK; spf=pass (imf29.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707842373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AczOKhjp7Bf4/UyD/LXtlyhkryYkJXo+ZrLQ7uU8DiU=; b=7RBNOv+bHTOzyz1PkTpdsl7oXKar7Ix/zgab5JiwzgA9RMGArA6/ph8dfDTT1dfbzVLO61 WzI0n8Eth8IVwQiwRaPQW41Adyb3vfY6CsTUnoUxJ9PRe04c4SrDGdErCmo46GlFiJIFaE Q3Ezsn3sl2B2lCpgYMNGvjPNShTGmJw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707842373; a=rsa-sha256; cv=none; b=2u/XkIOoMf0gNahMB4N8L32xi1IgsT1hk7cQTcu7GgOkNcEWeMXlbnggQTD6wn059ptLln LOdVJnw7sUaMFhJxZf6crLrk4Sq7eXuHCU4lqeosreezzmUAZKzRnU6ftZA8KPZKOz6NIm M8Qfb+AUMBeEUyl2CqupqK4AtUJpozk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=O9m5GsXK; spf=pass (imf29.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 55D92615BA; Tue, 13 Feb 2024 16:39:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C27FC32784; Tue, 13 Feb 2024 16:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707842371; bh=Fnf4xgH/e0W3UjNn3m69LYnKo5H+30NDIZsoXhuJPb0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O9m5GsXKbg9AI33fOqw69S5E2XdAleUnehXkybhM8JeSjXJaY+MMNYwiXbjJDsoQ/ G4Khoc5Kl0Ag58jKPk2up1CsZhP0muf2C1EnFEKcC47+PbJi4arFT65hLIruWd/yAP dVei+hZ2iSBa0bKXjcm3HJD80IDiVA9Yg7w97HbwvBYKryADJUhyKYQKore2pbeJmi Iw1lEcoX9nyYZYKG8RIu9iDVi6wP+OTVObhRGQTLdfFIWR2iaiuUqi7Sg06u0b7Xi/ 4TtE9+M7WqhijaSF5o3u0Jw5P/hDetkVydUybJN0dSST6AdJQm0r9QFY2YX5iXW7TO wlMe/UKFqinIg== Date: Tue, 13 Feb 2024 08:39:30 -0800 From: "Darrick J. Wong" To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, willy@infradead.org, linux-mm@kvack.org, david@fromorbit.com Subject: Re: [RFC v2 13/14] xfs: add an experimental CONFIG_XFS_LBS option Message-ID: <20240213163930.GU6184@frogsfrogsfrogs> References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-14-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240213093713.1753368-14-kernel@pankajraghav.com> X-Rspamd-Queue-Id: 279E712000F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: tkmcu361wkeebhfu5njghzgjgegxrb8t X-HE-Tag: 1707842372-709298 X-HE-Meta: U2FsdGVkX1/dP0ng5MLE7BN8BPWTfCgBPxzX15Nq8SpR6kZTthPVbQtVAO9C4ORlPTwd/186SN168GpS61luDRvPsfxqBMpalb310Q4qlWk4cy977R9NVdHV9e7h6iOza+VkNlFI2UBaXhlMIdBkY8/gVLTU1XM/hhWYPou9UxFE/acIvcKT1efzjFaJ7rgWBQa+YAZDF2BMpu9/WXW49YfkNnJ81/zjLmqwl3TJw6AKg2CXkrll5T1seewfbjUKF09gqbsUK3DWU/4LIWPgOgLb4YdpNVRIMHb7CCfZMz4B9KLkDFjd16i/doVZ4KYvUvXuhbvH5OyT0S/qkT5O0kT6+X9wuKX9nyRrMFEhKDBV7fh8Epd5XtVuuSIlUhGlnTxfTixO6vF5HO6n2/cglpMQmlaa4qAYa9b9I8ZDFh52uqnzSXsbewZo576sLp71F/89NRZp1a1/MR9cvA/fHbtOHVRj2ypXM/9aBjGg5WEerXzxCbGdgZ2+4n/pJfy/9ugzaVPm7csO8oFqwivRuFeNACnor9Z33JFpylAYW+xG/8zpQqWjH09FUYrp7kXOcrDy5YIAcUFaITN/WmL6lM2yLhCv12Nhdm0YFdPPeG3MFiXEwp4XUVPuy1pHtPPS9TRy22oCdiYn1mQ8aPQHuntrjISfwRo+rx59zIKC2q0jP8sFPq/Mg38F5wXo+Wz3Eq+Zi6jdNbeZEJvUeRoF287lsqw1pd1/hjtPMloKGxeOcBiMNKCGpXMhMVVDWzbtnBvtEehB59SXZxt8tVfZfIiyEpa0W4zHbW8YyuTNvc4IaK4RLePYA4nvkEMr9HjoCDl4TlU+T06TNJvLV6N/rd5nhFdpC5+CWAR+isn87ouACBGX7bUE2tHxrx3Bcau6Gb8KcT7NMQ8iCjP4Hq9knGJKSQFp13by+Nqtle0a5UpHZija6lSOk2T5WHsw0fyafZkL36hiriuWAuTjpM8 2BUDdlNv LwyyYo2to/iYo2JJCUJPGFrbH2teU5ZWC3grw5qC/4hp0Y6qzSWLFpN+NQV/4BK4xjYnZptO02nN/ORchHskjO1vA1htm5XslEStRy2y57rEJk8jhhBm3zshEJ65zPSxAvsTo6/wcp5jlPFzma/j4JpIJE9mzmu/WJoQVHf0j1aqIHWpCru47D6Tzw8QUpDoji+tz4F5EooUQnysvqVCG+UphyOa8GgA9cVM76MTDw5hXqpUbUkgcWFi3jRTXDfzfP/GsSwu6pdm6tm/MexSx50H8pF/ZWwTf9/iXPuytHX5C5yfJGTEUnjkzou54jmhQUfdD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 10:37:12AM +0100, Pankaj Raghav (Samsung) wrote: > From: Pankaj Raghav > > Add an experimental CONFIG_XFS_LBS option to enable LBS support in XFS. > Retain the ASSERT for PAGE_SHIFT if CONFIG_XFS_LBS is not enabled. > > Signed-off-by: Pankaj Raghav With the changes I suggested in the next patch, Reviewed-by: Darrick J. Wong (I think you ought to combine this patch and the next patch after improving the EXPERIMENTAL log messaging.) --D > --- > fs/xfs/Kconfig | 11 +++++++++++ > fs/xfs/xfs_mount.c | 4 +++- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig > index 567fb37274d3..6b0db2f7dc13 100644 > --- a/fs/xfs/Kconfig > +++ b/fs/xfs/Kconfig > @@ -216,3 +216,14 @@ config XFS_ASSERT_FATAL > result in warnings. > > This behavior can be modified at runtime via sysfs. > + > +config XFS_LBS > + bool "XFS large block size support (EXPERIMENTAL)" > + depends on XFS_FS > + help > + Set Y to enable support for filesystem block size > system's > + base page size. > + > + This feature is considered EXPERIMENTAL. Use with caution! > + > + If unsure, say N. > diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c > index bfbaaecaf668..596aa2cdefbc 100644 > --- a/fs/xfs/xfs_mount.c > +++ b/fs/xfs/xfs_mount.c > @@ -131,11 +131,13 @@ xfs_sb_validate_fsb_count( > xfs_sb_t *sbp, > uint64_t nblocks) > { > - ASSERT(PAGE_SHIFT >= sbp->sb_blocklog); > ASSERT(sbp->sb_blocklog >= BBSHIFT); > unsigned long mapping_count; > uint64_t bytes = nblocks << sbp->sb_blocklog; > > + if (!IS_ENABLED(CONFIG_XFS_LBS)) > + ASSERT(PAGE_SHIFT >= sbp->sb_blocklog); > + > mapping_count = bytes >> PAGE_SHIFT; > > /* Limited by ULONG_MAX of page cache index */ > -- > 2.43.0 > >