From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26E17C48260 for ; Tue, 13 Feb 2024 16:27:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0DE18D0013; Tue, 13 Feb 2024 11:27:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE4988D000E; Tue, 13 Feb 2024 11:27:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AC9A8D0013; Tue, 13 Feb 2024 11:27:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 87F828D000E for ; Tue, 13 Feb 2024 11:27:12 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5A3B9C0C53 for ; Tue, 13 Feb 2024 16:27:12 +0000 (UTC) X-FDA: 81787310304.30.B1E66AA Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf18.hostedemail.com (Postfix) with ESMTP id 7008D1C0026 for ; Tue, 13 Feb 2024 16:27:09 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FiG74dt6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707841629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/aXFZ0WlW5rkTBp079uvAgyM1gToqyjS4D+LDQZbtU0=; b=hQ3zosfp4N65bWdmUQbbtvCwgcQG5MkdRyyn9Hs4QPAfWSSBueGCLcKlizuhkerggrlXz2 AwB4oGl2AzT5FS0O96X6DMdD6jIJKbaJvinoNMxZYvbuL7O4IObKjHdzueTbXqxPSRKC5+ zdiDh4pukOlFmUZx30BYtfJkxRVE60k= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FiG74dt6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707841629; a=rsa-sha256; cv=none; b=CSBhTckk0Z3Zq8YYMyEk2BlWpTClJgVYIKK7/PPEsYFOEJHLQDF+HUKOMgNrlkb1Por/MO 7yyFwQ6b+noF3Kk3HSQqLbWR/wtphFuJClZ3eUF/GSm1570Z3e/ZWbC7Ab5p9gaX0aJr6F nBcVCqEcXPJ03M4nhXtz9+YRQdF2zm0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C5916CE1A2F; Tue, 13 Feb 2024 16:27:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08BB6C433F1; Tue, 13 Feb 2024 16:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707841625; bh=I4j0ct2ZX+hSPlx2NUqgKxHFmaIO2IKKpDrBU5uH/1g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FiG74dt60bJgg/aftLkydqOKtA4Hv58E9b1DOO9oSnq5kCkUx/WmmqIhjmCLGc/jY /mibd0lq2JXVJql4GDprEpgl8UkiAh8cvZKlaUXiAHuBEdY4QwAZ6/ms76Sty9OMil OKR18SChm/vN4taJNcZ+GaeMF3ABHyaOeAYq5EeAwxpancgtVsvfjk/25tGrH7o/5n hPLkqUMy8QpowQw1tjeOWHB2g0roL76ibATwDBSjSdSzrpFkg7YLFZspp72NGegvCU NeLB93fX+4YeqCJA2YwbtgLEmKSu9IJoGB+jTldkMQpav89jLuZwGvaKruC6zmIiOv /u5nimIGxC4oA== Date: Tue, 13 Feb 2024 08:27:04 -0800 From: "Darrick J. Wong" To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, willy@infradead.org, linux-mm@kvack.org, david@fromorbit.com, Dave Chinner Subject: Re: [RFC v2 11/14] xfs: expose block size in stat Message-ID: <20240213162704.GQ6184@frogsfrogsfrogs> References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-12-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240213093713.1753368-12-kernel@pankajraghav.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7008D1C0026 X-Stat-Signature: bpgqhwbmkcrbudx4tmudbi9fe5tt9r3z X-HE-Tag: 1707841629-301148 X-HE-Meta: U2FsdGVkX18HK4Z1WPyHp9ZGL6zkoWXpCjBQYpiANwLqq7kKTKWVXq1DcL+T8VXLJ487IyDiHwY30t8HCdrcrkypshqnbAcLSAyCMhJNR51fqylOnmAGc1TlZ9RAdw2Iby5P3ICZC0UPrQHiDK7aNeRb1WG8scwnQQF7ciBrUEU3oGeWlMexvM1tKRt7KyL4gflfaWP1MPM/NZ3sqkjX0VcOjLaHo4l91igARxX8390bxC5cTMAz4GQg8K7VU/SB8p+G5O1X2XX92WaM4Fl8gUY2pYV2zImK6FY9MY/9UgRTDtHewImFpB4ghTse7ZuVHtsJHfUE+zKLYmxcPB1jYe/IhBySBWuvMZkp7Q1RwctdmFYul4UP67uNisBU4MoYuGlcbIyrLh2b8t0uwLTuUhrzdgc+sUv6Mcv6EeMZKdvpNvfrzaaVgd1JY7KhiMLK9HPyYUliD319erWDbAY2+Ku1cpAoCdUr807JzCP0s2FdAKNuoQxeNaf30B9MVEP8YOaogtvdMUL5l+FPEybiU/bT4R/Q1qZSG/8S15T0HYlymVXa15wbQYzDRS69l5Mnw5Iw8LPKKFUgNRt7dyZXz51VCfNbbtGmr6qUG7pNaOz5VddyXr0x8zmuHKq1U9XGi5uAlLikimFmEtKh64JQqXkHYBlqIX+0V98wfU60tlH8a40ofDJ0i13a5kT23BgpO1GfpdAQ7FTFV50OVyIr+h5c1zktX47kOBOhnbPfvFJ7iFM8/+r3qiPPLpGNaP0A4Pi0dKlzS4HSwaEvH4yZRrij41zEgfY0qo9MEEPdkz6rXFFJR3DtXdiD3jLWM1IlpxYMge8KewnYZqECzV2MMJCWcJ7N1Jz9+1GlIrAh5mWga7SW+H12de0x2B+fOjP2z5FSKLbxPMI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 10:37:10AM +0100, Pankaj Raghav (Samsung) wrote: > From: Dave Chinner > > For block size larger than page size, the unit of efficient IO is > the block size, not the page size. Leaving stat() to report > PAGE_SIZE as the block size causes test programs like fsx to issue > illegal ranges for operations that require block size alignment > (e.g. fallocate() insert range). Hence update the preferred IO size > to reflect the block size in this case. > > Signed-off-by: Dave Chinner > [mcgrof: forward rebase in consideration for commit > dd2d535e3fb29d ("xfs: cleanup calculating the stat optimal I/O size")] > Signed-off-by: Luis Chamberlain > --- > fs/xfs/xfs_iops.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index a0d77f5f512e..8791a9d80897 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -515,6 +515,8 @@ xfs_stat_blksize( > struct xfs_inode *ip) > { > struct xfs_mount *mp = ip->i_mount; > + unsigned long default_size = max_t(unsigned long, PAGE_SIZE, > + mp->m_sb.sb_blocksize); Nit: wonky indentation, but... > > /* > * If the file blocks are being allocated from a realtime volume, then > @@ -543,7 +545,7 @@ xfs_stat_blksize( > return 1U << mp->m_allocsize_log; > } > > - return PAGE_SIZE; > + return default_size; ...why not return max_t(...) directly here? --D > } > > STATIC int > -- > 2.43.0 > >