From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C413C48260 for ; Tue, 13 Feb 2024 22:38:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93B6D8D0011; Tue, 13 Feb 2024 17:38:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EB118D0001; Tue, 13 Feb 2024 17:38:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78BC68D0011; Tue, 13 Feb 2024 17:38:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 65B178D0001 for ; Tue, 13 Feb 2024 17:38:21 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0D0C5C0D30 for ; Tue, 13 Feb 2024 22:38:21 +0000 (UTC) X-FDA: 81788245602.12.A67691E Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf02.hostedemail.com (Postfix) with ESMTP id 163108000B for ; Tue, 13 Feb 2024 22:38:18 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Sv2qTuvq; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf02.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.169 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707863899; a=rsa-sha256; cv=none; b=jJXH1W0pyvIf73iEtL3WNk7zWzjXSJuhjbp2DkGQ69olKfHXyUTZ0/VpmaxKpSqFsdftec wxsMlUu/yXRJ5t4xCXjLGBDpLVK1s5leTTlEaCAK+yRcz0q2BejNUhAc7EPXrj6csky+U6 oDKjq4mPAgK9eC4Wm1/bLsffs4qEtG8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Sv2qTuvq; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf02.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.169 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707863899; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2hiMS9Vllp3coocjvge8ABDhc28Vq8F9ZVWNu08lRdE=; b=UsFVMa0V4zHfe0ntwCxcDu9Ac//gbCDjn91fslLOeYTNnRmCcuvzFDrMT79Y6c6VnrXWSb ZtW7XRnkmcmaq5cWCnsb7EyYwl7+gRc6WorR2KspGcegotaihOKfGeSb46GcXRJ1XZ/E9M dtBHchTQmnP/3Nhc1sYt501iCce+JLU= Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6e1040455b5so473611b3a.0 for ; Tue, 13 Feb 2024 14:38:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707863898; x=1708468698; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=2hiMS9Vllp3coocjvge8ABDhc28Vq8F9ZVWNu08lRdE=; b=Sv2qTuvqqDWcimYjgnf38AYl/CK9JzxZFyHFljhnSiFwkM3BrMulqkzHJjjG8QyVAu 9cynJm+ZlQrq5MBqYOKVDy/mX+d3p4TCD+iQtQPfgQbeDb0oVJoNp1QqY4SRmiHTDE0P 39/vsO88BT6R67K7nrjS3fxLVwBP1TMiJ6C3w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707863898; x=1708468698; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2hiMS9Vllp3coocjvge8ABDhc28Vq8F9ZVWNu08lRdE=; b=cAkZ+IUt844IT2BtmOhaQ22Qi2+LPDX6pLSKoB/vz4zWpnHP6xPD7GY0FGO2seFcvy KX/8y1ZuzpZ9mgfqbp+pwb6Q24Xuc3bfznrtMnXvNPuSFAgVAN0Lq2i/TTOMnzm2liaw nb8OQ45CXc/hjO4q9vSMe7jytiJfU9BZO0Xit1Rc8dqdUhRzubGQ+0SG9Hay3/keUoJM hFZphBZronOgHz+2qPXGnj/MW4bV/GLUoRi7CQSNiTziP48k/OYFh693Q1Rrov18TBVQ tqsjTtF8cdgnXqyl5efC9JzxufCa1PqY4WJQPELF5Jj0vFAut9BPMJn14Yuwhg8r0QdI 8b2w== X-Forwarded-Encrypted: i=1; AJvYcCWvA275meStGTK975G77oZpZz0t8Do8S5OMoPio9Z/5e+ub1WsMb+TNfmJuBm/JQE6mlm3emv49yyLdEsGh1BGpR0g= X-Gm-Message-State: AOJu0Yyh/lV7gj3qWEHCQHsT1dPd1kIwFgRVmBVo0p+kfmkc/c/kHquf BgLInmC7E7qu3oLHzZRY2qkXqNl9moju8kXyubKw4mn9T25V2CRZUP+O5bsmTw== X-Google-Smtp-Source: AGHT+IEJjDgETfxLCnAPWSBnpqqJqIKRgKUxndtPjjWLwYN7p6m29k55R2OnXJztxNgokZMz5U882g== X-Received: by 2002:aa7:9990:0:b0:6e0:41fa:7a15 with SMTP id k16-20020aa79990000000b006e041fa7a15mr653579pfh.22.1707863897877; Tue, 13 Feb 2024 14:38:17 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCW/mn7Onajn1J9Z/lzc5p1K3GH0bHTJ8UQh7vHO5BQAFHnDtHbjjGikPt8hRIxFLijyXXfhs6BUN9IGUx/qqnllCDiNQW35HgkzGgIiJms/lS7cKaMxaTrICe0InwvzpgoTdPMlJXH8ZsyKhtMa1YtjeN2hhA1HGJ7RbTZSnMgNW5Nn7kqMq1jXl00ngm3yAPwt4B+ltS1m3X80zQ0tx2+0vuqofg1OJkcdOXWaSDMKQzjAgI2V9j/sN+NU12nSCSPRpWWje79JH5v2z5778ubXaBbRHfCmHUPR5jpZdFMxFDDRaMDf/I3IQksTGF+Dvz9thjaYtmnnla/Xf8d8s57uBU1wxG97yEGGnSk8Abi1qhLYAlgDk6rwO1+57C0IxWUsveToMKKfRTvzSXFBtvOXMrbqaEXeZYD6+KnSV4xXsdCITu8MvuzOgO5UCjop+8j2Os6P6oscGHq1+KkNrzNeQAdGKeIoq4frxWn4WjnyXY9l8erqIvfl2xanToYVpK3iWBYmuR5sVECyuowQkQJDlxWOW6eWs53JgYs5Rc7YlppdjxP/NspE/ksEkkc+SyDYflDndEmCqBETHM1isOIYb/QKCYfob55PByWAGxEynzShVBWDUAxrgUL3vt7Tuv1hdrqPEf3NuV6WudZ6HOymLHhktUYR0CNdTjRTNqR6yprREa7ffm0HRb1UFAmrPP8Zpghvk8PrJGNPkMRC8C9IsAb4mR826io/AvAdWw6/8HxQxjRifwiXL3ax19SiYvcaWZJORgRvrc6BKqDE+9YhtzdtY7mxwZaA5FPY2Z93Dzjhu6tBp5O4iBOTmH3pYGWF48N/ixRoGO9ZF2XT7PCRzy2HnrSHklqXYj8OiVtT5Z2Grztp9A54UxToDUwNm/rqVjreNyZUFIeybKxRtLmAxSXtWg9ZhjixxrmFdj9QJwTPj8xrHT0QrD2KPY nQzWzNvg sL7QoWy6KDuO0oyAl0vITPBG/cs14G886TXwdmDk7A8EOyY3m6dR6vNdga3RYMpePu/vzNqbOm4ygJkJFc8tHJAVzQNK46PAMrgR6eYNGymWaqkIvVBuFR/hnImOxZyoQlaKs3QmlXMBH/5S/PPuQAIfo5Hgcs/GjlnwbbHUqz6lS9HF74Kf3g9ohORS3UD8a7CYM0IVXW2vpqo8QuscdGqJE/CmetUsk81U36AV+rn8AB/jd9qAZBPpkscPzoE+ms0rADXE4zzMS3SI9r205hfu+7aoVS9+pgt7DHPqz0UF/QuSoA+4QGdmamg4PBvu6oszFezeZKHXxUV0cvvkw5PyAta9VaSDdeZPlCeIA/A3b31HF2iqZ2IZtHbyb7nKZHCY3QLOA+BGYeGUXZp58WpatZ3FmcHRTzDDpP+pP1JiTuJMUG0VvYNmBy Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id x23-20020aa79197000000b006e05c801748sm7926811pfa.199.2024.02.13.14.38.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 14:38:17 -0800 (PST) Date: Tue, 13 Feb 2024 14:38:16 -0800 From: Kees Cook To: Suren Baghdasaryan Cc: "Darrick J. Wong" , akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 13/35] lib: add allocation tagging support for memory allocation profiling Message-ID: <202402131436.2CA91AE@keescook> References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-14-surenb@google.com> <202402121433.5CC66F34B@keescook> <20240213222859.GE6184@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 163108000B X-Stat-Signature: 4oymjwmkypjjkd74mn3qzoz47y8qub3q X-HE-Tag: 1707863898-58883 X-HE-Meta: U2FsdGVkX19gQewZg1sOaDfUHlfL2loC7PYBkP6Z6sako5+Y5qHNv/nO4M60VL9+eTBwRYGueVd2PrprBkeSoFb/YI75YG1cfUh5ueIEZ4Ryjn8PiuOPKXbcbeoSDRlSYGhGG21BPBcfmuyWNzA4+AQ6imsAsk8TBpZD8ySA5wPgDENDIjMD8Qbuh7xTS9Ga2VVoZchKbfWeeesDn7Ic4/W4xz6zbIHA9YWWXXDV/wg76kfk74xf6nAoCZeoPIM8PWWKKsGS/v53tn3VKK8iNJiZv9ZZcNu7QXNRRgb0AgeZxvzDXxZPlcKUTKe1bxD9wXpVtkn9biVeJ2cOS6j9TwYA+E71OJlrFJ5XgY/13JcJ3T+Kh5ZNbJMydzpD03N9ThJCvPxxJvpe3yp17Z/5KTAAlAt/qytz/NGDR5bP3zGK0IPcm9iWIpVPx9WXNEoheQlp6FrHsfN5XGpiYvs/b3cTdZZ7h56znQ3tMaFmWszlq3pZqa7+4qzKlEqk99SzA/IhUkOPFA8ZLzp/dWZjR2bEmtbMNnLfW/jJHab84ddhe55fZ9mPBNNrQKeAS26yd/G+vNUE5srJNTUYH8bqTDTXr6U5L0CLJKF32iwIryPVojs47FYU3L6Cq4hkbJEywdgZ5O0lbKEy2sRpzv8uGg/wACGSwhW4n4EPUljK5ccyIMe/sAJb8f8VjUxJNk16MhA/HfiRuPiaJI9h4+IQJTZwS2YrCm/QTcMEgAZZxUjXlb1sGvKZaB0/shpiGLjnYtdRCYsF6yEfeCTvN61NI08+ZcgUC5RxDZv1VJl0PPQiZ9EORYN9Wf08ZOnH6Jr247hLUwAhcyNgmBfHtgKrmkE3ZYQwbpU+sFbUkDlgXZIKSkrmz+v2JZJ2JRPpuWVQCiRwyHf9FaGMbRRB3HqyMum2UrEta8iJDLTsrKqo/mr2lec212RwwyFX8AyyKKZHsKSfB3r/75zTWGF9+57 OYNy+rys BbjofWQH1Sgcv8wGnYTrmePMmrugb9JguNGJkXkVPzad4BCQKhA3HRbcc3rQsKpQN+1pO+yFME25hlr0Fkmc8N3YLYZ8OK7gbHsMb/EvNoizYFAoi7MDRL2crLMmdGbgg0E0fUkCrHabS21242ZjoHUSEqYvYeWzh20xsmt5RE84Ogf0MxVtICUNYsJvUE5USulc/wHUEZkWDUIDg1NoCUvKolEllUU/FZR8uyNCwTG+frs7GiKfAkIaDE+jZbyBidIDqkZ5JyEq7oWRm2u5vs5i8BTKMXWTFu1HyISQEsZeQFLnVU+1p9aQs6eJVGLPjHDluxQK9NwskS9SvKJXHv+TrySVam8bA3E0skVuwIcRzv8Uxjrx7uaxsUtqgvYa4DQVsqbL2R8VOiEPbb9nvksFLP0+X0MhV0BmuEv0jROplUFzS4H6LqLnzLH/F7EUqaQxBAbqzg+VnyQr/Ai84dxvEISRmpDs6HN3R7cC7CnlGjoS+bo4+HYEEw9dXrzqTvtElaiz3GQVNBS9ShbcHT6bDJz46l2tKg4uw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 02:35:29PM -0800, Suren Baghdasaryan wrote: > On Tue, Feb 13, 2024 at 2:29 PM Darrick J. Wong wrote: > > > > On Mon, Feb 12, 2024 at 05:01:19PM -0800, Suren Baghdasaryan wrote: > > > On Mon, Feb 12, 2024 at 2:40 PM Kees Cook wrote: > > > > > > > > On Mon, Feb 12, 2024 at 01:38:59PM -0800, Suren Baghdasaryan wrote: > > > > > Introduce CONFIG_MEM_ALLOC_PROFILING which provides definitions to easily > > > > > instrument memory allocators. It registers an "alloc_tags" codetag type > > > > > with /proc/allocinfo interface to output allocation tag information when > > > > > > > > Please don't add anything new to the top-level /proc directory. This > > > > should likely live in /sys. > > > > > > Ack. I'll find a more appropriate place for it then. > > > It just seemed like such generic information which would belong next > > > to meminfo/zoneinfo and such... > > > > Save yourself a cycle of "rework the whole fs interface only to have > > someone else tell you no" and put it in debugfs, not sysfs. Wrangling > > with debugfs is easier than all the macro-happy sysfs stuff; you don't > > have to integrate with the "device" model; and there is no 'one value > > per file' rule. > > Thanks for the input. This file used to be in debugfs but reviewers > felt it belonged in /proc if it's to be used in production > environments. Some distros (like Android) disable debugfs in > production. FWIW, I agree debugfs is not right. If others feel it's right in /proc, I certainly won't NAK -- it's just been that we've traditionally been trying to avoid continuing to pollute the top-level /proc and instead associate new things with something in /sys. -- Kees Cook