From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5554CC48260 for ; Tue, 13 Feb 2024 11:19:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1DBA6B009B; Tue, 13 Feb 2024 06:19:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA7506B009C; Tue, 13 Feb 2024 06:19:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C47F46B009D; Tue, 13 Feb 2024 06:19:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AE1FB6B009B for ; Tue, 13 Feb 2024 06:19:19 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7C487406A3 for ; Tue, 13 Feb 2024 11:19:19 +0000 (UTC) X-FDA: 81786534438.12.98FBFD0 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf14.hostedemail.com (Postfix) with ESMTP id 287C510001A for ; Tue, 13 Feb 2024 11:19:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="ZZEg/ZnC"; spf=pass (imf14.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707823157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kRixhbN6Ym1Zmusnenh11GI105dw0bqQnIm1JeLCSK8=; b=v03py/7+B0dVUBkusY7w5gdzJNilcwxkuMIqwnFc+1VVjHi+4Ds9rRpx9KLpdgfntnji0i SIJxBqnhzYMuhqWzYG5A+BcMyW2Rl0M3B7N6T3UJVaDaTlVIKBktFgtZMnZ9SPLmtdBzPo MSrz6RzuUNzT/xSi33+iGRfY1XvHlFU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707823157; a=rsa-sha256; cv=none; b=OFgbpIIJ3wekCqko5pz2jZ9E7hDFfKS976khq0DLLLws2zGvsXFpQKHHn3c09SfwSc9AEI aUOlI9G0rg/9cT5lhOorYG3U58VKLT9NMoImjY7x6FUAZm3QLJ7hzG8FCmTcl7CvPUoaYE pTZO7bLt08BZN1bltYXXGBBGuBtckSs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="ZZEg/ZnC"; spf=pass (imf14.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41DAI2V3018656; Tue, 13 Feb 2024 11:18:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=kRixhbN6Ym1Zmusnenh11GI105dw0bqQnIm1JeLCSK8=; b=ZZEg/ZnCZtXf+0rAXEh14DIZ8Sye5Nhv5T7O/GHGqhe/UlUBxyyIjoPTy+kciAagGdPa GN5A8rXGjLKKzQq5azUSEepMOhG1uAfv2MPHyLvkEPgkJVSEpKyMUoV+o6akZPot8bgZ rQxFMy5cJURaY3EA+zCymd6cySK6yRVWgj83u6aX9PqjCXSbHQSP+a3F9lVtAQU03W7Z cNVAbaZ5MibgX3c9/TPRO+DvscRxn4PXsP2cu6rx6BmYvr6JcXO2Kf3VfGBOeM6ixewH ViLcLfXfoS/DiZeOOHY7DyW3aHWKQk7MwYu4CJoSHcMD61K/mv1ztVb85syzviIuF7VA cw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3w86hts9w4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Feb 2024 11:18:56 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 41DB1fNm022081; Tue, 13 Feb 2024 11:18:55 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3w86hts9vm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Feb 2024 11:18:55 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41D8P7Jh016479; Tue, 13 Feb 2024 11:18:54 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3w6mymeuwd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Feb 2024 11:18:54 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41DBIpXF45809942 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Feb 2024 11:18:53 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6A7F120040; Tue, 13 Feb 2024 11:18:51 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E9C362004D; Tue, 13 Feb 2024 11:18:50 +0000 (GMT) Received: from osiris (unknown [9.152.212.60]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 13 Feb 2024 11:18:50 +0000 (GMT) Date: Tue, 13 Feb 2024 12:18:49 +0100 From: Heiko Carstens To: Mathieu Desnoyers Cc: Dan Williams , Arnd Bergmann , Dave Chinner , linux-kernel@vger.kernel.org, Andrew Morton , Linus Torvalds , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Mikulas Patocka Subject: Re: [PATCH v5 4/8] dcssblk: Handle alloc_dax() -EOPNOTSUPP failure Message-ID: <20240213111849.6534-A-hca@linux.ibm.com> References: <20240212163101.19614-1-mathieu.desnoyers@efficios.com> <20240212163101.19614-5-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240212163101.19614-5-mathieu.desnoyers@efficios.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: v7etkd58sOZye-tw7r45w1hzzfW55uLg X-Proofpoint-GUID: ex2g2pAdh4h8FGNj8JP3P_9xuvlIPkmS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-13_06,2024-02-12_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 mlxscore=0 mlxlogscore=800 malwarescore=0 priorityscore=1501 spamscore=0 clxscore=1011 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402130089 X-Stat-Signature: irwbqwi9s5ju6b7xtubs9et9hrmtk5a7 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 287C510001A X-Rspam-User: X-HE-Tag: 1707823156-341910 X-HE-Meta: U2FsdGVkX1/2P7mcE1efRvdsI+PEjhsbVbHpLt+M6n1UvCAcs4caPc12XCFKIuWi8dP7jm2XzmJr9u2apj5sV5Njr6n30YW55iTJFEHAUiask2hz7KlcQReQVj3vbLIMXFD1o4bdvDe7bHKbg+Doru1DyzoS7KabN24kWyqdx9OiRgBZhiI0cn5L7w9OJJCJNsloICryAs0h6BLJ+gC+4YSdQ3XyEG5syncQ264fFZNvjDwWDb2rBMTfCerzQ3PRJ7ilmrXQk8eizuK7vtceTKtm22SLKB6aIQ/Mta7vMWJimzgwAJ4adqQx6FwYkFu04Egrj8hqXfNF9lEDCoVeNKKEsZa0q+QYifTy9h8dDZXwm5OdBOLQS8V3lUcjzR193IIgosRv5BSiuDZPJ3s48/+ep7BSdlCTfccJFnmeIaCYFHqEGEuI0ihGJVCLk6M4GnAeMsN6T0dX/o9Xm+LL0uHlEimK7/TNJCEX91k1/xehiQhu/H9fvtUdi234uR5Cky3ar/a/CclY/qxa0uvevX9mL9Ll+aRX3IsgfIhXj9PFfJVpnhiCyifvkZpexvghGBtTRkpnlydS40WbOcslbafn+JZbjhh2rO9BAk0C2qRvatvpb9bD/MsvPxG0FNugM4sauKFfiQVcpdXM50zwvcfZ0t8xzlS/+6sjtyR6X5v+EniJMg6aVIDGVk2EnRNs5SOQbQHygDPTn3bXbNr3f4USUL878LXiuJafTSzUUJ3t4rUZPApZh/TW3dnxlAmJ5ez0xcA5dlPu397TVuE2Nl2YSOlnSNCvgdmZOSPOZhHduPhi5ej6BfkGJEpU9v7tGOPlDcqV1C9oKp28tMVBSWJBcras253ZLrEmHKoG0WlcByj55l2o85DpJGGh3XrYpeEhs/rJbcMeUy0oBY0mXfc6g7uegfMf13bB79hpJ9CBZ6RmpkggiuBCuyUReDYYrOm3q4fnYdYKVSsQLg3 WigDItRu ZQLgmhcPz0VLXxHdyfPIGdP9RlOB3259/AHaK/On2ocekxdoNhoAPSYACITPJxV9uKElRyrg0pRJljSdmjXfng4CJtew/CUO/+WuuN3K+lOKL4HyHeH0/+ChwikGbJQ7BPeEAF4lOtRsqxrA/tT3KX6TqKxQ3tMmC0XROOztywGIiNUkFq9EIjayzgjmP2GjEO67Oydufj1qY9gurZLVWWR4eEQA7T/c9tN85OlcXas/A9oZrOzJbTU6Q+16Pz/uyyQD2/w0mjxltRQRlfO2Rp1/T0l2lIxeNwYw/TdiDVdLRWn4FY4hzQiiCXA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 11:30:57AM -0500, Mathieu Desnoyers wrote: > In preparation for checking whether the architecture has data cache > aliasing within alloc_dax(), modify the error handling of dcssblk > dcssblk_add_store() to handle alloc_dax() -EOPNOTSUPP failures. > > Considering that s390 is not a data cache aliasing architecture, > and considering that DCSSBLK selects DAX, a return value of -EOPNOTSUPP > from alloc_dax() should make dcssblk_add_store() fail. > > Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") > Signed-off-by: Mathieu Desnoyers > Reviewed-by: Dan Williams ... > --- > drivers/s390/block/dcssblk.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) Acked-by: Heiko Carstens