From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECDA2C4829A for ; Tue, 13 Feb 2024 08:26:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 823796B0088; Tue, 13 Feb 2024 03:26:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D3D46B0089; Tue, 13 Feb 2024 03:26:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69BB56B008A; Tue, 13 Feb 2024 03:26:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5B6C96B0088 for ; Tue, 13 Feb 2024 03:26:06 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 01B37A02A9 for ; Tue, 13 Feb 2024 08:26:05 +0000 (UTC) X-FDA: 81786097932.18.BC93BE8 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf04.hostedemail.com (Postfix) with ESMTP id 09BCB4000F for ; Tue, 13 Feb 2024 08:26:03 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=ZuEscpu6; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf04.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.41 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707812764; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kMtP+3iWAEylu96mXy118wLFMmy/kFbtP3ySNbO/3c8=; b=lWhhr9+pRPmuwzKU22CpA5lesrcMWy9WP8FAuRUtI+Rwe4lMTKD+KSA0tdDnDUZtBU3P6x a6fDf5X0QVP0/MJRjOx4sAi4soFcslI42ZOm5ajKyYO5w1jAL9+tNsZO5i6fly54NpboX9 XtYeFznUXdEZcXkJP59/SFI8Z+1jT1Q= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=ZuEscpu6; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf04.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.41 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707812764; a=rsa-sha256; cv=none; b=TEIh2sWH9AttqmqBQJIFyOInOg11/fYQoh8jytXTml0T3fi3Qd7G4/63XWwAmTdIzRuN+s hYv0KB09a4TDwTeeH2T+HhIlIkA9wZale0GqMm6ZgArPfx5fgRDsMvtmw8pmWO3NDCcWgY DFaxOHTSBo7ATHyRdhPLbmT6jH5CwdE= Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-68c431c6c91so17722276d6.0 for ; Tue, 13 Feb 2024 00:26:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1707812763; x=1708417563; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=kMtP+3iWAEylu96mXy118wLFMmy/kFbtP3ySNbO/3c8=; b=ZuEscpu6/6wYlI0vXDUE9p9ueWkG2KXHRCT2LfNP7VVOkq7t9ObMiB95a31qrkplg2 eywcRPrVJ4bp2319Cb3vg4rmFNSOHdThu6AnfHaIvTghb+hGROckyd/lX6mXtdmN0Ii2 opOxvQQ92ScLydsQVQL82gJy4+/1l8xxxXyS1F/ztVwEjkkoQS2kltNDSo7jL+HtMo3q UilNiWyMJg2eBioSAXwLl1oyp/tPygqK8llJdtPSFAwCMl/5bzLiYnW4PdfBN7ifTJvy 9JX5IBYtXXeNR3QdqYez6E8S9NMXljax+Uvva6lt0sl0ytjn9GErj9x3CJcRvrxUPJ9r +cmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707812763; x=1708417563; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kMtP+3iWAEylu96mXy118wLFMmy/kFbtP3ySNbO/3c8=; b=CFmG62HXj8jXCu2YhL6Rx8JkMTMHAqKwRxWQz3hcbiQFyyNGX8cBJ+j2yhWA9j7fJ2 nIlFVNuYGcxeByBRHhS/USkysa+ilZuNkNAl+5/0YAl4ffLoHTAxqeuc05sSoSmADO4f X7TtUmdEW2NojKAvX1j6eHHA1vEfPsjq//epp3HJjuurrndLsghTqQJJKeqcTbK5uj/x MNW86RrbYFso8fC3jDtl+IquWB67WOovrrHY82debwYRkYrOD9spRtVcw5jSk1X1hTt2 DOEO1BCAWqc6P6ohZbtzINXdz0+FEDMaTMXxFgelbx/la5dazKrvLuYdUBcTzxoMjPli xrig== X-Forwarded-Encrypted: i=1; AJvYcCV2oBJSVsmf3BfEbyWmyOgWMsvOOACOv32C034/iOGlEGmmmKZ3Cci5to6PFSIIl180wMQcsLf957ee+9hnGO6juV0= X-Gm-Message-State: AOJu0Yx05rIYk0NSNjIMTW2ziAsQcIWZ+85vtHZI53T7VCGwghXtCk/G RQKdxbNew7P5dfMfnHpFKxfd704XQLJWwTw3hKM/51RcBQ1X8Gz2iEbFjyIs3hM= X-Google-Smtp-Source: AGHT+IFnNcQLPpRxJM0mabl8oW0ikqa7spWYyGyU6KFw0I0CHa0pUul0LlHn2X1kpr43kBWUWOPF2w== X-Received: by 2002:a05:6214:f02:b0:68c:5e0d:6a6e with SMTP id gw2-20020a0562140f0200b0068c5e0d6a6emr11992054qvb.47.1707812763152; Tue, 13 Feb 2024 00:26:03 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUNFSDMgBtpLaFjfITQiufMukwuNqcEXtQfJ6WdrDisPF79LqEGPu80Zi4obJcdACuPRprQnXGCr2nVkDRuwGhDwODTVURUfeYq8dkOwFujFESxOj2OHEgIyU5PSE04BJ3/HARw2fa4IVn0hPHLWbn9AA3P Received: from localhost ([2620:10d:c091:400::5:b0f]) by smtp.gmail.com with ESMTPSA id oh9-20020a056214438900b0068e473530bbsm815851qvb.33.2024.02.13.00.26.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 00:26:02 -0800 (PST) Date: Tue, 13 Feb 2024 03:26:01 -0500 From: Johannes Weiner To: Yosry Ahmed Cc: Michal Hocko , Narcis Garcia , linux-mm@kvack.org, Roman Gushchin Subject: Re: swapaccount= commandline option Message-ID: <20240213082601.GC3448692@cmpxchg.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 09BCB4000F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: nt7kyk9eb7bfh9se88ifoqbsdc4ca5t7 X-HE-Tag: 1707812763-140420 X-HE-Meta: U2FsdGVkX1+zQZ+syUYOj5k/IUrJO4OoalzQXtaErXPhz1nAV3/SOLUGbmDpSuMEnbru68aj9kKUQEFNTfcb822MkTiAAkhoun8hs6uRoIF2dYkxSgOJUDvlk+7ejm6yEKL4mP2T7+EO4JgApOn0+Ge2820NfV0j6fXg5Nf6CxmvcMzelJhNq87juQJKTyXAgyyfDEcPEjFzCnqzKEGoaoAqGvqdMh21hn49hwZLirVwxPv6WVo7nZ4szPG5nVhFBu20W6dhyiSncti2yKg67SCniwakGVsqkB9oGOzyySRucL6RhPnlCqcinRDpe171tf1fCCXSMioOtUoDc3r9JjeyJ7O75rrZ9R1MdA1SmbSz1UJHg8AWcLHqSUjqN3LQMsIHVPIequr47g3FH1tthbsxtg9BMrY43t+nIVvTzb9PB9sdxH4k2qX14/cHc2SY+piH46G3ULZf1ENZ0p6LXiIa2+QCG1LhXtZLrd8/qBp8IC7BI7vShWh/gZOvkcYMr8omdsbt+u6E0JAiY3dYM4ydBfRxq/Y73JE10fIf7wxwKXYi+1/iqZptuqtTTS1yf+CeCiG0T9ZgYtLALLViMDqECbBpzxrNe5n4oz9rfjJeHg6P/yJpHAiZ5b1bS3k76wcOr6tVGrUF0mM9T+KfHtbgZH0pHAR88ylEJRAnWewqUnXuHRESHYmbhQahFjLR5rlCnFonLIMjUpb/Fm6uMubqXTfCrLpB4KVJ1snWtIOVwostFzPhEJGkVeMxecT5vOcTa3jy8Dl6dewf9iCkWeMirCKpigLUBomiJiJGukC3gvVHONzE7Vb9ECRuB0MZiT69wBLwqvJPlfLvMF+g+wZFRv2pL36v3APjwibQSbzDa/L47TvPagmVxm6tpW2FwYvdujZVRIIUjJ3Mo81j26LsFgA5V8W4AMcXgAVgQPiaxtj9k7c9lbbKAA5zqFFCkgkupIF/BzCW/j82vZA ZB7/I5AK lRytDnctXufwEiRRMCaWWLDr/+6RseuzGJ5CgLMCnqpCdOnVTpM48lTL5XM+3poGbLbtqcpjokPlaWWEjulKVMz3bEiiPrR5CHPuM5/1nOkbAd7ACuAqTUwQU0cLMAOvR734d/xnGG6R8op4g5HC1TJhTHsGYta3QE00qrEHJ0kID6zXETpgMjSMSE5RMvEQ6nue3lpyLC6xFySZjKh92LgXz+6YdF5AbeOLav+AkNIGj0XkrFjxwn17OLNXX3jxyhgFaw5Y7vTx+PRLBb/hXsfVZeeT+1Sbvjrm0u5eJHVaRF8EZtQevGzWmC/yK8nJ+6KSTOBslt2deqtmrpz/AG2TYdWNvseTpOsdKJj6lZJjZUHJFHB/N/BE/Vj0kWROpcJ1K1OxZMYsg0ECJA8mTpRgdkB44kW4oD4oxLyGJHqmivTY7uXNmIb/ZLL8M173XWLIKnqfR+FXchUKWMitkeFcwh5fwec38tml6C1AKUvB0QUhgq5vOwpTP5r2IuWPrrcgGus+l2SiQRVV01MHHLXSj19UYdBEorkA//UPD7m27TjHQ81+dXvoyWzhWCevr3DzYY7wilQSQho9KqJFw+1AO/rlnJzaFw/cxJax33jDIdYZlZdOlnzdou4zr6m9IuAR4saX6RVop1HTD2y7yH+LGtMqpZHm1/kkl16JjcM+8IzShSPTOY9So9Hh1jfWdMQf5GB26+V45L+4XvfYxWRYAE061Ic4//d/sHDPmMeJJVWfT7L23OhKSpQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 12:09:26AM -0800, Yosry Ahmed wrote: > On Tue, Feb 13, 2024 at 12:06 AM Michal Hocko wrote: > > > > On Tue 13-02-24 08:01:37, Narcis Garcia wrote: > > > El 12/2/24 a les 23:37, Yosry Ahmed ha escrit: > > > > On Sun, Feb 11, 2024 at 1:33 AM Narcis Garcia wrote: > > > > > > > > > > Hello, > > > > > > > > > > I read this warning on Linux 6.1 boot: > > > > > The swapaccount= commandline option is deprecated. Please report your > > > > > usecase to linux-mm@kvack.org if you depend on this functionality. > > > > > > > > > > And I want to know if this impacts on LinuX Containers (LXC) swap > > > > > accounting. > > > > > > > > swapaccount= was deprecated in the sense that it is always on now > > > > (i.e. you cannot do swapaccount=0 anymore). I believe you are using > > > > swapaccount=1 and want to make sure that swap accounting will still > > > > work with v6.1, right? > > > > > > > > This is the second question we have had about this message [1]. I > > > > think we need to clarify the warning (and perhaps backport to stable > > > > kernels). > > > > > > > > [1]https://lore.kernel.org/linux-mm/2593755.Xrv9ptJ69j@sinistra.local/ > > > > > > > > > Thank you for answering this question, and sure this clarification is needed > > > both in documentation and warning message. > > > I've found deprecation message was commited on 26 Sep 2022. > > > From what Linux version release, this deprecation is included? > > > > > > I suggest this for setup_swap_account() code: > > > pr_warn_once("The swapaccount= commandline option is deprecated. " > > > "Swap accounting is always on. " > > > "Please report your usecase to linux-mm@kvack.org if you " > > > "depend on this functionality.\n"); > > > > Would it make more sense to warn only if somebody tries to disable the > > swap accounting? > > --- > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index e4c8735e7c85..dec75eedf634 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -7936,7 +7936,10 @@ bool mem_cgroup_swap_full(struct folio *folio) > > > > static int __init setup_swap_account(char *s) > > { > > - pr_warn_once("The swapaccount= commandline option is deprecated. " > > + bool res; > > + > > + if (kstrtobool(s, &res) || !res) > > + pr_warn_once("The swapaccount= commandline option is deprecated. " > > "Please report your usecase to linux-mm@kvack.org if you " > > "depend on this functionality.\n"); > > return 1; > > -- > > Yes, this makes sense to me, but I still think explicitly specifying > that swap accounting is always on now would make things even clearer. I think it's okay if it only warns when somebody requests disabling, since the confusion won't happen anymore for folks still explicitly requesting the enablement. I did add a blurb about what the preferred method to control swap behavior is, though.