From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40CEAC48260 for ; Tue, 13 Feb 2024 08:23:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8DB06B0082; Tue, 13 Feb 2024 03:23:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C3DDB6B0083; Tue, 13 Feb 2024 03:23:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B05526B0085; Tue, 13 Feb 2024 03:23:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A05446B0082 for ; Tue, 13 Feb 2024 03:23:25 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6E667A2047 for ; Tue, 13 Feb 2024 08:23:25 +0000 (UTC) X-FDA: 81786091170.14.4F92EDA Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) by imf25.hostedemail.com (Postfix) with ESMTP id 32E7DA0012 for ; Tue, 13 Feb 2024 08:23:23 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=m3bAsc0L; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf25.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.221.175 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707812603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t3EIDSyOrhhsNacGa9WcLJSLQkcwNJkIYV0saweyaec=; b=rr9KD8abTXDXLtkLOZ905ENgfvMnXFtX2bLDOiVYsWTy617qhNTGNg89OuPOBvuBEW2g6h BXVOoDyvp5BIXFJtBJmTf+4Uog2X3a6GYlmQhSovQQGp+McW+DQJYvtHGKtnkwoDA8SqtI 1EY5cnQO+MyMEdAB2M0Kblf8r7DKMr4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=m3bAsc0L; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf25.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.221.175 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707812603; a=rsa-sha256; cv=none; b=HI0qXNUa5HcmNPnClheBtzNTqxxYBP4wBuGm4ktiR4jwEPicTNcnSxxTcYHVrxgWk/u5M6 50VT1YmfGSvZ0oQC/o71n8fmerSbOippoXv5y1dHTDaXJGiy62c9sLw/YoZy7EZg11S1HG Z4AFe2VN+NOo+HXUUjtGMYku42uTy1c= Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-4c0245cba99so123339e0c.0 for ; Tue, 13 Feb 2024 00:23:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1707812602; x=1708417402; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=t3EIDSyOrhhsNacGa9WcLJSLQkcwNJkIYV0saweyaec=; b=m3bAsc0LKBuP3kHA8SoxYHub/eL3LM+8+rCWMBXOfw8jYcRe+tA5DyQPspe3HVnEzP bbIae25oglW/V0pF9oioU8k4X4JecZaUegrOB5ZzegwY5JqApYo+LQ9god4OATEQros5 dbNNEATgTgK4cGE56PxvSxRl8xsEQNS2gbipq00iDJhywDeyMl/HRWx9aG+wBjWq0ng9 gdyj2A5YpvxTbLyk28n8IvAk4h4tCphxZchU6Qy3/TtRgxF2aGPQEh/baeJnA9TRe0M6 lzBoeJZiUmzx/KDRtKSBhQUe/Du58plL6k5I+bRTbOK0Ugq8PfML1Es1S+Bfa6LC2PwO apnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707812602; x=1708417402; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t3EIDSyOrhhsNacGa9WcLJSLQkcwNJkIYV0saweyaec=; b=Rqfw4/7JcwRfAEUO2odumgzjHkpqB/oyF4pQ/2OumjqoAi1uPJZr0l4NX4aIhhNycV jRqNx8wg/V/Rbg2peBZ4BceOyu55lm9Lzxa2h4yA0cUwVG8nuD2XrcCJA0dmUr1/yHAn VmeCh+nHsXFDEcnbR5hJE8wTapuiC9XEIELtZJznDrIT+mDt1dTXhmjT3sCfxlgPEUjV vT/kWTGqsK+H9TCjVSo2o96Eugo7/SunisnJ6RqKMnizoMqxVL5ANKqjgJvkj7Lzrnm+ ncBvWD1sFLidiBuc0WJ6gBSfyLM4qa/EX17RVvnzfAAyyW8nlQu7euDqla8QYHQhsDve ACkg== X-Forwarded-Encrypted: i=1; AJvYcCWk7b2W/s9tSrBnWBuQYTejJqkDb9fNo38nTVi4GcHEM5/TEdgAoMR0d9tmQAfDwVd5R4ollqP62xvrg4U270EjJVc= X-Gm-Message-State: AOJu0Yywh+YDvNCMWKX2QKe0MV6tyX2tvkV7EqjClistdwOZ4taKa3SG nhB+2ChwSYCm9b+Wv5xR6mBRhe3gJbyAOmBRmJjKpM2SijMb51ZfSE7xVr2lMtM= X-Google-Smtp-Source: AGHT+IGvfxWs6f7sK8UbElHxyRE7RVhPCAa79ZdV8UiM2aHPaJWqqKa9OF4peL3QJJcefjykNaENWA== X-Received: by 2002:a1f:ed83:0:b0:4c0:26c5:5d7c with SMTP id l125-20020a1fed83000000b004c026c55d7cmr5243939vkh.6.1707812601771; Tue, 13 Feb 2024 00:23:21 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWzDxRqpomoXwlSQneKhUauSPtsfVvaEd7zaqwicA7qxyrthX+G69MeEnzcyS5vU4BMtCw6MuMFOEeTHT4isKIEhEgnnRXgKfWlQhMQh4iGOVfkT6N55eCx9eTiew== Received: from localhost ([2620:10d:c091:400::5:b0f]) by smtp.gmail.com with ESMTPSA id fc13-20020ad44f2d000000b0068c6fe93f45sm1044304qvb.122.2024.02.13.00.23.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 00:23:21 -0800 (PST) Date: Tue, 13 Feb 2024 03:23:20 -0500 From: Johannes Weiner To: Michal Hocko Cc: Narcis Garcia , linux-mm@kvack.org, Roman Gushchin Subject: Re: swapaccount= commandline option Message-ID: <20240213082320.GB3448692@cmpxchg.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 32E7DA0012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 1p597tbxq7f4z179ypirfnc8hjfzfs3g X-HE-Tag: 1707812603-239606 X-HE-Meta: U2FsdGVkX1+4cSpXP7ZaUUObvyxBf1bgLEMlIkijR9EUFxpuyPPwhEBbwZ84PR99vi8Rl3qohy7twlyu+ipDoGkiUGDmd+XJItJWygPLJTY9xhNPzozo/afJmFo2knJxz3zLHQHw6dUE65hy4zDNn1TfdW4mCsNkivVJy27wynmHLQK32uEMe9bG8fHZHYXLvYJCY9JGwZefa5bNZyKqj6VLfKIa6rxOlcSA8xo5HIUEN9uFb70B50NMX+aH2ZZ9+aNmFVOlOjn9z2TX8anwcapAkMuuDID7AXoZUAjJuR8i7WZseT1ns5i2ZDmq0rKeQjf3LMB9Jk0+xLacj9uFui+40WMM7z5bdpyr+3OUy5xWORXI+CNVPNp+cg96j8DEUs2F8B7R5vc+LqziGc5192kfKmYKLcyjQa6Lw7rFbdVQcAjS4gZIsdC0EmmoZJroJgiWtj93Eb527v3gUzhZYSzBvu5VJD3TKhgd9XRdC50po/j80k+mtGtQrKwFE20URzzeXTfIGGKCgRBxaAY8HG+Ueq/OTLPs35vv3i9fLfEKycQadEiajcsS/q1XVPRK6r9Nv9HByniIDUBf2Azww60rM+01LhQF4rOrdXCpGFLsNEIW4sg/uP48zJ9eY+YBfXHdo9sMd5e+e3iSR7Vk7Luea2MM6DFTSrxA/QawQg4JkkgKkF5VNQdxNHWMNwFkxfvFLPMGfjWr/5n9Y8QmCovXbVsX+VeaKxcGpUGQovFeM8ilU08SI62TLrvQAC0nGoXCHDhn2CEorKvL1BH2JhrdUKSqReJZNXcwF41apkibB5s2kmRrJRgHQEu5Dtp73BziNVfTSXVee2+nk6Jc9V19y/XyaiPgr7PgB9ZGKqMteCwUmN31bHwD4FvDZiqtlP1cHIuqeEPkgHlzbteBUEqRDpvg5pOf/q+f4GwYldllArOfhtWGsyeu+jgPjp77cZC8bm0APmNINZY5KwZ ONJSojEZ P+If3TmO9w5mhKLeOvQuHVaXGNrmo9S7DQbqD+fh15HWAiZP8J92rLm+6YkNQUky6nEuL/+JwtxdCOZMilGe+3Iwo3WHrxfjq4d2BrRsI0H9qWz8u7Kyym15EGEwlBhXhzLXeqnFKA4DPEwNzwI5CYIP1Lj4SzS/ohfRcaNa+AWw0/6M0yVfAN59o4rPDeadRi4gUbM5kypiopgquBZsXsJATJIyKYaFI74/Ww/v8vNVYvukLwcC6jBRCwiInPaNQ/T57obI4u5SaEKocJvKlCFqBCWIOogOd1BDalaJoqP9rUW/H5dnQZaWCKVaFyeuOWTHND5e34A9EdcV3MqHn+htZlw9h/6z6ECxTCtpTh1tt9VFoahZNnOuzxVdd/5Q0IkzLPHl7+FzoFN311s0drFYr8//4nmpjoLItFk/cuLjxcQ5ykMUJ4NvJlJMK4xF4RAGfZlp2+YofmSLv9Stwi1LbUGRDxn9N/HU9Fnyv+jSXZ6HhVxAwdaSyQxnNGH3gkgspdbSQudJGZAvp619Bksc4fjWwvkthZvcRKamm6+SAkUFbr3FhxAF5j/3N9xwa/iSusKtnCrQRRT3z6I3XwqdxF0gOzLbp7Nyc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 09:06:29AM +0100, Michal Hocko wrote: > On Tue 13-02-24 08:01:37, Narcis Garcia wrote: > > El 12/2/24 a les 23:37, Yosry Ahmed ha escrit: > > > On Sun, Feb 11, 2024 at 1:33 AM Narcis Garcia wrote: > > > > > > > > Hello, > > > > > > > > I read this warning on Linux 6.1 boot: > > > > The swapaccount= commandline option is deprecated. Please report your > > > > usecase to linux-mm@kvack.org if you depend on this functionality. > > > > > > > > And I want to know if this impacts on LinuX Containers (LXC) swap > > > > accounting. > > > > > > swapaccount= was deprecated in the sense that it is always on now > > > (i.e. you cannot do swapaccount=0 anymore). I believe you are using > > > swapaccount=1 and want to make sure that swap accounting will still > > > work with v6.1, right? > > > > > > This is the second question we have had about this message [1]. I > > > think we need to clarify the warning (and perhaps backport to stable > > > kernels). > > > > > > [1]https://lore.kernel.org/linux-mm/2593755.Xrv9ptJ69j@sinistra.local/ > > > > > > Thank you for answering this question, and sure this clarification is needed > > both in documentation and warning message. > > I've found deprecation message was commited on 26 Sep 2022. > > From what Linux version release, this deprecation is included? > > > > I suggest this for setup_swap_account() code: > > pr_warn_once("The swapaccount= commandline option is deprecated. " > > "Swap accounting is always on. " > > "Please report your usecase to linux-mm@kvack.org if you " > > "depend on this functionality.\n"); > > Would it make more sense to warn only if somebody tries to disable the > swap accounting? Gah, I should have refreshed my mail one more time before sending my patch... Sorry about that. > --- > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e4c8735e7c85..dec75eedf634 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -7936,7 +7936,10 @@ bool mem_cgroup_swap_full(struct folio *folio) > > static int __init setup_swap_account(char *s) > { > - pr_warn_once("The swapaccount= commandline option is deprecated. " > + bool res; > + > + if (kstrtobool(s, &res) || !res) > + pr_warn_once("The swapaccount= commandline option is deprecated. " > "Please report your usecase to linux-mm@kvack.org if you " > "depend on this functionality.\n"); > return 1; Yes, I think that's the right thing to do.