From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAEDDC48260 for ; Tue, 13 Feb 2024 06:26:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F5CD6B006E; Tue, 13 Feb 2024 01:26:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A58A6B0071; Tue, 13 Feb 2024 01:26:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 493EE6B0072; Tue, 13 Feb 2024 01:26:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3BA216B006E for ; Tue, 13 Feb 2024 01:26:04 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B3A2440672 for ; Tue, 13 Feb 2024 06:26:03 +0000 (UTC) X-FDA: 81785795406.06.3BDD1BB Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [83.223.95.100]) by imf11.hostedemail.com (Postfix) with ESMTP id E929940002 for ; Tue, 13 Feb 2024 06:26:01 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=none (imf11.hostedemail.com: domain of foo00@h08.hostsharing.net has no SPF policy when checking 83.223.95.100) smtp.mailfrom=foo00@h08.hostsharing.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707805562; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NQZ9iH0cLPAKonqGtWTQ/zKq+bDrUnPPLA21lS+W4Jk=; b=m1gutsotnln3E6V+OQQHXjkmkKfFmPUUYju2HzwrqYMTFt3wj4wLWWQSJZ8fENe2cRcS9Z z4Hbw2MaWudv6rO5nHW3ZNLxJeslsKKmiULPptDYcOfNL2UvbOt66iODSocABZfzLRJoGb qoJyBmnyfkzaWbbQ0K825TOPWaLo300= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707805562; a=rsa-sha256; cv=none; b=rmuIewvzBt5fXOjK1CqF9x0vrnnFYEaS+cUoIIzYlI8NMPkP7lFOdwe4KeM2tKHhqWmf7T njUPtOdHR4iFwNyBMA5d+4dkGdpnMCin8OhBa4ZGyVVV/TFjt3zTQkJzC8ovuUc0Hx+o8w eIetBryM8b4Z3Fd5kaj/u4Vk/fNpKMw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=none (imf11.hostedemail.com: domain of foo00@h08.hostsharing.net has no SPF policy when checking 83.223.95.100) smtp.mailfrom=foo00@h08.hostsharing.net; dmarc=none Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id 55410300037E4; Tue, 13 Feb 2024 07:25:59 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 413414F367; Tue, 13 Feb 2024 07:25:59 +0100 (CET) Date: Tue, 13 Feb 2024 07:25:59 +0100 From: Lukas Wunner To: Mathieu Desnoyers Cc: Dan Williams , Arnd Bergmann , Dave Chinner , linux-kernel@vger.kernel.org, Andrew Morton , Linus Torvalds , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Mikulas Patocka Subject: Re: [PATCH v5 5/8] virtio: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal Message-ID: <20240213062559.GA27364@wunner.de> References: <20240212163101.19614-1-mathieu.desnoyers@efficios.com> <20240212163101.19614-6-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240212163101.19614-6-mathieu.desnoyers@efficios.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: ikuchrpnth4m7mqec4jep48scg8i1zwj X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E929940002 X-Rspam-User: X-HE-Tag: 1707805561-77391 X-HE-Meta: U2FsdGVkX19ogb6c3PnbFwzA5W1NSUjo0OAFWBvPtAaiL1ZwZnAdCGhA2H2MAGBhiTD0qrxjMZcoMYwvsWngCvDraBg37TLBFurqxudfFUiwW5LFh4hwk8GhGZoMkvN9OCMmhlvJVS3b9/eH6/SlycQxKLLrN5AR7iCgJZv1Ue6N2ayp21H4MqhzqvgwLCTUwQWdeRCl5/0pbwdVLFcD8FDGm8uDAavsM+VLv4GYLIvCgyTF/AZ1sIsVTpbP0FKBli09/t+ufElpJUI1hNxHuu2p0dFIbaTJvkWn0UisC6qCPU381FdU4EgOFkWQIomj0EcAmDtu16GrVsoB6J5MbAzmZm/Ml1/5UectY2H+jIIvlDLhnay0FSSeamUtqRoB/oE1aaQoaGLxA7ZUQwCQSe6FhvgWDVMBD+zYn0GPMzT+rcY351mi7aIEYoYMVUgR1jcAZRdqx7NCNc1z4jluJFDR7xAMbNO4YzTbNfjIC9w7kPgfgQlJKHsJvDRaUz/6h3DO81b5abLySXNSyCf7aRvZEM+YWPyhiUnyAHlgHkB+8GmLHXtcX9jE2b3+aiXAGSL8SZGJtUWmbya0exPXMHBClAf3S8IZhlT9gZK2tRn8CSRaKRA8UVYvx1TioJg/pjqab+lTn/lgogbhw/evTV/CdLwgAu3+NBew0dS3biZX9IwtBk73nL3hcMQfoihg0K62OBOG1u1chanR+kme/ewqE+OqTbPgVvaFsLtDY1W6JSdcTgv4GIZ0PBNBeHNN5jRtUal4BSXUlkneD7J/AbiKe/6ob60D/T07X7DXjA/WJMcKNFPzHO0PalwCWECu3oR+K2EIXI6EQ9v/Eg/9F3P82z+U9PQRoN/xpisj/62tpJaC19U7dWcWNwJ6YqJFyBm6OZyoN+sgIzmmSG4YumAPQPtUv4jYeb97GYNxWCaqt3ZLXlzfONYViBVEfLo7aLh5F8c9wC+2o6AAZZi cKLHwdbo X+zTSd/yHMQZdTpM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 11:30:58AM -0500, Mathieu Desnoyers wrote: > In preparation for checking whether the architecture has data cache > aliasing within alloc_dax(), modify the error handling of virtio > virtio_fs_setup_dax() to treat alloc_dax() -EOPNOTSUPP failure as > non-fatal. > > Co-developed-by: Dan Williams > Signed-off-by: Dan Williams > Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") That's a v4.0 commit, yet this patch uses DEFINE_FREE() which is only available in v6.6 but not any earlier stable kernels. So the Fixes tag feels a bit weird. Apart from that, Reviewed-by: Lukas Wunner