From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A04FAC4829F for ; Tue, 13 Feb 2024 00:22:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35DA88D0002; Mon, 12 Feb 2024 19:22:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 334F78D0001; Mon, 12 Feb 2024 19:22:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 223748D0002; Mon, 12 Feb 2024 19:22:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 123048D0001 for ; Mon, 12 Feb 2024 19:22:10 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DAED6804E1 for ; Tue, 13 Feb 2024 00:22:09 +0000 (UTC) X-FDA: 81784878378.16.D2B0988 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 2598F40004 for ; Tue, 13 Feb 2024 00:22:07 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of "SRS0=4RJB=JW=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=4RJB=JW=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707783728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CaCpyDeHXDa+8CkGkZ4BeT+7NNJLDIM9RFOacxKeyRQ=; b=7T9Nqa8riZbSERWF3j8wabm1eWIA/gBQm9MqHS2+vhJzw1Et9DPOiMTHs6ElzLgVGgYzz+ Qqi5XCyZpgWEbRzsTsoLaIeNifHl85ego0iTGx77rjGaCIHUGJ9PTtKGgtpubjpeSplZrA iLgfe8tTBTWUtHd6vyLi1MPyAaGsx2k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707783728; a=rsa-sha256; cv=none; b=h/Q3GeeXt3/j5pB6gJkEmwP3yQS/qkXSB6XmcWQcwggVfnqrO/oWnh8dpwa8OhGdC4r2+u kJIUz1QPxlRygcLCqgH7CGs175MmdcBB32rvAcayTlXYOcpMgiWhpu+pQ6JbByqLTwLTwE ysqmMtsGGuoNNTwD0Evrtn4p3Giv/jY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of "SRS0=4RJB=JW=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=4RJB=JW=goodmis.org=rostedt@kernel.org"; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DCD7D60ED0; Tue, 13 Feb 2024 00:22:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3ED59C4166A; Tue, 13 Feb 2024 00:21:59 +0000 (UTC) Date: Mon, 12 Feb 2024 19:22:42 -0500 From: Steven Rostedt To: Kees Cook Cc: Suren Baghdasaryan , akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 31/35] lib: add memory allocations report in show_mem() Message-ID: <20240212192242.44493392@gandalf.local.home> In-Reply-To: <202402121606.687E798B@keescook> References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-32-surenb@google.com> <202402121606.687E798B@keescook> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: tkx5mbbx84bpz19bx3kjzggq4br4p1a8 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2598F40004 X-Rspam-User: X-HE-Tag: 1707783727-483951 X-HE-Meta: U2FsdGVkX1/XGTVLhRxPInXwwvoIJRHDEH8PHsn5YpgzspY9HrePn/KpRkZLJMXGGiB/4qQqEh1smBzDKL9PoegRJUlv1yBm4lAz7rJkv89ixIau0pIh3VhyX/OGqcMOwnoO84luPF5wdcgsp7cZLDQk1QU6U7baCapE5UF3BA3UCd6jVUnKvopBDVlTaXeV5aE6LAEt56vl5gDVYNLghAM3mjaUTckE31T0WbTkeEzDh6IvOOE89ML2RND5bPCXTrSD/tgAYTy3sgNdFrtZu47x4GaXjhCjUMjbFGqblTDoH6CHrzN7tI/2mLfA3V5ODVLUTag4rnr13WADwcEoExtnF2QLJSlHdYhFF7TQCbZFGWZewSgqnrEv+VB5SL/6aCx7nb80slQhtiHFsHkEu84TOMkO7FkCXIcl140priYE3NXlCNoZErkWTUqVZhHwKMiYVr+DQydPklJ1/osu2gobSb0StqeyWzDP7SlcQRRvi0SnCUefaHDWMHxhuBj56Y8KVZhuKqpZlbFo5N2Jz2FHf+P5+rW8CwzZwOHhg43bXhLfgyWkwdBVjAYR14mKFSTTftioMxNIqrLRYsFoHCSmYrI+us2sR9xI6hiroNsFx/Zken9WvH0Vz/TIlWOjXQc3JaYLea2Unj7ZxpeDEVw8CG6P2UYEVfkTCGgIJkM4llukmDLxJA1JerWbxPJhgAm+c1KN3KP5JjXkSPceqefnANm+NxUtEopI/QpOe+o9tHc9FHjQMtBW+HZDaTZu+J+eE8/bNjIjqwcfNJy+n8smKOTYhqHVv3ctH9GnwbctR2HsH2wtFhQOJgAD0dBUus7ZuUlbhyWDPbWRPWITiN1+4Ucsx/R0VKbRJbKCN9itb36isgLCWK7xTEJyVVzfo4dLCQJNKxYkjBCLLsh8bstgu4FktKj8Sx7iM8VV+uqpz+vXlh3T2NhdgTmze6ZTfmp7qElqXjGrh+/2RFU PlCv9go8 RuFTTbapSoY8QbZKnrGdI4/TYAJn7Q+wtSQZDqZqRP6iGzPWr4XPPTC2JIKCr6TJA9MV5oEKl3ef2an5fa0sUnIhlcAcWZP2wDY3HpXP5qUJhEE33yKtHY7z6Q+qhv6zC6diBSNcF7ySHdrXnhUMWkjA2oy58iGXsl5zH+4CKklA5Cxg+9T3EJ8vWAd5orkvGSoxoeJXUwHYy7CjkjAli4GLTOPNTyQxTQxCI2mQq9ndG8w7GwEWpKbVxVfvln+bdGNgxGV/Amt+lkSYvZiNyH9QzcjdZZ6MwdiOXIMZ0eQq+snqA8A9sBjlG3lBJ0n4DstL63bOZz0FszbPTFQRDChVWO3CoX9w/g2o0cShOIXq5TZ0KYtS4g1CvFi2/xLRgMjPMJw1D8Qwowvdc4gmy9p1MYgWAjFz8AU1BM8JJ2lAPAdw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 12 Feb 2024 16:10:02 -0800 Kees Cook wrote: > > #endif > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > + { > > + struct seq_buf s; > > + char *buf = kmalloc(4096, GFP_ATOMIC); > > Why 4096? Maybe use PAGE_SIZE instead? Will it make a difference for architectures that don't have 4096 PAGE_SIZE? Like PowerPC which has PAGE_SIZE of anywhere between 4K to 256K! -- Steve