From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3F79C4829C for ; Mon, 12 Feb 2024 16:48:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EB4E6B009A; Mon, 12 Feb 2024 11:48:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69BD36B009D; Mon, 12 Feb 2024 11:48:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5153F6B009F; Mon, 12 Feb 2024 11:48:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3F43C6B009A for ; Mon, 12 Feb 2024 11:48:43 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DB48AC04B7 for ; Mon, 12 Feb 2024 16:48:42 +0000 (UTC) X-FDA: 81783735684.13.080FC53 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2045.outbound.protection.outlook.com [40.107.94.45]) by imf23.hostedemail.com (Postfix) with ESMTP id DCB2014001F for ; Mon, 12 Feb 2024 16:48:39 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=G5WmLzJu; dmarc=pass (policy=quarantine) header.from=amd.com; spf=pass (imf23.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.94.45 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707756520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y6fuWCc0jG1unLA95FAG0wKoLIczJavaPCUrOzohaZM=; b=Fip6Xza8inBQlW2iO+M0OeFSQ8WGRTcdHaVZ/cZCQanlu5iuNCDOTTFYtObbglimcGfCrV unvCXCtqfwpzeLynKBarfUviykgYpuCf+MZf+iK7NgpWJmYgpgX/Y/Ol7ncN4KjY35Yl25 +fPJZmlCzz01QJ2FdHoh40XvbGkBd4o= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=G5WmLzJu; dmarc=pass (policy=quarantine) header.from=amd.com; spf=pass (imf23.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.94.45 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1707756520; a=rsa-sha256; cv=pass; b=IFVvB66vq+BnZfFyuaJ+wcJdz2U6eZJWg+USfYSfu2s1bjCrtjjgUi9OFn5ZPGJLGjcSnw YBkMg/PmmGt6RVhzWh2u2/0XX50sZJHPofYsvr0VBwQAUnkGRqxJzenM5F3gd6ztnUBZyH ZPV3wPIOjvSMSaUl3s7zdIp6BYuh0bE= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VUddeyoPkPO/20q+ZoUGIk0dN1732sIBPvfUUKVowQejtn9HjJWFpDEU8P4MUC6fX0OWhDHTOOwqkbhcZuZ01LvYQuROa9NR2D3Wg0w7sGYuRUQGMxHNdQu93FxvO7F5YhMncX3W4EahP0v8pNmqNBQSeLug2v5uNb6fE1UjedGA7dwRgT7HYJ6LzPvX6fhBMtCVFMyIQF+a7VMK/Hxe+eIX1SwmNxLfbGU5LjZqnkNWH/JxYUDU5UNwxEBeSE3pc5aLBQQTXNFXIWcrGWDa56tEgtRjNRRj1vUKxya9C+n6+1t9Kfmdi0xcjsrmrc1Nz37cgls0dMp03k6vPSzcMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y6fuWCc0jG1unLA95FAG0wKoLIczJavaPCUrOzohaZM=; b=GBvOgtU14V01brxDBkGCKeG8EefQaeWZrucygvHQIIxwHDWNU+XI6ObJGZ/6cXtqP/Sx40ob//OY2ZlXz5aT173QFWHiGXFByEE4MNz6DolIgwGeX85ohNosY3396OnKQAbCq0FWTzvZ4TNRprWHRSffM3I0oX6SmT2Imw2DSltBwhMiMSPL8OI+LTomcN/wxhmsu3x1A3dR7Da1ylJnq3qTXN2w+NwVKz/WzKBjkuaO3r/1w66rTMM7aSOJfWx7ZtANVjr7lReDd19pzg6eqKvS2AAy/Edg1qaWitAkz3AD/igdNH71rcrgtYPYiOJL/FY6mKijJoyESFWZe7rOAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=google.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y6fuWCc0jG1unLA95FAG0wKoLIczJavaPCUrOzohaZM=; b=G5WmLzJuRtvFKYpAg73RvkuA6OqpKO9HOeaQCHAyGcwCuPysD8s0BqguqVSPA+FtDNygsrgVmRuMNpt7PP1CkLFXwPqAPDmWirq6am7tUL2qBm8vGKabpTitQDaeG6rN/VOufK+n41Oo3tjRxfrxdY/Zjw2str5+BqeHRgFW+OU= Received: from SJ0PR03CA0383.namprd03.prod.outlook.com (2603:10b6:a03:3a1::28) by DM4PR12MB6253.namprd12.prod.outlook.com (2603:10b6:8:a6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.24; Mon, 12 Feb 2024 16:48:36 +0000 Received: from SJ1PEPF00001CEA.namprd03.prod.outlook.com (2603:10b6:a03:3a1:cafe::21) by SJ0PR03CA0383.outlook.office365.com (2603:10b6:a03:3a1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.38 via Frontend Transport; Mon, 12 Feb 2024 16:48:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CEA.mail.protection.outlook.com (10.167.242.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7249.19 via Frontend Transport; Mon, 12 Feb 2024 16:48:36 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 12 Feb 2024 10:48:35 -0600 Date: Mon, 12 Feb 2024 10:47:59 -0600 From: Michael Roth To: Sean Christopherson CC: Paolo Bonzini , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v11 09/35] KVM: x86: Determine shared/private faults based on vm_type Message-ID: <20240212164759.35cb7gds4p2inprg@amd.com> References: <20231230172351.574091-1-michael.roth@amd.com> <20231230172351.574091-10-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CEA:EE_|DM4PR12MB6253:EE_ X-MS-Office365-Filtering-Correlation-Id: 33846d7f-4fef-4026-5e57-08dc2bea7510 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yrP/NggfU4d85NfP6WNH+aZMKyPZvL/Mm8TB3QCQiq2EaCKmRbdIrmvq7z9a29jG1yMaTOINWI6+SY+qgq9wU/6fvM22J6U4dYbtNML2wvqpi/fo7UC46fScodjFwztqAqCDc8edlefbfEkKAH4vIPJpL2HZ4ubey6KfiOLGlyFCobuDma46bgA56eo8eH7OZv1Kvdmrr3GIhXbrYE98j47TfvVvi8mjRhAeRDpivXteVPoPCPcYYPkdr/s9EEec/J01wfE2W5LmD9qnzlV8yLjeGF9kkWKokRfYc79VBHIR9ODBWm0oP4kgsE2pIyxSIY5i+PqI0scuSxWD8SJSUyppL6kag99pilkg+frF3TOh7yW0JcHSo6gNJJBcVzpCyj5BoiBPa4j7VuOEr1idycYeO/EVgkxj5LJIIvVUsSsqIVVK1tbXtgrG7JM0oiQWXDO+l1KrPjV3t/j4r/37WLmcBHWNSm2kHlXjNDgHPY+bIdJid7G6neNpvM/KwPQ65CUDV+30RaS7z2F4+i8k5QMalD5sHnQQoGDVrDEEbM1su4wrvTZCslpQZVxd2N1UE09pQWmv5Qnyhdp3tE+ZDGv+qJUktUsMOtV1dcQaZEVObYi2YNQXRzUyapukAxFi X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(376002)(136003)(396003)(39860400002)(346002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(82310400011)(40470700004)(36840700001)(46966006)(26005)(83380400001)(426003)(336012)(41300700001)(1076003)(2616005)(16526019)(44832011)(8676002)(4326008)(8936002)(478600001)(82740400003)(356005)(966005)(81166007)(70206006)(70586007)(36756003)(316002)(6916009)(86362001)(54906003)(6666004)(53546011)(7416002)(2906002)(7406005)(5660300002)(66899024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 16:48:36.4866 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 33846d7f-4fef-4026-5e57-08dc2bea7510 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CEA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6253 X-Rspamd-Queue-Id: DCB2014001F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qohhqbgzkp9oqr15z3j8kg6kg65npmhy X-HE-Tag: 1707756519-51553 X-HE-Meta: U2FsdGVkX19Pr20BsoBNNSsP8j/eSo304/o+KmjSl0XH69QZ9hvRa1cH92uEk6bx5/QOVgg0IYptQUhrroiDsntNkcZ4LGv4qwTrLilZlNXnGqziPwGiJZUGa0Zz6kqwG47MYsCdEprr5xkJJG0m0j5CnNVUFKg/tHKOAc4v3elC8Rv92zZ+6aY4kGd9gQGAwNT9pg3FbyVZYvWeqwfXgJ6c0+KgIPNDK1Z19OjWyk1I/DXZkMlw/w4NCc9yIxhlgQD8PJjRTN1lXuuPYBpru1YRtNTIbkZuuFqEJH8k49ueutPbq79oktCateOXWe1rL7mcXn/dLLbTsPSM/u7gMu7HzPnns+QyNRiQtCZIl9TFcg2W/aJwpzYttjjEgM0hAmgByiH/aVYtkD4sBll5d16TDliyTcdbt0zXpSG/DG4GOOZTUO51+lmSjAYUQXpZm4cCuetv7ceQh6iKEC3E/atf6m4B3WcUJh6SwEbFdqumZU/oDQKdPxzWTVI072ZvLfEnYM9dnEDssn2g7q/MZRI9vJrDYKnX4XeRQ/FNfsgy0C8mewTQyUITr18K//SMfva+5k20wL2c/fx3dp+FbA8u9rP2nAXwPvBzTO/r2iVbWmfZ8Fs61bfpUhf/mdWWL7SNcjZFXE7YukJp3qcUQApWCTCxNkCvdxnA1pFtVF38DA1WC1WIUzxtRLAz8/29WTCQQxdl64lykqK9Y8/30ZJxrzpiuWPK5l5sk9s1UBQ5wkdngKZPnnYCQZQYQFACYx2Ko+dfuKmOC2QiyU7+fyRTz8sKMWu3MCCp7fkYHT0DcoPcoWPAGLbv3dPCY68yyNgils50jrXczL2w2FwEbvvuSlDVLgVEbBkvrkO1esgqLvAMP4pOLj8BXss9NdztQ9O2GY4cxTH76yeLbuK6e3+dxebhczNJD8TJAPLBwB2YCFIjTnHw6RJrvSynLVHYEfghbDqzMUjFgFEIsY4 FqJYPCDN G5VLkvhGT3jPl3fEeSwe+2d33VLnaBwDJ+ut+ne/N4hBws/mEBx8EAF+GLOXJplJKJMtY8cLcoCWauEmT/Pst0Wb8gyExuZ7y9bXbqYSY+UOES+7bf5Yb3mI0JYsqmKJq9F0C/8JXfy1h/Br3H8rRqVgEeAFQVsXxrZ2OPzJlRdpH+VptgkdzLjA9sfE5mjIQDP+4Xj7ntSa9VBeDMrjD2uzM9dszLcGQpRrOGpVSQr8yxMVuyQ0v37/qm7xBFUq+SlHB3gOACLDnLb1foClf7y2gJjDDu8Z8+24GLnu32IsANAtj23EY8N1+63JFBUQz9j+slG5Vhq7hg8fledupI8kESHeRK//PEqvJTe6qmICM/nvHb77Xxf/DjLDngg61G4uZqxB1YIJ+a4aQgKocm51SSb2HYpZMc9edi6CnEqsCqAjt5DVKHy1ZJejGZCxZW9YP10w5Howb7U32BIfyBMSVQBdjozUim58BtuGltjKORiCnlXUeQTMNQwSIv10RbLqJCXypNNczVjs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 08:27:21AM -0800, Sean Christopherson wrote: > On Mon, Feb 12, 2024, Paolo Bonzini wrote: > > On Sat, Dec 30, 2023 at 6:24 PM Michael Roth wrote: > > > > > > For KVM_X86_SNP_VM, only the PFERR_GUEST_ENC_MASK flag is needed to > > > determine with an #NPF is due to a private/shared access by the guest. > > > Implement that handling here. Also add handling needed to deal with > > > SNP guests which in some cases will make MMIO accesses with the > > > encryption bit. > > > > > > Signed-off-by: Michael Roth > > > --- > > > arch/x86/kvm/mmu/mmu.c | 12 ++++++++++-- > > > arch/x86/kvm/mmu/mmu_internal.h | 20 +++++++++++++++++++- > > > 2 files changed, 29 insertions(+), 3 deletions(-) > > > > > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > > > index d3fbfe0686a0..61213f6648a1 100644 > > > --- a/arch/x86/kvm/mmu/mmu.c > > > +++ b/arch/x86/kvm/mmu/mmu.c > > > @@ -4331,6 +4331,7 @@ static int kvm_faultin_pfn_private(struct kvm_vcpu *vcpu, > > > static int __kvm_faultin_pfn(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault) > > > { > > > struct kvm_memory_slot *slot = fault->slot; > > > + bool private_fault = fault->is_private; > > > > I think it's nicer to just make the fault !is_private in > > kvm_mmu_do_page_fault(). > > Yeah. I'm starting to recall more of this discussion. This is one of the reasons > I suggested/requested stuffing the error code to piggy-back the new SNP bit; doing > so allows is_private to be computed from the get-go without needing any vendor > specific hooks. Makes sense to me. Based on your suggestion here: https://lore.kernel.org/kvm/ZcUO5sFEAIH68JIA@google.com/ I was planning to drop this patch and adopt the TDX implementation: https://github.com/intel/tdx/commit/3717a903ef453aa7b62e7eb65f230566b7f158d4 -Mike