From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B74BC4829D for ; Tue, 13 Feb 2024 00:31:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A68B46B0074; Mon, 12 Feb 2024 19:31:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A18B06B0088; Mon, 12 Feb 2024 19:31:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E0E06B0089; Mon, 12 Feb 2024 19:31:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7C36C6B0088 for ; Mon, 12 Feb 2024 19:31:18 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 49E7E1A0342 for ; Tue, 13 Feb 2024 00:31:18 +0000 (UTC) X-FDA: 81784901436.02.B91635C Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf22.hostedemail.com (Postfix) with ESMTP id 57DEBC0025 for ; Tue, 13 Feb 2024 00:31:16 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Pdhwk36I; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707784276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=flZnqd6/OOEmgqviJI0+73E/bOCz1vKp47Qn2/+ubUU=; b=V7PXtF1BkjPKsnIRxpqqcpr8wmQI4X0siKZQviOulQ64/i9wxaXAAb8Cx+xN9F4NgtQMnv wh4rE5Pcoz9FiCyPhENRhFiOVr2Zg3mkAGDYD1917k+N6E2XRjd1q05gwHL1pci4ReqDJS s5f4RAvLstRiv1hzTJAJJD0PnzENWJo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707784276; a=rsa-sha256; cv=none; b=vet6HupQM9Ka8oXsdjSjqPe3Al0fm0pHO8DYdZ35TTEdvjnKLToPQRbXjfbF91EbWqA+uG ZdSWvUhV0pDvxub0Dx7++T62jJ0byMFWaPcSov97IvIcimk2AguJa/BUwZ9z20Qo1pJH/7 RVCo64g7ZZRqOmKAPF6CZriHIMpXDXg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Pdhwk36I; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d751bc0c15so33348085ad.2 for ; Mon, 12 Feb 2024 16:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707784275; x=1708389075; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=flZnqd6/OOEmgqviJI0+73E/bOCz1vKp47Qn2/+ubUU=; b=Pdhwk36I2SCvSS/TvDNpVT6tF6Hfo6Ipl2qchQ0bjtqW7AnGilJQkQpvUxdzSNvhcV QOuoffFKpKL/xm0/HbTB4a5tx8KGZS3xMSAdIxJDsjMbRtC53GLqbuYQIAmcde+sdj1P s9eE+cg2EmM/9D/llMIrx2gX96Meu9Fdc+OWY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707784275; x=1708389075; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=flZnqd6/OOEmgqviJI0+73E/bOCz1vKp47Qn2/+ubUU=; b=SVuscv8FgJeZKF5W0mUYGWx1/Xt29oTRADM2T4UHzmODJohbGBwFkW+DtLJ/wzBAJy rVf2PFz+0bwgmiGj67Gj4Mg0/vD2TgTIpOycZd2Ds+1eLkHKN/0YILMM+dPvGNzBhFwX D4nhnQEaenQ69Fb83SP4WfgCLejqwQaiDvIvFAIFYZEs2TI/rEFAMJGZdYYCS+o7EQ6d rJhRj+Ukv6IizAh5cEOvGZi/CFj8P9xIxM8OpXJ1dDS4CFB90yv5FODbCbQpn2cpjVMH y1diC5yq5cBleIGkwfNxkP3CPOFzCe5ira/0BR9dxd9IovO3L/iT9ZOTZkArx7q5PVnV Apbw== X-Forwarded-Encrypted: i=1; AJvYcCXBG+mtYpQPtELG1N0B+behUtBIO+DDZ3VaVrLHSAUglniFcDfI5rHJ+GI930yR5JT+mg7HDt3YkPFSbMJFUMSkcJE= X-Gm-Message-State: AOJu0YxUcvqtLIIPTI7rk/v0HzxqYt2nMGcMtROTgBgvjEJBcnWAkwqv iVkysb+S0AHz5bTMOUpVgTqpAfX/zoxT/Zyr4DK0QioHJjjR0vqfwsNt8TJzew== X-Google-Smtp-Source: AGHT+IGtI0nd+TpK4HvdYam5YYNsXCr7zy6W58Z4/CxYpRHlwT07eMZ58c8YRnGsV/w9YPVMLJ6Phg== X-Received: by 2002:a17:903:228b:b0:1d9:bbc2:87e7 with SMTP id b11-20020a170903228b00b001d9bbc287e7mr11716581plh.36.1707784275245; Mon, 12 Feb 2024 16:31:15 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXP5RZAw1oi53o/gxKC4lO2ca7b/Hnqmpu8kg53cb7pw3QU44jF2cY5+OJBO6UbtPdy3/ScqJ+yf7mzB1hCYHjxvomlODDl0HkKLCMv6E8skXfvujDWmni/YcNWO4nMXhGrOxeccbAmX0B72Uhdj7z1F5wnbrmaXvP4ia+UngYKrTfi6zBvPXGEMidOrtC//iBWuwimaSSwoLAh48OoaqZ0YF1ANYUBQHmL2TutBWkpjIGS2TqAYs27TCeERgQwfZbIsk/DHhYmWHL6p0EVZwjG8KAvifMOUVVcXuNh1Sa6TZ5Y3gTH6ughhPUYB2LKprUpqD6i1Yz7tVX7fjGBIcttAAT1kuCW4DlKJbcvzbxu16bupxscwO3CZc6mcJtOQC5DZZZmP3f1D6uGeMaeyaJbEsWEk7AFmtq9u58uiyHBRALuJh62/GZXPJ2r1F0nOMklbBoF4iW9CYBCQtgHoFD0uyUAt8KSb+R4XjOMTQwrYL+IS9RM2lDNbNcOzOlvf+6JvYioco20iLyMrCWmC0+E4YuJKUqNJ8vVWQdsf98PnP/hEU3orVBxYPh5gtfPTRDTl4moSJd6XjdbNBjbbLzcrTLEl62Zy3WKE7PzvY0WHqAIVNOP+c190IQbrg/bVQ7AocPN5UrCC00c1njxdtRP6joT2g2496knPxnT1ET9xMrrP9OsLeKPtpfk35zb/iv8WgnHojmXpiLLth0P0BUzWN8X6lkI5KR2laOddod5KZTJVKomMvDvD7HL+USR5kLcH8zXQ/A806PO/AtJmJus0fbK3dJyVEPGmyM76zJXGfwHe5jZqO7MaWE3KHHyFeghxm3nQG+1YYaiym3hNfKgvV0KtiyTHS/FQMXcaOhDobBRiPLI+ACHtnugOFWPepL/5sB6MN/0TBNeiJdi3GZtVopPhwVAr3wc2le/ryrc9EWHVaNFML1m6i3+xp TTL210VR jtMSem7iKf9pLwlD1xOKe32gXxOwoZenfWojO9rGAgoL5/f8DL3n7m3f7O76PQ5HJmm8cMn8G8T0tmdyg6kXdXbH7zAvineHF5nWDbpiSc+p7Qzl9LSvoTFweZ031yvdC9H/13LxKteGYjgBszsOQbPAlZNIlAhFKtZ719A4IjJPj8Sa4f+5PnB3hQQ7EFcJZMXPgR8Ab73qaXggizB7rMhTpr7b0oX/nHZMi7JjTL3cM8z1K9sinOvKJbRKrk6hORHp7RfvhJS2L7wtdbAxv+NJmc8Ke+Q2MHUQ/lnbWbrqyBLDNaEAqR+qaDtj5gZBiHL3YUL3kSUGjMIffjdpfL9hOTSOhrRGDt3NkqEHX7V/l3kCpd8TzpITAIhtblcZFvE5WOXduAoVGVN65Y3EfuvzkLUBDIyViEtttLHJi1WHEA4WZ7gMX/6rDR5a0= Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id d10-20020a170903208a00b001d92a58330csm894702plc.145.2024.02.12.16.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 16:31:14 -0800 (PST) Date: Mon, 12 Feb 2024 16:31:14 -0800 From: Kees Cook To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline Message-ID: <202402121631.5954CFB@keescook> References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-24-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240212213922.783301-24-surenb@google.com> X-Rspamd-Queue-Id: 57DEBC0025 X-Rspam-User: X-Stat-Signature: 88x9639qprna35xzf9mc7dry19fs4c57 X-Rspamd-Server: rspam03 X-HE-Tag: 1707784276-563644 X-HE-Meta: U2FsdGVkX18QjBqByXdELnAKyO6kstB/24e+aXWAwIv+BXdQEzFQBtWERihCbfBISSpWTiIWTuFv4gPuxHCgGMlV3PVd6n7O0z7+2aYR8s57X+m1lwDyKt6hoxsLDM4uTJlroUcItpZkfZ/hgA1tVx48U6seCh/H3KIb9wGaz2TRLEIAPxiNSSPOvph6CKqN+TR2fD81P8gz0LZELy/Jp6TqYxA0XKkW3nbtMZ2XoGkB8QKNY+Al6oirnidNp+W0Txs24dioQFlnYhBSZJ8U+aEptQ06FpDMEemoIeFfRkXmgoS4NHqEugae9xbBiTAGM0L7KtxbxQSawG0PpSppYxhe8sRXmBh3trXlUEil1N0AeieandiEKsh26N8DCoPGZEXCd99mmnB8taPJ1ayAGcg9NzlNRAvyTGQEPJVrAlKwxj/iZGnMvHj0tgsPshVKJsHp8fT3gs0nHo0FWPEU8TfiBiGhOd2SSY6MZ4CFk60mNicX0o0Zw4VNXKNqrbME3PmABoN26sodEHix2zPw5UMg9X+URRcYz3U+wFcZUwCoSbcEQZzKw3blRwDGqZzP5OLqJQAiE9PSqaatw9nA1vg+W8FgIP1kxPZ3Rx4kVgbYccdPOa+eNh3JvhY6bPSKiEgkNC6+5Dk9A5X0S8g3dRu7fjJleLiAwMJylYKy6iR1hTCxusa9lljR3GVRG6ntizAS3aiLHBZGDHA4oZfd4xlyp2VLbfOqmD93qcE5Os0ch4+rRGhoQDqid1g9+beo6bG3ANoMICJR2mD0UhiOv0ZGUNSrGHS6s/yohM7fpJjkWUIBe2m/ghC/bRz68l0D7NXyG/ylvpQD21XBU+tVO3/TLw1mvvVrkTV6p4I/lJgKKY8kUL5H/EM8CidIJf2W1odpN3yV4aX6NDth/nQ/i3keJOPt7XMyh1EbLKD7Oafi7zsmRVFmFH3VQTP6dCRsK/1ceQ+lfwd9Cm/F4Uh FMiHeU55 qFM7/uyqm0Sb3TtVXrVx+IINwezLoDbn77KYdkC22oh38T4gzgs2OxPXSF24+UxFY8/PNH/638bnj/zdQyCcVAR55IyVy6ty5e3v+FJIZPLMFXtQMgHh85qYsJmtNsNNSPswpnTItm+gqt2QVxOVMSEIDwMD1N+z8B0Nh4B5MeOptfIZ1NpkDKm3Mx2QyMDpWjsP+cwiHyUeY67dxIzJwKkn9meowhQxKFn2cuOz0Iu6k3wvwrxWBOLkAddO8jeFEal+GeozLeiJ4k9lajFY5PSFV31zZDYichEifnH8yJWDu3mmYNlKg8BnqPzsv+QjBa/wIREsM4U0BmcmeRccry2kGWMroOkVwv6wzb+1Ask8CRI0bv/f1CX2wPCn/Bc2QW0MtnuxNLlTHomuara+couKf9tH3eczwIUfsYQVx11QiQAbYnaFC08tuJ22CqIdEWNr2ypxJifzwZdt3eVdcLoS9lTC7oZ0bs5unQV3sYEX4VheaCZygsjsw5FncVHTksFA6FgL0wggXNXDVTHRUzykk6FyGcabqICOk7iRbFuvmOEBELbrWKegy4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000147, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 01:39:09PM -0800, Suren Baghdasaryan wrote: > From: Kent Overstreet > > It seems we need to be more forceful with the compiler on this one. Sure, but why? > > Signed-off-by: Kent Overstreet Reviewed-by: Kees Cook -- Kees Cook