From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F31C4829E for ; Tue, 13 Feb 2024 00:10:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C7816B0072; Mon, 12 Feb 2024 19:10:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 350566B0074; Mon, 12 Feb 2024 19:10:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CA966B0075; Mon, 12 Feb 2024 19:10:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 07AA66B0072 for ; Mon, 12 Feb 2024 19:10:10 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A520880B19 for ; Tue, 13 Feb 2024 00:10:09 +0000 (UTC) X-FDA: 81784848138.27.15547E1 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf10.hostedemail.com (Postfix) with ESMTP id ADD80C001B for ; Tue, 13 Feb 2024 00:10:07 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="bPVs6/f3"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf10.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.181 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707783007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CVCj3/bUzmp/ihK8I5QTojP8ThiaEloYRG+XcmjM3wg=; b=lSgo4Jg+yI5VrdAAtk3rX4/YIRlTJWin+bnnslHeu84zYLv9tVjjbyihaKg7NtGKh9fmmI BcE7YK2swWpe/exxFy/AnquvrZCkVSNz16u6PV+5GTrl1UraMw6TTyxZkmEeYe+Kyj5mqY O67Sjq3+cH6sqWarEHtivu1UWZN1OaA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="bPVs6/f3"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf10.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.181 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707783007; a=rsa-sha256; cv=none; b=RXPVekudHytcABjoWqC10ZCuBKBCm4XvsjX0Me7xFppa5AKkYKXXZzC1d1R0Pc7FLkT4pE UF5ZOXfGXtfwAGe050OpDVYa9FlyemkcY84ZDvIKNAXPYve4GRARidCd3FCEp8AvrLjbnP tyhWSGzs5fCPZbDJhVIrQc+sRZ1IAz8= Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6e08dd0fa0bso2581207b3a.1 for ; Mon, 12 Feb 2024 16:10:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707783006; x=1708387806; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CVCj3/bUzmp/ihK8I5QTojP8ThiaEloYRG+XcmjM3wg=; b=bPVs6/f3F99j3gM2YhArvlWfpd/NgKb2Md1NNz9bx4LdvGRBeTktCyasKyh1Jr0a3z siSj/EczkAdWtWjmt9dLYFl5RDbM6R58w823+KK0hNLgpVNhNG0Vf4wbjhDEvYHgG6TV z7HNtKH9W7RbyUx3s96ttGYLyWvm6Wt5j5hpk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707783006; x=1708387806; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CVCj3/bUzmp/ihK8I5QTojP8ThiaEloYRG+XcmjM3wg=; b=IsVs+fp0bzR7QbW0yDgZWzYmux61GeNA6zIUL7e62TqjnbLoA4IrNwbO04nk8ZWbjW 53u9cFw5JzKtc+ExxEbn5w4jSrwzzGINDQQhTj0ZqVyzXj5M23bBF5MaMJLs5vHWqp4b nYA80it5gLgkQSZjbgYOqy8I555CxnluAdLeSIqdB57qdC6cntUoeDVGqLE5Fja/4jm7 vMpOwlfRIoIyVcFShj8kos+W8oA6NQ2Rnfjwl+ir1fwufG6Lrzd1yK3ABp0dkasfchkQ qdb6hdYn245VRpzBVwPXBzYL3+NCbQY9Jp2DnrE8GneMcPGFwjOHhJMJNfXi8jPbm7t9 9gpA== X-Forwarded-Encrypted: i=1; AJvYcCVU/3qMyptlEUgtq4TGCafTANGopfowapguN+gbrXt5AiV3HRZ3X663QFg+0dS2lNBZWFFKCpQYrlHw5yGYZc1zQRs= X-Gm-Message-State: AOJu0YwPhuBUD0s6Y4dr1Gpwvyk1MDww29bsrhNomdUDY+bOJBkOuBrt s8UdCay+jUX98gx9m3Bc9INtKSbqcFbcy7JfcNKUf9hvMJ8pYL6l46/B6RsuxQ== X-Google-Smtp-Source: AGHT+IG8+S21TZSfYUwOkqoCRQ2RcEjzwmIfnhikattjnuWv8IGFv24QLPUEUKXJqadHC1uEKqY6tg== X-Received: by 2002:a05:6a00:4fd5:b0:6e0:e64d:8da2 with SMTP id le21-20020a056a004fd500b006e0e64d8da2mr1514832pfb.14.1707783006424; Mon, 12 Feb 2024 16:10:06 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVSwAySHXKx1pUrrLt55Zdm1EhMhKCx6ob3G7LFoadWJ962SsWvGkNWGLwN8ABMsjJcHo82VKcqfHdaZMMC3ZX8bsOVpIAn1GVyTr0qMTj+0OHs77XxyPp+cneEpG8Vvu5mriNkWXzs2VGJglCc8a5uMrzZ+Q5EPTh+PVyomZkA6d3etvY2gW+CpacE7VzChzFWp0UZ1v2PhmxtPs6udlgCYrEp7N7DewKcRhvMyjTwFZvVVZraA/zVXr/BI6kbq8hRw6xoQM50BR0VPsXtCk4Soe3KO59VQcI9uqOtzno5uQHiucZV9TFt9Pv0xz4rJEyeewF62QGqRaVl9h/Eig9qPBbxWxC1ekmon24FxjhDlLHtGfAmL0JIWsvJQtJ7i4pvrBA2ovaVbN2Axl3vHJoeBKDuuQ4Ra3I80lml2thHScWSw1zi1azW3xy7zwY4UCUlrnAhz997arbpJ4kkF/UceHW5D6V1zGjdoNrme3bVYynn5mGhECWbYhZHrqvoPyHFtw7ikSp/Bv32HZkSDIwVlIVDJIDlWv/4EB2g/k/CI6iJJITUhQwQr8NgkzqRpFBAdbHK591MrALuoPYthE623YQRoccEH1Y/S69Un788TScfzp7RkqO+EjrUJ1HSVlRHKOnbTFUh4EcNaPebtMwoKKNX8th7w/X4/yxvG+LA7ZmeEzPdo/5q7aoEzt6fFhjfV6+heqvroMrfW5aBQdGBvM8yclut2olJC7xlKUGdy3ztrhOyW+3yOtFd1aRJXgwfQBE5x2/wpOF8R486MqC88WW6Z0szhjFEtD8IJGMaf1XCf5/8wrLSwq4Qa0nyspIw1nt4u7uGbzr3v0Fx/SUDor7gXB84RKdnn2XNZUZjfIxgmPKkbUWZ/7ufHh6LoWnm8LhTD/sAftbB++jmE9X+vjsBGOGkAXfTIeNmR0BaSbjzySyeQL+yYxgnyM sTVf8Qme En4lxzghXl+QOTSW6G6gdCgLa36wILi2d3S4xdl130YDgxqd6TCrOUcYs5xFHYBMIuFlgGmo3CnRJMY9aYgCzR1ISbeFsqPfyAA7rF/aII4LP72of1YZH2Se//5g8e63sZ1MF7U66+4RPqz/o5A5gROZ0ZfqudQZJEvPThrbhckl5wTKT3morlEm74sYnBBbdB96L42wH0rBauEV9p4tG88xpVtsftmI07eg2BDLq4sK/7hSnZnh9M844sZLvgDay0rEINch5uVe22p7GRx+KHa6flRQ3HzPC+5z968sYBBhYC51QtD5SqwBYD4HZfJKlNK35MZCkM8NhBbe1zXqdlCwI4vhy/oGXTKH9Z334UzYNQrgpJKCQHwBj48WTTA+rfuF5IG9Pj9443fMheAHOAj3UI1rlvs3n3JGxrcc18GPzYe0+OyYdoHU7mPcw= Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id z5-20020a62d105000000b006e08437d2c6sm6612506pfg.12.2024.02.12.16.10.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 16:10:02 -0800 (PST) Date: Mon, 12 Feb 2024 16:10:02 -0800 From: Kees Cook To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 31/35] lib: add memory allocations report in show_mem() Message-ID: <202402121606.687E798B@keescook> References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-32-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240212213922.783301-32-surenb@google.com> X-Rspamd-Queue-Id: ADD80C001B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: f6wzyt9oe7zqsx9ndhm75t3on7wyx975 X-HE-Tag: 1707783007-60797 X-HE-Meta: U2FsdGVkX19hkfiZK5sI5FwFMjpRykeVf/X5mi389agJIxFILwSSF/hNKl6Vhnuzx9v5sObnttJO02trzTlBaAh2v/EOQRoBksr3Fd9tIFwJRbxBvPOyAD9M1O+/EAQL2mI0U1M1a8rsUr3gtucZikRjfarnibgysK++h1dDqQHrPldPDFmARByOghSJpVHkFQyb0KqMfnyYK2j9HabGYi2MGbGiYNJSwDeug+yZrPHNosmOv2NnYidWgfauw1DbUb6xRJI/HpV/m3AfEKShPSR+kGOcQVl/vXc7zPbjXtIaDIhtKklHXnjuDX5G5jli56dZWS/W3bwUhBZywPCNHLDhjk8qz2hCdjUiI9soyflfQQwAWBf27eGLi+bQyxOemlVS6eFVMmys9zqTQH+ISHNOdsuvB6KA+EW/2UHElb0IlD//sz4EJnjqtfG6CCu3K8hmwfFkRFSjZlLb46Dd209RSHX5ZNN+Mh3nfbUN+OyF0MmC8GNj9IcEmDoBWVN3ER9MkuuqAhQ8LcaRsTqlJB2rLBnUr34PQZY3PhPlyBMLE+T33Iu48/yETd+jNGp7hGF3XPKhzYwzuzJgF84KmJchmRiJFzUdXPV160K3OMEqP3e9hUHMPU7OXJKT3eAd+cBgUVcwerQaJsCqd3vLHoDtFEdzWvXuhZSXOnhnYBIBINkrrRMnzb5Kenq+i9s/J+zOjK8hFE+KSEQx/Uef1c5B980Q4A5YZcYPCOvf3raq2WnibVMO4WN8VqAQArdsN4m7k/vXPQXDkdvc649P8QaiKNs6iJHyMOFRwjzIrcuQwSMYJWf3fXF+LrqGJ5wj/yLWyEAiCHQzkXYgmCWgrREgJqkEBrScO42nuToQIPxD9fqgS+VURFP/WI6+PUyeLZWjV5ZSdqRWtSzzqJj0lA+8colPDAoz4Rhkkwacyg0VB228naXYvaptlRmHBZfMuDwR9FfdOzefg8jvz89 HnrqEHlv rWUpw1Afo9yx+byvjaOkKiCc6E9YamHKRCfX/FosqKhWm2WStrSX8TKJbu8/rhsKdGvUm8y45erWEuPhk1oMSfEXdA6tWrHL802+wnVD67/jY776wdC3x4LY47aJqZkBLXo8HNIpR8EiVFeDiMhOaQK+36NfJh98ykvczc81OfthiPjVm19Rd+3mdCVeMjPa17q5TzJAJrIW8NitPDSvKG9Zn0zqYmmaJLORVNmTPuXVGvXLPKpxaMFbgd61Ss5xKjqP0kdWsi0MXu9nPyCv0Aa+RG0Lf+RBp0UTgna0j3xIV3u4TrBoEKoy1C30pfZjea0nbNZ4GusujJ/5z4iEI3CEBp6nx8mgP7nDhuHeabTzJe7fF65YGHI1MOCpMQtzS0kWyNQqHdq0srxpGBZsfT64mJf4C+LFM7BomACq15XY7oLtvRRkPm/K9/qW7atYSgfMBUFKvZdR7TNF66JlUJJJQ4DpgajRO1g3HgSAW9mCprSuygjgZz0kstcH+cQio3MGHb8mabmISegj/YpQRYdIiGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 01:39:17PM -0800, Suren Baghdasaryan wrote: > Include allocations in show_mem reports. > > Signed-off-by: Kent Overstreet > Signed-off-by: Suren Baghdasaryan > --- > include/linux/alloc_tag.h | 2 ++ > lib/alloc_tag.c | 38 ++++++++++++++++++++++++++++++++++++++ > mm/show_mem.c | 15 +++++++++++++++ > 3 files changed, 55 insertions(+) > > diff --git a/include/linux/alloc_tag.h b/include/linux/alloc_tag.h > index 3fe51e67e231..0a5973c4ad77 100644 > --- a/include/linux/alloc_tag.h > +++ b/include/linux/alloc_tag.h > @@ -30,6 +30,8 @@ struct alloc_tag { > > #ifdef CONFIG_MEM_ALLOC_PROFILING > > +void alloc_tags_show_mem_report(struct seq_buf *s); > + > static inline struct alloc_tag *ct_to_alloc_tag(struct codetag *ct) > { > return container_of(ct, struct alloc_tag, ct); > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > index 2d5226d9262d..54312c213860 100644 > --- a/lib/alloc_tag.c > +++ b/lib/alloc_tag.c > @@ -96,6 +96,44 @@ static const struct seq_operations allocinfo_seq_op = { > .show = allocinfo_show, > }; > > +void alloc_tags_show_mem_report(struct seq_buf *s) > +{ > + struct codetag_iterator iter; > + struct codetag *ct; > + struct { > + struct codetag *tag; > + size_t bytes; > + } tags[10], n; > + unsigned int i, nr = 0; > + > + codetag_lock_module_list(alloc_tag_cttype, true); > + iter = codetag_get_ct_iter(alloc_tag_cttype); > + while ((ct = codetag_next_ct(&iter))) { > + struct alloc_tag_counters counter = alloc_tag_read(ct_to_alloc_tag(ct)); > + > + n.tag = ct; > + n.bytes = counter.bytes; > + > + for (i = 0; i < nr; i++) > + if (n.bytes > tags[i].bytes) > + break; > + > + if (i < ARRAY_SIZE(tags)) { > + nr -= nr == ARRAY_SIZE(tags); > + memmove(&tags[i + 1], > + &tags[i], > + sizeof(tags[0]) * (nr - i)); > + nr++; > + tags[i] = n; > + } > + } > + > + for (i = 0; i < nr; i++) > + alloc_tag_to_text(s, tags[i].tag); > + > + codetag_lock_module_list(alloc_tag_cttype, false); > +} > + > static void __init procfs_init(void) > { > proc_create_seq("allocinfo", 0444, NULL, &allocinfo_seq_op); > diff --git a/mm/show_mem.c b/mm/show_mem.c > index 8dcfafbd283c..d514c15ca076 100644 > --- a/mm/show_mem.c > +++ b/mm/show_mem.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -423,4 +424,18 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx) > #ifdef CONFIG_MEMORY_FAILURE > printk("%lu pages hwpoisoned\n", atomic_long_read(&num_poisoned_pages)); > #endif > +#ifdef CONFIG_MEM_ALLOC_PROFILING > + { > + struct seq_buf s; > + char *buf = kmalloc(4096, GFP_ATOMIC); Why 4096? Maybe use PAGE_SIZE instead? > + > + if (buf) { > + printk("Memory allocations:\n"); This needs a printk prefix, or better yet, just use pr_info() or similar. > + seq_buf_init(&s, buf, 4096); > + alloc_tags_show_mem_report(&s); > + printk("%s", buf); Once a seq_buf "consumes" a char *, please don't use any directly any more. This should be: pr_info("%s", seq_buf_str(s)); Otherwise %NUL termination isn't certain. Very likely, given the use case here, but let's use good hygiene. :) > + kfree(buf); > + } > + } > +#endif > } > -- > 2.43.0.687.g38aa6559b0-goog > -- Kees Cook