From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 030E1C4829E for ; Mon, 12 Feb 2024 22:15:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C5E56B00BF; Mon, 12 Feb 2024 17:15:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 84F516B00C2; Mon, 12 Feb 2024 17:15:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C9096B00C3; Mon, 12 Feb 2024 17:15:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5A9486B00BF for ; Mon, 12 Feb 2024 17:15:29 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 11CB4120574 for ; Mon, 12 Feb 2024 22:15:29 +0000 (UTC) X-FDA: 81784559178.02.99B4924 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf14.hostedemail.com (Postfix) with ESMTP id 2C971100012 for ; Mon, 12 Feb 2024 22:15:26 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=RUFLgUTv; spf=pass (imf14.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707776127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VGyor2jQd80o7izL2Q665nn1vzR3SBtHBIgEg9t9XJs=; b=Cgt6d8u7doU+XdCRJ/7+fYITdc7u5lv7j64BZ3/PRH4hZ/QUzMjkZ62wcC+CTVl0nbd4q5 wYl9jbcMp43ivBJKyKGCicB+k1Jnu8MwsziIE5OXAeiqY96b6YCO8JX/dDSMONGrN/0jJD Gbhep2wMwf0X4Tbn1o0mOnygJSkZKXs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707776127; a=rsa-sha256; cv=none; b=FfXsc7hztUdNe1JM3o2jKdrLQ1+3mt5Fy4iGIMvXHpwllra5MOOoMK/PC+xDExA3EcQaL9 9dNiTMJX6+SiQ/sJAQIZ9OQ9Z40/VToEoXgGEl+6+ZdPgcYgUi1K7YdffDj24x+uSGjR8B 7BDEfhp5cUlnci6mDRKrTJBdvkjCFMA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=RUFLgUTv; spf=pass (imf14.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-5ce9555d42eso2888624a12.2 for ; Mon, 12 Feb 2024 14:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707776126; x=1708380926; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VGyor2jQd80o7izL2Q665nn1vzR3SBtHBIgEg9t9XJs=; b=RUFLgUTv1yUrP+xGlp5YqPGb0w64iX68hHv5qcC9Sj6B0PwVEQu5VxdYHL54HVjPaD zI5kuY4uyrasGxtZFmpL5Jzja0IE0/PNsULjDZdLTNtCsbLopnisTCGB+rJx0yUQwAUz DvLWk9FCyxeU0+339ZPsRU5A6l80XhxYxqDqA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707776126; x=1708380926; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VGyor2jQd80o7izL2Q665nn1vzR3SBtHBIgEg9t9XJs=; b=Ou7UT6VXxM60uBYtaXSx/Vc/iSXBprLPvh+9mBgHQYx2ArRyFK5yzNI/1fJlPok16k uDzhvg2axMgHO+zn5rsJlf3hw/mCxryNfRCy0ATnivNSLnt/i8z7CvXr9yIc+HielOtD 2zHJqwfL0lL4MrTxBwDig3P7V+r3gII+1BJvsmbD2/p1qaDqELuoeKEs8yBNLxgvJa36 PpuNdvIMEOwSYGeVCh/MiGj6bxyrMMLbOE1lwxT/2H66zBEzvknqqUYeiF7H1ziumEta b7i19JiyZEwW2orn+a4EfbyoBLqQ9nHaD8Dxa4iA+fe/5n4/GrND/aIQ2KJrsyJVjlxG tlxg== X-Gm-Message-State: AOJu0YyiZdCPyzmKGRkqEAqo1Fvw1bGg+TuMgRmckJhhnXpSK8TqRGiv KEgq5dn54vPleEIp7rDIZMwC4R/zlKUSsFG9laFy4UHglO1mdvi7+iJSVd7Gzg== X-Google-Smtp-Source: AGHT+IFxIrD/PXb/vb0Lotbm41uUEhRD8ByydkeE4s+sXY1n0vGOexIhISKj/rtyIRdw/y39zUdOdA== X-Received: by 2002:a17:90a:f014:b0:297:a5f:4fb with SMTP id bt20-20020a17090af01400b002970a5f04fbmr5735341pjb.17.1707776126081; Mon, 12 Feb 2024 14:15:26 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXuS8l0SNNP37L18DjB7CHigtOpu2mBOh2bDf9AXMn3h0c7pDY/OuL3AIxKk9ZAx2n91f9GyBGnJ0Axeve48hw4QnnjI1dbienG7TJ3+hOwIyzrNUmxZcX1BR+yRe8iuuNcX14w9s/m0+HOPBvGZaMcNKT8MXNIoja+c25zk+T2ysfbj5F9HdjgzzoF7u2GjsnCbL6IFkH08JwX5WXhOLQeJp33JetEDNS8/WXwzyr8tQekx1rqQOMCzxTl7xVMB0ENp0Gm7llaix/ILuzr6ZO+VwChvhtBArqLgANwAUFrBP0f8RhEnpn/PN/b9tPP7R/0oLgaOusxEtM5DqAIwSPQbsV8PBd0flIh/nMXVhA3KGD1lubX93MBbdiHSPmkei9E/wqSQ7QmFXyC2txaiY9r4Yz8yyD/3ZMvzXeJnUJKu8uoa13hIWJIROKH2yB2KGUoayTLHlUEthuzLhT+Iwtd/KcdfzA6oTHAEts5OcPsdGGPlc+iSVsfj79/d90XX9nrbgLZQUqkJJtulMdohk2KOSh8Yvx68sFUVNBwrD5qtkec9EpiHUbS5prNNvgOKP0SFkyQZdk/mw6IZ8Hfn3x3qqRNimDvYMHmNRTL6vv+38GOWP+UiiCHher3il3xXtz9pLlMY+Nsx29tW3qjog8DEdApy0+kpTYajR/N4oWzKVr/xTRW83L/sU+tVSQiIlwJLjnuel1C2GM19JRUtesT/T/I/BTApvdjZHycOLQ1RKO9XOHLDhcEKV/hfd5xOilC+4PVisCzzNQRFYn0qSVJnxRAfBs3Tq0qkWUMG0vdvcQFCEDgGlO621YwKr8LaWx9Mdsu5TiQ+pcbIX8vHgNorR04rXV519R/AShWTnLD4UK/iwiV9upY/ExnRiijMvHzRfFqxKLuIRK8395+YqbHPWBPH2QbJoc8RZHPkC52Iw1o36q9rJ1k/1QfIb Jb1PXkB/ C8OW4pcZdo36VtoZYRs2pFwP78+GTbDERSlOYcMTo27uSvTPSlyW7V4owwaG1Zkb2cBiLnEsrN6ryjkOYUlbqHSGnvHY3dWuD2HXMP0N+nPYOskP0jkRjoj/S3x0W3+38OBo7TIT+TUfzvz3fDonfSVPrkjSbRkCWO1mIKl3Xr/ju6rZRZOIroO8gSnQKMVGk/M9U0Five32eQdmoA+dw/V7GFNcDOdL+gZ2lcXUcbsdurcpX1e8NARv2ibn/hbQ4jEIjHTneEZYUjtWV3hzQLU95j0Seqe8B8RmOxPOo/Va4TeXqjCK50coRfWXVp7IkUkVRn7NIAQ+gkOIcXKEtZRHuyTm1VUujiD1I8lKCbq2SeWDaqvoy0oVY5ovMkK8qudTv1GGv+Q3m3zfXiUDSeO/6KkDQ7ovK6Pes1qCrdXrUpXqSrf3I6eK31D2I= Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id pl7-20020a17090b268700b002970f177ce8sm1056099pjb.11.2024.02.12.14.15.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 14:15:25 -0800 (PST) Date: Mon, 12 Feb 2024 14:15:24 -0800 From: Kees Cook To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 08/35] mm: prevent slabobj_ext allocations for slabobj_ext and kmem_cache objects Message-ID: <202402121415.77843B9D39@keescook> References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-9-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240212213922.783301-9-surenb@google.com> X-Rspamd-Queue-Id: 2C971100012 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: najhiysxiw6xg3uspcum7iqnjafjpu9y X-HE-Tag: 1707776126-129208 X-HE-Meta: U2FsdGVkX19blMEt6cyBlwVvad5LF4Ref9T5s3RtSZcvkagZAk1mQy5wcSq0bEFyMzBsK7PWLGH1iJ8X4umLwM9wgzE4M3Kj5UhtKtSPW0LGJWP3d18+aU1a3o5AwKyCy9X6y81CwVHnoCwsUp1Otl1gwIsna19oifeVKCAsW9DaP/CwXssfdCWtj5OvJjRO/V/GkL8fE51R9YIxd+ceMGenBlUCF1jWBgMNdkPr3JNRzpepPAhHPwvfGbZuwQWrKqVRxhClGIktyYgcaHJNSIVrsG5wjNT2Vg2L61+VyrcVswxPiO5hBYOzjpR8UfqEuSfLhMpRjInq3ObRs06uT9o9/q7JwM5urPJiGnjM7Frg0v2T+cEJs4KpzRv3xGCVeUbsrOCTGIHUmg5JwNx+/ceGX1TivjUjyKo8AgV3dKXNgmHrmLMeyBsDyiurP7eSCzWvJu7jZa6gnvESCkqA3KNCKhwyhfda7pWZ2s8Kq9ZSGpQwIjNMG+WC+LOjdqdn1Zr+ZJxuCAoxshu52e/PA+1oTh1yLTTKpbN8wxSwM2050UzG8DULfhgw/+OHLdzPErsdTvWbTIcjr4eKyNfH2ZRnf2FYygUZ1SpNwvmZVufXSKqEgzsKZjnJr0ly5+zPlYJrQ49sDag6cVPErAp0yXrRZjsvhlTstf+mdoLJ0GC75xJkcqqyHbwqjFIvSE/3zu/oaJYzR844n0x0hkoGwkDJypWP4dV9zq9eYC/sH1KOHgj3FneT9x/grGbaQDUPZe7M5WRRrtqQMvTWHgWkTtGno2+5YgiZqQsqJhrjI1kqt0+LCRro7TqOeq0SbgWdS6vMY0fF48PtqRcTPW4rTY5ELDjw7y3wagtZlg8G+/PKQ3lsiskxVA9KtQgkCW2tq4sJXv4Ff5+9pAF2362P0C8bD0ahRizTInO0dMJjsb1u90i6toaWyv2Sz1nkwZtNlGDDU56zJapeCtTyin1 04xpsQl9 t5tt/E1MdKtLFQrZwU1Y9h0Q2vvXGtBUS3xV5mHoZxjM5rNd+iKgkucLlibr2tBblbtG4od2qjgQ7JW9RevZJOulKf7QsOYiDsu/7+0bvAFq5JIWhcSshl7qg7r4GeFLniswrQa+d689PuGK2hq8qemRcgiFH1pz/FmL8tyLhtrO7bNApu+jx7tSt8JGPEsUJkJSTCS1iM7MjdrYOV4WXTLxYJFnATrHy+mMFZ+GfT922FwiGaVRTZzKJxGSiipk1v2VRlQDW8avaBqOPM2vLafLNt8zJBiwrmFwPWUYyHvN/ZBVoDtDiHzQW2pSSnF/fuwYLqABuEqzbnq6axtogmf+ZKor2g2EeCbTt4oR0hZrAM0c5klKqujlq7Q61METRGaHQDEfhmMEmYqMcFV90rv3TaDP9wboLXT8mF6IbfVQ7czrG66aRQl+x7PtDhW4TLonZP9DilszD7nd9CQ4MEX6IEkaU/yD39vI+1o3SWxAYWbkUrNp4elv+JrWLDNJS6SEHw+id3D+BjuQTru2dDlJtWbKkCIX48UvMnWct5EnzdD0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 01:38:54PM -0800, Suren Baghdasaryan wrote: > Use __GFP_NO_OBJ_EXT to prevent recursions when allocating slabobj_ext > objects. Also prevent slabobj_ext allocations for kmem_cache objects. > > Signed-off-by: Suren Baghdasaryan I almost feel like this can be collapsed into earlier patches, but regardless: Reviewed-by: Kees Cook -- Kees Cook