From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B26C4829E for ; Mon, 12 Feb 2024 22:14:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D336E6B007B; Mon, 12 Feb 2024 17:14:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CBB796B0082; Mon, 12 Feb 2024 17:14:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B35BA6B0083; Mon, 12 Feb 2024 17:14:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A0E9D6B007B for ; Mon, 12 Feb 2024 17:14:20 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 743C6140234 for ; Mon, 12 Feb 2024 22:14:20 +0000 (UTC) X-FDA: 81784556280.08.90552A0 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf23.hostedemail.com (Postfix) with ESMTP id B8381140021 for ; Mon, 12 Feb 2024 22:14:18 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=UdEszgBd; spf=pass (imf23.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707776058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wZiXjxKnrMyz6iBNN8FZ/8Z5umOyXaSKjAB1K7uHil4=; b=Bl2NSBuyLnEKNGSGD3oGXbNobXggwM2jPiLz27V+34xptOJSi+WFH6fObyMeqbIcqnVTCx xWggUUXANN+E1295jgPDLY5mrTzDw6VB0d0HqoZH8HGMEfrKwG4Wh46K5L/CHAAmC9Zcov GqLDkEw+fDC6jTZtNmdLhCHtPtMqNTw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=UdEszgBd; spf=pass (imf23.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707776058; a=rsa-sha256; cv=none; b=EJEPIXH3bZjHIlKpsSwy6ZXcL3K+bVrjoC4LLgFbXoZ8hbBaaS7tT1IhnFReE8qMgbtlTy 6kjJr5YPuNqj1iLqzR/OU5mtiuXWqODJBb0auoqpYIAZxRGX1YJdwTSBj0j3etNqf3s2W8 n1X5YCog2+dJBq6o6+LXlv/miW3Sa24= Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6e0eacc5078so680311b3a.0 for ; Mon, 12 Feb 2024 14:14:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707776057; x=1708380857; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wZiXjxKnrMyz6iBNN8FZ/8Z5umOyXaSKjAB1K7uHil4=; b=UdEszgBd6ClXe3emVK17nvDv+/YsxP7tu5wViy02+UXF6Fg7WSk8e+KboVxPM+tQUY d3bffcJt1IwJ62qFjc2r+34fWsogyCLo7RDUAGZrwPmI05ENDTQb8M3L5DhPfed1OPAT ipw3ofH0jKuai+XegwwjotfKQtqNL07jxiqfI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707776057; x=1708380857; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wZiXjxKnrMyz6iBNN8FZ/8Z5umOyXaSKjAB1K7uHil4=; b=ixj/s4R2jwzOPursLcSqyNwwFRgyCzPKFPDkybU+TR9WFYB7NoUAkVlpnbnJoZC9Ik TPIoi0GQMLgfuJi+x9saXewLeIZ6xq+zibOg3qugSXGvvhJ2si/4ZgooUygMm9nxpY5A G0HMal1KJt7ObOU11EG9noTlUQrJW0frnMflOV5EUaROlqXG76P8TEIBsSqYzj+GArkm s7KVP89O0u8BemSQKJmLjFM7fV2T+3JrTx7AENFy8on60K4FuARGQsk6PmhGaHbLxYZh RhqixHoHUtgNT7XdGX8GxwXPxmrZ/zXAvtGnx4ydnxfxUBJ4zbHg07Gl4vLl1LmHhgoN uiKQ== X-Forwarded-Encrypted: i=1; AJvYcCXRdyneqah9GSSx5BLLgXbK3J+Sb4QKkpfanmE8E0zEv0Z1wmLA1hxUaKocYZSldjsXnTxPhZFHAPwq7SOxcoVBoc4= X-Gm-Message-State: AOJu0YzhdRnY2RYRWK49Kn9A/Y3KAg0brVAsr7T1orHZxAduq5+oa2Pd OSBOxftoTU0zmlfh7fM1OLBT+NQf5GnKC7YYFzSiySshF66PoVuSCtpWiRwU0Q== X-Google-Smtp-Source: AGHT+IHHDjbjdGBoX7r31Mm/8FvbfzbfnDRUbANKYmdmItwglHtrQti3piuZpW1tBBjWLBssKNAL0Q== X-Received: by 2002:a17:90a:6d63:b0:297:efb:a102 with SMTP id z90-20020a17090a6d6300b002970efba102mr4462729pjj.24.1707776057533; Mon, 12 Feb 2024 14:14:17 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXd6Iq94q+nzQyCD7UZJ5Sd0PLWQMPHoB3mx4VB94zSEAg6IDNu3br5BFE1eExmR8cznMledKK/STod2OwDKt3zpiL9K85KXz30T+3IW5Z4dKcTg9r1ac0EEUD4orveMTPKHk3bLfh6Aylcultx+6/EM3g7DmgMIYcj6hnpXS66oGrT71C9p1CgOOxaRMan99c6UCn7Sn+p+IvntLAgbRRVfwkunhtCj4f5eVCwCu4DKWVui3zHnw3AJz06cdJfNktpp/VV5PbRNLNoImtleaRTHzYgXIs/WIDx+xT6Kz8EWsujXT2jMbE4X5u5fT87mjDfPmGn+1IdHJJNwdkj228s16NXmbvbaT4YP14OQbBPyMep7EYrAemlPIrRcAvM1Wj62bScBU7/wkLr+G3h8FtoDPd7DUIp+S1rASLajvbE50SSNDkkiBQqflqcemkXEQMgq10Y0niiz34utlfhE4QO7v3+EtZRNQo/GqSYUKg7ImwgImoEw59woCM8lweKyFgbatF48fphJJzzRZyBsh3T8TgCEowBLjPs/SCQWn/AIOlcB6tFiB2JlIEh/OQ2vpPW1pQ/UPfQMRcveHBB+/Np7KH9wijIcaFh6DjTe9i0bDyokd2bNMo9X4pBUPXitvkMI3uLL7HWP0YmGkBx9bu33mdwCIXc4AbJA/8ccSv1wldtJdTIc4D4Ozjg5KJM1Vsb0nIM56ZFpC9vxrcHud1897BU2QdaNeII7Nmc9B246ykAxToMlQyJKI7B6iPl6Cvxgm717dOmdkMzYlTAJ2O8cuOSWvBAvVpD489mppNE/xIykNqg4URbN9qOfd8dSdh3FT/fK7IQZLy1KcCFEp2ofuLQF9ioGhyGce8w7dfxURqBE3USurbd/E0RvSJ0ZHHQ5gTKJMqMPyr8gQozI00P/SQTiVYtGl4DURF6svyVxPb5+uyHByXQccvT8r AYhch7YP V5R/i4jJ6YoIZW/jnXbMdBrDdTJthtr5TygxefEGqrSX7DzBxpili/VgBq9iYDTspwvuG7c/F4gui3OanGvi+kOaAyYLJjgC20DmEdhz1GjBp/NqJlZG26Lm8Hm4ZPkaD7NfBxhnQCjrJqSaQJORKWzE0Lfu3TISPrywXj4QJVO4FWbQELICQEP+mWAvvAmElvO8UIl7/GhZ2X3ZL6YlgX5yrXaWEuumfYq3VTBKn/TD9Yl271QeCPVHJf4zPubjVJ0o6r2cvCTfYxS5usoB1a2Ccs8LSuT+Futjhzb2Dr+M/seOau0i9/gRYJA4kxtEagaCb02w9fnNIouyjGzuLGopAt97CavVot1hv7V3byqHrATkBzChhCU1p6A1oyxA6hXzJAYHo215VrceSIb+X6czQ4qtsKEmLewSsEhDsB+UR5DGbNDX0GtK/jDWM= Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id ok5-20020a17090b1d4500b0029703476e9bsm1031910pjb.44.2024.02.12.14.14.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 14:14:16 -0800 (PST) Date: Mon, 12 Feb 2024 14:14:16 -0800 From: Kees Cook To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 05/35] mm: introduce slabobj_ext to support slab object extensions Message-ID: <202402121413.94791C74D5@keescook> References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-6-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240212213922.783301-6-surenb@google.com> X-Rspamd-Queue-Id: B8381140021 X-Rspam-User: X-Stat-Signature: f1frhd6h8zm7x764f6sbzkzt9mhhauz3 X-Rspamd-Server: rspam01 X-HE-Tag: 1707776058-202959 X-HE-Meta: U2FsdGVkX1+RthvVjYGbgA2p9kll6R61x11VX7icnfgG7fRyR9vAK4UN9hAh2Tjd4WZe955+NBtGkrUdGYwz5KE0bPLEZXjGMIYHS0R2YH9nrIMyvO4hvma8dEeFRjlemNA9AuwxE+pT1UIqyc5SVkrnTnRassFoGzXqffqCyZAHEZHchI5Vt6ycjcD5Ee2jxSgjaeyhuouKcABF41340ejQGZuPhUUr8pVfDKR0GE+1Jr0nrlp95ULqBEKt/sLCjyoIOTok66Wf6SQh6u8eI2tcDXvuEZY3ILaFTiO+QwugIp19++WsLFHDXuGHuITnkqd0DddlsnkxZSGvqTRB63vm/nnBkK3wIHqLtcX9o+GcZzwVmMLUUrA0lWXarSxTpVoFmBD7n+dk6c3rp4s8d4SdBJRoYGhajj09lYqjKp9Ao32pToI6PP5FmhONwShJ0Uu0nblVtBm8PtrxnBbE5WJT6VY9smaQSfzlTthHjr5kVCPM92nirT+H6SgXgQiIxzxLfFUFAnX/p/ydPYE/qeFgSA7+4WfyElwxqS5Bd8CaweezlcuQgJ+YK2sH6gLzWVCbk+MhQ6bla/m6bmLiWIe7dOSBS9rgxHNaHFT/nGxUW19xgoTUu6In3+9tAbP3UBN6YDWicj1yxZ2f36P4j7triA2V3zl2Ms+DqIn/BgEFor8SueRJKJjmcXkiJObS3vHvqV6OCxrtDSe4hIUeV6U525E8pl+dtd4M4wn26S1NAg1GiznAAdGyw3kxuzMqO1yo3KzjIHX8KbAbp4b9dcWcjvbDPW+R/aQrI2FepQNkH0ORixENb+WB4Yc0IcBJMF6Rc/uYsxVu603zaKj7o1vsQUTlvReDhTXZPyOK3ccY7f1NqX3Xv0L0O+bI4bK+hAoT3MtlnjdVmsf5hnkoieuQWBCPm8MpOzVuUUz2OW4ZPnIWwEsLlA1erhZxsSPvkWgQ7si0ExPSptDPBAU Q3oBt+OK 98DRkSAF/CGpBhPzv4MPwYDH3HwPrJ8+idSt8Ifb4Qxw3y6KS5NXADVRw8FeMaxS1h9IIryBJuGI1qU9lqBHkbU2dka2ipfM84Q1yZ3c7DQug3DG2s+yvbweV/dgQri8tp9R9phtQO2qZNmqaKOXzzezEP6FBBnXc5vDpCTH8REavxanPi9IKeufRsO0GZI01+FGe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 01:38:51PM -0800, Suren Baghdasaryan wrote: > Currently slab pages can store only vectors of obj_cgroup pointers in > page->memcg_data. Introduce slabobj_ext structure to allow more data > to be stored for each slab object. Wrap obj_cgroup into slabobj_ext > to support current functionality while allowing to extend slabobj_ext > in the future. > > Signed-off-by: Suren Baghdasaryan It looks like this doesn't change which buckets GFP_KERNEL_ACCOUNT comes out of, is that correct? I'd love it if we didn't have separate buckets so GFP_KERNEL and GFP_KERNEL_ACCOUNT came from the same pools (so that the randomized pools would cover GFP_KERNEL_ACCOUNT ...) Regardless: Reviewed-by: Kees Cook -- Kees Cook