From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34519C4829E for ; Mon, 12 Feb 2024 22:10:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6DF36B00A8; Mon, 12 Feb 2024 17:10:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C44926B00AD; Mon, 12 Feb 2024 17:10:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0D2A6B00B9; Mon, 12 Feb 2024 17:10:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A20456B00A8 for ; Mon, 12 Feb 2024 17:10:18 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 401BE160330 for ; Mon, 12 Feb 2024 22:10:18 +0000 (UTC) X-FDA: 81784546116.24.AE88919 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf25.hostedemail.com (Postfix) with ESMTP id 42C8CA001B for ; Mon, 12 Feb 2024 22:10:16 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=U5U6DOA4; spf=pass (imf25.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.171 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707775816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SkGi1YlkpzrNgkK7fsGdO+nBxolzeU4HsB6lcpcl19k=; b=WMh7jF55B/5TRUdWgQi2dDX+Wf2wGOFyeyGamfl8Avd4Z5m+iec4w/Ub8351ARhCGURVf0 nDZ1DzyuEfVd/378/wpuGtct3DJB+kdDseCNJH32WWmWiKlolFhgbcqOIlgMpDtP9CvlAY m0mNbHRGSkcAPtPgyv8SRFat2Mlst3w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707775816; a=rsa-sha256; cv=none; b=m9MRUYHvZyFK03HAawuOUx4C8b/EjP+EMlHHXl2kXxhDZqapGIY28X3Xiiz/kkzbsf7qlI f2WCtWU8k+xP6hhZ76cJbBJD0YG7oLenB3ilSVAjrTQusPqwIJ1m/ZT6DozdcvHlVTiPLH 5SzbYTSUzSDdWxcUezAWbFh7bX6e8cY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=U5U6DOA4; spf=pass (imf25.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.171 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-5dbf7b74402so2443191a12.0 for ; Mon, 12 Feb 2024 14:10:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707775815; x=1708380615; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=SkGi1YlkpzrNgkK7fsGdO+nBxolzeU4HsB6lcpcl19k=; b=U5U6DOA4VKDqOnjT22Baga6YjwFz2o066pVYPu8xnMk79U4YNkoKYOBZow6MAiymlJ FDFeERM5bBTAEkWPnqqv3CP7ebaRIIcEKXIixCJ6jTQVlbFTN4rIHZc0tgF+RbuSPWVP cag9wPo6Zm7Xg/F7Dfj9zPKgX+WnOQEZvifIU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707775815; x=1708380615; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SkGi1YlkpzrNgkK7fsGdO+nBxolzeU4HsB6lcpcl19k=; b=E+L41PLyxFsKaHlvF7oYL1mb2cgL//ROuGWFeFYNlEu7j1aYk30wvPiABiZx7Tg8S4 d/6fKVHaOQEbNQa1ZyKNAVpd0wb5dgcg31Jb/KTTLEKEgLxYL8TPc4045it8yRaoAoGt s6b8F8+IcJNTcUroh9pubWG833qE3v1TWhhG/OoHDCpdDITyqU3z6RlVPKEvwHvFks4K O+VT1cmvfvSFq5sj6v+rVDwCLedHBno6y01LXNmnSECWQJDwOJVMd9f4zJLJa0mTgCyO aHsWEITjq/J/wDdLksaT2WO7Wcq23Xts9ExNwzZOIn8JhSZ8zbQ0DBeDHLzwi8liO/IM eCPw== X-Forwarded-Encrypted: i=1; AJvYcCUssK5MGmDlEoCXDcML7qK+aSd4ZlWCyiEhVCEVGbeHgEjGj2f3R5EUoQ4T6IwjXtZb+GV6NZOEwt0R3hjC3cqyRIc= X-Gm-Message-State: AOJu0Yz6rv5N7yw5nXK9ENNd+ePgfcZTwTWO+ejaxaf5LFh+XECIPekE 4KNcejvMtu800DO4T1+x28tFdAenhns7wLkXNslRWEeVQ/ifMoXH/dLj2Gp3DA== X-Google-Smtp-Source: AGHT+IGEEhiJzpxZDHpBXXPPd0pIjWnTjgeaymujSvqJTiWQFTkiH2xxr7gUt7zfgdRL9mLW4nnaag== X-Received: by 2002:a17:90b:368a:b0:296:416e:ce88 with SMTP id mj10-20020a17090b368a00b00296416ece88mr4098818pjb.49.1707775815257; Mon, 12 Feb 2024 14:10:15 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUpdF/Y8DBZBxfNBdD0B5iOI8dVkHZAmLR/DBegKiiPdyoVsMB1nLqp9B12YR/ivSLUwI1ZziLaZst+j8+RII/J/NCgALyn/+4rG4J0S3NMBKFwk+Rb4/FRYHQ2nJPW62LK2IdDpFkZBB+2hYrvuWHCHWCiSJTfWIR6+JkqpdFMQVyDsAsh1/p3PAodMrb71yuI2eragivL80AqT/RRXZ910b5e+OU3z2UlMA9mMM2byZ5nU0FTOOKXvXGJKMjNSXWidUFP548IRQ03pwnCVvhyc416Hz0oa5UxInbT4ncwOemIXr4q3bzya9xRKGLaXeFwK3gmcLP5qeit/lmIY7Bm8rgLUvYEmnv8Eitbc/+v0XHS00E/ETXTONSl6YvFZ+7Z6hHq0vs/q/+nX05f22ME9viLeaJW8YGjknL6wLkg7utP9d+g09H7lDxUsc3nfLKVAbe0qAjbGWyu64vGFfZveEglNjjpDBLwTGucjpmZEoWVuWcEUp6g2aw9Qgd0FgJBqjUd3sqPdPYee7txlWVcU6EKtYnVLcLT6CjXFlcCuSw+wrYyKPmD/vE+n4nRlj7PxfyFxwCtSAp67sTbtk8tgLijAl2IxfcWpBq5mgxlPioyIqG5DOjZsDA7MBwkPhZ09WFcykviUmjFc0lXW6sXHGj57TWOzOAoiFGpKEN1496slsW0oSf4A7fLZVD+Gtog6BJH3mMT0TPes+irjuV9JtbB9tRRj0akxwSEeUV3uDrtQvTQAANwupaW9kBG3y6UA9IPi+l39Ue3b3dx8bvN4Gzq3nRiZ7uS/rI57URuKPRdY+36hkwm3692ZDwf7cBa6daXnXP05uxfTCNh97ZuxmlwKkeOXEsw3KURVfHZSYCKWU/HFRNStku0q3L8HTkDVXfFGcW2NA/FyD0sXpIf7Yr6206sEb8r75/YXEvZItGqHJ+m6l6Soj8hP0 EsGxlyHW 3zc5nTOxnkxPz8RU20l95HlSYJ+Qxb66dO6CgSDHFacz5bOAA3ypc0aVE/oKPR9JmdI1RIYmrL+IGub8FH2s+kbZUN+0SZNIcVTGj3yngxk22SXUbej4xeydT760/dpFXAK2P5JBzEPGeWT8QdKkpt/jqaSfJBTs46EB4kzVSZFDCFHyvCiNev9aHbaBuF1HA5hgs6CUj2FaQHcggm/7YwMs6x1rGUb29pnbTNiZsO2dY2439r1lCR9U2WOuQ08gaQ08VQg+8RdDXJkC4U2t9+BZvu1dAAUK2BP4i50DdpHeDDF5ZTkkDSU439xEYc3nsNRBOyN9zYH9Rh2P25uh5xAIw4xfAUTFLHWQ6a5qd/N8NP1ImqmBtd3yfXLg1pK7Mb3hCe+LM7WZBCME2mfj4BT7/LFTUKtlH3Ead+Zsh8Jw+VEyVka+XbXvW8wRE= Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id rr16-20020a17090b2b5000b00296a23e407csm1030934pjb.7.2024.02.12.14.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 14:10:14 -0800 (PST) Date: Mon, 12 Feb 2024 14:10:14 -0800 From: Kees Cook To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Petr =?utf-8?B?VGVzYcWZw61r?= Subject: Re: [PATCH v3 04/35] mm: enumerate all gfp flags Message-ID: <202402121410.2AC4CACAE@keescook> References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-5-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240212213922.783301-5-surenb@google.com> X-Rspamd-Queue-Id: 42C8CA001B X-Rspam-User: X-Stat-Signature: s7hyyu7t1me6ei37mkmzfwz97qajgj8y X-Rspamd-Server: rspam03 X-HE-Tag: 1707775816-164536 X-HE-Meta: U2FsdGVkX1/nPmrYB5FbSyeujEbLq8UQw0abhaxAXLPUi6fuNljql5JG6pvob0ZarIaWVzDdSuT68XZ+OMdqziO3j3xAg/UVR68MIyNBQBCfy36TB5tZo7Cx17D1ovCl9ZO9oYqwoRo9DW4IsyVIdCHsN3JEVc3D4a+r9DH73jhsbtehristb20wkXA+ULtr+XxCvq4n8ccXFoctC02btlB+jbDTln8hJCYvTCUUD3hRRaCuxQCq5G4zdhC0c9n376+PC/sqwJt8wTWBEIq27Monia4TnxjYaaMlP8ifKS15qMsOocfaX7m5HPLUr7TPqVNJ6LArGrGobfusmi5LlXfeeXEbv3SkCD99eW19T/Ohq8iAM3B6wJgVLmSzZzKhCW4M52BXe18hxqDUrCBEkAqx7Z1nWsbwA8fnbDverravGmDVR4uZP+/l7Qv9ArjaUeypB5TQBeDEUJR1hc9zgwYNs2glr8hOKjn9JE4Xhpe/t3h5DO5BUyAMV1Cbx7ksqkmkcNlDslzQSz3DcEQDLGTELdaSxUcNPslGjfrlx/aneafEqT33RN/Nn+wy+7e8BweGmUaCsxU8c3+RXWt0ioaliM16m1+m1qI6o9ZWGEaqAM3hX+eq9jTM5xZSMRV/tW4u0P/JxGcwq8nelfau5X5f0m7gp11zccMm5NCyQ/JyhyZUNwHG1J7bLnkIxmzBWngakeJusozC4huyFMpzPweHBFGG2lnjrtb1mDCpVB69RMKQQEH+rPjPcMzpT0zXG3rW28Ww6wBHiRKajQV2AD5pe8Ypb9MFkEA5JI770niVg5sIb+WW5I4gls09DbOgpqmU4MJCdZyEchCIqbSxw9kN3s2yIcPPuABweFJ2vZIPVhgfUVHdQoQzrgqb/EAvQef7SEuQ7jmvbdsSaddSBDM4/As2JLW9dPh5Nh8i0Vl3RJouYqgEg8VWLSwco4ta5xTvT+y7cE21a1+idjU C9EFT43H bfkUZqw1sifmw+s7nkm6pHPukSWH76yUeKJ2Gc8c3ANDmrFbf9xTSMlHI9eW3bjIRg+EDw7UlTey9zudF8SViMvFCOaLvNL55NOQbwZn5QSL1v4VwW2FxV0V0Wx4gB2RgAlY0qRD8bGMbbpdwoVEINHnAr6euCdSk+T5AJ5MI1LP8Pw0W+KU8opvnOq9sZK0+ff3uWHyrrjZ/+FSXAlAx1zhlkOP6dl6eBiQrDhoZo4lP/E3D4og51KI8xw6j7FKkp/FfUZVW0qViMit5i65TocduMST4a3gaOqL9wj03uCLYpjehQaC+wj1hOGBP6rvjz9rGyWHkhVC+adU2+44gKr26cRrmlnhF1Ort91quHBODoIMD9Xqc69vHgFERlczQJfPMJVK3tA61Vf2OwCY0vwH8HiHdm6LLhsSugBwzFVYV05Z/3m61Ei2Lwo7oTZUwv31Dhl0lll9FFo3NMa455bF1RLyxnSqYr+Qv4rmbld5brDunqG0a1jHR7IkreySYt/ReVQagtGy43JrstCscOAaKgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 01:38:50PM -0800, Suren Baghdasaryan wrote: > Introduce GFP bits enumeration to let compiler track the number of used > bits (which depends on the config options) instead of hardcoding them. > That simplifies __GFP_BITS_SHIFT calculation. > > Suggested-by: Petr Tesařík > Signed-off-by: Suren Baghdasaryan Yeah, looks good. Reviewed-by: Kees Cook -- Kees Cook