From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61DB3C4829D for ; Mon, 12 Feb 2024 22:09:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D305D6B00A3; Mon, 12 Feb 2024 17:09:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE0F46B00A5; Mon, 12 Feb 2024 17:09:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B81F86B00B9; Mon, 12 Feb 2024 17:09:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A93CF6B00A3 for ; Mon, 12 Feb 2024 17:09:38 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7F4F2C0A97 for ; Mon, 12 Feb 2024 22:09:38 +0000 (UTC) X-FDA: 81784544436.19.BF2C792 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf17.hostedemail.com (Postfix) with ESMTP id 85B1A40014 for ; Mon, 12 Feb 2024 22:09:36 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=YzACQK51; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf17.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.51 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707775776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ijXS7mVIfD783iJTrvPPuV7zXdag7eKduahqAMiyRM0=; b=tHzWMfGYZ8rw/hM79uxujbrupanac5odLDA6SmjZOLnremCIytSbnCP7XfYe2CiR0znzec kl525F4LQTB+3sWuZcJjP3ZxHTgj9c6N14tmdrgdH3n0bI8H6UPk4dnR0/5jx+4vBkVqFJ sHNxKeH3H/RNh5PeplA0MAHQAEwDDVA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=YzACQK51; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf17.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.51 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707775776; a=rsa-sha256; cv=none; b=QvIW9Ly6ytuLCxuBpZR4CGDIU8o1rs7UzI7ibu0GXbg/DojBmsx7SoZPcxtslnzSTbNTkQ qXoA739rcVsag4PD/oOYHkBWStUAAwXsWvMogaTST791KeGIs2+hNgh3UDHkO8WhIMcnC0 MPD6Oht8y+QkIzndP+V7U2PFuv2Gw5w= Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-296a02b7104so2629103a91.2 for ; Mon, 12 Feb 2024 14:09:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707775775; x=1708380575; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ijXS7mVIfD783iJTrvPPuV7zXdag7eKduahqAMiyRM0=; b=YzACQK51zHjYN43NSDNA1PWGo/BM9BBZ8taUV+JGIzJtEO2PkqzD0umE2E95GD8IPL k/vcWmiGry6FtjeBLAvXD/FE2CGfJypy13Nu/oTpmT6si2K5eIc+URVR04Q0o3OgC1qr 3226N5Gg7CZEU0fm0kZ1XicEkyWuThJXwzYRc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707775775; x=1708380575; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ijXS7mVIfD783iJTrvPPuV7zXdag7eKduahqAMiyRM0=; b=wyzlm+jnrExN9XTMROefSVJpho9KNEvlbs9R8AiE5HXtySXkONPgIJDeyZ5DCL076r Xg0BuIKWajjxaNHiLNfApy5iiQ6sFixwLGrYfORKOOwL2ooiHyisaWzCDnS03z5vT8AH FB8zwD/G/ZVR09r60THenOKwxheFbfDtRpQj7qW3slF+o27qDqSjHS4YjWOl/pvPhrDm xPyVjFYmebCmYO0m5LT8JTvHtzYDhDK25uZp+u6CkY0d5OWro/w3ZRoE//YIR1f/g9Y+ FP00s1Orw7P3Me2WtscmvKhfc/DmjoSmhg7Ku9ICS5lI+2VgqGp9HOova2P51r45ajdy XlfA== X-Forwarded-Encrypted: i=1; AJvYcCXZwuWRrVDpizpRy0SK71d9lKTmt9wAM57FbcKgz8osFmpER0SC3L3vAaJX8XGZ0UmKyeFPNRLH91jfRMYlfoQHEqs= X-Gm-Message-State: AOJu0Yy0buRlTPwaK35tpBj+91TSsa1WbLeXxDR0w3SI86Qvp8j0UoHL 7X7NHrYx4iOyCXxEZkglzkjvZGdv9ScK8vpeEEEM3+vaeKxnKxOTeYE89FncVQ== X-Google-Smtp-Source: AGHT+IHtmAgahRlfUaXuVM4yMR9ceeIk+HMmVNyNGykTRYCyNWh9xuO0z3Tulp0mrnAU9Bl8ly+Wjw== X-Received: by 2002:a17:90a:fe94:b0:296:341b:a60 with SMTP id co20-20020a17090afe9400b00296341b0a60mr5675939pjb.13.1707775775367; Mon, 12 Feb 2024 14:09:35 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXFmq6skboMuhDnTKadtJfZgT9VX1O9l2W6KnbcMFAx9XdyxAvFZ92lXTXx+PzHE4VqB6Gb8gdfUY7ShKXc87iDYPu8iUFBsVQA4zljB8EL3NcQmCuCuAA2JelgKNNUiT7SGeSRbMw1CAkEQZQh8uIr/3yCXRfu0URp5QMkzy33/bBOfgmF174GjmWNhUxTZN9KW7hL6Wuz9XcP7ZOqqY9T8APP3Dzj+hlnrq/x80FRVBSKjpzzWq4rGduaKKRqY84J/xBOLgiPZfoMX/O9LG1WIxGEjdhuYFXLeePiqDFM4m5ec+oQPNzSPs67A0Pq4I+u7tmgWTQlYw8bu21gO+Re2X6ORhTDAr1nFzWyW9ISe3A4du9EqFYks/H2EzrJM9r6u6mbgIddw/dZWLYYYBryy8tlvIZztv+fBD81ucoYG04mFuJ8IKZ6/iWgmFDMk2KFStg+7P+IcWbeDisyDX8/F1rOIPWId4mqMswUXk01OialJQvzbbPylPS0pM30+1ibRCjh01YKDJP7sb0M3O/DTuiR5MBfdpfU89Ei5wnNpOhPAH/PIfy5pm+TwP8oMPZEM7dpiUbbr+EZ+jlMR7Id663Z68oZ5f54NesaeFe4vXqyhtxVHiS2EsU71HyOj3MUvF6a1RTq3C123haGXnVTCoWBlDgj88ZZGz6BrG9/HYPhhM7ZteimtFNLzh92MF4ReMz2OSnyJhPlwM3qoWrdUK1eOIXjh8fyhR3l9/gt4D0SMA9wD+X2X9U61OeMorAg/Bi+HrURV4sMgZHt7ReAsLkbiP4DCi61cOBHXwMfMF3wKqs3hVQOVYpp80nXuklgrj50oR4nz1zGjeYgpFIqA2h6+dWGdP8QVQ8yYJgoHZJUDrRnlGhZVyZ37ZINAAw5v5DFqSWyS8x3GbR3xlTibMvOOOkGucOAweVmpUa30Nfxgb8iFvPjw/1jKC gqdJ5RfI fekofFghndqS429qPijj99NgynM/9MTts72pIwdTyJJJrFpU3xt66RwdCnmb+HcZrzPZ5d9/PqoYYP/Ej/1qf6sU+jRLLI2MJHnp6vANQm1JGSFB+fEgvCamSmLPvl9I4j0cEejzGvhkiZ3j1FjtXjiSO4idmyUz3VsduHmX5tIrK12ZuQ70dZKShJz7qlL0KfrzRdYhD6PnNXfagcQnJ3JyGqCDtEbwb8U+BpqGp139+UWhxo93wCM2+G8xL9yAwjyWw9wfm9t9MLAeD/aJFOP7htwlOVFFvpz/afZJZEFecr4UnYiLSc+PDzZsnupIZMsTOgtnh3QYM3QF6TCpi8qnxUJxX7bM4KlrYrmwWyRjreJ7UKpegfmXbgwgOKlVovjZrMGpqPKRyfdviIoY9c5WzRyBUT5Z9d14q0YfA= Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id qd4-20020a17090b3cc400b002967bc2c852sm1032925pjb.43.2024.02.12.14.09.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 14:09:35 -0800 (PST) Date: Mon, 12 Feb 2024 14:09:34 -0800 From: Kees Cook To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Andy Shevchenko , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Michael S. Tsirkin" , Jason Wang , Noralf =?iso-8859-1?Q?Tr=F8nnes?= Subject: Re: [PATCH v3 01/35] lib/string_helpers: Add flags param to string_get_size() Message-ID: <202402121408.5C98241E@keescook> References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-2-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240212213922.783301-2-surenb@google.com> X-Rspamd-Queue-Id: 85B1A40014 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 19afwka9sdue65widu1k3g6zge37qamz X-HE-Tag: 1707775776-191006 X-HE-Meta: U2FsdGVkX19EAslAjdtUIE9Vb++PjtaZn2v5g7LOeHbTwwD37YTsppIXqgHxRe57SPuMqVWEx9AkSmOfAP4G3W7zKI4GbbJ8Id7fVF31oLocfiw5iQrWRE/QDraofMMjy6YqlH2yGlGQ0kH+uLxq09bO42SINPr2Fn8/V5NXH7reLuTfm1IoaNeF8WlqOGFb94k11xFrl1TUlCbM9M1FmgDaSZOjm6FrTP/8B8Y3RqemjnzzSP38WWcU+fuk/mD3/aOBMAyDWXODXYUaR55829/yCjvCtx2eEKk7DRmF5pjyLmbZDQ1gP5LfRJHvK+pVCINJuhURFQDVGZrKo8KBGp3RcKt2M96xIn2fyP7gCOsgyy7YXk7f+AiE1hyOGUMPMj5bOw4AAB9CFX/qNQ+iOFbfDdcegWt8VERebDUVKZ0L4LrOzBVtlKLjF9PHcgryO/U+bqm41xgzR+uuyqjxa12MzgCtC0vShslCeara1x0AUGQPiKIAdxwP3AUxPQLppOJ4jLhK5YyZpxzgg3WsHuJi1nQlGS5vWqTyqB/zL25Tj5HnRTdrjkFbUA6K8iCkk4wGuLZjNZCCh/DRLbbWs2VgLtMT9SvtyMBg9/UGFHPw17inSVPaM++QvpSXJcEyfNu1EWJa6Mvkn5DIKCMxCYYY5RN84+w/VGjvd7Sv4GOTmvXuASTQwF1N58WwH3ET+JCfLDLhJzrrzcDJhxvzIJ0xnoh3XTpzDwcuJZ1gRahp1Qa0N4UfT1MIjxUc23ZIgqffBpyraXGcDBLWO7W12Q9xXotR9RIIsU4Z3YfG18FhnUX+fNArACaQXLIvNeHbr5Qboo0ci8rIfW8gmY5EGN/DGUy+f5usuQEh/19MAJCe0TV1vImwNRV4vpKb6JZuagkyQ9OD/cAiaYYW/orm3fffG38ygvCsMx4ZqwazmvCjy0pUBW0rRctoGJBHENXpd76wMlR4VGab1RyY3Cw swpZGbf3 Ta0XgtvVuoW1S3uMbnKZmMljl2/kO24pE4sXZ7M1b/nXPf6vTRICIXasCqCgQekVTcpx9bND0koakjSorYBPsHwZluVPlAEIm+d19kpRudfHK9KQK/BUPHPdj1HbPCUHyzU9E8tYurj1hK/u7JrhtbgM8ylma0qwlW4h1brBCiG31LAdE25ny77YhCTTKq1QzBZYdtm1QSO3MosdQY1ZxAPkXEGO20jzRGGlzOK5sbLxMu/y13pB77M3Q2Zm3G1JeA73VGDs1RJuaDoEbQ5waB1+osX+BhfT/oXYJDmbEb0qXF6Vt8CUaA0mYYmsb9ZDwZvFwuEibJyZR+rWgkSgNzGDmaqAlZB03Q4A1E/83Fo2fdUiEO9ID6IjH1dkETf0sxlco6m6bDxOTwOzKeJYxOG4xoYQ5Vv/1Tgd29Rk/jWC9wiem1lYxO/peepDcko2lbZCP5Og4EULhtk8t0n1Zixu4u+y1uOBwVLoSvgSX84vLuhZbOM8pcDoGIRQrPawu/iC/Gcflq6uiSgIO5Vh9ktWxyBzEOzCKF11QFxOsIDtjYWHU6oQVTyHhPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 01:38:47PM -0800, Suren Baghdasaryan wrote: > From: Kent Overstreet > > The new flags parameter allows controlling > - Whether or not the units suffix is separated by a space, for > compatibility with sort -h > - Whether or not to append a B suffix - we're not always printing > bytes. > > Signed-off-by: Kent Overstreet If there is a v4, please include some short examples with the .h bit field documentation. It's pretty obvious right now but these kinds of things have a habit of growing, so let's set a good example for documenting the flags. Reviewed-by: Kees Cook -- Kees Cook