From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22216C4829E for ; Mon, 12 Feb 2024 17:27:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 551226B009B; Mon, 12 Feb 2024 12:27:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 527CB6B009D; Mon, 12 Feb 2024 12:27:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C8306B009E; Mon, 12 Feb 2024 12:27:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2864F6B009B for ; Mon, 12 Feb 2024 12:27:28 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 03A7C1A0AC4 for ; Mon, 12 Feb 2024 17:27:27 +0000 (UTC) X-FDA: 81783833376.28.85B6B22 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 03B7DA0017 for ; Mon, 12 Feb 2024 17:27:25 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Bvq0y13B; spf=pass (imf15.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707758846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DPBeyL2QKeNnZrcFyNehWyHmkNTBExacfmNTQafQrSc=; b=m9PoNoeqxMiIytzXyWCYdYJTsAZmOQMQ2xcS5Q/QFWrmDFaozkiKMr1yxHOHkFaMTm7ccf 9LECvOg5sc45A4NGGSRyN2pe6mTZQFHl5V/c7JKpaRRgk07k509HbUePxIEEiCXF0OwheP DV3Nj+ufYgLJf5P1+Cl6aM9S+KE71Rs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707758846; a=rsa-sha256; cv=none; b=FMVW7xAV2buxzoq1yBFMn54Rlw0QNqTcWxkLcLtg6pJ41kdCYZ37Ql2RNpTnYD4UeyoqKX sKETizq8q65hY83Pff14XXheA6wUvtY7hHRQ8GBUdNbrhP9E6/Npz+QKKjx4FAcIOlmCs/ ypziIA7VSKMx69OHQU3Sm9rhhaBr7Hs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Bvq0y13B; spf=pass (imf15.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707758845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DPBeyL2QKeNnZrcFyNehWyHmkNTBExacfmNTQafQrSc=; b=Bvq0y13B6dm0qgwOwYusJveiIhft8q6kWviV/HaAMSXgBROdLPCOPgdn2z6dK4hV+lQAnc jfbzajucPSOBvbV6rUKVJJUXzFpD/PLWNKr7J5zpngafPqYOunEiLiZtlB1/Z0qV0P4aPC H36T+GfTzWZ9IujNr45htyeSUGFx6tg= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-8XtutEpjOB6ThXfUVPLvqA-1; Mon, 12 Feb 2024 12:27:22 -0500 X-MC-Unique: 8XtutEpjOB6ThXfUVPLvqA-1 Received: by mail-io1-f70.google.com with SMTP id ca18e2360f4ac-7bf36117dfbso440817239f.3 for ; Mon, 12 Feb 2024 09:27:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707758841; x=1708363641; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DPBeyL2QKeNnZrcFyNehWyHmkNTBExacfmNTQafQrSc=; b=DUDW13dTUueVyVd5EmE7EiPPtrl3eYy52VEnpzsoTXvYrAoID9uU8S7EEDu3W4akFO WEhWfpJdhqnTDKsnoJkN181n9bxTS6SpgfL2C/ijxGbYtoda5/Cq+a7VfGakuns8zSTN 7BYT+eL0vGhJIkUSrS0KHk6YKV9ADGbm/8BdSIiyV05jEtdGl+boJ3O45nUVlrVzbZRQ 9IDltIC4DrErg0KFMnDEfVui+l1vX9ytDb8frHm9gjv4klmndtHvpOXA6uz7AJd6OBcX 3JRRZg9oFfA3SyXc1ZqbDLft3ueKocc662AbSoAO34LuJ/EI8NA7RDiDHEc6LkHONmIm R9+g== X-Gm-Message-State: AOJu0Yz7Cyl8+aHscJ/75IqpSfm4WvNP4vlp645WcgFLsrDhgC2pMylp 2AjC7lCwuLPWOviSY+Wb/paQd+jlOeLziZ4Cw6cyLttVppFdx7Bzy18F0ySBhxpYKz5JHG7cL5D H1EiOww1mHBRwCcxB0J0a7qDtChq+i300mdYGcEW7Bz5Jye7E X-Received: by 2002:a6b:5b12:0:b0:7c3:f849:dd5c with SMTP id v18-20020a6b5b12000000b007c3f849dd5cmr9697182ioh.8.1707758841344; Mon, 12 Feb 2024 09:27:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IHpYYcqJOkfeHRl4fhQijxO0vEvLM718vOT5KP64FP3TvMwqB68vh4X69PRRTLaI4f1WfmXrA== X-Received: by 2002:a6b:5b12:0:b0:7c3:f849:dd5c with SMTP id v18-20020a6b5b12000000b007c3f849dd5cmr9697129ioh.8.1707758840805; Mon, 12 Feb 2024 09:27:20 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXmnLq4zNu+kjrxiOGmAXK9/5LLfQ78OvG6YnIBwLiYCyCo1Xtkqr/9oMISGzxLYkr0A+ejIwpR/gbAoX+v/JyfQzYZXyQdxN1KsGTT4mC/KTlJXmznk+JNbroyEHl3vvbz8bRnGPJ4ogKMx0s39GnfptsncvTQ6Y7bEjnure1aN+xnnUmmzp0o+wGw3WceawgtQIgSnpTfRx0eAJmiW3nzAL6Oo2YbxvPPOeZkAGsZqdM2hYTjcmHrhLFwJO8nbUieENJcuxrpk1y5rNYnzVvCmuC5EA7bMrU0ycZE391uLlxdq7/1dRxWDyx2bfDLE3uqTjc79iGu2KBcJpK5bNjOVqPnj5FO2+9P6yjA3rZ8X4f7WrJ0WJX0dkPvbe94hCRXZSwPeFevevVDqq91foF+rAfWSvIdzmEnObrEbTmNeNeBLd/x9EJtKMZecoCFsZb6OSuHD1BPbC0In09PBJs94anGJ1pLN33zFG2BnLDKzqfn/Qx2w2Fkwwwpp0bAH6pnIKoq6013B1kV9uyH0d2whagym8f/H+yJXJlvLN9gmGy+65ettXWoK4qvl/+e04Mo9J5PIB3G3FnjoO/TA1pXU+deYz0+O58ZN/exYcOxqVAHfSIz8XPWMvpOVnnxUX1Vzts5rY+Uou76eAJLojZNNFGWvJPMBrpBgnwybhiwQGp1TMNyIq9kx/kJ9Q9xEtZzhAXyTzU7diAjY9WNFpwI4AE+hHDNYmudp4zGN4X9CPc3St/QyHcX3LOn/uRY/cUPe/pxTvORUCaqk4mN9F3sJS5R3dJo2cHpwY8/HGkE+69zrNErj7C9kFclGlAYbmQ9mpHPnWVfNcEqpCRNeYPwHWjBbzAk+Aok9jpVG+CzVoU/0AZVt22W0+4eiH4gN88QMDYORqdmtxiLCZVCV4/ExIppiR22wEHuQmHR4mWPvYiSwG407sN3vFVDbJ /xzyKbjj vzrtzJqY5EHLwJz8xxdMOrcVSsTelZOKzTX8o/c3skfY6DfLbu65OBjYJZ2c34OVqqm9E82mJVEMhnlGYxRHgYzW5YSf7M8bqus9Mqx1Rbj/qwz6yQbgszHivSRMKpP+8ld9oj781P7czCHOZCwhHWm6s5e1Xy+Y4b2MroNq5jtAdlPr/ITd7kWNQsJnwtCH5J/gJC+v16pdTh7vK6wSfpNgGaFPacJMXezN8gNEo6GMIMhWLGJKkfjxI2KuXsfFSS1qAe3EtbnOAqOJMRPLNDVUn7PopRoPZ+dJkq90VJwH1f/Ctv+rKZwt2V6btrA3iQgiwn Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id hl18-20020a0566020f1200b007c3f4c29570sm1591895iob.39.2024.02.12.09.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 09:27:19 -0800 (PST) Date: Mon, 12 Feb 2024 10:27:18 -0700 From: Alex Williamson To: Jason Gunthorpe Cc: ankita@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, reinette.chatre@intel.com, surenb@google.com, stefanha@redhat.com, brauner@kernel.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, andreyknvl@gmail.com, wangjinchao@xfusion.com, gshan@redhat.com, shahuang@redhat.com, ricarkol@google.com, linux-mm@kvack.org, lpieralisi@kernel.org, rananta@google.com, ryan.roberts@arm.com, david@redhat.com, linus.walleij@linaro.org, bhe@redhat.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, kvmarm@lists.linux.dev, mochs@nvidia.com, zhiw@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 4/4] vfio: convey kvm that the vfio-pci device is wc safe Message-ID: <20240212102718.07543659.alex.williamson@redhat.com> In-Reply-To: <20240212172001.GE4048826@nvidia.com> References: <20240211174705.31992-1-ankita@nvidia.com> <20240211174705.31992-5-ankita@nvidia.com> <20240212100502.2b5009e4.alex.williamson@redhat.com> <20240212172001.GE4048826@nvidia.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 03B7DA0017 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: rzzutmhgwzbexsn4xin13heifabdqutw X-HE-Tag: 1707758845-334049 X-HE-Meta: U2FsdGVkX193tiG8xD1OqrulUfaL2p6gfr4xUSi/Yi6vpJDn9jRTWkwkUUVSr4CYEpJtO6m6+eRlJNApL6SinYPRt0KLPyNlhUem5UFVMSWEq5gqzprWwSL4LqD9PsfqD/FvkIPbqSbukEBaVzbSpUu1ymNvQHDN93MGUnQ0AEO/9MSFa4OXkBQfCNXDS6s/wNSBJ5yX1AsOtDjjTLass/a5b11G3lhGqb4nEnnSSRm9mmN9oB+Gu7ejPvZ8GUzl4bRTXPw2SuNom95jtpfLls77JQc3XaFZ+9HHRLV0k30DOEqYT3ooSjiazXNvs6X9HOBqQgNzAboQiLOBMx6472C8A3We7jMWvdfglI/k3xgoFrHXon4T3hpBtwvlAo65XZi46WCcLYjm1+YFtVaEp4yyy4Anp2o2OBzwpz9j4/XTjfennrXYtIUdUpNKOfQSd7CxISrjE96Wm5e8y9ztYUpt2dZdnAjz5LbnTEje67PYLTB2a/cdGW9Fcve5PCtL1NxqJnps+SojxXH1t48tsuUYCgpG8HfU3oCm8aAURiHTKzLmyG+s1nv3HkT9HN6eirqKt3/xBWUZxnSy7gGFx1ZTNK5NiCJ4LgdV53vdpcYqEr3zFdFHHnJzawbZsfqlzKvl7wRygzD67IpfJ/9j3Dw2sfUtWF9FOq4suN6JBHmASNTJW7Kh5joPjXVQaMMLCBtoT8dqTC5oeRp+7mHJJ73VQ3DOljzjd3OjbNoE5hFG5jVMo8DEmGg/vIGJss49zI1snffjwEQvvIhgsm6oACoxNh3oBh7+ZSU0xeuVEWk40G/Qz5RlEnEE5QR78kSHBNeJdkt+D0cXKae/dOi28PfEJrFFlUymzFw8UKJq5AH7OAUr1Ejmgs2DD15FMR48R8wzoI8GaB3FKN5TCHoSnkk5YkjcyQsV28N2kiw7ctbbOLP1zDcn0wI7gtg4qf9ffJebLYsh1fEjiYpXkIl Ut411Qgn CjQ9xXzuAzQpNFitRh+puySbseJ3PBP//6Ek03Zyn2ii7bnY4mXscrh5Bozf4Nz1eFDq9R/dZYWjpajWrfStlGzMYPMv6IFCo3t0X X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 12 Feb 2024 13:20:01 -0400 Jason Gunthorpe wrote: > On Mon, Feb 12, 2024 at 10:05:02AM -0700, Alex Williamson wrote: > > > > --- a/drivers/vfio/pci/vfio_pci_core.c > > > +++ b/drivers/vfio/pci/vfio_pci_core.c > > > @@ -1862,8 +1862,12 @@ int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma > > > /* > > > * See remap_pfn_range(), called from vfio_pci_fault() but we can't > > > * change vm_flags within the fault handler. Set them now. > > > + * > > > + * Set an additional flag VM_ALLOW_ANY_UNCACHED to convey kvm that > > > + * the device is wc safe. > > > */ > > > > That's a pretty superficial comment. Check that this is accurate, but > > maybe something like: > > > > The VM_ALLOW_ANY_UNCACHED flag is implemented for ARM64, > > allowing stage 2 device mapping attributes to use Normal-NC > ^^^^ > > > rather than DEVICE_nGnRE, which allows guest mappings > > supporting combining attributes (WC). This attribute has > > potential risks with the GICv2 VCPU interface, but is expected > > to be safe for vfio-pci use cases. > > Sure, if you want to elaborate more > > The VM_ALLOW_ANY_UNCACHED flag is implemented for ARM64, > allowing KVM stage 2 device mapping attributes to use Normal-NC > rather than DEVICE_nGnRE, which allows guest mappings > supporting combining attributes (WC). ARM does not architecturally > guarentee this is safe, and indeed some MMIO regions like the GICv2 > VCPU interface can trigger uncontained faults if Normal-NC is used. > > Even worse we expect there are platforms where even DEVICE_nGnRE can > allow uncontained faults in conercases. Unfortunately existing ARM ^^^^^^^^^^ *corner cases > IP requires platform integration to take responsibility to prevent > this. > > To safely use VFIO in KVM the platform must guarantee full safety > in the guest where no action taken against a MMIO mapping can > trigger an uncontainer failure. We belive that most VFIO PCI > platforms support this for both mapping types, at least in common > flows, based on some expectations of how PCI IP is integrated. This > can be enabled more broadly, for instance into vfio-platform > drivers, but only after the platform vendor completes auditing for > safety. I like it, please incorporate into the next version. > > And specifically, I think these other devices that may be problematic > > as described in the cover letter is a warning against use for > > vfio-platform, is that correct? > > Maybe more like "we have a general consensus that vfio-pci is likely > safe due to how PCI IP is typically integrated, but it is much less > obvious for other VFIO bus types. As there is no known WC user for > vfio-platform drivers be conservative and do not enable it." Ok. Thanks for the clarification. Alex