From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F94C4829B for ; Sun, 11 Feb 2024 19:02:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A90CC6B006E; Sun, 11 Feb 2024 14:02:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A41876B0072; Sun, 11 Feb 2024 14:02:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 908D06B0074; Sun, 11 Feb 2024 14:02:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 81D086B006E for ; Sun, 11 Feb 2024 14:02:12 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2D7B5A092F for ; Sun, 11 Feb 2024 19:02:12 +0000 (UTC) X-FDA: 81780443304.30.8AE1531 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by imf30.hostedemail.com (Postfix) with ESMTP id 770E880023 for ; Sun, 11 Feb 2024 19:02:09 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hJa8dKRl; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707678130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f4FZOu1DDnCe6lZhAudjn+mHA2BM+IiYbM1Y1cOZCYc=; b=Z0SLEyjNqqczvDCyFhWIBffCwfZIZrdxNZJlfFWR5tHfzaQ/J+htVJtPyjzaTyZfYUe6KS zXsEy0U5oXN80lvF9dxvW8DoKachT/30CjYCh/3bOPXg4iDJO8sAubk/VEck3upKrSiJed EAekJ7WRizGkkdcjPkQtzLUzCEOpOE8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707678130; a=rsa-sha256; cv=none; b=7l6t/8ZPJEqVVJk+X0xPJlbpbgAnx6FmUZVc65F1wKfQ1BeqAlV0iaAyxAFAlqYvrktuss Dn743dyrLInoeUs1Fr4lQhLsGpbP0o2D5ikkGJtIT86DZwJKFYvFiX0/p23I/z9TuFJjwZ gyfaasE6Prx94wXy2xiOvDKHxft9Kg8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hJa8dKRl; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707678130; x=1739214130; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ne+I1lVvIggr9Ct6CO9zOzMdMZ2Eb6zOcxpa0xPq5/Q=; b=hJa8dKRlxN2vBg4B9gegjewOCoGuULQx2zVfQU6tDA8OjKhLqcF0ajx/ kKl/9rz8n1RUTNobFEFmUU1X8KEfuqKbpkIvfw7jEWQOTq4vreC99ZKlq l/WMUtuL4oV0nGmygCU6Rt76qSJRUf1Y7Hmp4fIMYt2f94KV6RCy1G5ow MZuyQWua10XQrhyh9d6OQ/5VCv2ZQUn01tIAihW7qnylMkXUHBlZTvaoa NGkldrzuIwW9ySzDeU9rkqE04rK3+NFuxAFK7hc8ia+mgO4KBzyQl9Zxi 1yEdiUUv9x8vR1seH/+TW/6KApa2BV9FC/XHSdG2Nl7lmjVsxzxC/t44q Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10981"; a="4618790" X-IronPort-AV: E=Sophos;i="6.05,261,1701158400"; d="scan'208";a="4618790" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2024 11:02:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,261,1701158400"; d="scan'208";a="2811533" Received: from lkp-server01.sh.intel.com (HELO 01f0647817ea) ([10.239.97.150]) by orviesa008.jf.intel.com with ESMTP; 11 Feb 2024 11:02:06 -0800 Received: from kbuild by 01f0647817ea with local (Exim 4.96) (envelope-from ) id 1rZF5X-0006ja-0D; Sun, 11 Feb 2024 19:02:03 +0000 Date: Mon, 12 Feb 2024 03:01:46 +0800 From: kernel test robot To: Chengming Zhou , Andrew Morton , Johannes Weiner , Yosry Ahmed , Nhat Pham Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-kernel@vger.kernel.org, Chengming Zhou Subject: Re: [PATCH 1/2] mm/zswap: global lru and shrinker shared by all zswap_pools Message-ID: <202402120226.TK7G37U9-lkp@intel.com> References: <20240210-zswap-global-lru-v1-1-853473d7b0da@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240210-zswap-global-lru-v1-1-853473d7b0da@bytedance.com> X-Rspamd-Queue-Id: 770E880023 X-Rspam-User: X-Stat-Signature: jqxor4a9z3h9sr31epr9rnqnrdfg33js X-Rspamd-Server: rspam03 X-HE-Tag: 1707678129-65295 X-HE-Meta: U2FsdGVkX1+vav/oRr5VH9XNlCLJeefW6TUnrHdLBkdhrU5n1urm0mqf9dXfAgzFQCKiLnWQ+32PqtDQkxkI3ihVKeccE1pscfQqzWzDhMx11NyZFzU2ckqhZGYrmpSQpe7yBA0r+zrbydic6WXdNlzAuEKdPn3hDLCk37OzxwJzwbpw/CKlESlnTq0CJHqPpbYn25EEXq4+8Gx6Sb7reKVoM80ONubUjmk6GLpoCVexpowLcB9UHu4udcnszks5ug9DU1djSRhn+caKpypDvLyiP91dRtbZITdMq+njff0dqnMneeXzqmiblUU41JmORG7piNeYRekZ+Fsr7jkWDuQSmS77RAPVmsSMbBbnl0RXwI/bVhYLKswtR5WaM16OC+La5H9wNzZtwa+wkkqpoidRe7PdMnKmbaIMfuQYz5YDMiHKZxudjTSby+rFYsE/ZUizHQoMiZH6wY79KN+nbK1e0Qc97XJ6EHZMLbXBqWgLtQLWPVwT9HAmvoL6Sk29tPt5v+rOSrcoNKQqIc+a9YYiv4AcjY2vG/WHUhHCrvnlFKxGqQPqyKC/eDYMyLMrrp9B0FLryvcCINNufUVKH8VjIWJBUrTgv8yAhCJKawCeCY1D1itAorVrUpVjTUbcT0i3YAl/2cFwBpEqR21BMbdh6X8CzCKPAY7wLoer9RB6L8h0mKekqAixoc89bTvn2Bl7HcMZfkmBKvZH7Sd5mqlc4GMXVqZt3NaUpkGo6kegSToaI9UNqADoUsfaesGyva5GAK/1+orXhmE4+dlB9XKBgJSkuDxHHFLpCc8XntYpc10rH2RlS9qAw3/Va8bQJ2CtLLIAQUW39MYrIAFJVZcUyjDAOQSrq+Fv5RL3wzsOMnYxVKWjGJES1ReUQ2BnArVbnCepBJTFt1CKxMZm6EMcABZLNVbq4djmL4nJjWF7tmOo92ufCYNeUwJc/elSDKgEiKt+DNmeezddUmR d8dCBDSc gMfviO3JEHj+gHpnRcXe5iDPmcj5gWatiGCDWBKEdKMzznJF0wYMtMLT4Eqvvr0tEMsES1MsTxgzvScviZVUfv7Z+VkmUD332LKz1SInVRzXLFiBEzMXu9B+mQm/MTqtC2p5O8Of9D+Yir0by33MQBip4q+z2eqMXdIBzPDo8DaOp4YMQ6XNuJC6dZL4Et23+HxgoUTsj4nF15oeOQS2orcQgaPP54WIrf6P08Z1YqFmkzr89HboU+8ytBXm0pgwtRFkgy99bvAVT4oexivD5IGgRJJsUb581Sp5Wj0x5xWyEj80aTtkae8lwA756tliAR371EcGJXm7mtoWdy4YBxa8QhrX5EaitdgS5GD+DJD/d0asXL9zp4f6WwKExpjSMxBNyLLDycHUvL+ioOdwoyb+Uunh0ovq5cv59 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Chengming, kernel test robot noticed the following build errors: [auto build test ERROR on 191d97734e41a5c9f90a2f6636fdd335ae1d435d] url: https://github.com/intel-lab-lkp/linux/commits/Chengming-Zhou/mm-zswap-global-lru-and-shrinker-shared-by-all-zswap_pools/20240211-220028 base: 191d97734e41a5c9f90a2f6636fdd335ae1d435d patch link: https://lore.kernel.org/r/20240210-zswap-global-lru-v1-1-853473d7b0da%40bytedance.com patch subject: [PATCH 1/2] mm/zswap: global lru and shrinker shared by all zswap_pools config: x86_64-randconfig-013-20240211 (https://download.01.org/0day-ci/archive/20240212/202402120226.TK7G37U9-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240212/202402120226.TK7G37U9-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202402120226.TK7G37U9-lkp@intel.com/ All errors (new ones prefixed by >>): mm/zswap.c: In function 'zswap_shrinker_count': >> mm/zswap.c:1300:42: error: 'pool' undeclared (first use in this function); did you mean 'zpool'? 1300 | nr_backing = get_zswap_pool_size(pool) >> PAGE_SHIFT; | ^~~~ | zpool mm/zswap.c:1300:42: note: each undeclared identifier is reported only once for each function it appears in Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for DRM_I915_DEBUG_GEM Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=y] && EXPERT [=y] && DRM_I915_WERROR [=n] Selected by [y]: - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && DRM_I915 [=y] && EXPERT [=y] && !COMPILE_TEST [=n] vim +1300 mm/zswap.c b5ba474f3f5187 Nhat Pham 2023-11-30 1283 b5ba474f3f5187 Nhat Pham 2023-11-30 1284 static unsigned long zswap_shrinker_count(struct shrinker *shrinker, b5ba474f3f5187 Nhat Pham 2023-11-30 1285 struct shrink_control *sc) b5ba474f3f5187 Nhat Pham 2023-11-30 1286 { b5ba474f3f5187 Nhat Pham 2023-11-30 1287 struct mem_cgroup *memcg = sc->memcg; b5ba474f3f5187 Nhat Pham 2023-11-30 1288 struct lruvec *lruvec = mem_cgroup_lruvec(memcg, NODE_DATA(sc->nid)); b5ba474f3f5187 Nhat Pham 2023-11-30 1289 unsigned long nr_backing, nr_stored, nr_freeable, nr_protected; b5ba474f3f5187 Nhat Pham 2023-11-30 1290 501a06fe8e4c18 Nhat Pham 2023-12-07 1291 if (!zswap_shrinker_enabled || !mem_cgroup_zswap_writeback_enabled(memcg)) b5ba474f3f5187 Nhat Pham 2023-11-30 1292 return 0; b5ba474f3f5187 Nhat Pham 2023-11-30 1293 b5ba474f3f5187 Nhat Pham 2023-11-30 1294 #ifdef CONFIG_MEMCG_KMEM 7d7ef0a4686abe Yosry Ahmed 2023-11-29 1295 mem_cgroup_flush_stats(memcg); b5ba474f3f5187 Nhat Pham 2023-11-30 1296 nr_backing = memcg_page_state(memcg, MEMCG_ZSWAP_B) >> PAGE_SHIFT; b5ba474f3f5187 Nhat Pham 2023-11-30 1297 nr_stored = memcg_page_state(memcg, MEMCG_ZSWAPPED); b5ba474f3f5187 Nhat Pham 2023-11-30 1298 #else b5ba474f3f5187 Nhat Pham 2023-11-30 1299 /* use pool stats instead of memcg stats */ b5ba474f3f5187 Nhat Pham 2023-11-30 @1300 nr_backing = get_zswap_pool_size(pool) >> PAGE_SHIFT; bf414d6ae81ba2 Chengming Zhou 2024-02-11 1301 nr_stored = atomic_read(&zswap.nr_stored); b5ba474f3f5187 Nhat Pham 2023-11-30 1302 #endif b5ba474f3f5187 Nhat Pham 2023-11-30 1303 b5ba474f3f5187 Nhat Pham 2023-11-30 1304 if (!nr_stored) b5ba474f3f5187 Nhat Pham 2023-11-30 1305 return 0; b5ba474f3f5187 Nhat Pham 2023-11-30 1306 b5ba474f3f5187 Nhat Pham 2023-11-30 1307 nr_protected = b5ba474f3f5187 Nhat Pham 2023-11-30 1308 atomic_long_read(&lruvec->zswap_lruvec_state.nr_zswap_protected); bf414d6ae81ba2 Chengming Zhou 2024-02-11 1309 nr_freeable = list_lru_shrink_count(&zswap.list_lru, sc); b5ba474f3f5187 Nhat Pham 2023-11-30 1310 /* b5ba474f3f5187 Nhat Pham 2023-11-30 1311 * Subtract the lru size by an estimate of the number of pages b5ba474f3f5187 Nhat Pham 2023-11-30 1312 * that should be protected. b5ba474f3f5187 Nhat Pham 2023-11-30 1313 */ b5ba474f3f5187 Nhat Pham 2023-11-30 1314 nr_freeable = nr_freeable > nr_protected ? nr_freeable - nr_protected : 0; b5ba474f3f5187 Nhat Pham 2023-11-30 1315 b5ba474f3f5187 Nhat Pham 2023-11-30 1316 /* b5ba474f3f5187 Nhat Pham 2023-11-30 1317 * Scale the number of freeable pages by the memory saving factor. b5ba474f3f5187 Nhat Pham 2023-11-30 1318 * This ensures that the better zswap compresses memory, the fewer b5ba474f3f5187 Nhat Pham 2023-11-30 1319 * pages we will evict to swap (as it will otherwise incur IO for b5ba474f3f5187 Nhat Pham 2023-11-30 1320 * relatively small memory saving). b5ba474f3f5187 Nhat Pham 2023-11-30 1321 */ b5ba474f3f5187 Nhat Pham 2023-11-30 1322 return mult_frac(nr_freeable, nr_backing, nr_stored); b5ba474f3f5187 Nhat Pham 2023-11-30 1323 } b5ba474f3f5187 Nhat Pham 2023-11-30 1324 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki