From: Daniel Gomez <da.gomez@samsung.com>
To: "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"brauner@kernel.org" <brauner@kernel.org>,
"jack@suse.cz" <jack@suse.cz>,
"hughd@google.com" <hughd@google.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "dagmcr@gmail.com" <dagmcr@gmail.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"willy@infradead.org" <willy@infradead.org>,
"hch@infradead.org" <hch@infradead.org>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
Pankaj Raghav <p.raghav@samsung.com>,
"gost.dev@samsung.com" <gost.dev@samsung.com>,
Daniel Gomez <da.gomez@samsung.com>
Subject: [RFC PATCH 4/9] shmem: exit shmem_get_folio_gfp() if block is uptodate
Date: Fri, 9 Feb 2024 14:29:03 +0000 [thread overview]
Message-ID: <20240209142901.126894-5-da.gomez@samsung.com> (raw)
In-Reply-To: <20240209142901.126894-1-da.gomez@samsung.com>
When we get a folio from the page cache with filemap_get_entry() and
is uptodate we exit from shmem_get_folio_gfp(). Replicate the same
behaviour if the block is uptodate in the index we are operating on.
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
---
mm/shmem.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 3bddf7a89c18..614cda767298 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -256,6 +256,16 @@ static inline bool shmem_is_any_uptodate(struct folio *folio)
return folio_test_uptodate(folio);
}
+static inline bool shmem_is_block_uptodate(struct folio *folio,
+ unsigned int block)
+{
+ struct shmem_folio_state *sfs = folio->private;
+
+ if (folio_test_large(folio) && sfs)
+ return sfs_is_block_uptodate(sfs, block);
+ return folio_test_uptodate(folio);
+}
+
static void shmem_set_range_uptodate(struct folio *folio, size_t off,
size_t len)
{
@@ -2143,7 +2153,7 @@ static int shmem_get_folio_gfp(struct inode *inode, pgoff_t index,
}
if (sgp == SGP_WRITE)
folio_mark_accessed(folio);
- if (folio_test_uptodate(folio))
+ if (shmem_is_block_uptodate(folio, index - folio_index(folio)))
goto out;
/* fallocated folio */
if (sgp != SGP_READ)
--
2.43.0
next prev parent reply other threads:[~2024-02-09 14:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240209142903eucas1p1f211ca6fc40a788e833de062e2772c41@eucas1p1.samsung.com>
2024-02-09 14:29 ` [RFC PATCH 0/9] shmem: fix llseek in hugepages Daniel Gomez
[not found] ` <CGME20240209142905eucas1p2df56a08287a84a5fa004142100926bb4@eucas1p2.samsung.com>
2024-02-09 14:29 ` [RFC PATCH 3/9] shmem: move folio zero operation to write_begin() Daniel Gomez
[not found] ` <CGME20240209142903eucas1p17f73779c6b38276cd7cefbe0a40f355e@eucas1p1.samsung.com>
2024-02-09 14:29 ` [RFC PATCH 1/9] splice: don't check for uptodate if partially uptodate is impl Daniel Gomez
[not found] ` <CGME20240209142904eucas1p20a388be8e43b756b84b5a586d5a88f18@eucas1p2.samsung.com>
2024-02-09 14:29 ` [RFC PATCH 2/9] shmem: add per-block uptodate tracking for hugepages Daniel Gomez
[not found] ` <CGME20240209142905eucas1p14498619591475e416a8163dbc96c90e4@eucas1p1.samsung.com>
2024-02-09 14:29 ` [RFC PATCH 5/9] shmem: clear_highpage() if block is not uptodate Daniel Gomez
[not found] ` <CGME20240209142906eucas1p2c31598bf448077f04eef66319ae2f3a1@eucas1p2.samsung.com>
2024-02-09 14:29 ` [RFC PATCH 6/9] shmem: set folio uptodate when reclaim Daniel Gomez
[not found] ` <CGME20240209142905eucas1p150b096fab4b8a684b416d3beb0df901b@eucas1p1.samsung.com>
2024-02-09 14:29 ` Daniel Gomez [this message]
[not found] ` <CGME20240209142907eucas1p2024d2809a150c6e58082de0937596290@eucas1p2.samsung.com>
2024-02-09 14:29 ` [RFC PATCH 7/9] shmem: check if a block is uptodate before splice into pipe Daniel Gomez
[not found] ` <CGME20240209142907eucas1p12155b2fb002df5e0cd617fa74de757b7@eucas1p1.samsung.com>
2024-02-09 14:29 ` [RFC PATCH 9/9] shmem: enable per-block uptodate Daniel Gomez
[not found] ` <CGME20240209142907eucas1p2c61ae37b2a1ca2caeccc48b2169226f2@eucas1p2.samsung.com>
2024-02-09 14:29 ` [RFC PATCH 8/9] shmem: clear uptodate blocks after PUNCH_HOLE Daniel Gomez
[not found] ` <CGME20240214194911eucas1p187ae3bc5b2be4e0d2155f9ce792fdf8b@eucas1p1.samsung.com>
2024-02-14 19:49 ` [RFC PATCH 0/9] shmem: fix llseek in hugepages Daniel Gomez
2024-02-19 10:15 ` Hugh Dickins
2024-02-20 10:26 ` Daniel Gomez
2024-02-20 12:39 ` Jan Kara
2024-02-27 11:42 ` Daniel Gomez
2024-02-28 15:50 ` Daniel Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209142901.126894-5-da.gomez@samsung.com \
--to=da.gomez@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=dagmcr@gmail.com \
--cc=gost.dev@samsung.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox