From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A18CCC4828F for ; Fri, 9 Feb 2024 22:16:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 376386B00A0; Fri, 9 Feb 2024 17:16:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 326056B00A1; Fri, 9 Feb 2024 17:16:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EE126B00A2; Fri, 9 Feb 2024 17:16:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0F9FF6B00A0 for ; Fri, 9 Feb 2024 17:16:46 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DB2A9160122 for ; Fri, 9 Feb 2024 22:16:45 +0000 (UTC) X-FDA: 81773675970.05.3894CF1 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id AF2022001C for ; Fri, 9 Feb 2024 22:16:43 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=2l966Jw7; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707517004; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b56kcOPhsUTlBGFNjwOpS1T7/UtyqhN45SZoCKOIun4=; b=ya8nLjsLdXTeBzyg4ELuRuJ4G5avGvv87P88MYLPvYCOsBGynQP/+ues653Qq/V6xt+qnB MWsvkviYh8WKKFa1hHQcd6aAmytnTNQvJnYq/r3gZnk2Xr4j/iuAW8BXXSrAVySOIndcST 01k9jJTwiX6b9bKo0BwCSSi70d83Qt4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707517004; a=rsa-sha256; cv=none; b=uNpP4R8Xx9UJ1MV8nfyydVTCMqQODH86K3NwPTG18eZzVcLA7RZAhEMhYPcEm2Qfe9s1Cx hzi3n9VRxldQ3OMT6dHWURR2+8kUgrsD0Y3F/m8OjYu/aBkOshsfKFJ+RJh1xdrfU94xzi k7PtGCuB6nZvnloDfjSukGx611IzVNc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=2l966Jw7; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7FE8ECE213A; Fri, 9 Feb 2024 22:16:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E195C433F1; Fri, 9 Feb 2024 22:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707516998; bh=u27ysSO49hF4SYPfEeRGZ1NoCOVbBXK8slETCK3CYUo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2l966Jw7LqLUa7lGzWxyNFHrachqqwLh470CzhPua2TSEVGVOCpOdpyGMJmSsgQqe 5bfzHdQ3CwpUHouXA+Qgp+r6Q34jaDtZQAnjZCM1Tv3gmWv88LXdm9a3Zp5blhEzae n2lOvvpRsfJjnwNQQ0u+pBSQB2gtpO6dd8Xezohc= Date: Fri, 9 Feb 2024 14:16:37 -0800 From: Andrew Morton To: Anshuman Khandual Cc: linux-mm@kvack.org, Muchun Song , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/hugetlb: Ensure adequate CMA areas available for hugetlb_cma[] Message-Id: <20240209141637.129e417747ef130255db620d@linux-foundation.org> In-Reply-To: <20240209065036.1412670-1-anshuman.khandual@arm.com> References: <20240209065036.1412670-1-anshuman.khandual@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AF2022001C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wgtudyc3mtgdry1m1dipo8mst4px9gte X-HE-Tag: 1707517003-409469 X-HE-Meta: U2FsdGVkX1/uheLz5uqndIGQYEpmxO3XvaOj0jwGiae3VCSPyXHaedGuxxsvscZD8177ppjgFMOUy31TgP7iCrbQbACptfL2jR9MsuEhj/m6RaHFfeqpI0u9qMbMIQClDOMr99+0wRrlT+ZNNxJFSrIiz8FB2PMQsG0M7dqyYjg/eBQb91NfYwzLDR3jiexA2qqNcEKgovDSWWvyJ1pKQqYQ2I0WzwhMo5Q7r+bLiboLpTWGjz4Nvq7XxEG08UnUZqfndTd9+yV2r6mPGJMmP6NJV00cPp/NCdQpo7I9VnemPvMPIOMxDGBsgvxvOjBQ6exSnD+/HaZVY4GKIXckgSvJX9vEUNFSSjGsMoojKy07htrXgfwen+qHNSG7zGYt+52fMOKGkMANBf7xeknBBgvcCly2Yn0grnFT/DJpv4ZzzSKsADopTrjlhUQrNW1PArvQfXd9ZS27cDbT5e+NFjgjffnnHRjsubSqbJ2N/2ERE7O0y0kS4QVHMTPQ5kMTXGO6NMjnWCOQYNkEmUEron7AABd2ei552BKlEE7bQoOne1BWu32MMnvSBG5zPx2F64GvF+KykLE696TuiQ43sZaiYR3mnKtFVOwzTWlCyWqaCrraY94QZurZBPpQ8hcLjN6QYh5STxoI9yWgd70xuIudoftPDCQTPNn226Gqfu8gKteaU7f1Pg3OO7dX8b8hvi2Wn6Uy8Z8YqbokX8nBtNTe+HW0YUq0M/2Vg8ZYuXwHrfp1k1hfHA8s65mZfviz9gIBb8f8FZryKztzj6sQHBeDgLodNxnlHn7eS7MHDdKMSXJIk5i699rHs2bTZKZKBLkBkgzml9Xja3AJ0PvKpWr7VdKvnwiax8gyizVBIkUSADFTQbnR/fttVvMQ3kecuJoI/NcUiw8TUuqqALxYPl1z+0speQiDnZx+PIRhe1Ks0qTrXf0bAEMPXwZeWQL0xrQeAtYKLkN63V4D6f9 Sy162XPa rmA+KfdkSDnd5h2bZF4OAGDZ2CTdaQniRzZhGtgXJZLSRn8jLkdmZGPbJVfcZHnk6Scw20L3bFge+5aiXy91sp9UZIiDIzA2ROsYPiefT6oSdintJ3vUWpt51D/+8/DuQ4amqffm8NLxwIFwbgRpmXft41teTy4jmzsHW9/aeDE9hSF9bipA6kxxCDPqEnkNqS1/PwRSKQsbRxJWw7waR1gUuVCY5vJdgSwVEHONTSYyCDk5jelHE5h9LBnizCMJzSuNBPBrW7d2HvAHftbXc3smO/9MXqlbN0r5CXY9YKOpwC32p7caReuEV+/BlT2PPjI+MwOD2+Bg26M+P/P2x+B2JEvI5+60JAToPR0Kt3EjtfT54LAwq/dxgEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 9 Feb 2024 12:20:36 +0530 Anshuman Khandual wrote: > HugeTLB CMA area array is being created for possible MAX_NUMNODES without > ensuring corresponding MAX_CMA_AREAS support in CMA. Let's just warn for > such scenarios indicating need for CONFIG_CMA_AREAS adjustment. > > ... > > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -7750,6 +7750,13 @@ void __init hugetlb_cma_reserve(int order) > } > > reserved = 0; > + > + /* > + * There needs to be enough MAX_CMA_AREAS to accommodate > + * MAX_NUMNODES heap areas being created here. Otherwise > + * adjust CONFIG_CMA_AREAS as required. > + */ > + VM_WARN_ON(MAX_CMA_AREAS < MAX_NUMNODES); Could this simply be fixed up in Kconfig logic? And I think this could be detected at compile-time? BUILD_BUG_ON()? > for_each_online_node(nid) { > int res; > char name[CMA_MAX_NAME]; > -- > 2.25.1