From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4592CC4828F for ; Fri, 9 Feb 2024 11:00:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8059A6B008A; Fri, 9 Feb 2024 06:00:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BFD86B008C; Fri, 9 Feb 2024 06:00:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A36F6B0092; Fri, 9 Feb 2024 06:00:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5AD456B008A for ; Fri, 9 Feb 2024 06:00:00 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 28C30A2684 for ; Fri, 9 Feb 2024 11:00:00 +0000 (UTC) X-FDA: 81771970560.20.5B5FDE1 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf12.hostedemail.com (Postfix) with ESMTP id E6C6740010 for ; Fri, 9 Feb 2024 10:59:57 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=crw86jVZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of horms@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=horms@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707476398; a=rsa-sha256; cv=none; b=Ux9XkliPEbsgSbg4gqpQK5An3eVg9Ezj7LK1LeusH+Lvk80bx+osrM9oL8bzz9mhCzG73U SCltMLeSQzlJNp1pwe8uyRkvdM8g0Nh/Pq2sFtMrw5vg+pFZJqNtao7auS4cMxlLVv7vPV 7o5/OK2Dzpvc4SVI55ez0GtJlKWtlIM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=crw86jVZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of horms@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=horms@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707476398; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gXX/i/M5tWLnTDuO7j74CGJlZn3xNujOQGGxRZzPWog=; b=cdHOrhCPsLXFgtdrNaZ7S3LG9FC3lK5kTNwYodkS4A3so0TxlhMSkP+qRIoFmMQyE528sE orko1tX2Cb5VWWxxQyxopQJEOrp6Co6xqldCymo3nW8ORXd6K3OBNI6THmjEOVWz5Ho60s CAy38efrt7aMG8oyIzsUTCgBTO1HioY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B8C23CE1FBB; Fri, 9 Feb 2024 10:59:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3E54C433F1; Fri, 9 Feb 2024 10:59:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707476393; bh=FFLWrgG2VHp3uRF0u3LiE7N3T26kky9+Tfd1oSmlI0I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=crw86jVZNx+OjqvNSgKMiIlh1/TuyaFkxQgr4lOvuHwA7ZCHOLYVT+QyTXRvtr8E8 /s7GrX5Ss4XUbblkURa43fzs05SGNFZ7inrSJ4HeSd7L7bmwXAhbd1w1yhaWt7NOpw f5z1Zc6CZuPHLeBzs8rCrvIz4U8M2Jnm/Mj4JBKe8k9/KgN/uOtWTgEkjW+JqYw8IV 4SpzXjCDYQzlg94S1xkIFeFlgcqxu0I7gds9B/lmVVkgBqZuhMYxN5ARWrTr2xVB+9 XrSObopVoHJQlZGsPJkEBgToDVIebtPdh4CWv87vmMkSMXFS8QXJ2lyKZwbtNoKocc TIa6PF8//FkEw== Date: Fri, 9 Feb 2024 10:59:47 +0000 From: Simon Horman To: David Howells Cc: Steve French , Jeff Layton , Matthew Wilcox , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Christian Brauner , netfs@lists.linux.dev, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Steve French , Shyam Prasad N , Rohith Surabattula Subject: Re: [PATCH v5 09/12] cifs: Cut over to using netfslib Message-ID: <20240209105947.GF1516992@kernel.org> References: <20240205225726.3104808-1-dhowells@redhat.com> <20240205225726.3104808-10-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240205225726.3104808-10-dhowells@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E6C6740010 X-Stat-Signature: yaumq5jyhu847g1ryjksh1hyzeibm1gk X-HE-Tag: 1707476397-457746 X-HE-Meta: U2FsdGVkX1/tdbVDcsIxZXvRbwsp8YHPKlwPyk5o7/iWsNUshTgZJj2Ndj1c4OpSypNoADD9WG7bbhVjJONBMIty2T1eArhPUdZnCOFr8TJW85r+k74rpAA2HykdPAbG81t9fapxSujC9K06yf956PmoC7TH6hJWdV39QaKMids0fES7COlM1hEbNoNXwnpojHvTwaiOBzV/XPWMhYHizbcXDkxN22RFfTa29D2lnp5+bzX1mop4R3Ou9hJlM1C+F7ZlUxJkBaBQJvZVuAKRen2PnnzZS1hZBU4ZbT4xH7UfInIHrYGjjPISgL15eue0RTRwzJwCHneUf75+fZWD5sXWr1TvjHitoi60ELIMefYeY1Teu8t22JQIW3SiAcau9LlWL6LubUdYcljsgTbtiM7jUAVaJNK91WObwhRMxDMHMypms3Yt1WctviOwcpwiTXuvPTh7JDDWATcp/J/vITtBpBqNPLpYG4PfoKSK0Y7kvqIKkjvNoIK0FT72dTa8ZwBrd/rSva6Rwp4uiTKG85wdZuocMs5qHKU9sW7HzGlGPxy1VZZ0BFf3cvDV9SNK3DRYHgQvzAemUuLEG/VhvEpQ/kg3WO89rlKjyyXZhtSPq15W4yAesfaMy3c+o6wPG562dgChZQ6xZR/QmnUOL5ovx68DCUGMx0FQqHTzGMHHBZAUCiZ+ovVqVyZEjnsr49r8e7/CY1Fh23gC/VW6ua8OzbxmJJMdOcBodbpluZhKFUzDGkCVV3IQh3vXxW1Ph2oEQgIneNmWq3TGrtmGJyGS+VJQppuEzEQ9Ns0kbt/dBJMrGguIwxWp5bibzMQwwCAQ5cSNeOx5WeFVpdbAoy4oFa2o+O+oiLJGxHhzLYqBcUaV1aIjAJ4eXlwiuFHYDL6aO3tJUAe9hGMriimexLoowHP+NksrykIuHTovgGttsJSC7qYTntuAVlGyydHzzJCohsaqrZdxC5ZF6Ws RwwpWuGi N/kp0r/zxVKlQS0CXYt9sBpWYLRpXwrcUV/3l9OV+zpavFC+KFdfHUSqxa2qSrN5m4HjCd99Q/3LUf8HXvNT3phaOyFNSWxqcElwtkJVe6bMHKFJtKgdpWxztjpCwH4rLmInaKhWG2kjcYN5aJtskyR5VpkE4N+j5bbjqiWBduRdYqdJNaCYNnYAsAhYAhJt9PnZvkfVLztjCR4eYCSYh4nrcWSoXl9xWw8Qq4uw9CwXmnkIWY6nwWpT9+0lbbFc3eRYawjRRC61LtIg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 05, 2024 at 10:57:21PM +0000, David Howells wrote: ... > diff --git a/fs/smb/client/cifsfs.h b/fs/smb/client/cifsfs.h > index e8e0f863e935..5cd547b7b5ea 100644 > --- a/fs/smb/client/cifsfs.h > +++ b/fs/smb/client/cifsfs.h > @@ -85,6 +85,7 @@ extern const struct inode_operations cifs_namespace_inode_operations; > > > /* Functions related to files and directories */ > +extern const struct netfs_request_ops cifs_req_ops; > extern const struct file_operations cifs_file_ops; > extern const struct file_operations cifs_file_direct_ops; /* if directio mnt */ > extern const struct file_operations cifs_file_strict_ops; /* if strictio mnt */ Nit: this hunk would probably be better placed in the patch at adds cifs_req_ops to fs/smb/client/file.c ...