From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 965B1C48260 for ; Thu, 8 Feb 2024 15:35:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C16796B0071; Thu, 8 Feb 2024 10:35:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC6E56B0074; Thu, 8 Feb 2024 10:35:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB5536B0075; Thu, 8 Feb 2024 10:35:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9C6DC6B0071 for ; Thu, 8 Feb 2024 10:35:56 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6A158140785 for ; Thu, 8 Feb 2024 15:35:56 +0000 (UTC) X-FDA: 81769037112.30.A385E70 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id 12532180012 for ; Thu, 8 Feb 2024 15:35:52 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=KQl0RuAM; spf=pass (imf06.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707406553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GEcT7Dv26ItwbPQBhNsHVSaIeMNEoPZCK9rZiUkJ8dk=; b=l6n5rMBx+mLtuCt8yh7eUkZWwsGQfys1uKX2RmxxDNoIHiWhSMiwvR/Bw9A14uMn2862Rp 0S6Iiz0FIMKkmVWeAuRUfIdVrnlbk/30/71kcYu/KI5dv4JAbItJwEm5LkhyLAh9F3TGw9 LICI8I2e0pPRWYFcVjIBRhpWJ6dyqgk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707406553; a=rsa-sha256; cv=none; b=0e1P+EZjZJl43D5pBUiAiI4fzLw4jJmrCe0cgJvpAGmrbZ3UVAeVghZmN3DcCoOqaVtCR8 FEE/GycnKpf0PnVcLh92imTPKyilflJ5ic2wbBGQ+DY4eDzSwT0f28dfW+2mIvB2e/q/mS DKqtKcb/zVKPrs4qvemNPZ2ma6atUVI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=KQl0RuAM; spf=pass (imf06.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 54B34CE1D4E; Thu, 8 Feb 2024 15:35:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C68F7C433F1; Thu, 8 Feb 2024 15:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1707406548; bh=Oyd+0UxjHh1jKnK11zlznPLxJVZq1YhY3TWT2JBQK4I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KQl0RuAMe+WdOE/LDDy3xatZEz8RXFLJ2liVNPHOOif2Ui/V0aymQ7CZRV2jT1OQ4 beAM6RNDfy49jWgzm09Plsu7hram53aUgPfAOmrMdLTy4y5qPfb2PUkZuPWA05JgMP 07+IOiEeobpR363RjzTmorEP9HVwp8jiipWIWjI0= Date: Thu, 8 Feb 2024 15:35:45 +0000 From: Greg Kroah-Hartman To: Alice Ryhl Cc: Trevor Gross , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Kees Cook , Al Viro , Andrew Morton , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Subject: Re: [PATCH 1/3] rust: add userspace pointers Message-ID: <2024020859-lusty-ladylike-29d4@gregkh> References: <20240124-alice-mm-v1-0-d1abcec83c44@google.com> <20240124-alice-mm-v1-1-d1abcec83c44@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 12532180012 X-Rspam-User: X-Stat-Signature: wi8gdajx9x9tp8zywqax5hjxstbkaao1 X-Rspamd-Server: rspam03 X-HE-Tag: 1707406552-473332 X-HE-Meta: U2FsdGVkX18bRNP8vOYxucJfzEp6kdPmxasnESe/nNdFuxZVJHEjkZEoMoI4M9JNvyGn2uZTHVUvQ30KbQ63EqQ/1v2+Fp5A1isDK+ppEHlmKTyHG7c1AOwUexR+n/X+dO7wo+KRP0Uo+AlAd0/2ukGYjoPfd0LvBlgUkjgOsKERt5ExRV8Y3smpkQ2ckMWcPmnfaZup+2NeIgeGVDTE8sF88c68IuSYFFdvNuePDRIjiLDdtqYsfnoTp4MeAhN47hbf1xSxifv/RPYCSAmhojDv/KWUpaxbe+rAf31y5c6sMZIXXUid/2NQdgnfrNP73RBqxNu+L/jG1HolDZR0aSkbyILiNSQqpZ87iIq4EAu2gxqBGb+yuPoIsQCfcfRl7qFiEE2xdR/fjBKrAKwkyV9OYUArJbSPf3c4xUefjb1YFaNbRCUXLAMo7s3AdbZ2GhEZ41TqGiPiTbWsHu6Te1+FLisz64b8H23IMYBm3arnlcFRA0lNX/Qd3hSmuCI2P8lAeK4VvnTif9scqcJjpplr7xte0wPkHUwdw5gwTlDI5Cn03aQdR9ue4+5sUk4QByhOdGKABkigMRFNPX9MBAKP2qhG7UvmKn7JH/INBuA1gIHkOODRQ0tjqBG8ebGOx5YaB9zoxXNCVpmSN9ptMbeAU6iLs4oXm7JdhKScijOtHXw5gpM4t4FrjGCyz3cvtRAZ/g5U066172IJdLtRw1s+qwWDo4Sk7K30DkupB5vJgfHWtwhcMlS6+1qiJhasQ2CtV8fCuKoU+AjKT5tSJS4H2ZkOEHwGw6gCNdRWmZfJVKOxyIqRPtFRsRMA3+E98W4iQeHD+soDuv/J6ZG+HGtQvBpQUtPgSwS3M3XeLtT3tM0yhcjGAZby/ukf4mPKW4iazVcqoJ1yL5pFrJOH6hwCZwdr6t/ihKvWTaB3AmjsAgp+FfUPskivKn/KfEuWJ2rcmjwZ0B/qZEXHB0H Y2ICTnm+ 8/9A2lXx33is9yYBaKnn0fv0TgmDd6aKSIfauHzUO6BuP0u6td5LVCYR+51YO0pOkMkot1MMSmKLkUSf78rJa0QJA4pCgXim7j9r8h4ycKmioOXJZrzQziQmN1/gwIh5P4nIqzbAMuTlGFCcFv/yXub4lsM3AA5s1c1MVxWSECqW3iDrdRi3mTbAljqNqHaAPUrgJ6QCDqnafVGEM22/uXtMzSVc6rIVfxjtqHcCZZNxIJWC6f5MX3tdeRxY6/DdJsvA6FY6gryZp/oXQUvAalYQt0uuTk5Ub+Tt2dWDCf/mW/L7uqZjGo9kuDQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 08, 2024 at 01:53:20PM +0100, Alice Ryhl wrote: > > Is some sort of `Debug` implementation useful? > > Leaking pointer addresses in logs is frowned upon in the kernel, so I > don't think we should include that. s/frowned upon/forbidden/ :) Along those lines, you all are tieing in the "I want to print a pointer, so hash it properly before I do so" logic from rust like we have in c, right? Ideally you'd use the same logic if at all possible. If not, that probably needs to be done so that you don't accidentally start leaking things. thanks, greg k-h