From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F97C4828F for ; Thu, 8 Feb 2024 16:04:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DC816B0078; Thu, 8 Feb 2024 11:04:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 665816B0082; Thu, 8 Feb 2024 11:04:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 506456B0085; Thu, 8 Feb 2024 11:04:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3B3AB6B0078 for ; Thu, 8 Feb 2024 11:04:12 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 04EE2C0F12 for ; Thu, 8 Feb 2024 16:04:11 +0000 (UTC) X-FDA: 81769108344.17.8BB5B29 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id D20DE400EA for ; Thu, 8 Feb 2024 16:03:40 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QXka1czU; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707408221; a=rsa-sha256; cv=none; b=VfaKsjCN7xe5CqEWizx6nkVAxqv96Y32dpisTfDMwUzS8hUji95v4CD7dqElxCIgMVRApg wvXMcfPDSpwedm12tM3t7NgoGM9M2whUcq1i5sQW99fG73XlGYrMK6er8aRoMQ8htukIjj feh94pd9CBm6mynRzWoHu2m7+LQbfJQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QXka1czU; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707408221; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jW0uFQPbD63mebNe0mCttT7Vc8i704z4fN+ymF+pF94=; b=cyZQwKtHv8+HAZCp0pViob6/iECLH65b3ZR46uuwz4KCDy8y2cQr8QuCjfOz1V1WJoJ/rC E5g2maOFWixCzhF9AWxG9laVGYrxM+ZWfE+tietSgzU0sa10AHn9atfieGGXoStN4lzq2e bqzg2KVj2DsA0nnT+ySBBG90rLZVKz4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 539FFCE1D80; Thu, 8 Feb 2024 16:03:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82305C433C7; Thu, 8 Feb 2024 16:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707408216; bh=Igdsqh4bs6NiYnvDyhbANp18ct18WHK41QmYJ0p6Duk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QXka1czU0HxJAe9/Z7tqp2IwCy9Q7ND1ud7yKWgr0aPaEVbYVwqMOntZqEIM7tDup fyZ/7DXkg7PF38L7oykrP7viPizC7oA/enqhJFWWvgGBGU7osfq8yChKKHb+9vVdwO elNtxaGsUW1a9WOhIyyvO4IMI+3unJKVWXzamEiVLdFxl3TgXEkfdVfgEC6XFo2r7o /Q9X/yELfNXpTjnehQAQOAIH3aiUBAkAAavp404eHDHl5D5E47vxGbgAJYonZmal0W e9Dm1oRowc9Ml0tArZvIPSo8GFRBsC+d1PMwvQis4p2xEKNRIV9M7qI6OXS9on4RmR jdnJQ2p9qRXJA== Date: Thu, 8 Feb 2024 08:03:35 -0800 From: "Darrick J. Wong" To: Andrew Morton Cc: Matthew Wilcox , Christoph Hellwig , Hugh Dickins , Chandan Babu R , David Howells , Jarkko Sakkinen , Dave Hansen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Christian Koenig , Huang Rui , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, x86@kernel.org, linux-sgx@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH 2/2] xfs: disable large folio support in xfile_create Message-ID: <20240208160335.GN6184@frogsfrogsfrogs> References: <20240110092109.1950011-1-hch@lst.de> <20240110092109.1950011-3-hch@lst.de> <20240110175515.GA722950@frogsfrogsfrogs> <20240110200451.GB722950@frogsfrogsfrogs> <20240111140053.51948fb3ed10e06d8e389d2e@linux-foundation.org> <20240112022250.GU723010@frogsfrogsfrogs> <20240207175621.dd773204e7928dbeee7a92bf@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240207175621.dd773204e7928dbeee7a92bf@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D20DE400EA X-Stat-Signature: 4t9cb93bjci7khip98dyyqwpr6hx7yiy X-HE-Tag: 1707408220-870031 X-HE-Meta: U2FsdGVkX19pD3rSQ7r/ByTx2ac3CwhLBnGmBNlhOFLgZ7WrwKSvP+zuUjP4UvpyIUROvuk1f0VjUDB1rpyb+H1iIqdNecq4DFTHIfVK93C/sIyQT9KAa9EPWcIxPZW9FgMrOUAANO4uJFsf7SWyBJeDr0lm2FSC9qsBjHTtXYyQ6Fh7J15fZamc+6lNICALbyAIcqy38KUjNic0fTIxpQF9SHhtKbwCNr4aRGUFDxKaRNKf5j/i6UxmFEiS52m97AtyoswJeNEksORaPAAZG9RArg6J2Ij4/VGtQ97t/PLnHOgNm/Id1BaNYp1C3MY5uGd4Y//ay7tpt0iN5/epoBI6n81YSHmM0y7RjusOLB/iu4dGPKMCI2UFZdcS9g0qfGzwr2fr2tQPfcwYSyiuJPba6ee13ic9PFq6nXUsqePCTuAbwIpPEm9CvOz9LUOw+HE6H/uiJxkwuuR10SdBhmM4ns5Yzm9QNKQB0Eh/yIKdxeumXqU/1QhlmR3T14iQfecRJ++RNdC7sbrvXvoNKEPpTc4JYxSwf7wNkuzI0E20rLDv5eSOhf25bqWdUzEVYE1C0a23AnfcCUr8vTII6UE/uPRnDuLnKmtXJ9ByfpbVBm8AuhH94BVy1eD6Hq8I0YxwS9wWKCpfsh3hXokmwfHLzeIMxZHYcrt3dUloLiCEWaoQNdkDnJdDkqeu1PUbvhONrQwVi1RjMnxvbOhhDoLqZhaHT+/hmYLB8rB4ge9mmKph3gm89CBj4MJkbSygGGrgl6WleMHoj4xI8uqF5ipkGlDfXp80rsOrKGWkzq0HMHbgaH0OaBVF7GgPAwWQtmQzGhubCkRvMJW32xASAI4YwLCajkvzmKgkIulcDpTJo6vNUnwDfBO8Pr74dWoF91Nyb3SfZr5lFiQAT3WB8AXrW8QBUqQvn+lsGGrOwGXDspeVrszAt+V0Mi7jirptHc57D39wUG+/ZhOBJE1 9ItQnqf9 Zef7lP0+ls2Qgz4AokSuDXc6ml5ftc2urlKtm4hXvCinD/gCN80PpQnc8iX2oNhlBl6BBqg75yrcEV26sNEqyO0VSGQq/ad3IuT3rsWEQg+jcigFnemVG/00lzlRWAaaCTwA+oVOnD2RAz7M4tTpJ6o14x4diqtEWGbvDbg6/vfaWAh965Bs3yUg3q9iGTai/euK1OS2HA4/UNlbeLJ55p6MMq04XwUtQAi7ffGjy4uaFEe3SbvMtfc8UYyMpBTHhmkXHYxeQ61MsLiPM7zEdnLV1a2tK3iy3cl4A1yXPwH18Xjhua36CYyIyOqrqtxGUIyTGMGQZLkGP/NA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 07, 2024 at 05:56:21PM -0800, Andrew Morton wrote: > On Thu, 11 Jan 2024 18:22:50 -0800 "Darrick J. Wong" wrote: > > > On Thu, Jan 11, 2024 at 10:45:53PM +0000, Matthew Wilcox wrote: > > > On Thu, Jan 11, 2024 at 02:00:53PM -0800, Andrew Morton wrote: > > > > On Wed, 10 Jan 2024 12:04:51 -0800 "Darrick J. Wong" wrote: > > > > > > > > > > > Fixing this will require a bit of an API change, and prefeably sorting out > > > > > > > the hwpoison story for pages vs folio and where it is placed in the shmem > > > > > > > API. For now use this one liner to disable large folios. > > > > > > > > > > > > > > Reported-by: Darrick J. Wong > > > > > > > Signed-off-by: Christoph Hellwig > > > > > > > > > > > > Can someone who knows more about shmem.c than I do please review > > > > > > https://lore.kernel.org/linux-xfs/20240103084126.513354-4-hch@lst.de/ > > > > > > so that I can feel slightly more confident as hch and I sort through the > > > > > > xfile.c issues? > > > > > > > > > > > > For this patch, > > > > > > Reviewed-by: Darrick J. Wong > > > > > > > > > > ...except that I'm still getting 2M THPs even with this enabled, so I > > > > > guess either we get to fix it now, or create our own private tmpfs mount > > > > > so that we can pass in huge=never, similar to what i915 does. :( > > > > > > > > What is "this"? Are you saying that $Subject doesn't work, or that the > > > > above-linked please-review patch doesn't work? > > > > > > shmem pays no attention to the mapping_large_folio_support() flag, > > > so the proposed fix doesn't work. It ought to, but it has its own way > > > of doing it that predates mapping_large_folio_support existing. > > > > Yep. It turned out to be easier to fix xfile.c to deal with large > > folios than I thought it would be. Or so I think. We'll see what > > happens on fstestscloud overnight. > > Where do we stand with this? Should I merge these two patches into > 6.8-rcX, cc:stable? This patchset doesn't actually fix the problem, so no, let's not merge it. For 6.9 we'll make xfile.c clean w.r.t. large folios: https://lore.kernel.org/linux-xfs/20240129143502.189370-1-hch@lst.de/ I don't think we need a 6.8 backport since xfile.c is only used by an experimental feature that is default n in kconfig. --D