From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07CB9C4828F for ; Thu, 8 Feb 2024 22:12:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79BF08D0005; Thu, 8 Feb 2024 17:12:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 725D68D0001; Thu, 8 Feb 2024 17:12:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A0328D0005; Thu, 8 Feb 2024 17:12:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 43BBE8D0001 for ; Thu, 8 Feb 2024 17:12:14 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DEDA91A0F84 for ; Thu, 8 Feb 2024 22:12:13 +0000 (UTC) X-FDA: 81770035746.04.8831234 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 29E4C16000C for ; Thu, 8 Feb 2024 22:12:11 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=R1wYTsHn; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707430332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hYvz2YjHfvW3HsdTZVUvgW7AY2zWAg/r8UwLowpFBxc=; b=cNAcb/5MD1Wa5aPcQbwd/797sVh5v8p1bjgr8YY1iRfP8yzr+xVBKdKYuJYmUk5ikEwjHT zq8elckgDvKKCQWW/2MekcpKKpTskmAQeciEBOk//a51/BuA+QQ0lWJ2qrGeiuccY5ORZe csvRE3yMtpVR20e5OB5jpSREtAijhw8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707430332; a=rsa-sha256; cv=none; b=m6HC0xJ0QwRdiD36c3szAojZ/SFFjDeJqEK6Fu1LbupsohNp/Xzi2BkWMXTVMXql4um7hx b9o1on0aUsHwZQHhwd4m8W6ToXjF3xzM0TR9mV7BKreOvDHdxNees5vkLfjEZgPwxcN8wL PljOc2qwtgu88dAVwCfcF09hnAqbidI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=R1wYTsHn; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0E35C61EA3; Thu, 8 Feb 2024 22:12:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A1EDC433C7; Thu, 8 Feb 2024 22:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707430330; bh=Fyeg55YvWWKTvSypIQeno+CRzpBsW/T+sUqfpxDTOKY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R1wYTsHnJ7RwWXrnxfaVjjAZ3dexKuAEngkW/Ur8FsjgjOv5LrCVxgG63mCt5S1bW xOR1+Rk9+QWXFTmjstP5rxW0/Q24vkNWH3xlEPrzniqmidjCYVebtwTR99k/1VS4BP 4Jgrk1wSFLa1obPh5VAEEXPyNFSRObXoKwidxpvg= Date: Thu, 8 Feb 2024 14:12:09 -0800 From: Andrew Morton To: Mathieu Desnoyers Cc: Dan Williams , Arnd Bergmann , Dave Chinner , linux-kernel@vger.kernel.org, Linus Torvalds , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Mikulas Patocka Subject: Re: [PATCH v4 01/12] nvdimm/pmem: Fix leak on dax_add_host() failure Message-Id: <20240208141209.a73f4d3221f9573468729b8f@linux-foundation.org> In-Reply-To: References: <20240208184913.484340-1-mathieu.desnoyers@efficios.com> <20240208184913.484340-2-mathieu.desnoyers@efficios.com> <20240208132112.b5e82e1720e80da195ef0927@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: fk9e9jk5psux7n5kzhbdetdzekjctg6p X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 29E4C16000C X-Rspam-User: X-HE-Tag: 1707430331-262472 X-HE-Meta: U2FsdGVkX1/lNrup1xrD13SeWh4N9NOhtb9atNhQ65ONTMiqYSp/C9kxsPoN2tr8KIj888D9cl0JBHH+TB1r1LIQKqaoe2siDeoKTn6XGkDhQ/BJDx6ESLbXgfAF56p/B6bMHoisHa8XdgzNFRg4SLnlDR0ynifJw8+VMjHclhO8gUfHcEU8Ip/cVTPQv/EBmPXVMWLA5aMwnPzNxkXB+HFAHAZqmfSGPy6g8Liqb5IRy28ELfrUSBAvpD7qZ2OOuTf/uFBlki9AtAqTHdFmTVFcbaPuskIW05n/AnO5QbSNqQ4l3xIPb/ZO4z4lsuzAEdOYGLwZyURBozSAXNRg9N3IJZhgXoOu/wmUgtyXUv9eB4djrw6kJcw4FXKb8j3uqHLvWdSVjtT4fR9I2Qx5IiKEN3fUHX7LO3/Y1NFQq9t3QaXaI6ceY2hRH/N6X4SxWTvA2BgbD2XE9yp/g6iPHEkvI/X+j5jMVUITnxOQWu2J6dtMPAjnhpwvK7+UxEPl2jnsAB6aKwE8oqryHZZSiJkrq6VwZ0eRjOQuhnobhJK4YrA+QROyjG0/aOnzUBjHpncdFiAPSkFqOw22cuVBFQFZp4QDz6v1xOPp5bN6SOp7kDu5mxxw+Koae9NL9TafRoqDsodpBCGEKThUvhUSo9DBv2E74OkJHXqksTp4rXnrad0wvQSzExPZh5BT3GJzm0K6mditJ7An/IXXLN8dsBIXUtTkZ247ru1/qmiG+J6HCnokKKHPTE34o0YpsyKNr01WEu3txLSdpeUM3h7epXvjIFgD2xp8HBJ79Y8RNqtdFrEcuj0mWiosJAV/2XDP9dUCbuhl32vetTPl/9gGp8tSUX2I4YdHk/TjayZibnSuH2BDpWLuDZPqlBmRVyX8KriyrVZgDeKUL25DT2mWcCInBnJ9egSbzidISu7KP7bN4q8BuVoWCWWWaC8lwYLc9KMkjvsl21JMkyPwOZH xzgSnWT5 fpnXuPo2yELHx8V4fd/8Xsko+KbJpqWT/7o5IHgvDYc3x0Vkm62k2d60QwchuykvvPu2/1OmMLd9bwJsuEjP2AvGNPJKvMY5wl/l+2naR6b2P6CjgHSfc9jxCfqDhIsJaEUFeCWEO/L5OpEgVgYbAmOO778YWd6MU1Na8UCaoRP8aFQWvRHgX2acdrzzWDS14Rbjvppv8vMWnGttGy7eBCAnLdb05gTYfMXhTy28hXFxROtVxKfyOeX+IsS0IrHSaUfzI1MzZpY+k2uAfTt7vrTth9JXSegH5DY2bC5n2HqoUVITKOj1ZVr0STFryyI2MBap/C+TyH1G2TEMARg9tedP+7lkJ1Hx4ttLpXsxHacbliKs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 8 Feb 2024 17:04:52 -0500 Mathieu Desnoyers wrote: > > The series seems useful but is at v4 without much sign of review > > activity. I think I'll take silence as assent and shall slam it all > > into -next and see who shouts at me. > > > > Thanks Andrew for picking it up! Dan just reacted with feedback that > will help reducing the patch series size by removing intermediate > commits. I'll implement the requested changes and post a v5 in a few > days. Yup. I'll leave v4 out there for testers to bet on. > So far there are not behavior changes requested in Dan's feedback. > > Should I keep this patch 01/12 within the series for v5 or should I > send it separately ? Doesn't matter much, but perfectionism does say "standalone patch please".