From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39B37C4829D for ; Thu, 8 Feb 2024 21:21:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B24E36B0074; Thu, 8 Feb 2024 16:21:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD5246B0075; Thu, 8 Feb 2024 16:21:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99CE56B0078; Thu, 8 Feb 2024 16:21:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 881856B0074 for ; Thu, 8 Feb 2024 16:21:17 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 541E5120FFF for ; Thu, 8 Feb 2024 21:21:17 +0000 (UTC) X-FDA: 81769907394.23.527EE1F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id CCF4718000C for ; Thu, 8 Feb 2024 21:21:14 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=iTzlcjDx; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707427274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ng5LpbnsdP/hc97uslriq/HbSNA1euLNB7WPBI8ZPUE=; b=Xw88rBcFID9WOJozxEhENE8voSK/5ddnjabgrb4T9xfoW1MLmDJh9DxeNFir0xDthlnzNw TQdheTWp6aViitM04a8QHoiuwweC+lKXdUfoWFwQI2c+ui2ZH50U0BOU+jaFYYvXeT1JDJ PQCGCwQJkjolQheOVTEdMQye/CjzvoU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=iTzlcjDx; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707427274; a=rsa-sha256; cv=none; b=8dh3FVE/yyrj2ul1hqbWhAtBgHhuF7wOt5ROfekBOSO7IH6tAByUN7r+o3A/czRVXUE9GO 0ARWSOhiEJKsBt+bBONygDsWYR7L+F6d7ccYkRKTNR1R6CdPERAQln/eF/nM9XmKWy5yep Jwu1fVcWDDfcM0wAEVcEeY3x2G2eHrw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E8D87611AE; Thu, 8 Feb 2024 21:21:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEBB6C433C7; Thu, 8 Feb 2024 21:21:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707427273; bh=TE6VqizE4efLqCBitG06M/VRnFw1efWMckznBQfEJ1k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iTzlcjDxZeqzpLgM2c0UDW8zutFRN4NZqOJxe/vrUtVOb0QDld35QCt+eWiNlHKal rin8MDPU0+SovgV8/BHHKMuKlFuhrSakoXhhtMP/YjSVL/NpHL9xNGmg0I9kHVZovM TVqUTU26ZDU8HiClwub6vU1ocBypCHs/iQdkq2dg= Date: Thu, 8 Feb 2024 13:21:12 -0800 From: Andrew Morton To: Mathieu Desnoyers Cc: Dan Williams , Arnd Bergmann , Dave Chinner , linux-kernel@vger.kernel.org, Linus Torvalds , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Mikulas Patocka Subject: Re: [PATCH v4 01/12] nvdimm/pmem: Fix leak on dax_add_host() failure Message-Id: <20240208132112.b5e82e1720e80da195ef0927@linux-foundation.org> In-Reply-To: <20240208184913.484340-2-mathieu.desnoyers@efficios.com> References: <20240208184913.484340-1-mathieu.desnoyers@efficios.com> <20240208184913.484340-2-mathieu.desnoyers@efficios.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CCF4718000C X-Stat-Signature: ewryxm19s519dhy6csfjnjtrt877putk X-HE-Tag: 1707427274-689072 X-HE-Meta: U2FsdGVkX1/dwF1f4wPaY1XWZZbEqDpbikakocoAVd85b0Ji4NzidAaLbK1Umr5HSUirT/M9BNvrTlDjiMnviQL7PeSGmqzSNv2Ko8OOeBp1gpisKa7pwBy9hqG3LoLvPjn/28eg+ccOSaxShKev9DVKuNnNArn2kwoRbLUivsJC1TTI5caNeDR3hwtDBt7obT/agiE/WikCsJpoJO/gC6/SlI2opgn9G+WMRjaEZXGJUm9jouGZrQI/kX5gWzsr9b0P1H7471HhpXzUc61H1c5F05wDmrFS4lvBmFlFKwrSlslOYOdfPv3FuMmKaApjqtcrpDk3SCpt4TRnVvT0Un/J6e1+4Bl0cEDUWr6jzn8zv3/eiwi0VAJuMg2QiivN+Yoi3FNps0v+mEcT0nawWaOSmo5oq7cFqPeqjg/PDclpy8F8pkChMRcB+BdUKybYQXO1KLnOgUYZRt1hH8O2ZAucGiWOX/LMAl2T0rPFe1fFw5bRLgb2B8eV1fIlgOOSmVwjJtz2xVgDThbqjS5MOK9kP7x/aflSGUGaWSmU3czpsr/yaJw609rAoVVGwfFuCspX8asks5MOq4xcBBFG9cbu800mGb3fGNdlI9nqPz8km2xi1Ga6zVL9ZsME/NvxuvJPCwKUb4/XO5HzwYmrlnmzuD7Q+QjDeDqTyEIzSIKd9fNOpF/iOcUK4SM1rnR0eopRmS//VEPcd6UEOvttWt4UlV3dFxnAtvB0yhVwhO+hHY9NcWf7zQAObTBuBOvwgnnIDAwkqjexHL+clbmf7Rq0+JCB+m756lR8qjFx6Eff8dztpbg7blMQDxB6yeX6xUXUMc2rhkCwgt+hcNlKsoxJxwPeCbHuB9L40TbomWGy/NcB0slpfP7goWRlLgyIuMj8L+7sdk0V9XCe6AO7/NcIuUDjKaEqLVQLvzEWGdTzDkUI034+/j6tTIifm6YCKJfF3kI3MDrC6hAk8Om NN9gZBbY gxqJn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 8 Feb 2024 13:49:02 -0500 Mathieu Desnoyers wrote: > Fix a leak on dax_add_host() error, where "goto out_cleanup_dax" is done > before setting pmem->dax_dev, which therefore issues the two following > calls on NULL pointers: > > out_cleanup_dax: > kill_dax(pmem->dax_dev); > put_dax(pmem->dax_dev); Seems inappropriate that this fix is within this patch series? otoh I assume dax_add_host() has never failed so it doesn't matter much. The series seems useful but is at v4 without much sign of review activity. I think I'll take silence as assent and shall slam it all into -next and see who shouts at me.