From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7620C48260 for ; Thu, 8 Feb 2024 21:14:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 551B66B0071; Thu, 8 Feb 2024 16:14:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 501A86B0072; Thu, 8 Feb 2024 16:14:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F04C6B0074; Thu, 8 Feb 2024 16:14:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3354E6B0071 for ; Thu, 8 Feb 2024 16:14:45 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C7E804039B for ; Thu, 8 Feb 2024 21:14:44 +0000 (UTC) X-FDA: 81769890888.21.1E80247 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 155B71C001E for ; Thu, 8 Feb 2024 21:14:42 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Uc99V5DH; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707426883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SSGaWvTaNr0kCO6ka6TS/b/v7+wofAx15IdD+SD7Uqk=; b=AegVTImyG1aEsb+lEOr0OwZwHoiXdobaiYsPSA+tVyxg9Jwsfn/gYJnEd15DoE6Ak90CI4 0QzGPAS673pbY5Du0SWTkRGqY51FhYYJSPqwFaJaZUHNXmSO66mRJd2IQibFkf1RTvQZ+G Z7Iu0dI+1HlecmpQhAcngG5SD4g0cPE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Uc99V5DH; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707426883; a=rsa-sha256; cv=none; b=qzkEvNsjPyeqpL+Nnpl7J1G2IN+L6lpmL92FubBz2w9ZliUfoPplTvUFYOnL3PkWpbu31K oGq2YWnEgxmm5ac6izVsQcued++2MKueGwjiQlQsYvM2gYzi/Z24o7I71onOPYjLqShXzs 8aIdKR7vrYeBM1aQAkrwz31/DbRPO8c= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 05F0861EF4; Thu, 8 Feb 2024 21:14:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C482C433C7; Thu, 8 Feb 2024 21:14:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707426881; bh=0tLxzajo3F13EStdBpYkrd0ox9wDY8lPKOCgwbS1BKk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Uc99V5DHpe9c8t1xKzGnPE/ibjjqrCTnXQE6DM62B3zGjzG1+yNNlozl8qqYpExPq C+IE618faRYZXv50S/BeaFdatfABd6eRy4sh9CnOWPw9EaazLDDtfCALmIixYfnmpb mZVKxCfDgGYBYWHab0fJzG03cBP4aXK2Zye7esfc= Date: Thu, 8 Feb 2024 13:14:40 -0800 From: Andrew Morton To: Kefeng Wang Cc: Subject: Re: [PATCH] mm: compaction: early termination in compact_nodes() Message-Id: <20240208131440.e30a650505fac4068ab75ee8@linux-foundation.org> In-Reply-To: <20240208022508.1771534-1-wangkefeng.wang@huawei.com> References: <20240207095841.1648144-1-wangkefeng.wang@huawei.com> <20240208022508.1771534-1-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 155B71C001E X-Stat-Signature: desy9r3mr6ons8s8s3xkckhaxwr3o6p5 X-HE-Tag: 1707426882-480328 X-HE-Meta: U2FsdGVkX185PDQ6ZB1ic8sNBLd96xcEPyyOXOyLG0I3NefuXWiZEwGF04CSn4Mb7941FSAQM2ZNmz74CQENuk9r9XNvGktcENQ2e6JSSIaFLWjkWtYjI6n862Mw6Y2626SnST4UgHYfN9v+DVCLF4fPDCSzM4VCRzoXo2e+fvZPac26efW4nm5HpFNaKWbZgiuSz21YBq2qB66zbx8ndMwOgW4DtxTLeLcmYElPlyjnrNIvwJ9iaJV4KF1gOUqtFSoNkkN1urVNzrnDIriLYO0WngboLbCsHLi43Lgm/NKSGi/jQNrxXyW/X3Ih0eyEl9Gfr1DEUfgaP7YR06Y22yo8bPEuCkq9cqSFO1LTcfnk8mTUQzbRQqCAm8hlq6ToD90bbdOv7o/+B8LwtbEV0HwUuqIURiIo+mfVm5tYQFB16OMDFhxVrkjc8/08Vs0yPmPqzdnd60u34TJIS7OIoZ996YvmSfeBM5aC3x945mcSxin8ZsV2gTEfDRJ9lU5+FTB1Xy1l+I+MWQrnwzYgrku2aeKBW3PiApjEjAjBrebj72AaBOOA2Byr69I4X9LSu6sdhdLMYkrfBh8Y2mBouxzf67kGNNlthjaBOw566wjbnNJSCrySaKDoOVuo1KZbG3x8TPFQTR6cCf+w3oZVBiiyoi+w9XNlLLShEpziRrZB8GKTqkiDXTFvZLjWThvIKibHcpa32cr8xED2aNpGWl0CEwwIMjWmK85wXPXDZPW9iDc8a+uU0shpf/UYW65bYO6rI9OdU9vKeSVfOBVTcQvDNwq6xntFi8XYh7MlnwfHEQ05JsdY3cgLh7YxpKzH5fxThduUk5qH50kzsHpOiFj0qPud+YbMvJjso+lPRJZUVZ2kdWDdJ7IRCsT/v8PyNvRqVRM5ZuOuELDjT2kTccClQu9CrSUO+ezOfLnrbKk0hFO2jUUNQIXNdmKXiytcbejR3fpFnhZB4+1183b f6EuIBXt Tz+USvcECVvhHxBlW5Lj4NYOfSNwCLTA4kSNiQ9KLqwdYpBzKQNg+YKWoyAYIg6c1iJqCkQRYlmVGdMnLFSWAZd0zPBgzS3jUDJfX1khqsBT5Tj81auS7hfOuLkUJEdAaXrqEHpKrvpXAvQZZ4jBORHqypMYCzNGsP2o9c0fMJ8Uc2vbg4IhdKXJ7XLZnPgdZFJuVFPUjb7dFHaVG4odfJZ+66eu0OyXINPbTFXBzQRAF07zS2gldMj8js0CcAvE92hti2PcJMLbBmG+9NroqaYEQpItBZGYXVRpq6yTIOjyBNYTiEd41Tgeh7aU+5XA7DU24 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 8 Feb 2024 10:25:08 +0800 Kefeng Wang wrote: > No need to continue try compact memory if pending fatal signal, > allow loop termination earlier in compact_nodes(). Seems sensible, but... why? Is there some problem which we can demonstrate with the existing code? In other words, does this change provide any observable benefit under any circumstances?