From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD6EDC48260 for ; Thu, 8 Feb 2024 12:57:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61E456B0075; Thu, 8 Feb 2024 07:57:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CE246B0078; Thu, 8 Feb 2024 07:57:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 495A46B007D; Thu, 8 Feb 2024 07:57:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 39D496B0075 for ; Thu, 8 Feb 2024 07:57:23 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D61BD16080F for ; Thu, 8 Feb 2024 12:57:22 +0000 (UTC) X-FDA: 81768637524.14.378D116 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf14.hostedemail.com (Postfix) with ESMTP id E200B100009 for ; Thu, 8 Feb 2024 12:57:19 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707397041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NTpRIPBCfUGwZxPPLoQo4oZmazGno6gvEHBoGyTdeO4=; b=pfpZbOQojAAws35FMZWId28U04ISpW+73Z73L+JtIlObU8bxkhcuMP88kNdCpyojyka4at iVjVTLXL7/ABmZomgryeRiDSI2DhYyBB2wbk42/XQ79uSatESroBMoZvqSJlnudBXeLYgX TgKYv+sWl/3+ajBdrjQO+Z76AhEApnQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707397041; a=rsa-sha256; cv=none; b=eV90duN0k6Ivm7+ie3CLU6FN+wFb0HBkhTuNfotOMIa/lAYD/BqI6wGgvHYGJLSPQ582eZ Ea79fY9QzNIjCOG5ruGgty8yDWOOR7cbYSZrJfVfDe6UGHbTc7ADDVbaLP7irg0RE3bvGP aYcKmwhPQvfYjwSvNdWiyNtgxIC3zss= Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TVxkY6xmJz6K99q; Thu, 8 Feb 2024 20:53:57 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id F1FE5140B73; Thu, 8 Feb 2024 20:57:15 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 8 Feb 2024 12:57:15 +0000 Date: Thu, 8 Feb 2024 12:57:13 +0000 From: Jonathan Cameron To: CC: , , , , , , , , Subject: Re: [PATCH] cxl/mbox: Add Get Log Capabilities, Clear Log and Get Supported Logs Sub-List commands Message-ID: <20240208125713.00004776@Huawei.com> In-Reply-To: <20240207103634.199-1-sthanneeru.opensrc@micron.com> References: <20240207103634.199-1-sthanneeru.opensrc@micron.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Rspamd-Queue-Id: E200B100009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 1hg3q9qksm1tcr4oq37sodxy5i34cyna X-HE-Tag: 1707397039-33863 X-HE-Meta: U2FsdGVkX19bJoY+6fugNzs73L3Yl26VJFYX5rkXE4ywyLHqO/dwdTqramAkyju5RBlhnetGA1FlwmhSP9QUqP7m6WQc4qAJZrLuD+N0sBL2d2gj7MMVn258UeFXjMDNaQv1uJuQIcC4mAm9m0jS9OUL38Fhr1WUtkdIadxcHWxAFy9VF9Txj8pXPG4mBJ/bz0kVpyvUOkEUH68HyzdoJJ2sKTDUrd0BpYa/5S583fpLA1QnVZvmKHcR6dTKAwo5onygA5mfPC3c1Szg7I7KFkBmmWnuud81NvQz06aXNQfmv+aNCr8/q0ubToL+SnXUDjltb/CBMnaiiou7trDtXCjoS6eQMtueG4APaUPdAQjnYyJ70dbX7SYcSKZ1zcVO4sZm7yg9+QAA/Ozw/LzHfAI9rqdqfaO0TraGEWJlOrdBWUrGKn0ayy9oj8vXFgOGV/2uc5itTVYhMBmBLdSgy5QiRCbU6X1C/IjcZd6pco+fDkwxv0QD6jezKeNnzZqtkAMWhbc6DkkesD3t+T3wpPYzUYsAu1q50ihHerMN31qBJogxgbLxyNm3eFmp9Yv69QItbjSA5MyENuInqWAx6+5FFA88Y05mI3cLz7xIkyA3qcjdEGeP189LH0zT/IJZfxwICca8FYEir4ZXwQD9pDfnfMa/oGjzhizJVEfVHASUEW6WMOTXmbPGSU0rYrgW4qFcT7TjkS49NKzqMadKpXS/kBJZ8pz/r7gdHf+QWh8FSPbYEtY6L+dDK8ylvIH0xcWQXkfpPMx9qF+DZZhcRC6KgOtRdIJzwndPScjk9UJv2PZ0jmUA2a3QbTkRHKUFlUihASu7SRUOqpWiv/NjJQ++dbIQnHsdDQ8rwEIFTY1MrvvVjPmSUIk3mtqDHFLXuE6CSg+4v8/AHHCZ9DfDqaMEcIpxB6+z8wRzz0CYfGdnUGE0WSvee7z7CBHp3rL5xhrnsYgYKZbgPJ8vEC3 XklCRomQ UKjynzplG5qqZ4VtTPU9ruM2pw3KXsCoEkcVSyiyKnivB1yqWAo02KhtnPT5t5mek2DLBVCB30iw2A3S7dLKbYyxiCQs7LtbkpLibOWHjitQlQXdZLeycnrIKoxkzfsFK76ypTZvm86/rYM9Y7Kqi7SRB4OxJL2Y1gaBcstTLYNIy/kMT79hpBv9na0dWL/wwrzUvOnd3+eSC8bLxzFN63nDqqzMvmSwdk5t3KBJzJe/Sf4+NdRLGSdvZrLN2qP82w43faV1hoewYBL2fPLPnOQKOyLVlPK2sE6iNOHURGQcqxLJn4FPuWOC48YDCkgOD1cgyTiY/shrXwqs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 7 Feb 2024 16:06:34 +0530 wrote: > From: Srinivasulu Thanneeru > > Adding UAPI support for > 1. CXL r3.1 8.2.9.5.3 Get Log Capabilities. > 2. CXL r3.1 8.2.9.5.4 Clear Log commands. > 3. CXL r3.1 8.2.9.5.6 Get Supported Logs Sub-List. > > Signed-off-by: Srinivasulu Thanneeru Hi Srinivasulu, Whilst I can conjecture some valid reasons to expose these to userspace, can you add some examples to this patch description? We might want to filter the clear in particular to avoid a clash with the driver log handling. That is only allow it for vendor logs. Perhaps split the patch into 2 parts. The less controversial GET_LOG_CAPS and GET_LOG_SUBLIST, followed by a patch for the destructive clear log. The memory scrub handling might well access the ECS log for example (I don't think the current proposal yet does this). Jonathan > --- > drivers/cxl/core/mbox.c | 3 +++ > drivers/cxl/cxlmem.h | 3 +++ > include/uapi/linux/cxl_mem.h | 3 +++ > 3 files changed, 9 insertions(+) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index 27166a411705..64a44e286488 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -64,6 +64,9 @@ static struct cxl_mem_command cxl_mem_commands[CXL_MEM_COMMAND_ID_MAX] = { > CXL_CMD(SET_SHUTDOWN_STATE, 0x1, 0, 0), > CXL_CMD(GET_SCAN_MEDIA_CAPS, 0x10, 0x4, 0), > CXL_CMD(GET_TIMESTAMP, 0, 0x8, 0), > + CXL_CMD(GET_LOG_CAPS, 0x10, 0x4, 0), > + CXL_CMD(CLEAR_LOG, 0x10, 0, 0), > + CXL_CMD(GET_LOG_SUBLIST, 0x2, CXL_VARIABLE_PAYLOAD, 0), > }; > > /* > diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h > index 5303d6942b88..4128c810051c 100644 > --- a/drivers/cxl/cxlmem.h > +++ b/drivers/cxl/cxlmem.h > @@ -529,6 +529,9 @@ enum cxl_opcode { > CXL_MBOX_OP_SET_TIMESTAMP = 0x0301, > CXL_MBOX_OP_GET_SUPPORTED_LOGS = 0x0400, > CXL_MBOX_OP_GET_LOG = 0x0401, > + CXL_MBOX_OP_GET_LOG_CAPS = 0x0402, > + CXL_MBOX_OP_CLEAR_LOG = 0x0403, > + CXL_MBOX_OP_GET_LOG_SUBLIST = 0x0405, Name should include something to make it clear this is getting sublist of 'supported' logs. Not the log. > CXL_MBOX_OP_IDENTIFY = 0x4000, > CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, > CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, > diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h > index 42066f4eb890..d2df9782a5ef 100644 > --- a/include/uapi/linux/cxl_mem.h > +++ b/include/uapi/linux/cxl_mem.h > @@ -47,6 +47,9 @@ > ___DEPRECATED(SCAN_MEDIA, "Scan Media"), \ > ___DEPRECATED(GET_SCAN_MEDIA, "Get Scan Media Results"), \ > ___C(GET_TIMESTAMP, "Get Timestamp"), \ > + ___C(GET_LOG_CAPS, "Get Log Capabilities"), \ > + ___C(CLEAR_LOG, "Clear Log"), \ > + ___C(GET_LOG_SUBLIST, "Get Log Sublist"), \ Likewise, mention it's list of supported logs. > ___C(MAX, "invalid / last command") > > #define ___C(a, b) CXL_MEM_COMMAND_ID_##a